From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B4EDC47DAF for ; Mon, 22 Jan 2024 06:41:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 076286B0081; Mon, 22 Jan 2024 01:41:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 026776B0082; Mon, 22 Jan 2024 01:41:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E57F96B0083; Mon, 22 Jan 2024 01:41:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D68F16B0081 for ; Mon, 22 Jan 2024 01:41:07 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 755C314069E for ; Mon, 22 Jan 2024 06:41:07 +0000 (UTC) X-FDA: 81705999774.05.272C777 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP id D292B40003 for ; Mon, 22 Jan 2024 06:41:05 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=WipcF8Vy; spf=none (imf11.hostedemail.com: domain of BATV+f852a6472c07d339093a+7456+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f852a6472c07d339093a+7456+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705905665; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JyLVogNGNZ1BROULmBv7h+zmh6r0U05SHTnqZnunzMQ=; b=w+4t3euN6JT+ubcAKu+BrsrLpjcKnc4g6e6maEySaQkxLpsBdcBVpTe2sJVAROe1Jne1xQ 0d4/19RLJ011M1FrEMIo6/6Z9oFqvVBMyrtlZf2TdFAudhgRmA+ALqsWJL5np411r9XO2M WuCSvwc76BigRuwG9pnchuJaBRMygv8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705905665; a=rsa-sha256; cv=none; b=n0m7Gxx4LUO3dvqBcJvycawtKQ0ogshmhCZQDhczAFVe8NXpP7ZpZEj1tA3gvAm83DV4jh JhYev+Ks8pMEfcZ2fFDRbDxtZGvNkep9Fsk6gK5ks4Xi1uT9dBaNiApnGQNUmb/W4HKSSR WQVDcaAe//1tLRDNpi4DoLzHSx/PnqM= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=WipcF8Vy; spf=none (imf11.hostedemail.com: domain of BATV+f852a6472c07d339093a+7456+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+f852a6472c07d339093a+7456+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JyLVogNGNZ1BROULmBv7h+zmh6r0U05SHTnqZnunzMQ=; b=WipcF8Vyn/TFv3DIkIqgvhNyaC 7TjSs8wU7IijGdo4sTHhtvd68furHm8JormEFIpnt1lpTmpnDQVCh65cCRQ+MVDX2/er3QH4/t7pb gGDtnzyqswFyFoazLreku60HOy+HStUxfFXrR+R1WU7ZFC6mBySMNp7xMvOgO26w54KvAmSDIwIOt vpt/6BoeNfZT6ZMqI4waE15E+cCpJUhrfqkrxT4zd+QLxcqV7pQs+q9SllO74nNGmvQ9YAJc3lON6 uuj6siInUnnlwVtK7IH2X7hAhNZwMMS0OO6TOUbFocLqy/QAILJP6EvT8LR6pDTVK/lUraIIY3VQk ywv5i6YQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1rRnzT-00AlSI-0S; Mon, 22 Jan 2024 06:41:03 +0000 Date: Sun, 21 Jan 2024 22:41:03 -0800 From: Christoph Hellwig To: Dave Chinner Cc: linux-xfs@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] xfs: unmapped buffer item size straddling mismatch Message-ID: References: <20240118222216.4131379-1-david@fromorbit.com> <20240118222216.4131379-2-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240118222216.4131379-2-david@fromorbit.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: D292B40003 X-Rspam-User: X-Stat-Signature: m6mwq1nwo3pptro7fo3j49fq66srb3jd X-Rspamd-Server: rspam03 X-HE-Tag: 1705905665-739108 X-HE-Meta: U2FsdGVkX196QbKrHhCXDa7Q4XXEeN55hWSJjyw6IJiSDWXmqNsmZu27g8w5S700jw2/N9zPcviJEf/j7s55L0+KEk/rR0CIL8F5sjYe259+DqjYG/BZIJJMFkMCgML9LlqCA7zOa90kfuzKFAh7UZqITCNO4X9xSSyCQ6QFFcl53p3PFyy8DAJJ30J4Ec/vdbUlmqlp5gbtPNPEcK7kTGbRqw34F9ez1LfTc0VOLxmXEoXRxR5yXZ5ipuCekRxQ/hUJLiLC9kY/Ho2Jy89HMl993LMenpggtCEZQdtt5bSL/GQitaq066ILFZg7SGdnl63UZOfZHqkBkK21JU2/KPShhtrMvAgt9/+aYFHMqbrUO4qqIukyb/VJpvBgsbcVfj9OwP8UO7wqeRsMaPdnU8SzHSqFslquHECB7Zk1AaLGkyI5Hf7BQEON+I0WPK76k6XsnUuWHfQcXtX4AmWhTxhQEjy1j4whRnsecDQwFPaj5LqgUZcNVHYJNJSzxf4lsr31hiF3d8W3GkVMcTW5+mnMj/e3pqcKYYrP26IcpoXntdhFXeword4b2h5tdncBPiX2Z12wiu9bXBygSsi9VXP087cVA6pqsEl3er2qhY8wfkdnbmniKReelkATOMUjbbhM/VGiC5q5AZ0iEPJfUy+iMuDPZM+Iwb54g3YDCTMLUdmwsJpmsPf+Y9dVbH0+FqaM+5KgDjF1FegtyIupIlGgtzGNyNrDBdmthzcnrhssrivTzaHd3r7m0DRpYjnM3vYM3GNPCn8jVJf5l40eoql765YMAblUdafQ+nwsVtxSnmc4QkUr7itKgMolcHBPspjiNhQxFDOcITQtSWHjdSMKDQwDDlT4Kr3MWEfiWrcUPnzVeW59rdoO1A/HwG8o2vp7EN1d+/8fYySkIhpI1KsrHUt/QizmeSTCxlFs1AdikaJMI0QDeq5zHbJsplDKmS2u/mZIak+hN3Muzie 7VYPhUmg vjPoI/Iw0zCExCJeU0poDXtXxzWJMwMomCDD0wr2NUEM7bLM47bKmjmJqN93RGwEaJciP4Jp/hbvTbXT8M9zq7x0W8w/Omhiqi+51VMNiM/Pi7tJo/cug+vFVH9uSqeQCs3pWtHl6ZMpQ/R8hS5dn2B2ZtSW7KOGkbmIdn1w+GV32Z81jgX/Om9MqgqlBqSkvEV/QhLnPRTuflfLsTjg7FRnOy2vNKErOW3qUnZ4vIojDybldJ8WNnLzSAdTTlj5jOzSHdFtl6awVjRs8IQxRAoPBsJU43D8/km6KJZHl+4BXlnekYpE35ffwNjJhVxTqhWzmDAFrxc/45zoyme6xUSeExAzvrmcCcQnAlVnK/sPklh4FJqZpDj9irgjxZNK985kRAVmNPWOUSU0Flz1wkRKvK22XhHqJCbUzqrELzEmLsJseODDOUe6G/Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 19, 2024 at 09:19:39AM +1100, Dave Chinner wrote: > Whilst touching this code, don't bother checking mapped or single > folio buffers for discontiguous regions because they don't have > them. This significantly reduces the overhead of this check when > logging large buffers as calling xfs_buf_offset() is not free and > it occurs a *lot* in those cases. Nice. Looks good: Reviewed-by: Christoph Hellwig