From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 634B4C47077 for ; Thu, 11 Jan 2024 15:54:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBAB46B0087; Thu, 11 Jan 2024 10:54:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C43396B008A; Thu, 11 Jan 2024 10:54:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABD836B008C; Thu, 11 Jan 2024 10:54:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 995666B0087 for ; Thu, 11 Jan 2024 10:54:55 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 240C3160B8B for ; Thu, 11 Jan 2024 15:54:55 +0000 (UTC) X-FDA: 81667478550.09.86AEE77 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf23.hostedemail.com (Postfix) with ESMTP id 3C282140014 for ; Thu, 11 Jan 2024 15:54:52 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=H1ProeLt; spf=pass (imf23.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704988493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9D6hjaSglgdfQvddjjobt6j5XcOqKqKM6+zvWQwcr/U=; b=y5lGMBNrnzj9E4pIAEmt1XeIs72V2SEXcXtHs/DV+yuDkMxyigdOj3pb/iyfbcPvJ9uNKB e6Z2fxEPfdLF8rtFxNsQOcFzeMlynDJkHmxKOSrd6QZuxoaJjyXd9o6ZGFhKSdUIRh60eO XUspN3an9v76C7eMHNHb6D0m/yYfXIQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=H1ProeLt; spf=pass (imf23.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704988493; a=rsa-sha256; cv=none; b=Nf5TGijqYM5ZtVCQjk+uujO7L4iXF5qiCMoT5THGd3b+E/oPTTO+x1nL9sMgOHu4SJIg9M Z3tXgUPpWghLs9FD27CXk6yo/kSvlMI9sCSZJ3R7aQ2OfSNfe7n8wJdM79iA1Uf3zJG3GN vwXh9sQ/x2oRmfsEnwXHjUtoTwV/zMU= Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-50e835800adso5601969e87.0 for ; Thu, 11 Jan 2024 07:54:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704988491; x=1705593291; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=9D6hjaSglgdfQvddjjobt6j5XcOqKqKM6+zvWQwcr/U=; b=H1ProeLt+fkByfKquq6gOBwPBQa7ZdD60vrapnjunmOXULhROqPtOkEkER2WLrhhF2 Kw5vbdzw3+wp1ktHD5H+En88oHZZ0YfWKZX2ukL9+lu1VddaxdcGiXuR8WY1c6rknG/I fvN0tQ5++CyWojA/KkHHRSp4IM1zEK64tRhH5XzCzXOryT+ALkbTtd6DWDB+iPOjcYXP uJo9yAUW5ol8YiBuAbjijRNDDUPeN8t8KZWiBmqWEOEq0ciOkPuZdhIwKGd5FrYqD34R YKilIlHrxreQDAGWe7cWl3Kb0ct7btBRsOhZYpvGsp3q6c2dvHnzcnZBqAmvWGncoiJ+ 8peQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704988491; x=1705593291; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9D6hjaSglgdfQvddjjobt6j5XcOqKqKM6+zvWQwcr/U=; b=sPM3IcrxAxtokQSrxNT7EGZhm+omvFmtSBDErfVGfgV67MHn7oEVMMhmlsMNBmlhZF GhbYzVFnbp4HAYqzh7ol1wNppJnlX6R4Tl77iIm5ZUKrb407QoKkCaRImxsXUdHp/7ju LI7JzSEsuG9nOo2eP4pbVoVtuE+GGcK1Lsq9qUeO0u+VOkiH9D8wy5QKc1vMC06GFIWz KA3AzdFqPd5kFueRhq5l+u+TsjRwAnM4NAgI9hMknndiFG80NTvpLmCyFOM107lKIirV 9SdbAkBrh/J/1CLWuLm0qzAaLhEQNwAmm4JIin4AShUKhZf90QL5TVnMBZnzQu9GUdg5 bSgA== X-Gm-Message-State: AOJu0YxFHe0zarhJ0+/hh7Ykh8U3m/EvEEWXTSfmzghLPpaGYdfir6gP 6VdiFpxkKEYidolMy0KnVKg= X-Google-Smtp-Source: AGHT+IHWww78MAc9JmlyFjErWKyyUMNZFBcpBvlXspy60BDMWCT/6SDFn/2Pg6iG6jtsOZpHcyBc9Q== X-Received: by 2002:a19:7617:0:b0:50e:a93a:fb7a with SMTP id c23-20020a197617000000b0050ea93afb7amr484815lff.184.1704988491077; Thu, 11 Jan 2024 07:54:51 -0800 (PST) Received: from pc638.lan (host-185-121-47-193.sydskane.nu. [185.121.47.193]) by smtp.gmail.com with ESMTPSA id f5-20020ac251a5000000b0050e8cd014d7sm234026lfk.16.2024.01.11.07.54.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 07:54:50 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 11 Jan 2024 16:54:48 +0100 To: Dave Chinner Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH v3 07/11] mm: vmalloc: Offload free_vmap_area_lock lock Message-ID: References: <20240102184633.748113-1-urezki@gmail.com> <20240102184633.748113-8-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 3C282140014 X-Rspam-User: X-Stat-Signature: u4q43c67pu5wrg6s84esn8bpbkihbuwa X-Rspamd-Server: rspam01 X-HE-Tag: 1704988492-619457 X-HE-Meta: U2FsdGVkX180lymh3taVq+ZgnQ74II08brWrXcmMuJdr02reF1619k7ns404grAXbmz2nTdmCOcMTfknlAhVcoRUVxhi8wpqgLUCbVWuO7U8LrikJJuPBc8I3XpxIedR25Xq2FKzOVjkRNzi/imqoKqTEGCQYa1O0kYvq+VfOgKngLZ4Q0KfR3oZ963TtvYCvaWyNVuFV79dbNx8SW9vOEulkERshqVhNgvV6uONcrym1i0IVjLhy3R661KmrMeyI7rLCT6gwm4MsLdQNcMe/5haNXG/wZGNs3rruCw/Z9s036hM6tXXIwSBi7Ln0zm/Roz2ScV/5QiWD1TrqTVpn63apfFJsKfH0TXDh7EKFHFdAACaJ/0mRq+IiAzOT7ssS91UB5x3OrMuJnci2S2iNKW3/dO1siQSajaI4B++oz0SoodHAZqGWnNr4bdUoy89eJkIVEOOOH4xtkj3omGHSELnRPr3Sn15bz04+DEhwlTDMUnDhpN3EVNKSMM7bAUejG8orRMrCBJuzeqSX+3GCU5L++eS4aSZA6XlV6OAM4foRN7J5FNwu+EmsBzYrp1BHcNW9+2lCO+fR6yiyeY4o2QvJu+2FIemhJ8b+An+S655/oCrA3FlNpij/yGzghPiCiSwYu0GVtI5F4pumt4bAPMzh2/pdDhgdRcStuGSlFo3ALe5dQNVxJA2ZSyWKIL0lxzovhXR9gtYezhRfxPx1e38D7Xc1BLQ6NEvut1s/Bg/6dLhxMC/2MmUv13aKveVC+Jumkpsl02/9mmHeejCh+Nn+KUsX1DVet1WUZsZFkxhHzPNqKpnwedWwjZlSH2unzhcRB1qKxYi1G+xO5hf6Isc63YIWz2QvOzkdew1vf2fSKFR7w3R9dkcTmDIPcg2aec6+kKH7D0fUdtyOg4Y1QEg2eFLBioMvCgpjGOYdObj2hcAo4zyXCAcVvnMnWT5hYQIF0jW/sXz5vTQv+I XLW534xR bQdOhL+BZ49C+/hoSWFAn5GQ7BnwZb0snidpWzbZca2v2ecoGIE5pr+LT1IQAYHdPzQHKl2R0zlBXH9YQTgRmshmqiQlNcy/jOXLP5vbOv0fXaJiXaVTWPxUjWTokN7rFAQEm9n3Rr1/mxGPeomCdGvjy4wMEFsWxaj70W5O0b+RGjCJzSMdIfAu2oU25i02QIq+loVUUAaH3fLivSJojEouJM29hUcxuOvvPRkkkLFCISRyxbnnP8JYhAHoc37rvy+MP0hzqyQNsf5Sk/o7j+CMtNCRfOcaeYLU1Z9g+Aj4VXpscETfDSsgjZfRtJK2PKNiL3x1pWsG3Rng6Nrs2RqeEJUW7SSn+H2fFhw56Ze2yIup//V7S1UlRKV94w8XQmyW4q4EH+h0r9P+VmjcHRtVWjAGZq3fwAjAUWV1ziYt8bhxVQ9XBeACSgo6gfqmZ0i1VJczOrU3jSZ6kOZW07QLPXg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 11, 2024 at 08:02:16PM +1100, Dave Chinner wrote: > On Tue, Jan 02, 2024 at 07:46:29PM +0100, Uladzislau Rezki (Sony) wrote: > > Concurrent access to a global vmap space is a bottle-neck. > > We can simulate a high contention by running a vmalloc test > > suite. > > > > To address it, introduce an effective vmap node logic. Each > > node behaves as independent entity. When a node is accessed > > it serves a request directly(if possible) from its pool. > > > > This model has a size based pool for requests, i.e. pools are > > serialized and populated based on object size and real demand. > > A maximum object size that pool can handle is set to 256 pages. > > > > This technique reduces a pressure on the global vmap lock. > > > > Signed-off-by: Uladzislau Rezki (Sony) > > Why not use a llist for this? That gets rid of the need for a > new pool_lock altogether... > Initially i used the llist. I have changed it because i keep track of objects per a pool to decay it later. I do not find these locks as contented one therefore i did not think much. Anyway, i will have a look at this to see if llist is easy to go with or not. If so i will send out a separate patch. Thanks! -- Uladzislau Rezki