From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59920C4706C for ; Fri, 12 Jan 2024 14:44:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF1838D0005; Fri, 12 Jan 2024 09:44:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA1888D0003; Fri, 12 Jan 2024 09:44:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8F658D0005; Fri, 12 Jan 2024 09:44:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A9F688D0003 for ; Fri, 12 Jan 2024 09:44:48 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7FA7A16072C for ; Fri, 12 Jan 2024 14:44:48 +0000 (UTC) X-FDA: 81670930656.15.7C96C99 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 5F3B6A001F for ; Fri, 12 Jan 2024 14:44:44 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Sn7JQ+7Q; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705070686; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hqGwOS00qmKxW0C+TUt0vOaYrXZBnYN+kRwkXhDrv4M=; b=PkmXOPjzqj0XvGIUbyS98o0eamD7UI5zWyEctG9lELkR/4rlZbw7kmfQ0BgEp2FxzUqLNb JtrCQxH287aHH8unx8SGPjTRGLn5OipPwdjXk5fLiokUqcj6XVkfMtLgCAHkUUcUxUdnxc 5x5rQoo5R8d1Zd/eahtY+BOuqGf2d/g= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Sn7JQ+7Q; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705070686; a=rsa-sha256; cv=none; b=sQ6PHBc+xfNdtlOOxPFq0zKqqL2J2aRsaFAXhq6CczTrqs3hOFrWOnrwYOIas9BA7JTpxq CWdP3vC93Vh/1uA0zf/AMt028mVgottQACsXnbo7s03A/duadRi+ls8zYXC+UA1G8FhNN8 t5+5Qoc3UQXXmqE+PzErQrjU9v9R6Uc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hqGwOS00qmKxW0C+TUt0vOaYrXZBnYN+kRwkXhDrv4M=; b=Sn7JQ+7QZUTUNuuMV4HPSgWFsY EsGbWaPQnfaQDuAU6xY4kwdoDd5JtdGYLZ5UM6JrhLUCopHEd/lZ2xxjUfH6r6G9FWuRbwVKNuS3k b1hfEeJpC/aqiuQYMQmztI6A5Jv98tDouGS7yabfIGM4ebjhWST4QySKR9RDnQA6VbFA/7PIPY/Pa 2eqQdDnCM7Fs62mNp/ywgnc1LOL2eS4fFpJ+ELAp6bFkf+80pZ5HcFmmbTkr/invxU4QLtYMk4L1+ jYHGREr6r9UqNJQOzqvtklei896uLD+4OK2fP0p+ucNurMQp890rQSLgHbuKLk494UPCARw5xJSyh Lcd9MwIw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rOIlv-00HUfY-KS; Fri, 12 Jan 2024 14:44:36 +0000 Date: Fri, 12 Jan 2024 14:44:35 +0000 From: Matthew Wilcox To: David Howells Cc: "Jitindar Singh, Suraj" , "rohiths.msft@gmail.com" , "gregkh@linuxfoundation.org" , "linux-mm@kvack.org" , "stfrench@microsoft.com" , "pc@manguebit.com" , "jlayton@kernel.org" , "nspmangalore@gmail.com" , "stable-commits@vger.kernel.org" , Christoph Hellwig Subject: Re: Patch "cifs: Fix flushing, invalidation and file size with copy_file_range()" has been added to the 6.1-stable tree Message-ID: References: <2023121124-trifle-uncharted-2622@gregkh> <2161774.1705069315@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2161774.1705069315@warthog.procyon.org.uk> X-Rspam-User: X-Stat-Signature: jdgqcow9zdy75hmtrpz8j4u7h8sreexk X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5F3B6A001F X-HE-Tag: 1705070684-47505 X-HE-Meta: U2FsdGVkX19OK/qhwP0yRgcz2He2Zuyrdax0Nxtx/3VHEdUKcek1tamRwCQe0PcXb7lRkLpnWloPB39UIYTN/5rzAIvHpDoDFcdY5sq++TLGdQiZ+dUugYzO9ndhY3iVkrvjmriWwyD8UfPRl6lNUuYilJntrk6pVDspAT53h0xscdRMgLdcdy/WG9YqrxfMywz7i0HOLFOVjYibLb/3mHJ6h3WrUfmygngPm4Q8P1aruAUcBceMF5liluUxY0bm7Xcrn1EnDynqQg2YZC3nG1Lml1OiPIJ1YkT5TW50QN5VAG1oQryAFTAD2NfRQTG21vMADc/E4lGhXVuQjjoc5Ozww5ZL768MMgOd6xoSOTn1LGRCiWyaJFZLuESXRirFtgOA1uSYXdMLErKWB82qudmLDHQ4p0mL0iYlZRR3BQ9XghzY9b695/dckG7HLjXNb5ak3uPe44FYf8BKmtRtpnq93ouDkO9y8jpNLZqQWdYH8/FieLGoDkjzASm+6JTRGlih7XhS8AyTtD7w6Tf4/KLYaIbP0gUmMc7+AljGf607Km0FNvHkTfoQZU6oFGPCe8zqZoBcVyE08SoKoa3FUB/4vZA7G9PNoFlq0q7LiOXa1zQ6x8VHUaZICe9UZFDWxQ2eVF7uupvrNc6B2v/kaidKMpPy3uufDAYWakTOsRTO7IhqIfNdNnjBQ70zNf/9eRjh6KAbvtcTQUArPYgsGfX60vtpGF202zU/ims+bwd4SRsghsVu51iqeUajWzluQdTgfHzB+EDpc+bcu/vAfI5PdlulbHyISsZz5CWZItrgfofhdHwnnJScH3rLUTfUnwbRLsYrKe+Li4aqENW0z6F0bGhl0/Z81ezI/bkAJao8Yu8zRUyWrN2+C24Gaz6ruxfF9YhNMIPZPiE//poLNlvXqxBMS5PeichxECi73xrW7HoyCQUzhq5peF2E7vdXGt2MCMYuxsZ/fWcYFqU ABJNfFWN kYZDbT+NmpgbDsiYmxxGvbATrKVpwr+oPVOhdQs6Pv586voVkhT5hZ0/LGVcXY64sNSCgWxKFSxKGvrvBxBms1R6qBdXeRucNg7iHX38w7W+hUOfPnh17xiVpskn4HgjutvL6KkF8qSPIXms2iRKO2epRb9jXowVCofqyYOiUcFQkWHh9o+Xz2n5NkUBflMqWuRv4HQsvJ/F7+CCYu+8NLUmVsHRAZVEXlAVFBCxKUYs7HLqzfTgQ6T7RUlpIfcpad/8enOtC3I4UT4l24rZY1v3GY/Rz55kR9OsIOpNgBXOeSJqpwLY6Hpu0hp0e9SKY+1EOYTVgbYfc1WyWg07VDquMv8aHxZ2GcTOR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 12, 2024 at 02:21:55PM +0000, David Howells wrote: > Jitindar Singh, Suraj wrote: > > > When testing the v6.1.69 kernel I bisected an issue to the below commit > > which was added in v6.1.68. When running the xfstests[1] on cifs I > > observe a null pointer dereference in cifs_flush_folio() because folio > > is null and dereferenced in size = folio_size(folio). > > Yeah. __filemap_get_folio() works differently in v6.1.y. There it returns a Let's cc hch so he's aware of how much pain this change caused. Never change function semantics without changing its name or arguments. > folio or NULL. In 6.7 it returns a folio or a negative error code. The error > check in cifs_flush_folio() needs to change to something like: > > folio = filemap_get_folio(inode->i_mapping, index); > if (!folio) > return -ENOMEM; > > David >