From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1F39C4707B for ; Sat, 13 Jan 2024 09:31:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8004E6B009B; Sat, 13 Jan 2024 04:31:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B0C96B009C; Sat, 13 Jan 2024 04:31:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 679366B009D; Sat, 13 Jan 2024 04:31:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4A9DC6B009B for ; Sat, 13 Jan 2024 04:31:14 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2503C1A028E for ; Sat, 13 Jan 2024 09:31:14 +0000 (UTC) X-FDA: 81673769268.14.64510F7 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by imf11.hostedemail.com (Postfix) with ESMTP id 2DFB940013 for ; Sat, 13 Jan 2024 09:31:10 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Wg5xNqT9; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf11.hostedemail.com: domain of ak@linux.intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=ak@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705138271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/MfQVj9eQZkESv1Q+8pI37q/xl6WbuISU+fGulwlTaY=; b=BTm9y7Z+OOFa6JEXqDqzjPb1XLDSmitM91o6GPNeRhp63CdFuDGv7cQ1K1XJgCL/ufRFSo 3hRbQHt5G5c+ed3x8vK39y1UVCXMIMNQ22tZvp4IbwKxGf/6nFk5n0ccart+GWAfVPA+XN n89fwnw8Do1UTW5+U06I3EpYjRKFc5k= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Wg5xNqT9; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf11.hostedemail.com: domain of ak@linux.intel.com has no SPF policy when checking 134.134.136.31) smtp.mailfrom=ak@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705138271; a=rsa-sha256; cv=none; b=A2Jp4DyZT2DJQQBwDwTY98W5HGnVtjWaiMy8g4z5x0pDYnYUOA3+MN0OrpgP/ucLetUxq4 Tt+ca69OEKwwB8XTdBMjilkcGirwzNrPX8BTTfscp039C78oXc2gclWw4CHY/x6FMzpW7c zMkyeGC4gCZTsDcm6mUk+U69L7ZODcU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1705138271; x=1736674271; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=SjTM9ZlVdC+zj2d9f7k7IlQgeOjiVf2LBGRGd/ifRbk=; b=Wg5xNqT96B2vZCaGpK+uL8SyjatWgwLcqxmq9oFCZTUdmcc5N1njG8N8 ve0KA/6elL4pL4hgospxKnO8uWJSWLzx1ReW/jjXrPMXrCc0I5ik1NS33 GDO/bQtBNTwdCxQN8Q6zf3JLHf1UiN3oBeE+ahb/qlbDM3AuaPleKj9Ud RgA1bl4+TIk3B43E/33KFPr/XLq5GF0DbJn5WmmmWSqpsZ0gfK/ngXesy wLXRcC9b3MADbHv113ifl6OEA7irix873zlIywqfi6iGZ5Z2oXetLdDGL cKqgtXyao9OgBjpEWAB13DBhuStiKzVHsjnIhVADd/SoToGQpaRTbVBdP Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10951"; a="463646413" X-IronPort-AV: E=Sophos;i="6.04,192,1695711600"; d="scan'208";a="463646413" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2024 01:31:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10951"; a="956337463" X-IronPort-AV: E=Sophos;i="6.04,192,1695711600"; d="scan'208";a="956337463" Received: from tassilo.jf.intel.com (HELO tassilo) ([10.54.38.190]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2024 01:31:09 -0800 Date: Sat, 13 Jan 2024 01:31:08 -0800 From: Andi Kleen To: Marco Elver Cc: Andrey Konovalov , Oscar Salvador , andrey.konovalov@linux.dev, Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH v4 12/22] lib/stackdepot: use read/write lock Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 2DFB940013 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 5cgopdf56ypnau9ogymhuqpwjdse1w6n X-HE-Tag: 1705138270-857853 X-HE-Meta: U2FsdGVkX18vVd/Wn4mfEGKUx9aNPivhVdb+L4ilvL8bM1GvrRtQRGczgJ+mH2rNTPSLVF7EzJVYH5WlgAYcQOOQZuFi5sOBEk5rBFTW0exUHdUHwKPHg+fpZPEbatBJnddqmFqe42mj1Cc4Fqn32CAgw/TnSLT6Cq8b8Ykc5T4soU1trfW7bvxZWWAJtdWi13DxODlpp6lop9wfshhZucJUF010ffJsnRZ5pzIa4YqOUdPpLLy/AjBXZlqwD+X3S+BxsU2KeK1p5tc304/E+1Vnb6XBZ+B2qdjswVvkad5E5p4LCy/SznwfM+MBhpO+YdRoAqI//IGlZt90Id50sjHjfPY4f6q1WN+bss+cyM8I1aAoVLLaU2gCKmRrqwjztwo16vL7/Dy1Yefbt4fWNQyEqQMGMa/8gekMWKFOEe/jQWHEnitIiFjJaWgF7/xg41SB1qXrGpSViBvFTZHlUUBdIhXIsFJVhnfwPbgzsLUQQVJtuCApvVWnK1+lFXlhoEDH5Z6Xf05MWS7/qdjehHhPsANMs5k02eoKPxst84lrYg1ZPmdcYpzXJ0GfRRE2ST6qYLLBNQO1Ki2jLMFmW0uoTGr2aJbRkebSy9RG7ErCAqgt4oUuN47G/Xgo+OrQyxkaWARIS7gKYzp1HbKgcCr0i7ZEyP+LDhsC52PHuW4MKR2kTV9xSZ0a2i4oU92QQFez4bBbX3aDRXzIBpoZWrKrU3LSUBER0t2T3sBVX5nDyVf6W8VSmTrZZb1bQ7CnbEsMxY7g3HbqclhxQWCvIkRDdNwUHzU1fkLhIDdg1Dn4W3AhwhGAiENMoAFpTJ2Mw5+DJNQHFsIYi6NWL23aH14OqZnxSrg84v6+35AntgpRwttNCNT1In9Phz/Q7vEmV7qxHbIwLw+W/6vA2dR7dGP4AEh5RgYZmu0oYPeTfxH1I62tifCxjPtUOKhbdNf4PVmb2vFSpnIbJVVEeVy csl8EKMx cW5LxBo7gMy2rHIgBjMrLCHF1hhmMPFncgxy2c4uMF2FSl1ntoyJlJL90hsqe8wkmYL4KWt94HMiSCorR3PHsc/wkcjuk+DNEQIFgwd8VuamjzTXDj92XIzVA/drMCLYNLoWK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > This function is only refilling the freelist. Readers don't see it yet > because it's in none of the hash table buckets. The freelist is only > ever accessed under the lock. > > Once an entry is allocated from the freelist, its size is overwritten > with something non-zero (since it then contains a stack trace). Those > updates are released into the right hash table bucket with > list_add_rcu() (which implies a release). > > Am I missing something else? It's probably ok semantically here, but at least I would be consistent with using the macro for a specific field. -Andi