From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33281C4707B for ; Sat, 13 Jan 2024 17:02:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C2426B0085; Sat, 13 Jan 2024 12:02:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 271696B0087; Sat, 13 Jan 2024 12:02:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 138E06B0089; Sat, 13 Jan 2024 12:02:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0436A6B0085 for ; Sat, 13 Jan 2024 12:02:46 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D629B1602F7 for ; Sat, 13 Jan 2024 17:02:45 +0000 (UTC) X-FDA: 81674907090.23.E067536 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id 96A5F100019 for ; Sat, 13 Jan 2024 17:02:42 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XBIuTwAz; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705165364; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Hp64LaVQJQsLqAZDOrtoGqIE7tJ/OaeKJ7yu7L90+M=; b=H6AOTU49kUqvIIN+ZSmvq7CFmurexJs6cGz033aRNsk4V0LELb43Ubprto64VYQktNA/oc qnCPcqLEsMayvpwzv5DJK62Nv3xvi1St9P4eImnfozaNx6LQVLMQFOwm60Tbc3NkSk4BRD 70kSl8UQfBisX34TkoA1qsCB4GDooAY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705165364; a=rsa-sha256; cv=none; b=CKrclzx6nrYtLK+OZtbuR2ojo4AA3XyqVK2rmZmDTaAuWIs9w5ojYKphnjZz1q+47i7yp0 KjYraU28tExMCkLNu9agDxSeMXXcsucTPBWk7oqbr/lWjIbqUZhptG663kGU0J0VEMSKbk 8QLnbCjmdxRuPewoBICUOjfGvOs21/0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XBIuTwAz; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8Hp64LaVQJQsLqAZDOrtoGqIE7tJ/OaeKJ7yu7L90+M=; b=XBIuTwAz+mQPEryrwAJZ6UeszL jRRvAwZGsDwM+EjYOskJsHH426TedF0zOhO4dleXKFl8tB1ZGSqboB1hWsPCWQvH0pbpnDM55DNwS Lr0dKgdg5LacT8loLu83uemo8t2l9iWXo69urvao7o+z0i9hTiGI3uNhISvVmGUtOSygUJxU2cPsG eZMkpsyPBSLlmhzV94yUymYsRq4E5EdLNprAc1bPkJRuPSvn2VMgeVqaEhWXpqDWPcZlbuYTJkuAK t3NU6QTovMv3xH60byNK5NqAL3NxlsLHwu3Utj6KUio3HjGPFnAS2Nz1zvBekHoNbzBJZMQzVnNkq nhnVmF3A==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1rOhOf-003X8M-Rh; Sat, 13 Jan 2024 17:02:13 +0000 Date: Sat, 13 Jan 2024 17:02:13 +0000 From: Matthew Wilcox To: Steve French Cc: David Howells , "gregkh@linuxfoundation.org" , Salvatore Bonaccorso , Paulo Alcantara , Shyam Prasad N , Rohith Surabattula , Jeff Layton , Steve French , "Jitindar Singh, Suraj" , "linux-mm@kvack.org" , "stable-commits@vger.kernel.org" , stable@vger.kernel.org, linux-cifs@vger.kernel.org, Linux regressions mailing list Subject: Re: [Regression 6.1.y] From "cifs: Fix flushing, invalidation and file size with copy_file_range()" Message-ID: References: <2023121124-trifle-uncharted-2622@gregkh> <8e59220d-b0f3-4dae-afc3-36acfa6873e4@leemhuis.info> <13a70cc5-78fc-49a4-8d78-41e5479e3023@leemhuis.info> <2024011115-neatly-trout-5532@gregkh> <2162049.1705069551@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: tch1hr7a8fydf8d6azx81u7sixaefd96 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 96A5F100019 X-Rspam-User: X-HE-Tag: 1705165362-902029 X-HE-Meta: U2FsdGVkX1+V+VmVLmBuIToTm6mrkSpJsqDLz0Z6LefDeSHeytTz39RK7gvKfJralSZyQyGRKubPdYekyoUWJ/wfs2n+iRUVE3zww4yRhxt75Xla52/tz3aR1EV2ut4eF4dH8dGZitBjcKkJrRQTKyidVcnX8/0wvczQGQVLIMirjAqqmoDQV4JzMbRcdFTaErE8/BKprI7e+FBxb1yDR8AJvp+LPvFqTg5tSNojtBiLoHgZ3Kd7xsGmKBESylTtNjVR666zmORqAwcuFaZUgfFFsi7qoJpcLsxZ8mjILxkjTSqfkdTIP4RrriFTE30/Yoj4YsGFcoWZ6irgKg5VnmTO7xFQfwCdvp8M/z2ZRYMa02lJCrbBrYIVhHaYsP2yieizHpm/iU3BBjNoJWlxJ/sz/WovIsWHI08aw1dS6ok/iBsCRHkPxIPFmffiTM1WAHxJSXj8Y04wdfrwT4xUlotyvQH/LJsFXajOojo79HRqe2yjHLGBL1VHLIHxhaVGjRN1O8E9BvAWGsDj8rHMTUAqj82hAML2AhuzmQk/nqrTGo0Z/SiOW5zJ4i05XTibyXDbomXCNrZWLg6DeMA1/jlGtSe4IOlEHYrdf6zsa6Xjm7RMyLoBQ/TnkAl5EyoUFIgbbdsf22hv/Xv77+eESqoLlfNVaNR5l1HmP69akSiq88Lk53hF64+KWuvmAUhpgEkvExaCw5N5d6B3UA3Fq4jAEiRCVhCfKAETELIVOM/PtAMKRHXgUI1l1mWnCVm8P58/Yi7T14D0XDacdQ/rN3rJOTo8sG9TbFfK0T6gK1C6e/irfTAhqNgL1XXFGG9EkpwsbqJ2wfb/LUcVykBCCF/pqfKXg4xRflwgDbhyloa+RNsjuO99RDRi/jiERRP4lNZTQB8O9p5rLbo1FxoxmIyBqXHB1jmEBLLKpH/LdBGyJrs52UjDJ6aap8GZaf9Q+7UZfPiU+9q7jYNBD/w LY2NAcB6 dt+nw01U3ZShi61HFqlCGKKbeBUKxewFn3Wvq/RZvlDB/ov6lLY5wFXr0FWnXyk8u+nt6kU8ikzR0GOukGjQaeqLr2QZjEEnV91m5BKzDRItst1aH1olYkmohaNQ2dgHdn/a3veVHYnKwmQ7VnekU8U9U8T1jG8SEeVtfU+cKOZMZcbz7jIoK82yTf/CalvCj3aL9cHY7NPN07LedbmKyRnNXpwcCfnt8tEWg0Ur1uGiXDZ2BNWpYk8paDH0qJsYWjShk0kvWB7EiMidLn3bl9rws5EluM+nAA47jxPVlr7LA+FA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 12, 2024 at 11:20:53PM -0600, Steve French wrote: > Here is a patch similar to what David suggested. Seems Similar to, but worse. > +++ b/fs/smb/client/cifsfs.c > @@ -1240,7 +1240,7 @@ static int cifs_flush_folio(struct inode *inode, loff_t pos, loff_t *_fstart, lo > int rc = 0; > > folio = filemap_get_folio(inode->i_mapping, index); > - if (IS_ERR(folio)) > + if ((!folio) || (IS_ERR(folio))) > return 0; filemap_get_folio() cannot return an err_ptr in 6.1, so this should simply be: - if (IS_ERR(folio)) + if (!folio)