From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B4FC47077 for ; Tue, 16 Jan 2024 11:24:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93FE86B007B; Tue, 16 Jan 2024 06:24:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C8D36B007D; Tue, 16 Jan 2024 06:24:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7688F6B007E; Tue, 16 Jan 2024 06:24:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 647FB6B007B for ; Tue, 16 Jan 2024 06:24:42 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DFE771C1368 for ; Tue, 16 Jan 2024 11:24:41 +0000 (UTC) X-FDA: 81684941562.22.7EEEEE3 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) by imf20.hostedemail.com (Postfix) with ESMTP id 128A71C0009 for ; Tue, 16 Jan 2024 11:24:38 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=armlinux.org.uk header.s=pandora-2019 header.b="0U/z0Je+"; spf=none (imf20.hostedemail.com: domain of "linux+linux-mm=kvack.org@armlinux.org.uk" has no SPF policy when checking 78.32.30.218) smtp.mailfrom="linux+linux-mm=kvack.org@armlinux.org.uk"; dmarc=pass (policy=none) header.from=armlinux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705404279; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HDuqmhpkWHxT2M2pI/xOk7Pu42NAZCIU40/WZmESav8=; b=u3vlBxELeBVH6pN33MY4/bAPLV2wnkawQkSq5VR9QwgqIGiW9MVgHLVex+IHBGLFZapeA6 qJZhTdZ+kSr4am1S8+ZHBV1nALXvzlkjike0O/wz76RlxEnKROT/coacEnDemdyB8ovqWy oFDZ8yayZZa0DDthbiDZ1SJT7FnYCIU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705404279; a=rsa-sha256; cv=none; b=UH81YpW/sxwyrjS5kz/JPGzjUJDAPDNF/Ohsc2Vh4PJHytfARMaFGfyFKPVzFth2ahU0bZ BSzGJMbqC76NENkqUTmko6OwE0ORNoypnblNOY5VZsfBDuiTXbhklW2GyGjVUNoy0p6NI0 nR1OKarnCUqtguzzLMlYMRdWZhSnW58= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=armlinux.org.uk header.s=pandora-2019 header.b="0U/z0Je+"; spf=none (imf20.hostedemail.com: domain of "linux+linux-mm=kvack.org@armlinux.org.uk" has no SPF policy when checking 78.32.30.218) smtp.mailfrom="linux+linux-mm=kvack.org@armlinux.org.uk"; dmarc=pass (policy=none) header.from=armlinux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=HDuqmhpkWHxT2M2pI/xOk7Pu42NAZCIU40/WZmESav8=; b=0U/z0Je+MXosykY6zSoUo4s8jD JK/PdzgW1Zzy6OZi8KGwD8Y2QQuTlTSyPpkkzuQ2ltD5fNvgVrkXqNDR9yhj8AE18qtzc5lXACY9/ 2FvIKU8u8IfjTAxNfTG58wXOZ2Px9a/7gPbUr9nr+m1FUFObWmrkcFKTSyOIguhMPEprbmn7BmPfO 6LrAeA/eO9Kfrgfefj8NHbWdfSYoRFva2XoLGL9xOzbkn9TUdut8jQhBdRtE+7QBZZ+yyWEaQkgJ4 fdaly8yM8fITkf9ee2ukTzN2js+Samar/NV4KySHQf+OVXBk54A12hKvtKtNZP2FpySY7sVBK7qrW uvepZy+w==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:52656) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rPhYM-0003Og-2w; Tue, 16 Jan 2024 11:24:23 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rPhYI-0003pb-Hq; Tue, 16 Jan 2024 11:24:18 +0000 Date: Tue, 16 Jan 2024 11:24:18 +0000 From: "Russell King (Oracle)" To: Eric Mackay Cc: cl@linux.com, Jonathan.Cameron@huawei.com, Matteo.Carlini@arm.com, Valentin.Schneider@arm.com, akpm@linux-foundation.org, anshuman.khandual@arm.com, catalin.marinas@arm.com, dave.kleikamp@oracle.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, robin.murphy@arm.com, vanshikonda@os.amperecomputing.com, yang@os.amperecomputing.com Subject: Re: [PATCH] ARM64: Dynamically allocate cpumasks and increase supported CPUs to 512 Message-ID: References: <794a1211-630b-3ee5-55a3-c06f10df1490@linux.com> <20240115235911.80586-1-eric.mackay@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240115235911.80586-1-eric.mackay@oracle.com> X-Rspamd-Queue-Id: 128A71C0009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: me6a4s5uob4bewju8po8ejqfs4b56hb6 X-HE-Tag: 1705404278-519164 X-HE-Meta: U2FsdGVkX18jFiOWaaBo9Elj19UrQeFsjnwibtXyAWA52V5WNZsDIoF9aaiB7Y0L6O6WHzTMKgSKEbuyH0qsqWNKOIguBtPqVqtryJ3396WhP9a5FhXve9lgaNcAdn3HJtnt+Ae3sVwqnHvc6d4QwVwxEDUKGmcNlnmpy1XCPNBLJDB3NkSoGx3bxTLGEM/REdYeg5mzzze3aN0wU/vkyMtdctOCbWr9g0S6L71fSEPZwvRI3r9o7bLybCWAP9kMhs4aWNDLCYn6QqPo5scwonnNyeyd/vKtSAhMCA6LXXtWHUBC5Ec1BMBeJaWxW9ukSf5/DAoPk680QCPjcvy+z3GkjuqaRdkDtvfK33as2wVZo8C9wnmNyYtyZVbzV2KjTRERCl0/LQRa5U3ik0xQD09Kyj3dH30QyPcTp+Eb1anNHhCuYXgLKFBf297sdJLVwHhkzzRgt9v/MmpLkU07b+Ml75FGb2E1I58GcA6xzysMUYieZq48NGQPkzkDthoomqNsWet7e8fzGEMmLSHpckTEtEnKoCHXFDt8zDiXEsUjld39BHQDKiNQaOy1c6uxSVTJlBHKLLBv48/O8on/QHJdcPp/Z6zJlo2DQlo/QHHWrQqvJuiDTGJd51XI1gMTk8K4oDxrq5fhVqUnMjvreXdaNq+kj8gFx6sDo0E6FImXjvytFqsJ7cyln9ZLGG7a65LhHgzzLOl8gAZX+4t+m5BNvTp0JMOVwgRsy5xPpykl1mWFy7Lg+Ov4xCt/QKCAIIWARdJHmTfXE4BNKMgOu0yZwIY0X6epueeVXPzLJ4nURlSSNIjCXAbjf8nEtoW80nP+JR40B97XCG7ZqWqud5G6IqtuOCF3FNSy3jUt9M9H0jm/qxnsCZQt6s+/Zo3UkHMHuAoBPZtsIcwrT3cW00PLe0XGHU5e0QLOYMX+GOyaUGT2BTPUZJAHXI7CKdhtPttEGENykn5yiazMekD DpCpRoE0 NSqUFLIZnIK9ycXrn5u8eMBsnzP/Wom0juwYUAEOs4SjqViJJg5BOLcaC6qCbRuC9b/IzD3zUY/o7SNAPUqAY0zmvB2b87x6PPKMmBTr+z56DNgL+0qZ77WAqRFADCKP3X+RHR67d81TZjUsMJPzJJ8KcrFR7ukXzZRIyT1X3XoOD5Wf/nMJms8xntFejZ1RQA7PDtJwxnvc2lBnngj24uWhGlclnq1ujsh4KdhlkGECumxSdFGi1nS0SHYZtcdlf2ehlP9FwukFQpNDp/SQGHBbEBxdFywkjVsRUGLkm/lFpPUIGNTPrcK6glipxSvUVBviz2FxN2kVUUNdHVOlc//qVwMuYNqbOO5Lu04n6xczxaV7OsWk4JEpDUALSK51DifdPfeWgjWyJ10fRLiEwNTD235yCx/6po9Y/RwrUQyV4pC1gaHi4nNVdPWubjCsNjoubQmebN0k4NZ0E2tKwwMPOYlq8BPoSJbKSrHrUv4Bxaf0CD5VCqEVafE0pRoNek68SERlv0yWNdGA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.027286, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 15, 2024 at 03:59:11PM -0800, Eric Mackay wrote: > Whitespace issues aside, I have applied the patch on top of kernel 6.1.55 and tested on both a dual-socket Ampere Altra machine with < 256 CPUs, and a dual-socket AmpereOne machine with > 256 CPUs. Works as expected, with all CPUs visible and functional. > > > config NR_CPUS > > int "Maximum number of CPUs (2-4096)" > > range 2 4096 > > - default "256" > > + default 512 > > Nit: the new default value should be in quotation marks, if we want to be pedantic I can't find anything that requires the quotes - and as "range" doesn't for consistency it seems that default shouldn't either. There's nothing in the documentation that indicates quotes should be used, and looking at the code, it's just treated as a string. The only thing that quotes seem to do is to ensure that whitespace will be included. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!