From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9F77C47258 for ; Tue, 23 Jan 2024 15:01:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 536276B0087; Tue, 23 Jan 2024 10:01:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4E5646B0089; Tue, 23 Jan 2024 10:01:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D4AC6B008A; Tue, 23 Jan 2024 10:01:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 22F9E6B0087 for ; Tue, 23 Jan 2024 10:01:51 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4EBA01A0AE7 for ; Tue, 23 Jan 2024 15:01:50 +0000 (UTC) X-FDA: 81710890380.26.3AFA68F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id CDAAB1A004C for ; Tue, 23 Jan 2024 15:01:42 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OZ4uDMvo; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706022103; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PepByJiWQ5z0YJAy3zsX5i+pG7M9t28NlsHRNrHyzFg=; b=Vc6zXQzwwOfzfzdlsWytN7bCWdyAj+bJH0jIsy+W8mM37FmpeAsElXFt/XU90LEsm8/ds4 nvt7JCt/g5Z/3rS0+3v5I4KAJKnr7dNvJ1hO4AuKSKdQpEuig6seygIFFC6mX97EGQj7za zoh/ICdsaXgcLemoj+G4Thlo1Tcm5+s= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OZ4uDMvo; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706022103; a=rsa-sha256; cv=none; b=xa9ebJqGGVqg/xtX8/5MVTWH6o9Jq89eA9Yc6CDf8FKoVWQlDPPBRDO+4E4Zx+U7dQgJZl rHSZOkiRVci9hPfkhS8KQj01iUPeosTZt9VWCcskcy3OlUx8rp041pBWZoxJk81kh0yU9B PQSp+wbn+gBpa/k0MlVr8Tsm+0yH6dY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PepByJiWQ5z0YJAy3zsX5i+pG7M9t28NlsHRNrHyzFg=; b=OZ4uDMvo60iZ4l06WQT6UPpOyK 1Mzz1amI2B4lmc7SzQBo9/H5nZHwSc+ahhYWItLeLfbqvNQjOpLZ379CUtpyrKiJpaFB3y3qceoFn 2/09mBIgxlyPrDWwBI1N1vIcVhBAJ+ccP2Eft8qdX7sawkIRu0Y4eD33nl5AX1fWh4yZRXAHa0diJ xtf9jKwnR9O51wT9yPKs25kKmm0Ym9Nc1WnmkYd5euK/RIRwr1nWxHB5018vQ5PnPMYfUbcXkcguy WziupYXg/e8D0xyqPtbSRcqVXqNtY1gEyT+tocZwXdwgad56hM1QmUaMd0kzNvFae844ES7sQELU7 yz18rMEQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rSIHS-00000003Un2-0lR2; Tue, 23 Jan 2024 15:01:38 +0000 Date: Tue, 23 Jan 2024 15:01:38 +0000 From: Matthew Wilcox To: Ryan Roberts Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Russell King , Catalin Marinas , Will Deacon , Dinh Nguyen , Michael Ellerman , Nicholas Piggin , Christophe Leroy , "Aneesh Kumar K.V" , "Naveen N. Rao" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , "David S. Miller" , linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH v1 01/11] arm/pgtable: define PFN_PTE_SHIFT on arm and arm64 Message-ID: References: <20240122194200.381241-1-david@redhat.com> <20240122194200.381241-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: CDAAB1A004C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: pfg5miwxm71fryq1caeku9yqeoqifx3e X-HE-Tag: 1706022102-212379 X-HE-Meta: U2FsdGVkX1/puY8sO+4E60oG439JGRkZgjSBskhytwlrNtk77aJVVU0F6sD4gjekHalWnEuDiB1NNHj3uYGV80EUjR9yhYipnt54vmmhAO39j+d0hdw8apmmLiHb8GUJfOgMgbBZjX0GIFV4rJI1hEeNLrCIq/Oc/xYcBQFx++Gs4kE07tDDkjvZBrYgbT+52JnGqkuBS8iBA5/jNnM4i7WHnR7fcHDXDndJX199CKulr6blxFSwotXRm9S4+5pBrJWNQdjpd3FIYdbk9EWbp+yx+j+iOSgVAzGlE47IB/hqqzcumqbvVqQGWSHT4jFr4FEmvNiJk0AatYzd+UDDQo33stNUp2F8YvCUCxEnMQkdN7OQTuSIMw/gxh0ZBYSHYih+VeuHoyyIGuAFFCYsZHmHXNM7BFBSMCIiAn/WTc+/jkPV3NrfTI4vwBixVhkLXIMYiQFOQBBDR4vA7QEXxdJOSjdMPpu8jLtNwuZNrBCLo/mACwVDJnQMGh3rPOyOQ+EIH0AQJzYhSZoq+pmoacE98HDabSm7NCI0f0m2XLl0B5jsEuHolDpCtj4qL0gkXvtEklEpP5Rv/9G13mIii8ezpVn1RQ1AjaiqDJ1vg19kUmPuTXE4ZxnZfws0NPdBHyDvXb8LLAIdNIKPi9ji+KIyPmRH/q8jEzU04g+STCn7UnIFfuYSlErpWd/5+aj8M6o6+LTUDqTX86DlaREbW2GLp0hm7OTqOMcMSL2Cthyl7D8RYFEmxDRlResBIO6wIDMTLiyhjJ60Sfesi0jqNwBL12X5MGKX/E3fm5d8/JgZoZlbkGACzj238S3KZW20F6jZs2A0aHLFxQIF0vglPY2CVp/tnm2yC0BlnO5DqHkyz+Fl0lqxXybkDeLwtsGbjKlHUqFMd39nhYA3gf6gxWwa+lW3qWgHsDhF98Gq/w/LA2v6pECZZJ8y0xWWHTbPQWbbpFOGXeMpjnUleCy +mprHiPh Y23LwFIbQYGI8uBV7PnGfkyTTOK0KfCAaSjCy4+McehgYs5ZckngGPeiYusi49fsb1AlPnT+9loTPs0ea0FmwIOrZL984Qcf7srYdz6uYmCHaucBUZReCkJqdz5wLSsAQgZy/rT6kdyQl4g9RHHy2wI9ZIZhwhbkkakpHvzgUtvvnoo174GlVRdv/pA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 23, 2024 at 10:34:21AM +0000, Ryan Roberts wrote: > > +#define PFN_PTE_SHIFT PAGE_SHIFT > > I think this is buggy. And so is the arm64 implementation of set_ptes(). It > works fine for 48-bit output address, but for 52-bit OAs, the high bits are not > kept contigously, so if you happen to be setting a mapping for which the > physical memory block straddles bit 48, this won't work. I'd like to see the folio allocation that can straddle bit 48 ... agreed, it's not workable _in general_, but specifically for a memory allocation from a power-of-two allocator, you'd have to do a 49-bit allocation (half a petabyte) to care.