From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBB4FC47077 for ; Thu, 18 Jan 2024 06:42:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CED06B0087; Thu, 18 Jan 2024 01:42:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 557C46B0088; Thu, 18 Jan 2024 01:42:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D1576B0089; Thu, 18 Jan 2024 01:42:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2AE976B0087 for ; Thu, 18 Jan 2024 01:42:29 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EE66AC05BC for ; Thu, 18 Jan 2024 06:42:28 +0000 (UTC) X-FDA: 81691487976.22.782EE6A Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf03.hostedemail.com (Postfix) with ESMTP id DE1BE20008 for ; Thu, 18 Jan 2024 06:42:26 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OFiQrywG; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705560147; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=57/OCQn/jtJ0d2EaAgtp8HVZB8wQOkm9HshFkxuQTAw=; b=y9EJY2iXEgVuezwqCxWac9iph3RAvCudiq3aqRfoJ/k7vL+lWAUbNG4aMTE/j1Fonp+VaL eT/4iTcoSSOk4O2KQRWPOZRI6bctN2Tc2DpDgITwNHI9dSvZuSrh6oioOFoJT0E+7LN52J rtEMaH3AhKkrx+8XZCi3jym5Nq/hKHY= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OFiQrywG; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705560147; a=rsa-sha256; cv=none; b=2fm6yCOyLIBo7hfV5e33G4rnknHgX28nQLj8r1HKVm6be/ETA/miA73ikzbgzahJP0finv DjyMtnE+xN7WAcG2+FujRUlhAgIXHSVAI9f0V/sn70UQ9qv8g2CsncFNXbWlojKA3qECCB 6r9luihf6Q7xLHcIPptClSeHMvdlrN4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E82D7CE1D82; Thu, 18 Jan 2024 06:42:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98146C43390; Thu, 18 Jan 2024 06:42:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705560143; bh=7irHwcUOlLLvJ2czZrHOJqq3RhjBpa00ankX30HggNE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OFiQrywGk1L0FEqB3zgPffyixtDSEM16hHyBN8bHBAmzU71ff7sCJqTwVgsvAKDlt eZs379UnaSF2wDZaqEyGTl2qmoIrPmW0f+Rby1pW6+FpJ2kqCKuHMnwGQbhPzggAo5 xQ3Znn82qCXhFiC0/Gg8vV4OsxLpDb+dI6XPbrXFTjuaKJlgnNl+egrHUGurPIAJIe yXY2ssLC4m6AVNrTjzb0ZbI1nfHXgv7O4d2aPD4nqJzhQTKwP7haUVNemqyY2NNmQE 8+LVv4bDTf9geyLSUyUqnIDYZjYmOF2TB8jnicLhF7Mw7zpuVWeKCSpiPIQdbjWxx7 C3GRh9wInDWtA== Date: Thu, 18 Jan 2024 08:42:08 +0200 From: Mike Rapoport To: Yajun Deng , Huang Pei Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memblock: fix crash when reserved memory is not added to memory Message-ID: References: <20240118061853.2652295-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240118061853.2652295-1-yajun.deng@linux.dev> X-Rspamd-Queue-Id: DE1BE20008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: ofrc9zkdcxi365pmxdu33wyko4fa9xwn X-HE-Tag: 1705560146-971491 X-HE-Meta: U2FsdGVkX18qiDdEIwUoztzWIv/Wr46Zx0aR0S+JgLcHkq+fQkGmmPIerh+BGTdCTi+TaQatYQz1qPxruhZNGSoi0OEcRaIO536I50wRBcD/XHVjUxDkfVu4yEJUp1Q0zeLtyEur9MJqD1MCTe5BbSPRMRc33YVRiNypwgWuLxv72USU2q4SLo+eNW8G5hggExdTKFIQyWgfFWCnM/oq+qTTxj/POyphHuPS0Cm8NppgLW4mIr50+nh4wOAVHKR6mYbPohSnl/xS0JbM7dzTTwJUZ2Jh0ulG3tniJqLqJz8M2eipu2Y/T7P2pBsOKSidbV/7yYIN6jktsMpG2AENcHWvBmgaH7BDS1bFyZ5aD4Tj3X+DXbsZankMyBXpsahp3dhggjtAcM+XL62E4lmADjKY/Oz882+PPeAVmfm99kUkpe1vEDJFPozLH7ebO5jPiUk0bRg5kkl3SfCKoSU3GjezzltZOPht8kzhxdt7VsCqqadJCXwXwqj8UiYajqtgdwJHhbKce9nI2BOhamIutZ8i3AaoaD9jccLGbUbSZ/uFCVGy0A9ZBnA0fj/4NsIlbA0xEO91ZU/so+aL/sC+ADjUdbn6xDi+CfqACfPY2MCZtRCgmC2gRudV43fMoWeLNTD+8A/R34PaSl6ffJBXPdSYTL23LpeE2HIFCIeNgyqpabiiiIz0JL75pM9rX1AMdynkA8eeirXI2HZEhUNC7GnMHEWsPJqKj0iyt8beMXnWeZtNoA4kx+oC/xHIrCQvW1Dfuh8hQkRn99AuK2KrCBqOfn3E/SJgqPB8XJsAho23goi00Nm+euVksVd63zDqjmamlIWCvhyipy8O7BVZPA1QaLNHjtPc9GSmdCBKYiEcxjnUf7XVRxeYtblR15IhlGTEsLmUAaQYAMHjM57Ht9TzpsTn0KvFcH5+YqhBgABcY8VLx4u3gp/MvtKoF1jiSg7aQpbKLXUWc4gXyj/ SpMou/LA NNsFzg2UavCNFmqBjogXa76NHTc9u4wWbcuPn73X5x2COG1njzeMIjEwFr72GthoRdNnBMAaiEtUB+sEgtcc5rFOWBf3ApA3SyNRqH49nWafv1JDfA6aju5jd0vLrzk49vhmV0CU3wt5li35mJzQ4luEU79uuZpC9ql27+r3R7UZ88MjXSxPVqbToMw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: (adding Huang Pei to verify this fixes the crash on loongarch) On Thu, Jan 18, 2024 at 02:18:53PM +0800, Yajun Deng wrote: > After commit 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()"), > we set nid on all reserved pages based on memory region, but some reserved > memory may not be added to memory on certain architectures. The nid is > invalid. > > Add the nid check, make sure the nid is valid by early_pfn_to_nid(). > > Fixes: 61167ad5fecd ("mm: pass nid to reserve_bootmem_region()") > Signed-off-by: Yajun Deng > --- > mm/memblock.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/mm/memblock.c b/mm/memblock.c > index abd92869874d..4dcb2ee35eca 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -2176,6 +2176,9 @@ static void __init memmap_init_reserved_pages(void) > start = region->base; > end = start + region->size; > > + if (nid == NUMA_NO_NODE || nid >= MAX_NUMNODES) > + nid = early_pfn_to_nid(PFN_DOWN(start)); > + > reserve_bootmem_region(start, end, nid); > } > } > -- > 2.25.1 > -- Sincerely yours, Mike.