From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DED4C47258 for ; Tue, 23 Jan 2024 20:43:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9EB78D0002; Tue, 23 Jan 2024 15:43:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A4DF58D0001; Tue, 23 Jan 2024 15:43:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 916788D0002; Tue, 23 Jan 2024 15:43:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 83C3D8D0001 for ; Tue, 23 Jan 2024 15:43:33 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1E0C616025F for ; Tue, 23 Jan 2024 20:43:33 +0000 (UTC) X-FDA: 81711751506.01.213ED97 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf03.hostedemail.com (Postfix) with ESMTP id 3FEF520008 for ; Tue, 23 Jan 2024 20:43:31 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="EcDO6/bq"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf03.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706042611; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0/M64QxEWn2HynUowyBZgYrVqasAYN5VNMIeSyQ1vgk=; b=z4UkEttTAuTMZtMJG0JGORtXwONERMA4bkhS8uIWB81M0h3hm8zfZlhesN95ZOc13JF8v8 n3+7bFJhtE1aCPoTONVlBaAUGr3ttAQ4aTn3xCtPJoMKqbr9jLP1+o7sOYJbegLQZVLYaB BgpQsmhPkJUVTOc4OxEE5bEdIe1cbFE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="EcDO6/bq"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf03.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706042611; a=rsa-sha256; cv=none; b=ARSOg76yHMPKSpQ9zdnRCyK2xWcZVD0SzuTyV0Fx4rdk/2sn40dEEU/V1GdQ6PABSGECg9 JZaUukE3gjZRqJiDvge+BZGtEXWV8TSst0RtGAy8fz1nx7c8qh9afhDUXIdDipzJX6ltWU dq5ZsuEo9ppzDDSqRKRrkmTWdgqn2JM= Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1d76943baafso13416255ad.2 for ; Tue, 23 Jan 2024 12:43:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706042610; x=1706647410; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=0/M64QxEWn2HynUowyBZgYrVqasAYN5VNMIeSyQ1vgk=; b=EcDO6/bqKtpyQHyd3KVpdqx1wmSN8aCgIOivg4GaXp6gFWns/EcjdFHRFhn3lTxkrZ 0SdHuJ0Ophomcs0G6Lr3CaSl0iatdqSqnCc2d4oSxW/ducTDD25bMHlTMOYNnKB4LpkG CRaxRfoGKNeH1g9zAhxlFGKFuWxsRO1QKmS/6wo1q6djgvSvSGk0CUHAPbaKjf2ya28R 45jLreJygK3J0PwCw4NCYbcSaNKnM69XYaa0f0O0QdX+DAEYshD5w3PWNKr4Rqy+HQuZ tL7umzkuGXx6M0z4X2D1Kro74V7TJEj/JoCEMi4U3rsqkDbyYyXCW3BIhYX20UqKq2G9 nNAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706042610; x=1706647410; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0/M64QxEWn2HynUowyBZgYrVqasAYN5VNMIeSyQ1vgk=; b=rPdJe4u6NH5/NvwaO8/WLBFzNJ8ezEC3SO1qfTdk9XLy8NYQbValMktdw1j7tJtg3Y s2omWWyzgIhoVAnuok5dRXwEzbSB+oEcSlcea6KzPuwjBi7tVuPrQl7hL3iICOgSI4Ah Res4gsH+DIoV54Y805v79C58tDlPTFoAZzPRfkG+ppyGOvbJxMBg7jhXlp76rUp+KfS1 L/gmoMksEKkS3jY8pPRtNTbEnSNtJcyt4WaG5MhY+pUVQty7vuNocw5mvOkHIZxvwewG Udt3x0qtcy1oARPcbh05OP0Vp2P9b22yRI4c3B88j36t0/ui6lBjPzEcw7NjwRWWkQjr G10w== X-Gm-Message-State: AOJu0YyPXDqxH4d/5tovwAf5GoV91sjC3iD8+zPgsp1tXt1UTzx7cfw5 iPk7kbqZ7pcqYi3WT31An2UGGr/AHFemyGFETdAA/0TJWVQ0NMuV X-Google-Smtp-Source: AGHT+IFkwmV6/GQzYxMoUXFdqmuslTw5E1Fh5A73QIDIocbRUdPwz7AmIQvOP3orOG+CWkXPoEU4lA== X-Received: by 2002:a17:903:32d0:b0:1d7:562f:67ec with SMTP id i16-20020a17090332d000b001d7562f67ecmr2594794plr.102.1706042609936; Tue, 23 Jan 2024 12:43:29 -0800 (PST) Received: from localhost (dhcp-141-239-144-21.hawaiiantel.net. [141.239.144.21]) by smtp.gmail.com with ESMTPSA id l12-20020a170902e2cc00b001d70af5be17sm8832683plc.229.2024.01.23.12.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jan 2024 12:43:29 -0800 (PST) Date: Tue, 23 Jan 2024 10:43:28 -1000 From: Tejun Heo To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, hcochran@kernelspring.com, mszeredi@redhat.com, axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] mm: correct calculation of cgroup wb's bg_thresh in wb_over_bg_thresh Message-ID: References: <20240123183332.876854-1-shikemeng@huaweicloud.com> <20240123183332.876854-3-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240123183332.876854-3-shikemeng@huaweicloud.com> X-Rspamd-Queue-Id: 3FEF520008 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: u9yensz1pii34cn51x6xyiyi77di5o1w X-HE-Tag: 1706042611-360760 X-HE-Meta: U2FsdGVkX18cbXXzFW8kGSbg0K4387lK3YkyRF3JzztrdWd40k1H8nx2gLHLQRCoLpuwuxx7pFGzywy0kzK65I4tRhUc02/jzwbiQ49wEgaxCj4NwnoSvK6us0bCr8XW9qu2fmOI8y8d6BqFRaIa3rvSceX+htMNYZC25EdaGd7PFrCw9z3x6rhZo4/7ccIah6ndux3JNrlHa88gUIk5wAU+kKyVagxZNAPJ/zOKGCo/b+xgnfeqI1ECAjRuGQ7BoPxMAb6D8V9C5Bbe4mYgr/I2frqyl95W/95zT0s8fLCVNdP3UdzojbcAPm18pBYXUycubfGlsU+0bvL3kMRsw9/deb9y7d3hhwORngr4C8XDv82AzHctqr8LF17zyMGig+IYr8X2Q75qKMuaR9ZqtMI0xPvrQU1ioUHLqS+6riCovi7rUVIXSLZ4e4CFEVunG16qgE3h082cirL18nEg0Lvmq2wqLsK+8eig9lMEYxTGq4iozn9CYx5H5zvVr1kUCENTZk1khqk955bWYABKs/TOZ7vYT3tYdc6VlgGMmTDyRv7rlfiWKsVQww5InZ2Qskf5im49EgU4Obqw5mV65KuYjrprQF2vnmHmbpBUEvvuY2TTGcxqojU7AVk62y1+wMrvNBAITI0Df9pP6BpvdXqeBxisFuQhd3K1wce0zuSonxQCQi3ZkovykcVruX3REHVQZjIJLb7G+PbStrm5v/S4px9RTjcG6SdSwRzE9Csvz7/9dvFnflaFH6W3PSMYbNlhRxMzZVZhYgNpmaIV8YatHahsuuIDy0Hp0JL0kNPeFIOBbsa1Le1Al+dmpN5thcuhsiMgF8UWIqnJ6qTxgy/sipPa52OCQp8kj2MNSKAjTSWEWrw/YxUYTRXybzR9ACWnn7mQuB4QVxOffGX/khyUu15fKkOCNhgjjSnOHH3M/lcVTgWENFuwhDB29y1O3abGqqZzVSNP4bdtk0s Hb8O9jOT 3HRzXMfJunYg9aPzewHy7TRH8bRs9n+608AHwlRWS/jtaWUQrig9Ou3gOxlxBZx3WOE1602/v1t++sReWHLsZroduDBaVxv6R+BF65pS5ABCxYiIR7DHzAMHf1dbgdm6TQtK5A3GHYK4Wqmt/JwHW0xcIbRrIICzQWPOgFzQ8aXJISfhrToQeEUGleUoyciLAvLOdpeN01IA/R9Se15xyXGByO0IzkXsNtIYLCMlOmo8OtqCWkF7L0sNoQMuJC4YcdLXMsNKQ5Vhl9xXCGnZqd+yP82TIv1J/ven1eW+X29TN2oKIVSbQ50SqGMVo/DGuLG4k7exLN7BN2ze1UA92iwd/eG46tmp7ieVfU03eMCVyxHnZJm1vkDOpNubk1CsIlAaW60VFFpfDOv1gzjomP+qpRG3llVWrBkDcxv4O2bYmeGMTHfKHlYTgO59d/5h13t+GG8ZCQERaoq/TSeE4WtBnHay2PUbCVDZi50Dj922XR4JirUH/Shiieo6rsbDTZXhpcrUotwx4plStMhY+5gpQeTmDYIROtk7GXwWPIZzjs6k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000720, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 24, 2024 at 02:33:29AM +0800, Kemeng Shi wrote: > The wb_calc_thresh will calculate wb's share in global wb domain. We need > to wb's share in mem_cgroup_wb_domain for mdtc. Call __wb_calc_thresh > instead of wb_calc_thresh to fix this. That function is calculating the wb's portion of wb portion in the whole system so that threshold can be distributed accordingly. So, it has to be compared in the global domain. If you look at the comment on top of struct wb_domain, it says: /* * A wb_domain represents a domain that wb's (bdi_writeback's) belong to * and are measured against each other in. There always is one global * domain, global_wb_domain, that every wb in the system is a member of. * This allows measuring the relative bandwidth of each wb to distribute * dirtyable memory accordingly. */ Also, how is this tested? Was there a case where the existing code misbehaved that's improved by this patch? Or is this just from reading code? Thanks. -- tejun