From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3759FC47DDC for ; Wed, 24 Jan 2024 08:13:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 691F06B0074; Wed, 24 Jan 2024 03:13:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 63F566B0075; Wed, 24 Jan 2024 03:13:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 506B36B007B; Wed, 24 Jan 2024 03:13:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3EB1E6B0074 for ; Wed, 24 Jan 2024 03:13:18 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B8622A0673 for ; Wed, 24 Jan 2024 08:13:17 +0000 (UTC) X-FDA: 81713489634.19.9F408F2 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf01.hostedemail.com (Postfix) with ESMTP id F055E40011 for ; Wed, 24 Jan 2024 08:13:15 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706083996; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=B9qF18RzvDXzodIwOLOD1mj5uV5sasqvoSwmEt0eiQ8=; b=w9aSFm/IObeAWeFIhQJLuH6So7pqPY6QUn1sgFIK+QflfOMALkkYVSgXx7ewuHZ8CPhHZC Utyr0lpjN8VFn2an2RiiZ5KLch4jt9W85ZAq3IEq2Hk2sCThe8oc5FSX2ZFt9xKF9olTIh hyHqTjwafZlEyAlOn+llhJVcWxhJhUM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706083996; a=rsa-sha256; cv=none; b=gJR8Zgt1Ak7Kl0FjesSmvghQXm/x1oMiuQnmCTakSjf8iYa+9Gf7VuQJ2mBaBhbsKToqQf qUoZQCnWC/YWOGg2jIU10UNKlO5OVkp+vlf4t3/7B4UziWlJSuJwzgGXm8l6toWDDGjdqv R0XTWad2Orwwekx7sSMRHMDAFvZNbt0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; spf=pass (imf01.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=none) Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6daa89a6452so3558594b3a.2 for ; Wed, 24 Jan 2024 00:13:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706083995; x=1706688795; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B9qF18RzvDXzodIwOLOD1mj5uV5sasqvoSwmEt0eiQ8=; b=kUYB1ERAIguZLO/7obCgLGutpI4sdoL2QbKm/oD8upMwAJTHXu8egUek0OOPY6QO6q lZiVY9c0HlbvsEmhTkjxsqRwKuy5BJIS2G9VAyW1jWrvWAAV+UcaQw8Mrasv1AX5llRU Dfe7BguPLPBnXdqKObLo3qpcnt/tN31Pxhhxe72oDUpX/rEr3pzONJHPCs3ys5Ev12K6 6JO2cGJqjLLgLKH+P1OAoHBQH8lfAtmdUF9iaKbLkbg75zntBauwWNZmis8sKIN2XZJb QstoYS92GcssoUQTux/0QqDL/K6thkQWT2CA1+iXqQPRjs2cwcMrpv4o5gzORbWbcWBf FelQ== X-Gm-Message-State: AOJu0Yz0ZivcfO4gY3KBw8r5DGpwdi1GoMjZzNKOIJV7epLSKlOrp8qR 4pX4vYqcBWxAov37UOIAKpI90FN2DSQoRXxvECq1JdVDslr+3+eX X-Google-Smtp-Source: AGHT+IHbq4iG8bKu4Eji3JiKtMcP1j98BSAv4jldXfilN+5jE/9EtPklfe0VP/SbKdgtCHsW+VeWEw== X-Received: by 2002:a05:6a00:2443:b0:6db:afd4:f54c with SMTP id d3-20020a056a00244300b006dbafd4f54cmr4792529pfj.0.1706083994816; Wed, 24 Jan 2024 00:13:14 -0800 (PST) Received: from snowbird ([136.25.84.107]) by smtp.gmail.com with ESMTPSA id e14-20020a056a001a8e00b006dd8985e7c6sm974076pfv.1.2024.01.24.00.13.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 00:13:14 -0800 (PST) Date: Wed, 24 Jan 2024 00:13:11 -0800 From: Dennis Zhou To: Steven Rostedt , George Guo Cc: Masami Hiramatsu , Mathieu Desnoyers , Tejun Heo , Christoph Lameter , Andrew Morton , George Guo , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] percpu: improve percpu_alloc_percpu_fail event trace Message-ID: References: <20240122073629.2594271-1-dongtai.guo@linux.dev> <20240122105700.05e5ee46@gandalf.local.home> <20240123094443.00007b20@linux.dev> <20240122205539.705f5701@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240122205539.705f5701@gandalf.local.home> X-Stat-Signature: p85cf5nwnwtpcizzhq3r5i19uxkt7xif X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: F055E40011 X-Rspam-User: X-HE-Tag: 1706083995-140791 X-HE-Meta: U2FsdGVkX19+wD09atX2CXdDwSXecZ4GKP2GHNOEop7VoRHISC6QmNxJa2izxi1ugM23P9WYSydsB1jh7TxfLwe+cnAssWe7lBIzDHUxJm1KgQVpxgnI69BT426FKFU3JbArfQANCtpRDIwADDITisylXIbLto7in8Z/koRB7yK7QSak17jX5ILPZBHkFkq9BWsXSDfZd1yGyuYHZz9s8c61bfydfrWmt9dwrymIXMGyMoGgAYAX2eZjx/Yw1M8g3MjW+oixPC2aPIPzEXaj2GQ0TPgMBNTGRHx0sFNJOFuQ7TxBiFRq4bIihCXZfz1C+zvxO7WI/kBPge6jmSGO/VPURzZCIrL+Kxt+yy3bBq9vOCbj7rZLyBG2p6ZPKIgiNRMEg46PLlHPIV3qePZBiJ/Pi/w455E9712bBJ2UIP4ve6jmgs78BqqXac5jBkNf66haJ+tANTRg87mGfEWxcoXbBBkMQ3qckUZSACjITdPH7wAkP4vaM6VS8b1UBKR4hvjOjze+r4SjYcWixtym4Jiuce6tIjC6kGwFJIY1e/7y2yMPrtQN8GHYcyHqah16DiOCbUL4m7GNGLWOqC5vHHScPczDBzRkwcHN6tywivvvBi+0005RosUYHfg8aMClXN31n175XDuIDMXTs4XgbY/TWDPhDp87PS5Z16ZTt/WvaXO9oQreiVj3lvaTgdec5GSeLPOPEv9KaNX48Z262RE+LJns6rGOlmCxHUkuCaJsbypBEVkZcm7EghgGFik2dINW+lm5asfDHC9qCJF+ylCXf8+UKXPJOLd4DqokjAnfEqziWKk7QS2GIOM/7A5tT5QYL4/LbZKD+2HpVue35YkyFjB/7AgLhlVVIHT82G4P4wTszl9OhyAfpBPy199I8ZHQYv/vPUZtCn9qhfMcUPt5UyUgeefmCRPocvaP8iAnsplrQAC4qhuTXL9bOFjjBBc7/g6iW8wIORD34jY TpEdgp32 Wf7XqL/NbRzm/O+I2b/OwOUPJaFEqhqONBdj6n8Kd6ENKuOSYKVyD6tC6aRMkb/isA1GJ6+4wmEZlRMFogFd4Rwu3xyzUkPpkK3YndEl1UfuQ0cnROa8AW/evAIDkMpKZksQ1XyjQNWmnNLl6A6tw4rcgwJY+QM0ZjF9O/Od/FTMhlHc+7MoMFSAt6DwRgHkT9KSVmzf1H9JV4BCpS9OdTncfdQi0LBy8WEZhZTfOv0/kUhcFdy/kbNvRGHgpdpb/h2kWyESyUOrQwyHI7MOWpCGrE51Bqrm6OC8434t0kGlH7BH1YaXFKEMqCoHVcBkvLrtWr9KOLx7T3xYyp9FGMhie6pC19dGOlspIKg+7/YpNB9IkQNPz7mTikL1bcuTyaNF5H/HVw7QSYNGg0mUBE0TqAwgKxi6yevPeaIBcd9zLV2YnMwfKjUfObFXdkdAJIz+GP3hrK9thITHz1JkwNrA9MaBqpM5Hx83y7DjFpUTZCWBQMGldFtSVxIvFnAEshpvpPjbkOhUuwRg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Mon, Jan 22, 2024 at 08:55:39PM -0500, Steven Rostedt wrote: > On Tue, 23 Jan 2024 09:44:43 +0800 > George Guo wrote: > > > There are two reasons of percpu_alloc failed without warnings: > > > > 1. do_warn is false > > 2. do_warn is true and warn_limit is reached the limit. > > Yes I know the reasons. > > > > > Showing do_warn and warn_limit makes things simple, maybe dont need > > kprobe again. > > It's up to the maintainers of that code to decide if it's worth it or not, > but honestly, my opinion it is not. > I agree, I don't think this is a worthwhile change. If we do change this, I'd like it to be more actionable in some way and as a result something we can fix or tune accordingly. George is this a common problem you're seeing? > The trace event in question is to trace that percpu_alloc failed and why. > It's not there to determine why it did not produce a printk message. > > -- Steve Thanks, Dennis