From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D1C5C46CD2 for ; Wed, 24 Jan 2024 13:20:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD2EE6B0078; Wed, 24 Jan 2024 08:20:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A822B6B007B; Wed, 24 Jan 2024 08:20:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 970F16B007D; Wed, 24 Jan 2024 08:20:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 88AD26B0078 for ; Wed, 24 Jan 2024 08:20:51 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 340BA1A0C4B for ; Wed, 24 Jan 2024 13:20:51 +0000 (UTC) X-FDA: 81714264702.07.FAA6F25 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 891801C000B for ; Wed, 24 Jan 2024 13:20:49 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Sl2lHko6; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706102449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pOB7vCAKoihq9Mi/fz7gX6tPYUodOZN7LLoA5qHlBxE=; b=w4/aoj4N9A3V21cVxlVxM5fHwKzo65iCky2zzYS2CG+PVeF9gfMPVIGFNeJ1ZwHMjM/PIe vAHY5Dr8JKaiKbrdKkpRleo2FtjE6tCPZFyL08v3foMltKTzmduacZCSpYd+3GXR9hKls5 ljYHAKCiZvN190gBirtF6cXYVq1whCc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Sl2lHko6; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706102449; a=rsa-sha256; cv=none; b=kp7QY1GioxgNKhj2ciVvIKdzlfhM8lP1R/HiyahZJXVhFX+/9vI3FI9B6UKnWKHEiAaZw9 HfWghbx78vsiL5CO+JWDt5PHy+ImsBPijzj65yLG6JDu5i9LZ4+zWwPIjIbkFlV5yEQPkm ltN5bDArHJVwHui5145DiMgFBVf84qA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pOB7vCAKoihq9Mi/fz7gX6tPYUodOZN7LLoA5qHlBxE=; b=Sl2lHko6gXK8czMgyEaf531wdJ HsCaUuf7W0LGVqJ7ZC6L9C/IS6Qhl59hAQOMC/3/3rnZ7tMwq+ieY8j9T+shopMX6WjnP/rFF6NEs +Z95aQk++UPxUdKtVAOTNvDNMTBrjp3q0Bdjx9vCrOO1LC21Wi44dOjzEkxsi2jz0HxF6Xhj4XqXw JWcTseOe+J0UljIgoM7VHxTLEQ8biAN+zzoU/GY/5/4/PiAS4c5QcpYGSSodf62DKv+I7i+Rm7NqQ PIlTBOF7zk5ZBiORmT6pD/Ldo4P1QenQ8DHqiyRU0ZBI7nA3r+Y+0eXQ4cBw1SjuEiAxVEA2ouThH POkphRMA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rSdBO-00000006jJo-3LOI; Wed, 24 Jan 2024 13:20:46 +0000 Date: Wed, 24 Jan 2024 13:20:46 +0000 From: Matthew Wilcox To: Zhiguo Jiang Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, opensource.kernel@vivo.com Subject: Re: [PATCH] mm:vmscan: shrink skip folios in the exiting task Message-ID: References: <20240124124308.461-1-justinjiang@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240124124308.461-1-justinjiang@vivo.com> X-Rspamd-Queue-Id: 891801C000B X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 38gma6k6xm7mysswbe98xfyjd8thc9o3 X-HE-Tag: 1706102449-506949 X-HE-Meta: U2FsdGVkX1+jIERR+A8qzWZdWxu/XrkEGohGmJk8mary7e3BcZI3Epy4EbTlSCamopV/JFgsIB5cW8/wTipbITDa2/CrkPHlT3A1RT9/e9Q59k384+eZoh3OAjOspuPXPIMrflpdjZdQYKBMPopOI+4hozREI1RsfeH99JyF9UabzIyvEcGqaxk+uk/DiqZUJhlkvmvCm+R8LMbgOzKpTea/VWOD1lGN3MzMEjhUx3baifOMaKXP9iqSTShr/ConB3vwbtPcSspsEZA0phXqYqnQsDEDlkgaJdjlvJ30YARqGVq0BM1QOhGsdP9Y8nZh118tMoiEQw8cn4Wr1zLOkfsm06nMApAOe1DkEaRDot2HCA3+9fL/y7H9Xz3M+yaWsX9WyDoMm4+nZWJBUut8DF2WODXfLRlyW781QIJOXa1TeAOivM7RHCsQIDhGOw9bPjcNOthjGbHj5wbRsPZUfHEb0qHkOVlPztLN6SPxXClajfM0Hs8n5XTh/2ghAayyXEwLNwqzkyVWU6BMgJDAZ2CmwDagmF9Mmd8NfwOuYQOiuQzJgzF3s8JO5R/kDw13UksdbDkDdH09akEXKHwcl1Fz6A30EDPx6MaSfLqs7+Ywe1QsgcUD1aIQsLwAEUDBdBNNbauRHiVenMQbBX4c5zwX2ConRGCwiZur+0tRsgnP9w9YRGj3FPbLJkUr3NKipU+tbLD4aTJJ6srPZpv5RC4HPTHV3y7h0MrfTgo8ekQQMSIQcB8Q83BbBSqq6Cn+n8Gr94jWypXMn6ehtyMrQXSkhuATPd/1MGvHGaCTBa/zqM+7FoMuS2lU4KLOLjYLvn4z8fFKy18aPS29slUCCCXn6rFKa7E5V00x3SHksn/8j/MX8PnwZIrwVG+2bV0CG3e+rHLQ2F8MS+LAwH8GRrdx7OsEEl1pdSdOwkYuBIZLs3qTWYtSZaXPL+5Mn3Np5NNHA8FhuhfR/ZI7mvs JyvDj6BO 2x60A3A5hPZ2d/wyh0sh078SI0Llh+3w1M+pQDeJ7EO8sHSZDXOBHEy2JiSG1obAzppBRVjD7DeR+87GhJ2GwOO3al7D72xWOBr6lcTLGVfH27rNoNCYOm0sKibe5zC031TDXGXlvx3ZC3vs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 24, 2024 at 08:43:07PM +0800, Zhiguo Jiang wrote: > If the shrinking folio is belong to the exiting task, this folio should > be freed in the task exit flow rather than being reclaimed in the shrink > flow, because the former takes less time. > > If the folio which is belong to the exiting task is reclaimed in the > shrink flow, such as the anon folio, the anon folio needs to be first > written to the swap partition by swap-in in shrink flow, and then the > corresponding swap folio needs to be released in the task exiting flow. > As is well known, releasing a swap folio will task more time than > releasing directly an anon folio. > > In the scenarios of the low memory system and mutil backed-applications, > the time-consuming problem caused by shrinking the exiting task's folios > will be more severe. What testing have you done of this patch? How often does it happen? Are there particular workloads that benefit from this? (I'm not sure what "mutil backed-applications" are?) And I do mean specifically of this patch, because to my eyes it shouldn't even compile.