From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFC34C48260 for ; Thu, 25 Jan 2024 14:22:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 300938D0006; Thu, 25 Jan 2024 09:22:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2B08A8D0005; Thu, 25 Jan 2024 09:22:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 178E38D0006; Thu, 25 Jan 2024 09:22:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 04CF48D0005 for ; Thu, 25 Jan 2024 09:22:46 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A6132C031D for ; Thu, 25 Jan 2024 14:22:45 +0000 (UTC) X-FDA: 81718049490.19.961047F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id EFF252001C for ; Thu, 25 Jan 2024 14:22:42 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vNgjUpj8; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706192563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UoCX5dqCasoSQIfaxgxhOKWLb4P3Rs8GNp2O4jjAuio=; b=Hf2nDQUD1cpbWx6fjFgbjVvGKMqAktKhId+XHvS012I9fsASIEsRRe0SZF92B7vz/9mer5 zJ5TCCYdgY6nUo2PNagRlaTfAUdLTgCvonsyU9Tp1p7ldDyrQsBkJ0uEvQWqRWggpWDybt 9xSdixcPxC4d9WpRjlovAN38hYo58dc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=vNgjUpj8; dmarc=none; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706192563; a=rsa-sha256; cv=none; b=5fHUbZUUMH7lqylKAMD1hpCdEE8hQhpWS3mU2E30Ls0zY08OsTjZsMXDOPOjfWY0cFvGeP Hhh1EjQDEgEPCUFCIaqNYo3zduKlznPS2Wr6Rn17V5Uw7PQhqxNLL+J7INusd+LkL+PUr5 mDya5Vn8HwCt8tk6/Bf/XCxfe2PziYY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UoCX5dqCasoSQIfaxgxhOKWLb4P3Rs8GNp2O4jjAuio=; b=vNgjUpj8NOSogxwQUUgiuOP8qB WYRbkEWYp/9J4ytYbhj2j2feFb/FW+wKnSoupGyd2ly5KrA9JMlcfYtikaD1kryCgWY2Lt4GByk4q jmbsuBwBHPP8lFlJgbmUPviaAi+D/cuZwhnNOdHi4lTsAJFO/CZ4aK4qqeCdQyjg3ibfh9Xk/YzxG FlXZu8JVGRIHAtBxgZC0KMmbNjL6eTeIBCPXJdN/TDIV0lj8S6N4rd5pmkiwYuzD0gUbDSgVm+2Yf 3oa/jaQBv1wbaoXc7IKovygEYKj3w6BC57CqRKsru45EQEkgL3lNpsmOgdY5s+9n6AR6ptGtrotde dkZYta6g==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT0co-0000000AB9T-0pRZ; Thu, 25 Jan 2024 14:22:38 +0000 Date: Thu, 25 Jan 2024 14:22:38 +0000 From: Matthew Wilcox To: Miaohe Lin Cc: naoya.horiguchi@nec.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mm/memory-failure: fix crash in split_huge_page_to_list from soft_offline_page Message-ID: References: <20240124084014.1772906-1-linmiaohe@huawei.com> <6d3f4822-8bc1-1551-b088-0a6d4c13f049@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6d3f4822-8bc1-1551-b088-0a6d4c13f049@huawei.com> X-Rspamd-Queue-Id: EFF252001C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: p4rwaijpdwp4qutd88pxdi6bp98a6q91 X-HE-Tag: 1706192562-695872 X-HE-Meta: U2FsdGVkX19kIQ7WazGl84zzD1c2+jxPBf5PqipdRmpc1XdxY0MIUB30b1gWKpqPtB/uxKYXvW77kM3353Gb1FKLKO9jsQyumGQRqOgtCk/BVl5mSWY4BamAdPI56TgWOFZsJ7MNSHpvEKxYeTBLAMIsRbUrNQMVLfc5xw9G8FULfzbuN6TDfyW/cSJ30H8xqGZrlD+kMq2lPeJs8ZTREUuLBT8VXvwX43K6csUKOwVjJuLxfPYTwSpAQqAJKPmceihNKyyzXcE0xrv1Jl7ReWXvm7aug7ijObhaV58Bz4WlkEOqW1RxTD3qvkIkYXTkZ/VTl9jBZR9SEXzJ0xJfLg+3itRPN8LMwXRXmIcUflbLsJMShsSpEqCOpigr1yDGak3UFgRgRv5DlPvRnX6q4gg/86miTXWGutpTyN95dgm5tEMADSnV3SdrfoF5OFcbiwcAbSnfcaZKnVPzWr4z8ZRa3RG/Z6yeIsyi7GWyatyypO7YRqu+Ut5rXAYjUhRLk3he63X9OeoFrSUChj4CYeMgcp7GG81QowS2US200HPNFdm42/94GMYSDwVozpjQwkpD6IdVKZC7m8KEZh6WIrynVS6UgRswDaFg1haAzQI/YAl5XbzjxOmzNyaKjcsVcOaWdJSeHJkV5cWpCHbcFUiam/d9gL1JnU81+lfpLkfVILG4kArZXu6gWi+unGlRKGiP9KGAN1NpgScwU45SA9YgWNh6g6OittGahk1ACI2EnI9Rg/0lYyVNL5b1unrH9gtTuxBu08Px+yXxMiXym+PXjWjRwmRope/ERrCQMF3IqahF1zvi3C3i3txtReDfu+gFoYkW677VSEblCDvOsMPXRT0FBI+2W8lGK2aRUgRFD6BvGJL3uSOEbHc+BH6YxEIJ1RoDedE1dHHy10MpNKp2nI3pyY3wjOnGHVgGRw827TawJfdr6a9SKUbolZ4sk4nuOQBI5IX2x8IWBXI EbC9mD40 TWyWLJq8sTQvekEiPW8b8FIG2n8Y2hM2XqrDQKM6cCKd1iBQIhTBLS0MczvIAqPqDdnIrCJQlI0X9F5lfifHdUpH7PqJhYrwOSiAz1U7SlFxAgpNsv/nV17S/tLmW8ZxdjjHf4eqKBzkPQnFdOUq95ZDY5DEwnjoHm7lv9au1TobxrkWLns6Gnp4X0w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jan 25, 2024 at 07:53:25PM +0800, Miaohe Lin wrote: > On 2024/1/24 21:15, Matthew Wilcox wrote: > >> Call Trace: > >> > >> ? die+0x32/0x90 > >> ? do_trap+0xde/0x110 > >> ? folio_memcg+0xaf/0xd0 > >> ? do_error_trap+0x60/0x80 > >> ? folio_memcg+0xaf/0xd0 > >> ? exc_invalid_op+0x53/0x70 > >> ? folio_memcg+0xaf/0xd0 > >> ? asm_exc_invalid_op+0x1a/0x20 > >> ? folio_memcg+0xaf/0xd0 > >> ? folio_memcg+0xae/0xd0 > > > > I might trim these ? lines out of the backtrace ... > > Do you mean make backtrace looks like something below? > > Call Trace: > > split_huge_page_to_list+0x4d/0x1380 > ? sysvec_apic_timer_interrupt+0xf/0x80 > try_to_split_thp_page+0x3a/0xf0 > soft_offline_page+0x1ea/0x8a0 > soft_offline_page_store+0x52/0x90 > kernfs_fop_write_iter+0x118/0x1b0 > vfs_write+0x30b/0x430 > ksys_write+0x5e/0xe0 > do_syscall_64+0xb0/0x1b0 > entry_SYSCALL_64_after_hwframe+0x6d/0x75 > RIP: 0033:0x7f6c60d14697 Yes. I'd trim the sysvec_apic_timer_interrupt+0xf/0x80 line too. These lines aren't actually part of the call trace. They're addresses that the unwinder found on the stack but don't actually fit the call trace. It puts them in in case they're helpful, but marks them with a ? to indicate that they're probably not part of the call trace.