From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74045C47258 for ; Thu, 25 Jan 2024 20:47:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E39E46B0072; Thu, 25 Jan 2024 15:47:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DEA146B0075; Thu, 25 Jan 2024 15:47:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CD8666B0078; Thu, 25 Jan 2024 15:47:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id BE9746B0072 for ; Thu, 25 Jan 2024 15:47:50 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6255CA24E8 for ; Thu, 25 Jan 2024 20:47:50 +0000 (UTC) X-FDA: 81719019900.13.3A12964 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 9418310001F for ; Thu, 25 Jan 2024 20:47:48 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=N6o2AsrF; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706215668; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BBqOb/ZqrKdawgvhDpAKr22AD6q4pmmVnTFBoWIGiU8=; b=rKoKLVHrtDQrZIbtnRtL3CnDIFuNZUUYZ/A7/DOBcwN058D0tse+YjV2TvUSv3KLHwXRqk lDskTkFY4wRBoUwTa8fjOBzVmcCyO0uMrsXbQ898zCGg2KJAfhbps43+AclSj0aakh60/v d1uIA4wgr8VLeBFsIQJ06fVcvtiw/qE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706215668; a=rsa-sha256; cv=none; b=u8q5d71ru9dYC/sbPe29fXrOSt/qBB8HtgEouywS0xJLdtV0N39KAxSQ3f74Dd5oeeDc2n Uo/IeUlYtIWqubQWjdgLz3+PNDvKUd6rnYzooFHh2IBp/+wFsq1/iJAcBqy+y5xdoDs5ZQ rj9Y9pPi6lkkJ/2yy/BjV58snBXT1YY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=N6o2AsrF; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BBqOb/ZqrKdawgvhDpAKr22AD6q4pmmVnTFBoWIGiU8=; b=N6o2AsrFBnAxGhkLunHLObyk6I e4zIFiWfoXqIX1uGE4X5PvacBk28dmC5837lBiaHc/0AwORUO7ROgg+Nl8jhP+maRD+1utRm1Bh87 oEL1gHoCpSocSeYW41GJz3OCLXYq1nTa7wVQqyohz3CxubRixhcW07tzQGKL/q3eQ+HANlwcc+W3Q Im+GTbC7oygnNpQRb7DI/08r6ASMkp1NGYRXZUA6iBam2ELid26Sve4ryqWxQBBMSdKIbjI+VGP0t Bdt8FM3sEOJrJdcoFkIeGXjiHxvruvxzYaK90OD1m4gPm/RJuL6zdClJzEDiEWxpRaVf/KfMY3YtY qnxp6K/g==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rT6dP-0000000B791-1vmr; Thu, 25 Jan 2024 20:47:39 +0000 Date: Thu, 25 Jan 2024 20:47:39 +0000 From: Matthew Wilcox To: Luis Chamberlain Cc: Pankaj Raghav , Jaegeuk Kim , Yangtao Li , chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, fengnanchang@gmail.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, vishal.moola@gmail.com, Javier =?iso-8859-1?Q?Gonz=E1lez?= , Adam Manzanares Subject: Re: [PATCH] f2fs: Support enhanced hot/cold data separation for f2fs Message-ID: References: <20221130124804.79845-1-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 9418310001F X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: wr3mky9t9fasia9g8335egyso7i6hybm X-HE-Tag: 1706215668-605611 X-HE-Meta: U2FsdGVkX1/tgTa5WJRHkgra0qeFifDLdRp2APvwcNwa8j4e7ZUFiIrulah+g+k5bqH3E1ercjO5Q+bpPy3FPcJDjngPiaEhE6ERS9NGSzaM19PNVOcmI8mOa57aLytYvIWWjgTjfvxagNJpQ7FmcUEWBTqP+DNLPrSrPsYCIQwBYhtd7aG/H/i7CKk/2ltsvzMPSyTl9l+eYrG1pmkqTByqqD2+duXMZZubj6wqFeVOvLD8WgGLqYdb1DxiPyPamWXNy4tGQE6LZ2ljnJCfSLGQ9zlPteX+HyTh2DFsWwQspzRjL008wqY8MAXMTksrYv32Yj9+D4CN9qErHMXZte4UVnoupnI9LmBs1xACUytWf737eWiL8Wuh2PiXfXUkPpFJpz37G8gCMSrdyWo/ufmWXABnX7FMulL8JDq5QY4ha52lNYWx32RBoRex6JiGA7qgNlUbd4tKX3bVRssfenfLc9GMvhT4Ika7gUtutXAN7+XMSZX324fjVah1lObpwDVID6Zzjb7x3P6JsPLwYWqq5zRYV6XDOBvJGOAGsMZY+5DcFxJqh8qJz8ECslbZHDjLe442tAUNV5j/KF4iwexgodLkwOHka8lBCcniO/MRAsRsLb1JOIogTP3NwgNaNiaHw8jEaDDKf9MGGFTQXKC4QnvBRxNO8n37s9aAVHbVVbPFUKf9D8hpZMkISP4b23Htov2UPXEEbelwemk79/fgospsai0IGfcUOiYoSaiLFviizE1520Oy8mJr0XyZnVsZDU9AiO7MNjn86xzTiQc1np5sPX78LbFvOMF+eyYARzoEXwsLuDpkLnoejIyuuOfCdQt97MFN2u0my1EyVtCq5VcPkidJwRHczwLX2huL0tFG4i9aiKzZgdBb4dovZHDfqpEC4mrla3NT2TL0n8gZQil9luxhsiTZYhZa00whbnR5/cmf6m+YwZ0+wYGmiQ9jJAISGpJelwxDzAI tBdqnHtf VQsafPY/WzZUa38qrU4KYK+XxJWXgRayooAj36CYrZ7gdBxFX+Jm6Vh/JJOHuk4mEmJ4C7kJvXvkiFiSl3koprzRwP8wag3BqwP7yFAoPYscrgKClX9d9AhIcPm6oIapTWrybL5JhjA+j+Wy+Q7JdLC4zeP2hXpdWg/vAjVv4icy7USXBQwe5zk8uLDlJYmzVXSseP4ofRje/VFqhkcFF8YwsNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000015, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 07, 2022 at 12:51:13PM -0800, Luis Chamberlain wrote: > On Wed, Nov 30, 2022 at 03:18:41PM +0000, Matthew Wilcox wrote: > > From a filesystem point of view, you need to ensure that you handle folios > > larger than PAGE_SIZE correctly. The easiest way is to spread the use > > of folios throughout the filesystem. For example, today the first thing > > we do in f2fs_read_data_folio() is convert the folio back into a page. > > That works because f2fs hasn't told the kernel that it supports large > > folios, so the VFS won't create large folios for it. > > > > It's a lot of subtle things. Here's an obvious one: > > zero_user_segment(page, 0, PAGE_SIZE); > > There's a folio equivalent that will zero an entire folio. > > > > But then there is code which assumes the number of blocks per page (maybe > > not in f2fs?) and so on. Every filesystem will have its own challenges. > > > > One way to approach this is to just enable large folios (see commit > > 6795801366da or 8549a26308f9) and see what breaks when you run xfstests > > over it. Probably quite a lot! > > Me and Pankaj are very interested in helping on this front. And so we'll > start to organize and talk every week about this to see what is missing. > First order of business however will be testing so we'll have to > establish a public baseline to ensure we don't regress. For this we intend > on using kdevops so that'll be done first. > > If folks have patches they want to test in consideration for folio / > iomap enhancements feel free to Cc us :) > > After we establish a baseline we can move forward with taking on tasks > which will help with this conversion. So ... it's been a year. How is this project coming along? There weren't a lot of commits to f2fs in 2023 that were folio related.