From: Matthew Wilcox <willy@infradead.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Chandan Babu R <chandan.babu@oracle.com>,
"Darrick J. Wong" <djwong@kernel.org>,
Hugh Dickins <hughd@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-xfs@vger.kernel.org, linux-mm@kvack.org
Subject: Re: put the xfs xfile abstraction on a diet v2
Date: Fri, 26 Jan 2024 14:15:44 +0000 [thread overview]
Message-ID: <ZbO-kMfwhg1TAGn5@casper.infradead.org> (raw)
In-Reply-To: <20240126132903.2700077-1-hch@lst.de>
On Fri, Jan 26, 2024 at 02:28:42PM +0100, Christoph Hellwig wrote:
> One thing I don't really like yet is that xfile is still based on
> folios and not pages. The main stumbling block for that is the
> mess around the hwpoison flag - that one still is per-file and not
> per-folio, and shmem checks it weirdly often and not really in
hwpoison is per page not per file. That's intrinsic to, well, hardware
poison, it affects an entire page (I'd love to support sub-page poison,
but not enough to spend my time working on memory-poison.c).
In general, I think there's a lack of understanding of hwpoison, and
I include myself in that. Mostly I blame Intel for this; limiting the
hardware support to the higher end machines means that most of us just
don't care about it.
Why even bother checking for hwpoison in xfiles? If you have flaky
hardware, well, maybe there's a reason you're having to fsck, and crashing
during a fsck might encourage the user to replace their hardware with
stuff that works.
next prev parent reply other threads:[~2024-01-26 14:15 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 13:28 put the xfs xfile abstraction on a diet v2 Christoph Hellwig
2024-01-26 13:28 ` [PATCH 01/21] mm: move mapping_set_update out of <linux/swap.h> Christoph Hellwig
2024-01-26 14:39 ` Matthew Wilcox
2024-01-26 13:28 ` [PATCH 02/21] shmem: move shmem_mapping out of line Christoph Hellwig
2024-01-26 14:40 ` Matthew Wilcox
2024-01-26 13:28 ` [PATCH 03/21] shmem: set a_ops earlier in shmem_symlink Christoph Hellwig
2024-01-26 14:41 ` Matthew Wilcox
2024-01-26 13:28 ` [PATCH 04/21] shmem: move the shmem_mapping assert into shmem_get_folio_gfp Christoph Hellwig
2024-01-26 15:09 ` Matthew Wilcox
2024-01-26 13:28 ` [PATCH 05/21] shmem: export shmem_get_folio Christoph Hellwig
2024-01-26 15:15 ` Matthew Wilcox
2024-01-26 13:28 ` [PATCH 06/21] shmem: export shmem_kernel_file_setup Christoph Hellwig
2024-01-26 15:45 ` Matthew Wilcox
2024-01-26 13:28 ` [PATCH 07/21] shmem: document how to "persist" data when using shmem_*file_setup Christoph Hellwig
2024-01-26 15:49 ` Matthew Wilcox
2024-01-28 16:54 ` Christoph Hellwig
2024-01-29 15:56 ` Matthew Wilcox
2024-01-29 16:04 ` Christoph Hellwig
2024-01-26 13:28 ` [PATCH 08/21] xfs: remove xfile_stat Christoph Hellwig
2024-01-26 13:28 ` [PATCH 09/21] xfs: remove the xfile_pread/pwrite APIs Christoph Hellwig
2024-01-26 16:21 ` Matthew Wilcox
2024-01-26 16:48 ` Darrick J. Wong
2024-01-26 13:28 ` [PATCH 10/21] xfs: don't try to handle non-update pages in xfile_obj_load Christoph Hellwig
2024-01-26 13:28 ` [PATCH 11/21] xfs: shmem_file_setup can't return NULL Christoph Hellwig
2024-01-26 13:28 ` [PATCH 12/21] xfs: don't modify file and inode flags for shmem files Christoph Hellwig
2024-01-26 13:28 ` [PATCH 13/21] xfs: don't allow highmem pages in xfile mappings Christoph Hellwig
2024-01-26 16:26 ` Matthew Wilcox
2024-01-26 13:28 ` [PATCH 14/21] xfs: use shmem_get_folio in xfile_obj_store Christoph Hellwig
2024-01-26 16:29 ` Matthew Wilcox
2024-01-26 13:28 ` [PATCH 15/21] xfs: use shmem_get_folio in in xfile_load Christoph Hellwig
2024-01-26 13:28 ` [PATCH 16/21] xfs: improve detection of lost xfile contents Christoph Hellwig
2024-01-26 16:33 ` Matthew Wilcox
2024-01-26 16:50 ` Darrick J. Wong
2024-01-28 16:55 ` Christoph Hellwig
2024-01-28 20:33 ` Matthew Wilcox
2024-01-26 13:28 ` [PATCH 17/21] xfs: add file_{get,put}_folio Christoph Hellwig
2024-01-26 16:40 ` Matthew Wilcox
2024-01-26 16:55 ` Darrick J. Wong
2024-01-27 1:26 ` Kent Overstreet
2024-01-27 1:32 ` Darrick J. Wong
2024-01-26 13:29 ` [PATCH 18/21] xfs: remove xfarray_sortinfo.page_kaddr Christoph Hellwig
2024-01-26 13:29 ` [PATCH 19/21] xfs: fix a comment in xfarray.c Christoph Hellwig
2024-01-26 13:29 ` [PATCH 20/21] xfs: convert xfarray_pagesort to deal with large folios Christoph Hellwig
2024-01-27 1:09 ` Kent Overstreet
2024-01-26 13:29 ` [PATCH 21/21] xfs: remove xfile_{get,put}_page Christoph Hellwig
2024-01-26 14:15 ` Matthew Wilcox [this message]
2024-01-26 14:18 ` put the xfs xfile abstraction on a diet v2 Christoph Hellwig
2024-01-26 16:47 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZbO-kMfwhg1TAGn5@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=chandan.babu@oracle.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).