From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78EE6C47DDB for ; Fri, 26 Jan 2024 16:33:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EA9B6B0093; Fri, 26 Jan 2024 11:33:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 09AFC6B009B; Fri, 26 Jan 2024 11:33:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECC106B009F; Fri, 26 Jan 2024 11:33:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DEEB96B0093 for ; Fri, 26 Jan 2024 11:33:45 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 851FA808D8 for ; Fri, 26 Jan 2024 16:33:45 +0000 (UTC) X-FDA: 81722008410.29.17C34A1 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id DC149100024 for ; Fri, 26 Jan 2024 16:33:43 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PPlDH2h3; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706286824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T2FEK9DaSYNLvAf9tDBZboB/NTfQJJZt6JciDg2qLws=; b=xzM5kB76ansH0ZxLMNv8vzaRTZo+5ml2T7Ynetc99RiWcbzP1o6+sHxWojEUAfaO/DfyaM UOGKe/msZ+oZruGaOnPgx/rjQNjqGd2tTpaHPfTz21eBgGBDfg5Y4r8evnzVs77/ZW3NUP NYYIsKXH4Q5TO6OuxheFe7CrHHb/Ax0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=PPlDH2h3; dmarc=none; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706286824; a=rsa-sha256; cv=none; b=EC8+C5c6mFlCBpteDMn0F2l8Lxybx6AcqjgRwdG6K5SQIWd30/JQHCeDyBwPksr67nxqoz DGHChthMQ/WQy1yFThV+woDZj8Ev71sOfu5MqUsuY8AKMHQ1BFCp0TIGjazvYFLi2Cg+IM OC9okF3hwLvyfnHjqbDZ9vpY+kG3hO0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=T2FEK9DaSYNLvAf9tDBZboB/NTfQJJZt6JciDg2qLws=; b=PPlDH2h39TrvZdVurqByVwdPEn yMq50gCimBfF4AtswLNd/BnFi9lvROVNuRxc+v08KGTaRWmppzMn29f/jPgA9iM3uITPJz3gRUsaC eF+Ug4zr4l5JsUCmVyjixBSgtYv4yFIOTp3gaON4Y+VSOf+2slX+yig0tgY10q23cyrd6VxJy9+7J 1EoNqzTmkxcEJkW4qljhmBXxUDhy4k/2+XuNnGTA1DqqzCvjjJy5gTOFoPlaXbvLDf1SmBeifUblE wokzTLqMqYmAf0k9CibWccPHY/4t1/iJsK9r8YN8amO9Y+5DfCw2vOcKU95zgMmmK1WIENVkD7JAj ZHivi1Rw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTP9A-0000000EBDQ-1bM5; Fri, 26 Jan 2024 16:33:40 +0000 Date: Fri, 26 Jan 2024 16:33:40 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 16/21] xfs: improve detection of lost xfile contents Message-ID: References: <20240126132903.2700077-1-hch@lst.de> <20240126132903.2700077-17-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240126132903.2700077-17-hch@lst.de> X-Rspamd-Queue-Id: DC149100024 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 718w3f58hmc4hpcr3psczxgkt51fsgcw X-HE-Tag: 1706286823-98210 X-HE-Meta: U2FsdGVkX19JrCeex8X6pLMKXwEfv04d0zXBbak4mgppNXo3GpKowUm/I5H06ZFST+7tbhlxmnqC6eudyoV2L1hyW8xPU1Q0wEOs1hQhfsh0Ea+KRgT3/eTL4jYBL2ufTwUF8rcCpdoNfoNHKsUPmRlg3wBpCrueSrloMMgKDB6BIjTsMpwUZS6+2oJCWhHLhQ0uC/+JvmE1DrOdz7DTYO9EoAajVmJu2D785eharZWzDpJ4q9Jix9j7gf6VvMA5dbob8UUuXoY+T7FRPYOcsdQb5pxay2e7JKf+fSkjy0SbnF7uIvFuMRvBGTWrcpmmiHd6fIXkIcuEYP2aP2nbgZdGcY3+ggx2tyfwMff6HWaWaARWHPG24uk4uupSthVEZNei78egbdzC5RncjKWcofPgGWuAigJufijYK22mvd5LiDOrErOBBBzz1ARoGMR8ek7Rpg2NVG20RHpNlfuSWaTPlWqUhS+Z0OYtong5NhhgBbNS8fzsT5q+C5trmD0ZEIjF0SBesqDvNj85Dg9JU84b/q/zSIVW/wMdMZpg1NkHSv/VoLvUJNu9DRQXIiQjT6m5LLJR5TVckv29q83lS8OJObcJb9xLnanho+LrDI3MeZkt+HoTB4corpFKMLpWSHpjxjTy+6mNt1vgUYNefLQpiRbhBctdRPnq3mAvqzEBEpJzEgLzlTo0sbkZSOmgWkf0KAqNb2mBxw/jU84DNyzy8c85HMMh6uegmvrIc4enjr8sRcj0f5e52TAQxNjqBeoff1pA8My0SGmUtW81vOzhosn1KCOWa17R1zu06eyLimosGic8A9JUIYE46ctHU9dcvAUSkl/r+GEYF2LN9q9IGY7q6emt5W6FjcCgrIarheNuJCDLArEwFS4pdeFt2NF1Qg0/fHeDOonpEY6fdWzEqFS8yOnopmryu2Fo+Swxzb+CV037lmLQEH+xMsny/2Wbhl/s+1D6TBTPhKB R1gP8BMd T7/6lGguAolR5RTDmnH6leoMYzZUm+FT8oYTlJs3igJ1ogkTmnwkFNhALPDQENLGItgqe7mI2MpQSoWx8u5f5misur3k68qDmFIr73d15i+smZMhXOjRWu/j+Bkgop6MbXf7117GX3RLWBHg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 02:28:58PM +0100, Christoph Hellwig wrote: > +/* Has this file lost any of the data stored in it? */ > +static inline bool > +xfile_has_lost_data( > + struct inode *inode, > + struct folio *folio) > +{ > + struct address_space *mapping = inode->i_mapping; > + > + /* This folio itself has been poisoned. */ > + if (folio_test_hwpoison(folio)) > + return true; > + > + /* A base page under this large folio has been poisoned. */ > + if (folio_test_large(folio) && folio_test_has_hwpoisoned(folio)) > + return true; > + > + /* Data loss has occurred anywhere in this shmem file. */ > + if (test_bit(AS_EIO, &mapping->flags)) > + return true; > + if (filemap_check_wb_err(mapping, 0)) > + return true; > + > + return false; > +} This is too much. filemap_check_wb_err() will do just fine for your needs unless you really want to get fine-grained and perhaps try to reconstruct the contents of the file.