From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 551EFC47422 for ; Fri, 26 Jan 2024 16:41:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0CB66B008A; Fri, 26 Jan 2024 11:41:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DBCDD6B0095; Fri, 26 Jan 2024 11:41:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C83FD6B0096; Fri, 26 Jan 2024 11:41:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B87A56B008A for ; Fri, 26 Jan 2024 11:41:02 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7E2411A0585 for ; Fri, 26 Jan 2024 16:41:02 +0000 (UTC) X-FDA: 81722026764.05.E648A79 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id D40AE1A001F for ; Fri, 26 Jan 2024 16:41:00 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JmFQDTqK; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706287260; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9e5wKxEjraETE54fr2R/8FQJEBN+YlpNRgDqH691Hhg=; b=U5koWq6Fk5vtQSqFT3N9DHTUK1ZZwvJWu/qEwHlA5KyAbqmjAftxVWa8zeGoNAsGiu5bL6 y3RVa3jEowQ2ND9QZ06nL/BFt/MNLaAtJlta6msEpZ/Rj+xWRDZUnQEF9/USbCpQDrug9B GfsZ2F8BVE12qDWj/vd6i99+fi4Z9FE= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JmFQDTqK; dmarc=none; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706287260; a=rsa-sha256; cv=none; b=iVMiydw+KMPWucrjAosrQz/+zkXMJHDxaN2EBFaAuNJ77ZLXyBp4N2U1vSDQlfIblFVZ// WPFvkoVe7VFmvD4vYyunfdj0rrV1858v5hUJAlqptPJP+dF8RbQ+tzTZ0IfSDgN9Ke3XoC 61lzg+VwvW63HXtvo2JbTYV9KdW3Ap8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9e5wKxEjraETE54fr2R/8FQJEBN+YlpNRgDqH691Hhg=; b=JmFQDTqKnsewIiYyKzTVdLKMEU nZDays14WGsmy1rw2Nx7noHSgPneNfwt6UwmZA1LT+ntC+s7XBxtMZhYfUphPpa8ZYnJhnlJw0o1t 4vgLj9LO84tkJqWcXIzOrjlnjyKRmyAc7oUflqc2kmjGDuU4DH384YnegCkfoWr6zqESynwquEpd5 EjrXgKIthVirdeRoE/0WKWrsETCYKMZThuzxERGzupNwrhjtbcrg9ihPY8l4SFT3c/U6zhIUt9/jB BkbeyGRnO6QULaJdPgryUsZ6dGb9V5pnRsEryy//4gMCW3ZBfsJMLQlsdIlRqdzYO61joj2T01P83 I2nUgxXg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rTPGD-0000000ECPG-1ju5; Fri, 26 Jan 2024 16:40:57 +0000 Date: Fri, 26 Jan 2024 16:40:57 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 17/21] xfs: add file_{get,put}_folio Message-ID: References: <20240126132903.2700077-1-hch@lst.de> <20240126132903.2700077-18-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240126132903.2700077-18-hch@lst.de> X-Rspamd-Queue-Id: D40AE1A001F X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: wq5pxxjn34bqxk8ecaennkfegddxrho1 X-HE-Tag: 1706287260-748093 X-HE-Meta: U2FsdGVkX1+Abb8cS3MzBNyibTR7tRpxO5kUW1YQTz8BtfSXjWiCiRiYrl3yilpxGeO7Bg7agUc1d1AxnHihsEaWefChzy8MrLw7EHcvDDwVvrI0qxQE71F8aawqT2mjP/qFyBC3X9m7dtOFVc0iUd8BVpMDLX8FET+CD7hNmBJy1qycQgKfwUaNj4wjVH9udRL3ggBQJXztysE1WtzHwlLLtgJ+3UQwW3yr1BrUyrIoqUF/zXFYR+XFYmApgHzMob+FMJFjfIezTbSVgZg0aKd9B6jYftfq3bvRNJokEtCf2LHmufHzYoW9pFLAYcy7As9nZhdLdxJAVTuZlft8XODVstDncZXtPvig0Si4kLQ8U02s6Rp5iCJb1UtcEzB0CwrUDA3HgUoP7Bzm0LFip+f5s1639zwDRJMlDgPVq+3CioCjaCsW1g00d43E/ixuaZ0+uTqf0ut/O+7whqz95T9b5tkx2FcSCs9as4Ze5j04iDPzKpa7fDt/Pee+mstkdwSu0eF9YosR/b1lusm+kA5CwMdGpsukNwc6X1f1GYEru2miPssuZFwN/AxW0IHk2W+/QnCwvyuzxTxPnxBDFdG6+Apra2LMJbzFTAwJ7Sh7kgv1slNmqRiwy7qr8IvfXIaupYABM0SiPZ4w5OR76akTaeTJA4RPmeAgRP0J2rmDuY8YfUqPzykrds8kOVRlSfgtXf34qpCCztnmD0KGVMAire/r+MS5IaGImsFiUGjuNLdnpXn6DQZCZK1UZIW3gmZzN7A/mIXIF7Yeiyxfjm41Kdcziu4RCVMj4raBOmBG3CiaA04shk/pnIJJrreVNSMeSDv5LjYIecRs4uK3eBPkrw8eFPXYvnxUrtljlXzSNByB0avYKtzfGhE7wy5fGZsJwtCl2kwS5Vk3v0D64pQnICZoYe3Xdtl7NbXVqtzt42+U1P66IbdNPg9SjAVsIGAYunyH031kQeILswX 2f5DfDrk haFcYHPdC4xPfBK+L2//9Ze8xTtbIWwEQp393wmTtD4B2cb8TnF5Ya65gJFa5TMA1RhUlitbVbzWabzmfn61BUT3lMxc+55Vf/xCjmAwF7oF885QVY6VqdS/1ATukz3dqEZDWB8XT9f0HNj5+zpWprDCkjwH2Oh+8F8hWSRLhQdqjMnCxvVDCV+d5mg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 02:28:59PM +0100, Christoph Hellwig wrote: > + /* > + * Mark the folio dirty so that it won't be reclaimed once we drop the > + * (potentially last) reference in xfile_put_folio. > + */ > + if (flags & XFILE_ALLOC) > + folio_set_dirty(folio); What I can't tell from skimming the code is whether we ever get the folio and don't modify it. If we do, it might make sense to not set dirty here, but instead pass a bool to xfile_put_folio(). Or have the caller dirty the folio if they actually modify it. But perhaps that never happens in practice and this is simple and works every time.