From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24812C47258 for ; Sun, 28 Jan 2024 20:33:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E6286B0080; Sun, 28 Jan 2024 15:33:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 796556B007E; Sun, 28 Jan 2024 15:33:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65DF56B0080; Sun, 28 Jan 2024 15:33:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5689A6B007D for ; Sun, 28 Jan 2024 15:33:29 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 00DCB140719 for ; Sun, 28 Jan 2024 20:33:28 +0000 (UTC) X-FDA: 81729870096.26.5722433 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 8B88E140002 for ; Sun, 28 Jan 2024 20:33:26 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oqnQIp+t; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706474007; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IZEIuzWowjgS5paVGB9Th9MFI7haSD4QDPVH8hqmr8Q=; b=5KLDp3+DyFHLQYIXMjYCMmBTMrTzu9ce+imCTuWQnGOd+wvPd1Py2mM5bf1Jz1CHq4hDD7 13os3L1t4mTSb+P+YSEdtI3y4fQU9v53mvGYVbl7JzTG0E5sbbDZiuRAl9Pyt4mfsPRdHP 2rx2dnKIJlrvAEmhHoAUkyg2+xjIYhQ= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oqnQIp+t; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706474007; a=rsa-sha256; cv=none; b=YsLgh4oWB85tDJ4PvgeaOeheyZ8m9uo/YZvhAHNWioEoXwD0kaTFCFJLZ69sETtbrMEKTF 9mik5e/Nh6VwIUgZyevovI+FVR76et1hMKW790hFis6A5qfQhtqvuIyNShoORPBYA47R8z ucoymPKLQHNqo07lZ4QfUiCy5l8LU1w= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IZEIuzWowjgS5paVGB9Th9MFI7haSD4QDPVH8hqmr8Q=; b=oqnQIp+tGoCwXg3AX5ySUTiKnx 13q0cLtA01S03CnX0BvnXvmGb+kyK0eQG5q1XZQXg1VoTPvvv+AHJnKUuixCYy411HNRHCLd+fNRG PvoYvXlC5K4ngxC5yhj+UtSiqqqvD/tInnu29iH3gzokOn/30ZXd48a751ghasoVVKz8ukeQxMpJO zoL1N8noutboa7xeU44qU7kOEF9p/jdAsgCYCTd7eBWjhdDJ/BZsOZ9AYcsf40W1PtRORZnDOwzy3 Ro8e7AhfQ50dDGQyjJLvbQsKxeGt8u5nIPQagqh3PcRb5gUvBowbPOAoao7T+0vs0bmIaUH6tPYth 8hMUlsZw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUBqC-00000004UMo-21gF; Sun, 28 Jan 2024 20:33:20 +0000 Date: Sun, 28 Jan 2024 20:33:20 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 16/21] xfs: improve detection of lost xfile contents Message-ID: References: <20240126132903.2700077-1-hch@lst.de> <20240126132903.2700077-17-hch@lst.de> <20240128165549.GA5727@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240128165549.GA5727@lst.de> X-Rspamd-Queue-Id: 8B88E140002 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: nt1przyugg6yn1yu1gn86uojn5tqwxu5 X-HE-Tag: 1706474006-895486 X-HE-Meta: U2FsdGVkX1+QfcDk53i1r6wB5Ykf8FoZzETH7DuYQVqyuV/IL5tGoYuxXQzHOMB48AP8tJ8UUmG+WXXWn1PpYMUKEYb4ElTKWAfZKsSaf/1bIoFFXar+efUYFGRmKlO8goXuAzTPuPu7a4MIt4/BdHckwJGA/A++K3ktecSkjekCJFIqXOdn9H1O0BV8Cd5LUUuRFr04AyEBG+uGXCIX+1FTxhmLoadrrROr0n05ih9lhBLENHplSjgusasbsGx4BnaxIsONunjp1lsBM0K9wywNbPI0cftN2QfCg+LgII0bgy0+KOm6Qx4MjCuVvN+XWCWDgEg/k80prrgMrzFdoQ1S6JzlQOUOTz2r7xqV/nKLylwnkvUxLx/EZEEYPmJ+0eA0M4PxsmgbKkx5rZ+muWWZDskIuvlqqHBmFOUyZTF6Fd5EPOZBhyiePVRn0N1qUp2PPYqdvXRUHeOUUNG3DdRxWhnUqdjnlvQ+VmAOz8gKpWR1zPS9yw2aWyyNbps4arH4eAty4Yc1pYs58j4rJK7AMZnwqLgEEcA/kCxgNDArsEe79aPj8FRLE5vKnM19sbup9XVhuF1tXkOFbzx6Z01WvjU8ztR6FgZse1r0yIve5ZtSjll1pvvlI09Ze1Hii3u6DpmV7aPt6j5N8pSvD+koHAGDI92JSfE0F6KLKGe04aJ+o59awoJcSRB7slaxFc0zyDwE8Ps8QLERA9p6GV47sbbFxv5tnO2cqFg4yCGKJBq7NQXFhyZNbLtVykuFM7hsOQEazHvYbPNcRgw2EvXSrfwZsS6HDHLXRxVyZtAdqpBp0/AsJhodbitrtOu8Tc47sANlD8/bCvewqkINrHc/p50jzLBephHM9M8bKPs2TsQzTIkGfneVRx1Lp8KXp+VUcGcx9Rr2osrfSl6tK1P6hTWIaoTqlSvFk+sogKHKfLMdcu14sZ6wBxBCXe2jnhBOl3MJFjPBUlHLueX xqY6jp3E ybzVmvaNey2FXV109MWwNTOc6PW005tB2tR8iTtCu80yvwfrnBCnhzJZpevQT/D/6oWEufjixgGKbTxP7RMlVf/vwm2y9D1e6A43J47UkCstUtUfubQrTfMwTGbavEEM8epXZ+G0PNth131k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jan 28, 2024 at 05:55:49PM +0100, Christoph Hellwig wrote: > On Fri, Jan 26, 2024 at 04:33:40PM +0000, Matthew Wilcox wrote: > > > +static inline bool > > > +xfile_has_lost_data( > > > + struct inode *inode, > > > + struct folio *folio) > > > +{ > > > + struct address_space *mapping = inode->i_mapping; > > > + > > > + /* This folio itself has been poisoned. */ > > > + if (folio_test_hwpoison(folio)) > > > + return true; > > > + > > > + /* A base page under this large folio has been poisoned. */ > > > + if (folio_test_large(folio) && folio_test_has_hwpoisoned(folio)) > > > + return true; > > > + > > > + /* Data loss has occurred anywhere in this shmem file. */ > > > + if (test_bit(AS_EIO, &mapping->flags)) > > > + return true; > > > + if (filemap_check_wb_err(mapping, 0)) > > > + return true; > > > + > > > + return false; > > > +} > > > > This is too much. filemap_check_wb_err() will do just fine for your > > needs unless you really want to get fine-grained and perhaps try to > > reconstruct the contents of the file. > > As in only call filemap_check_wb_err and do away with all the > hwpoisoned checks and the extra AS_EIO check? Yes, that's what i meant.