From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AC17C47422 for ; Mon, 29 Jan 2024 11:53:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A2A516B0099; Mon, 29 Jan 2024 06:53:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D9746B00B6; Mon, 29 Jan 2024 06:53:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A24A6B00B7; Mon, 29 Jan 2024 06:53:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7B3A96B0099 for ; Mon, 29 Jan 2024 06:53:34 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 556F41409E1 for ; Mon, 29 Jan 2024 11:53:34 +0000 (UTC) X-FDA: 81732188748.17.AC46884 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf21.hostedemail.com (Postfix) with ESMTP id A0C191C000B for ; Mon, 29 Jan 2024 11:53:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706529212; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=if2n03CMgAlf7nijefok4vkk2tA0wzYdWX1B+N/hS4I=; b=zAFMvjXZww4tMuNrSU+GmwpNuqLG62wH0JMbq0DHOftStbgH0fc3q1ELfDc4B39u2Eyobz DD/O/bHxian8slPRXnhoCGRd4BLHPm7gbmpESGz4kC3j42CWZXH0JrIJ13/NHQ+t/qgaiq QyYSHp86su3Hu6/DA3OQ4olPenRYvT4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706529212; a=rsa-sha256; cv=none; b=kTpknf5+jizXEhkGxDdm3yEV/7oCIO/YXK1Edoqsq1N5ELqkDtUXvZwJJoXbu8SdBRdOIZ 9I2yW0og4PnyQsleBTDoPJn2f2qqapOWiT/NbBMkeR4FVnGuMHu8X7yaVmtKpBL2anuavZ 3d+0oQbNd5Ex4njD7IcFJfIney5Bhho= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BAC471FB; Mon, 29 Jan 2024 03:54:15 -0800 (PST) Received: from raptor (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 830E13F5A1; Mon, 29 Jan 2024 03:53:26 -0800 (PST) Date: Mon, 29 Jan 2024 11:53:23 +0000 From: Alexandru Elisei To: Anshuman Khandual Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCH RFC v3 07/35] mm: cma: Add CMA_RELEASE_{SUCCESS,FAIL} events Message-ID: References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-8-alexandru.elisei@arm.com> <545bb7bd-31c7-4166-9f81-778b82ece6d4@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <545bb7bd-31c7-4166-9f81-778b82ece6d4@arm.com> X-Rspamd-Queue-Id: A0C191C000B X-Rspam-User: X-Stat-Signature: dbd4a38qtjdhnnohqccjojkw5w9rscbr X-Rspamd-Server: rspam03 X-HE-Tag: 1706529212-686693 X-HE-Meta: U2FsdGVkX19rcqpyWQg/Na4XhzxipXFZAWLZoKrMUEdF09OY5/tKsn3y3adRhJrY6qfcdVB5l7qGASbjJGQPiYDuJtjqgSoWD4JpBxM1/W94MnF5atGU6Qll20mfQkGHENQd3Wg9pgREesVw7nUZoI+f3pYF3d5Th1AFJPtH32lLLc0dLeWZ7J7v7qJdtFe9NLguEP/p1PAbjze1JFmObM2r1FEXESvOiSFhIYapGg9jtcI2W8pGJ3gOmb1XJIxy+dca0yR3qoV8JYhzvBDwrEeymVWmthtWRWrCDbhsJgrT6k0crsqSfZlhqvxajFRuKuTn4VMf3Gww0bywQUv1HDRZdXs7uV5yr0ShIVBUTeeBZnZuhGB9kySbWfRN8WPmIZWAY0VwehlJ41zQm4h8cK4g9XBWVXI8Dpw1Yr9BLOVUeteuZfP5omKKvBrfQi11eFdr6fa7mxjbSEQNx3YxDLjrVmnCk9k2LVPNpW7ucjEHdKnHrkU9K/LfLGXeIC8dJ18QW1m1xlZRTa51dAcqUOsOB534eEgggmIlIZDMDHn2apxMX4rl72Q+oGBJ1RGpX/RPqkaPYULquNV6nrMj3BGsM8dLtJi4VQuvOrUagoVFmeta1FM5vfzM0+HoYlsXZWhMFJZCSzPrNYFN6MkgBFk2ll+APrft4mslJnsMZ0sbHDQDa2dk0yL6/E+V9fVE2QQH5aD2nWXS9UZFj1ZCGuV9MuPdptBKS3b40/VIwoAl8q+462+GeZQTyASq49uhicx9nmOwtvui3ckZKgaVTlqtAZuQGLsBhLB7suKzy+l/mRkfZgXHL5J/wCFySUgLktH+KBXiNfFBk/GF08Qhl1VGJ03FzlMKXIwXoWHWlXifVJiZSIvY8MyxrQYOzQZCrOZNuLiYXsNPA4CMSnnfKZUS4ShxV0zIm4DHTJvznpRsgjlDh/yPgGUCZdJ8QpQWYRPI5CTEQ3k1rRFVu9l z+R3c2m+ 9i8NR55ST1ARdmZPZLEOHBdfbPJSgQ2u4QFaBoQr7B/I8oICVFMtwOxuZoDcPSpsyILnPEo4p19dIfaQHQmgylsyAqJ00lwg+nwsAEXRWPm6Gyh/WZjY5Xe7mVLBqPvxtBmhcMTAF0uAlVPNsQJPUBn34yTs8MlFsOn4L3flH0yj6JONyTmXFStc8NLkkA1F/MyZCVlTUCkjWjosMyA9vAAYfkQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi, On Mon, Jan 29, 2024 at 03:01:24PM +0530, Anshuman Khandual wrote: > > > On 1/25/24 22:12, Alexandru Elisei wrote: > > Similar to the two events that relate to CMA allocations, add the > > CMA_RELEASE_SUCCESS and CMA_RELEASE_FAIL events that count when CMA pages > > are freed. > > How is this is going to be beneficial towards analyzing CMA alloc/release > behaviour - particularly with respect to this series. OR just adding this > from parity perspective with CMA alloc side counters ? Regardless this > CMA change too could be discussed separately. Added for parity and because it's useful for this series (see my reply to the previous patch where I discuss how I've used the counters). Thanks, Alex > > > > > Signed-off-by: Alexandru Elisei > > --- > > > > Changes since rfc v2: > > > > * New patch. > > > > include/linux/vm_event_item.h | 2 ++ > > mm/cma.c | 6 +++++- > > mm/vmstat.c | 2 ++ > > 3 files changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h > > index 747943bc8cc2..aba5c5bf8127 100644 > > --- a/include/linux/vm_event_item.h > > +++ b/include/linux/vm_event_item.h > > @@ -83,6 +83,8 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, > > #ifdef CONFIG_CMA > > CMA_ALLOC_SUCCESS, > > CMA_ALLOC_FAIL, > > + CMA_RELEASE_SUCCESS, > > + CMA_RELEASE_FAIL, > > #endif > > UNEVICTABLE_PGCULLED, /* culled to noreclaim list */ > > UNEVICTABLE_PGSCANNED, /* scanned for reclaimability */ > > diff --git a/mm/cma.c b/mm/cma.c > > index dbf7fe8cb1bd..543bb6b3be8e 100644 > > --- a/mm/cma.c > > +++ b/mm/cma.c > > @@ -562,8 +562,10 @@ bool cma_release(struct cma *cma, const struct page *pages, > > { > > unsigned long pfn; > > > > - if (!cma_pages_valid(cma, pages, count)) > > + if (!cma_pages_valid(cma, pages, count)) { > > + count_vm_events(CMA_RELEASE_FAIL, count); > > return false; > > + } > > > > pr_debug("%s(page %p, count %lu)\n", __func__, (void *)pages, count); > > > > @@ -575,6 +577,8 @@ bool cma_release(struct cma *cma, const struct page *pages, > > cma_clear_bitmap(cma, pfn, count); > > trace_cma_release(cma->name, pfn, pages, count); > > > > + count_vm_events(CMA_RELEASE_SUCCESS, count); > > + > > return true; > > } > > > > diff --git a/mm/vmstat.c b/mm/vmstat.c > > index db79935e4a54..eebfd5c6c723 100644 > > --- a/mm/vmstat.c > > +++ b/mm/vmstat.c > > @@ -1340,6 +1340,8 @@ const char * const vmstat_text[] = { > > #ifdef CONFIG_CMA > > "cma_alloc_success", > > "cma_alloc_fail", > > + "cma_release_success", > > + "cma_release_fail", > > #endif > > "unevictable_pgs_culled", > > "unevictable_pgs_scanned",