From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E1A3C47DDF for ; Mon, 29 Jan 2024 13:26:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFE348D0007; Mon, 29 Jan 2024 08:26:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CAD918D0001; Mon, 29 Jan 2024 08:26:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9C818D0007; Mon, 29 Jan 2024 08:26:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A9DA38D0001 for ; Mon, 29 Jan 2024 08:26:13 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 74DCC1A03C7 for ; Mon, 29 Jan 2024 13:26:13 +0000 (UTC) X-FDA: 81732422226.02.E11BE61 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP id 1797A100023 for ; Mon, 29 Jan 2024 13:26:09 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="XtLogM/b"; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706534771; a=rsa-sha256; cv=none; b=hZajzQiG4CZ6ElE3W7xhcujjfSmaSdfh248/cFfYGsCYCoW75uMOoeHF1E4qJzcg7QUR9C LVr8grQOPh9k1IxhHPgvPlM9zENXHRuef++RIOTJErUsMU81ObI0ZC9LKvcBKh7/Q3O4v/ kr0cRQhdt2Pz6nwqI70k+cGfCbLl5dE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="XtLogM/b"; spf=none (imf14.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706534771; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+Xny/9dxsbpogvH8OKBQOEtr91O6R9Hp8hj1G9BwXFc=; b=BX3ktXEsm8V3Cfdj80u+2wvy/EUDaK0ILJFPBs3p/+X6bvi4axbXsyO++YKcWHcvh6akx9 niw4WTQGmkrcEzO6NNBdiWN2XwgGCkvD/wjDtmcEO+yT+gXapBKEShBCY5N8udgV1tlCiu ih5fxAuiqInZFvgAio/6wANIHYHpnOI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+Xny/9dxsbpogvH8OKBQOEtr91O6R9Hp8hj1G9BwXFc=; b=XtLogM/bjdvsN4LPHEVaTg29du 0Unj6JuGv0EHxkbpUCdxQr8yIE3G+kAX/kJX+wiyiINxVZt1Lp6yByH7mj3xUmi1lsIJPbErTUwmt ENt4Qa0/KXxmZlQbiWoVkUcvX3KDU5VgfBTZTx6wkiPhB1dseNe4GwPAmkU2PFzAy5fwvJoYSW9ze FrjdfFENUWgA9HB218k9Q7AklwhGkZQGIrNRErGK8BCrjzt3nbPGoSpwXOGJ5CTR6Kh/3IeKZ27iR ry4JKdRnvVrQmXBH9x/tXavd2pvkj/91femN7KJwvCkZgitIuCjOSzHUrlWRYO0xRiGLifncssWg1 3Jxna3MQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rUReI-00000006hqA-0T1r; Mon, 29 Jan 2024 13:26:06 +0000 Date: Mon, 29 Jan 2024 13:26:06 +0000 From: Matthew Wilcox To: Ming Lei Cc: Dave Chinner , Mike Snitzer , Andrew Morton , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Don Dutile , Raghavendra K T , Alexander Viro , Christian Brauner , linux-block@vger.kernel.org Subject: Re: [RFC PATCH] mm/readahead: readahead aggressively if read drops in willneed range Message-ID: References: <20240128142522.1524741-1-ming.lei@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1797A100023 X-Stat-Signature: 85e3p85mw15sjbp8jt9dbpfisayoqeh4 X-Rspam-User: X-HE-Tag: 1706534769-670947 X-HE-Meta: U2FsdGVkX19X7KAy9IjDk3vCA03tWZQDaCURNHlPtNXo2nOgtAf3inuDRaikZkI1nUDeaBjsJwIjJvbs3MxBrSfeYClSGScSrNBNdAx5dGaKnhg4mla/m1fX5EBh53X7q05FBkY3SLWq/8qILCRLgKLG2BJcRMnGMCefmdDMIdFiSEctlzfT5V/ZLftDrkwOF+f5jnTEopseti41GbhFFoRlNH5SGoTKLPadEM5p9MxUI/XuxQ/483eVx5CBlRk4X62EkpZoK65LqZHQvu5CtQ3mQ4hs/HejnYBb7IXfWy8kPb8B9Vv4e43LaYPU3B44DjNs+AxcA7aERyULb7s2A7WeUBOaB2w65sRh1ok5VsyVx2GWhP4wHu+huNQB0nzFo9mh3Qd7ttwHDcwOxAASRqSMbL9jhnXbDmzdHhRwXlausoBmgMagxMmQ3YRA33q/GsQbT9EJxg9b+CW8KzWOgbh6bD4dQbtpoptKZ5yTtI0XxU7zEBJanRDIbn513YhKV3T2J+wDLu+JIm9DSKYBc5/dLHP3yXR5/UM/7YGdF7DrpYBRVuQABI9iGzuy1Yf42VVz6VRxsjX0rGgxmd/U9EX3w5SRBtqUA7Oc8bZ772GhgBe2TzCwKJZzl2cR/qK3ilUlnsoe1WvnbpS84lqpPc1vmlv22j1dpCfnwAXvaeLh1vk7VClAllRV/T9EBxgG5G/N9y71KriZ4ohdCS8UxG5k6HdJLWrPNPrYMLJp10nD7vAmPevijiTolFExX+QhMLZZWVZovylR32s+Tk8pNyuPNM4xIKgle2PNvDEt45ojApmavxqBHPWEh2dYtwNZQR6sSO0JOPqms6Sivo6Kgq6fnqq4lXmQNFy3OUaQj+zXEnJdK0JVoYous4DEgODBz+yKVvqJBI7syjOItIlq/iUtxSpNwQTLxJbga4o+5IQ2dH1mETvIwlOi8/ptCSPonCKNNeyhLHjB95TsdnV LHDZf2h0 h2HEl1me0hP7kVB8X+RJ1oeItd26s8DRkwxWwLlGFfm+5E4P+g6T07E+sxm201r+ccYj5zBADHEJUDIFL+jKxVzuCS+RuilGPYGqP0yatZsZW95EwBVMZY4KC8CTWA1HG38UtMLZwckm8HCs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000099, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 04:25:41PM +0800, Ming Lei wrote: > Here the single .ra_pages may not work, that is why this patch stores > the willneed range in maple tree, please see the following words from > the original RH report: > > " > Increasing read ahead is not an option as it has a mixed I/O workload of > random I/O and sequential I/O, so that a large read ahead is very counterproductive > to the random I/O and is unacceptable. > " It is really frustrating having to drag this important information out of you. Please send the full bug report (stripping identifying information if that's what the customer needs). We seem to be covering the same ground again in public that apparently you've already done in private. This is no way to work with upstream.