From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50CF8C47DA9 for ; Tue, 30 Jan 2024 01:44:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D06A36B0082; Mon, 29 Jan 2024 20:44:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C90586B00C4; Mon, 29 Jan 2024 20:44:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE10B6B00CB; Mon, 29 Jan 2024 20:44:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 976D76B0082 for ; Mon, 29 Jan 2024 20:44:42 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 6916D40138 for ; Tue, 30 Jan 2024 01:44:42 +0000 (UTC) X-FDA: 81734283204.01.F809BAE Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf02.hostedemail.com (Postfix) with ESMTP id AC9F88001A for ; Tue, 30 Jan 2024 01:44:40 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=pOtuwBiE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of 3h1S4ZQoKCEY6w0z6ipumlowwotm.kwutqv25-uus3iks.wzo@flex--yosryahmed.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3h1S4ZQoKCEY6w0z6ipumlowwotm.kwutqv25-uus3iks.wzo@flex--yosryahmed.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706579080; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y1Y7vLTkmo8cyE0XH1YStz1wPF1Bx/yJQoozY6U5ttI=; b=6E5hZZUSZhRlYo12/EW+vkAuhvs5RddHiI4tCWnby5a94lLDHwo8NhTS5bzNxoru5yRTql SR3sKrEiyFoJBGX/aXTy8BP14EEEesBOR6E4Kk0lbYY0Xn30wAeV5+UIJSUEAlwoqR8OrW exsgqHnqt0EWlIyX2ychWRV1NMpxkD8= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=pOtuwBiE; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of 3h1S4ZQoKCEY6w0z6ipumlowwotm.kwutqv25-uus3iks.wzo@flex--yosryahmed.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3h1S4ZQoKCEY6w0z6ipumlowwotm.kwutqv25-uus3iks.wzo@flex--yosryahmed.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706579080; a=rsa-sha256; cv=none; b=AeKavrqdCis+EVmP+Ha+Ht/ySwat6WImil0+ej3GmRI91ypCoZRjpN/9jHmruiF5dhLvON rL+wUqpF21PHs3dwoE3oeOgN60GUO9WXZQ7vapwWHVtahIfYpbnU+yspj1T7/Sa8Z5kQAY XDC4tE7RbTas1sfIYYXZya4fyU2BNgU= Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dc26605c273so6715857276.0 for ; Mon, 29 Jan 2024 17:44:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706579080; x=1707183880; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=y1Y7vLTkmo8cyE0XH1YStz1wPF1Bx/yJQoozY6U5ttI=; b=pOtuwBiEv46w5eubSwtayU/yhjNQkBYtUmAnGU9Xclr63NTxsvYUdFSjmgXwfWUpi7 /ANQVNXw8ZtyQt04VTsu4DKNEa9rwS5pJL4YxwTjqMLXY9Z8W4GlQ2/+a1ZPfdOki9yW sRsJD976cRkzLlMODpYyoMZ1+GZeq+gYjGYarHI0gL1RJbAbBZ0xQscqVBeD4u30UIq1 6Em/6yhg9OAiUJS2B+obw2kE8iSwJ7LQ7yD458zd0MjRdb6wMs200aatPz/he7kPcKsl NZX1LSajUD7ENo9Z3gHIiX7tSDTa+fvw0T20+dJa0Tl0R4nkiCGCFEienIejTInDrU3i n9gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706579080; x=1707183880; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y1Y7vLTkmo8cyE0XH1YStz1wPF1Bx/yJQoozY6U5ttI=; b=FdPOc49/+e8kjefx8ezshAL78/N4zcoBSYVZFj3aK34wmzC4fuVUNyjx0ybQ6n3O7H xQ9BQRuVQT5POU6d+8D4UZHA11ItzLPIh5Vg/rwEqvuX/JR6+tbEzn6FIQoxCW+Ei28y gbJkB6wDBEu6XImQOaAMYXVbAhJRwD/cwE8TlHCvXZf7HFhMJRJlKrX+g5PL+UYaJwbz SBA72Qc/E+9vgM84dU88Jbs//YOL/JiOxUwIZdvXLvE6Ux9bxIHG+Jpee7ibrISmXyc/ Ui/a9zLmZXGZmmiBsjnxyz4w8kTvMpx/EPsTZnxHyv/kv0ZDCqT3tQJ0LUnGlp+dRDu+ trQg== X-Gm-Message-State: AOJu0Yz+PXXGrjRFbON1t9so1JmgWFrrVvb+QIaTpR1jVE13RISDhIbi H744b8ilgyFnmj+VbB/6snWyVVsXWdrkoo4QXN6rK5j2VIzvz1hP30PBZXv2WWSog7L4NHXxO0U 3qKOkYpNmIPHsixhqww== X-Google-Smtp-Source: AGHT+IGyy9j0WVXdyAlRr7sgiCu+Mpt32BjEZHf0bFxVEhAafS8poK1FTjJc7/2OA3zVvwNPpzwQ4NYqU7tkOPeb X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:6902:218d:b0:dc2:2af6:6ace with SMTP id dl13-20020a056902218d00b00dc22af66acemr2591033ybb.3.1706579079816; Mon, 29 Jan 2024 17:44:39 -0800 (PST) Date: Tue, 30 Jan 2024 01:44:37 +0000 In-Reply-To: <20240130013438.565167-1-hannes@cmpxchg.org> Mime-Version: 1.0 References: <20240130013438.565167-1-hannes@cmpxchg.org> Message-ID: Subject: Re: [PATCH] mm: zswap: fix objcg use-after-free in entry destruction From: Yosry Ahmed To: Johannes Weiner Cc: Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Stat-Signature: jgar7b8qjq97x759bm9aycexwp8honfx X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AC9F88001A X-HE-Tag: 1706579080-249431 X-HE-Meta: U2FsdGVkX1+5bbeQgX8w+qh3eaQdkts0Dd6yPntNFmv4dJBqfMI+M5oPzjvlbE3vMruzaCX97VMEHG2ejs2zkd7y/1m7/jlq2qRlT4aK3zNuKJU7IBZWkY4p6S2f1akMdWmEP3kcxZOVoEd77d9eK4891O/zgVhpYojlotW6Jmb9woRAaqMAxyDymzEpDUx2q/moPEac2y4WTmiFCXzf2D9rrTYG8vcyURwv+uz/pZDF3w0MwcMOVis2OMmyvI/U5Nhw1asFviD68HQXZILaARh1oKdukQmtw57m9E5E4czkA0K2oNd4JMFvTd7QnTOVcKEBtR977FvnBMPly6q86ocEn635vOgla0zMq88gNEBXPoFnvr5j4lZwe11uDP6j+8k74tSH0aQHIQC9I0H6eapnPr8aK5Zh0hYHWVzQzPPC60N6d4Av9fGCk/k5/o7xs+LfuTMW3uKxJTUquur62tvNyA7smrLqPJ7pAI0KjSKRfcIla3NLQ3ZAZmMjdsykMibgH5HbMq/U3yUKmdiKykqjuZTodjXyi/Epj+gbK8CDOxUWafGE7BBSIndgNPhMnxi9DL67FRPsGteyHz4bZu63/CzWAU09bV/8bHJo4gNRFr2MwnBLhJuj2ev/8zxOB9fmaCSHFoNsXbNNjjdyKzULhWEqu7MO8nyrKGqvra2dRoffioDAyCqe6UlYju0iZTsM5AcG6RKylSvT5y9dwgAPQmHzoKRqI2mB84IlqXxPv02GKYScazu4RXOgjCj6uPH2bsp/lQUlECTRFTkY7+LuoV+vdSxAtFU4EsRhMRQlG11hJKDDLzBfOrDbdF4K7yE/yE0s8XWpsBW9kbo7I7NyMrftaQ+naKOIUR+Z9dk6VW35+ct8sCu2z5e7xuj/qV1Pqqc/x6erwFQM+EWxvuxLq8/KeVG7SJVErbS4A+eqEmPS+Ih9vTtDb6pqpm8s7qulxP5Ff8oLLvjnLKQ sJUwh6k1 04MdCOre7iF3whViMJVO2gd77u1P6wl6grq5mZBxqeNI9QWsDDXcibkG77wJ4dPjhbEbHC8DhXsk+tByFq2WuIYOCNBjRiZ7jdwZVvbczGT6oZlMyUJ3XkB+OnZyMSqzVGSaIcI0j/1rN4FUvVeqArfNf9g7ZjiMytR9+VZuPEw2mlVi/D2cf3Y6TfUxe6dR6AS9OusqxPR9IKrh+3q87ADZl8GZjnv1tf9MNl5EGmC1XLYIH7RM3DIT+rq54JsrKqh2PfieK1DZ2EVsEC2v7SQzzhtmP5W5HjQ1nXwfg9Yu/ba4a8MugTGCkTGPlTE1NMDUJUylnFra4o9Vr1DBHEYTPeffCfp5LGA1FxJWLIQaziSVC9cR9nzJVhEOKbp54PdX6Ed0ne6TifW7ni1ziTCJJJFj2JqGX+hAwJq2gzwH5/4mpkUhFx4m52JsgPGefOSHNc4xGGJaElxstYG5Q01AzZ5VxBfHd1vEQM/gye6D3tCQYFVXDA9xEh2Y0UMkOzJt9BJqaktF11ZVfGjWQSaycmUA9kv7MxQVczsqe8MSgsq5goeGKiuw5NJSjmV2HboiWZ9WgFFXl3CMARIREPVS+8witnMp60+rXUqudZwTZA0v9lEFe7PDassnu2Hpatds1vAWBwubPKmkL2nx1FxcR+yuWqDSIC9CodnLWUgr2VzOvfuNSb94u90nd/pjt6FfW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000053, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 08:34:38PM -0500, Johannes Weiner wrote: > In the per-memcg LRU universe, LRU removal uses entry->objcg to > determine which list count needs to be decreased. Drop the objcg > reference after updating the LRU, to fix a possible use-after-free. > > Fixes: a65b0e7607cc ("zswap: make shrinking memcg-aware") Lots of hotfixes for zswap in v6.8 these couple of days :) > Signed-off-by: Johannes Weiner Acked-by: Yosry Ahmed Thanks!