From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FEF6C47DA9 for ; Tue, 30 Jan 2024 08:12:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4BD76B009E; Tue, 30 Jan 2024 03:12:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AFCBC6B009F; Tue, 30 Jan 2024 03:12:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C4B56B00A0; Tue, 30 Jan 2024 03:12:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8C2DA6B009E for ; Tue, 30 Jan 2024 03:12:24 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 66A93C0B21 for ; Tue, 30 Jan 2024 08:12:24 +0000 (UTC) X-FDA: 81735260208.20.EB97CE8 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf30.hostedemail.com (Postfix) with ESMTP id BAC4980009 for ; Tue, 30 Jan 2024 08:12:22 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="u8IV/KK0"; spf=pass (imf30.hostedemail.com: domain of 3Za-4ZQoKCNoUKONU6DIA9CKKCHA.8KIHEJQT-IIGR68G.KNC@flex--yosryahmed.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3Za-4ZQoKCNoUKONU6DIA9CKKCHA.8KIHEJQT-IIGR68G.KNC@flex--yosryahmed.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706602342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KxgbaC8ibp/Nn5JOJr/iczAyfc5yUQS/YUOOzTWbh7Y=; b=fDx+S1zm+imZOSefn1OavJjCiFOkebVUdkDzTGcrR/fbkHf+1fu92mHKTIxQZR6r/nLmJY HU8/U8rgnJNh7XWMrwyz9aoL+SipVaXDM59454Pf8rUIKPDyN+9pZWr0IojeBSsHKLWylF gLslVKe5BKkbVV/hSnqIVnABkTVNCbI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706602342; a=rsa-sha256; cv=none; b=H0WXCUSFs5SFMHNDBmcpj5/hENUKuOcDl0v67wQUoNZ5tjfpGW+ifgst1RtY3RHE5M9Qjw PLMdr7qf+LQmQpnvjmh+Ky/86UFR0bHprrPoYaT5OHfBDXbyZJtLTdfbRo3ea8ygEj7V1F mHaUBlWyGZ93tkzEHIBJoFZe8gcljhM= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="u8IV/KK0"; spf=pass (imf30.hostedemail.com: domain of 3Za-4ZQoKCNoUKONU6DIA9CKKCHA.8KIHEJQT-IIGR68G.KNC@flex--yosryahmed.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3Za-4ZQoKCNoUKONU6DIA9CKKCHA.8KIHEJQT-IIGR68G.KNC@flex--yosryahmed.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-dc64e0fc7c8so5021771276.2 for ; Tue, 30 Jan 2024 00:12:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706602342; x=1707207142; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=KxgbaC8ibp/Nn5JOJr/iczAyfc5yUQS/YUOOzTWbh7Y=; b=u8IV/KK0SEx8SQsXj0i2+8ay8zSqdIpu7zsd0Xdz00P5aNJu48gISkKPAL9J09MNh2 g2wxZGl0lNul8daIJ1AVvDhlQZi0k+AgbvJfshaZdZmaIwQ1aUbdfO0k/a1bmd3L3gHD XEH4dVvzLuxBtYDbPJDmMT10Ojh1819G0pHTGE+aMSgK6PjZLd94Zulunm1fpmBWExut 45e5mELFsPYnSdOaC7j1EgGRiTJMwJxaJGExYygWMjsUq+gyNm/kwgkg0BxWp9zz24w+ xefVH3Kndzq276LGquCzCU+SMyWxzwn1yLuCBUjitXHXTIreoOmi5omzxo7gx53XI+X2 vHVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706602342; x=1707207142; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KxgbaC8ibp/Nn5JOJr/iczAyfc5yUQS/YUOOzTWbh7Y=; b=mj/9G5+wuaz9jzESonzIs62lGVM/h81pXF3LMjbYluIp3gwDY8Dl53yM/a6NmiOMvz pkDIG/J0ZHW7D6O5bwSpQYjHf5ORHE1pqutC1sQ71Y5U2SKAO2U/Pm9y7jLEGJSVB1jx gIdYEqBc0hZ/uQLJuSptaE42KSHSCFBSJgCJNomJWtDqFZNjk3cznGNqKxmpp+wC93Gb ihcAuc02a+ldPI+lPsUeGX18JYl4dWZoME0dj2r/FcoUzl3gTjah8xf8Dgrf8ZpPvMYH mzBap7KktEQVn3p1TL+ZRKSzOoYBl40aqqXakHW/Zqz/B5m9SBX+9fYFjbKam0xBn3t+ UD+Q== X-Gm-Message-State: AOJu0YzPA3UBnLvPIpYgBLgNDsDfEJXqFbSgMir7ymR2NUxvBGhcEvN9 ntFtJc/QFPeq6EKF7vcabWlMISny5aMGOJjRqFM89lYfoGjYEy4U4EXxVahKfVFhJmL5EbMVNkQ Xan/Y6n/CiVStr9WNkA== X-Google-Smtp-Source: AGHT+IGQskCjKzTgfcP/J3yX1uE0o4Vjlq4IixL9Z4YMfLtYqKL5X4HPxe2LoWfTAzvoXxfgnTEXHOneLwKJV29F X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:6902:10c4:b0:dbd:f7e4:c7f5 with SMTP id w4-20020a05690210c400b00dbdf7e4c7f5mr486918ybu.10.1706602341970; Tue, 30 Jan 2024 00:12:21 -0800 (PST) Date: Tue, 30 Jan 2024 08:12:20 +0000 In-Reply-To: <20240130014208.565554-9-hannes@cmpxchg.org> Mime-Version: 1.0 References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-9-hannes@cmpxchg.org> Message-ID: Subject: Re: [PATCH 08/20] mm: zswap: further cleanup zswap_store() From: Yosry Ahmed To: Johannes Weiner Cc: Andrew Morton , Nhat Pham , Chengming Zhou , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Stat-Signature: 7ojrb9a9zgfuzp5ewcat6t7tffq8jc3q X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BAC4980009 X-Rspam-User: X-HE-Tag: 1706602342-574496 X-HE-Meta: U2FsdGVkX1+GfHYfFXwqSyVoGT0GImJfi6UVpxiR706HYL0VoWVlBzovXg37ZO8ZMwHw2R1VMcwKpY/9YVnF+Vb+iSvZhXUMZdZs0wGZsZ+9fWLKeLV5DAS21S5meBgtHbaQ4O06+6Ob8NjeBeaEhp2lE24SjZeg831lpSf/Xr/Qfd3e5v6OzkanWefHvFwMZvvgg2nLqc52txEa52KIZHAm2VKWilmtI5Z9wYns0pGCX5tZ7d75rpwaoJZV3LY+FMaq27FzvYAcAUC9i40ltwLVBuk3PNvvphJ78T7NXbKYKC9myh3vM5bqxq5qC/nML1WJ7/TwgRm1Na8/s7WS6veEVI9BCHah6LByenB1bpbHJJYsMPa4aOedfbdAhDIvjGlkESEikC4uEB+kKYwmAaJPgo8AjfiEq2yLqpvQKVxb0jqotUMnx/K8+VU/JcrdjJIPobzpcZ5mebriPAhHkeK1uUVjFKXnJeniPleDO+ldHUOU5kgtMjmaZUYy+u1gfwHE3Cs19akX9c+3CWH+bzW28YZR26y78PvF5JuSL3sSfMWQo2L8hDpZjeJU/j/LbibaiUWaJ0tFY01keXBOaAHEVAiTZA65xwslvX9tD+ocdQaKrZZq8UzGZgxIQqrBtj8RXJC+sDSs6pfT+kDnHd6eLgn+1a964Tds4xyIOF9iKBZvuQjrvMsj0snoDj10J3RFiZAt3Exiz2e/Z4kyg4f3/QKedZ5usp2ULVOHP1Wm9FGFAjpgTnSjW6fYzkj2/ohyOAvLr2LqtK2Bdn+dDDZb4qGqNYCs9zrGwh8DQiweVPBWYMBdRyBy3ZVDEzBPEZ/UVE/yXvKtQaA3DsTZzy1Oy0VDM8ZOyPqA74JO3jp/1dnLXugjSVzEo4Xtjl/Pce1z1+MWl8WhwmY/+npTrQY6NNAhzwY4Rlki8cT0EUBBRXZeMMwrWlaSvHkItFLHs9TW1PRBQsR5EnxcOqa +cPWiOQ1 8WUcVVULvdtdGuPKq+gRKOeCusdTl1K9gpZTw7JC5Maj9t2RcHDh97mX3uzZH8acAtB2EITk0prQQRY537Waq5c4g6ByisqMPWEC2LetIKjmaRm49eBP6CQTHYEllcKuUT3+DJM0wDadcZP5NQGZ7YkJCq/a4ppd04MxtS6c9hjvW+VOWFfgw9gbvz+EOSUB28BuFjiyxYQpil7BHOpXeIK2xLMJEFbDzSfA/B4t14tdbcruhBzQP9uwoF4xb8iSKnvR6OAIjE9z8C9mPHvvwR2DU5qbCcIkRrHAIfnmYzEyfr2jdkdNrsua76JYirNBOhbcBHYqzs5zHZKnTxquoMBWhqqghnYRNmxrreWxkyPZRm3DBcvWv+UMyM0JBFdDSPdHDlwadkLKhLQ8H5vORKtXGLXjI/pQcbUuZHXGfuulQ6TaLc9ZzHjvfxnUVfJTr+PNxY1UTxuci2CvsrEi7eE8gnJTjeS2WXVRQCFc2EeIHnu4KA512kxyXzuD7UN/HDoSsVqXPnHC2s3kUeKiE8SPxQjZPBjDIM/QIuaoJRlGoBTJjoiWFUjBoI6mR6IPo8yZ/yQAs4ol0Y1E25wKu9dmV4yG0Nr8Lut071ZcHUcTr2CC/GNMX2kHCviLrfmTSCPl08YqpJd5BWE+cC6bVDF/fNAkwnqFtQCGLiWsTiOuU8JnTgLDCylHtXynJ51Bud6l44zPSFi03z/x7VFeWDoa6zU2p9lb/uybqhnHykwWwLp0++XIesy+hQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000173, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 08:36:44PM -0500, Johannes Weiner wrote: > - Remove dupentry, reusing entry works just fine. > - Rename pool to shrink_pool, as this one actually is confusing. > - Remove page, use folio_nid() and kmap_local_folio() directly. > - Set entry->swpentry in a common path. > - Move value and src to local scope of use. > > Signed-off-by: Johannes Weiner Acked-by: Yosry Ahmed