From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0000BC47DA9 for ; Tue, 30 Jan 2024 18:55:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7146C6B00A8; Tue, 30 Jan 2024 13:55:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C3346B00A9; Tue, 30 Jan 2024 13:55:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58C3E6B00AA; Tue, 30 Jan 2024 13:55:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 475FD6B00A8 for ; Tue, 30 Jan 2024 13:55:48 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1DDFBA02E3 for ; Tue, 30 Jan 2024 18:55:48 +0000 (UTC) X-FDA: 81736881576.11.BDB049C Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf15.hostedemail.com (Postfix) with ESMTP id 56B55A002C for ; Tue, 30 Jan 2024 18:55:46 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Gu52fAPy; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of 3MUa5ZQoKCNYQGKJQ29E658GG8D6.4GEDAFMP-EECN24C.GJ8@flex--yosryahmed.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3MUa5ZQoKCNYQGKJQ29E658GG8D6.4GEDAFMP-EECN24C.GJ8@flex--yosryahmed.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706640946; a=rsa-sha256; cv=none; b=i8akhackyLuLBkgdQP4VM+uMup+q4I5GXLAr3FMWueG7tGqd8V0dKxuRPahBBRKuD90tb4 q9Uiq8Bbm43Z5LKB1aGFUq3aGzBw5DhszJ/BC+QqZGBgIvmtad41R87/Iow5G/2J3U52gw kATQXY6kslEqtQx72coO7hVJBz7Ts6w= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Gu52fAPy; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of 3MUa5ZQoKCNYQGKJQ29E658GG8D6.4GEDAFMP-EECN24C.GJ8@flex--yosryahmed.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=3MUa5ZQoKCNYQGKJQ29E658GG8D6.4GEDAFMP-EECN24C.GJ8@flex--yosryahmed.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706640946; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fv/bTQ1xMvf2SnP8rg7hnK7lCBHHXhYmdjHeTk9P6G8=; b=yyxrGBJDwRwpENlBFRD94+3d9nxiT8aS1cnGNC10N3RNWdrRA/7lHNzqx1qEhFSTl3gJph G2sitquvo5014y+8kD3j5SWeTRl+XNMYsojLX1raKe4KrHwazppPyZilykxGMubhC+Nvmt f3R/nb+K5FeQQevS3P8wASXMYNFoPlI= Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-dc6b266a4b8so427751276.1 for ; Tue, 30 Jan 2024 10:55:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706640945; x=1707245745; darn=kvack.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=Fv/bTQ1xMvf2SnP8rg7hnK7lCBHHXhYmdjHeTk9P6G8=; b=Gu52fAPyB1j48wJijcuvPOcHeeeWaATPiYbUIqTpfOMjgVK68HxGkG6YqUCtDPBDUn /naIprIeES3Ljw41NpNP+JiLUbW9l5MRcoqc7hIsr4Yl57My/unDRVBojaPXo5fNQCRV kIuTOoRl4rGlFKE6WySMbyI9XTwS3qBT9cHkGF/en0mlgykp8dMhBxaTUXcMHXW2MkH/ rUUAwBaigT4eEcan0G8tflXdAoaL4JpgUyWP6+F12vCqHLJzuq8RrKUGx1Mfy4CLyKj6 SUCNciTUSNi1V7PrlhO1JbPR19jGqoFPZ2bmjTkZ16Fl67ZNM5eLJZDQIXsU5w5AHSJf 9j2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706640945; x=1707245745; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Fv/bTQ1xMvf2SnP8rg7hnK7lCBHHXhYmdjHeTk9P6G8=; b=CWdKZPxgQcNnYdIeYyHg83EN1w6AMOQIPWjf7kLtEbsDow2Pk38mMHOFf38G6S6q/5 UAfePKzH4kqF7IS8M37GvOhJUpL212rj24VOxEwIC7WxYOIwBOAD/BeGywVqoylt4VDB O6iXN87WlJ2vZjykYRSeO2SRouq5bUTLzW8l4qTTla0Q6HILySS9ygUROHL9NWD8Tjdy Vvaha8Bwh+ktUtWviE5ZvNDLz+d87KTu8f9rqVmuqYS6dvh6tBtid/NjrcG7VNjHxJ2m 37FHbmuokOtHxfo0ecqMwQFHEGhLUmyge+sO62yFeMVHP4bxF3Lf6nWwXebhoX/H8mtJ OQqw== X-Gm-Message-State: AOJu0Yy/j6lr9FtXwUUdAcNXzUBvx7XYMGNi9jZZjUmFOvvsEBFWf4Vz ACeksM3aFHNKPwngyaCgNSGRbSJZu/70x4IWT9zkBw4rnhp3gTW3A4b4CZ3dKmu7GUAgtOkeo+0 2KeLWQgjOdr+CHM1fUQ== X-Google-Smtp-Source: AGHT+IGkYCoroPgQ0vC/qjOZHRglhy7FVefWVZSNBL/apsveQNFhYpaPcmuSmn1r9c0pb5X44+CYburGBcOpRHsF X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:6902:2406:b0:dc2:260b:64d9 with SMTP id dr6-20020a056902240600b00dc2260b64d9mr576357ybb.10.1706640945579; Tue, 30 Jan 2024 10:55:45 -0800 (PST) Date: Tue, 30 Jan 2024 18:55:43 +0000 In-Reply-To: Mime-Version: 1.0 References: <20240129224542.162599-1-nphamcs@gmail.com> <20240129224542.162599-2-nphamcs@gmail.com> Message-ID: Subject: Re: [PATCH 1/3] selftests: zswap: add zswap selftest file to zswap maintainer entry From: Yosry Ahmed To: Nhat Pham Cc: akpm@linux-foundation.org, shuah@kernel.org, hannes@cmpxchg.org, tj@kernel.org, lizefan.x@bytedance.com, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 56B55A002C X-Stat-Signature: 1tpnh4ysqznx6pch5g1pc6g7gbobh6mm X-HE-Tag: 1706640946-326157 X-HE-Meta: U2FsdGVkX18p2uk2oWv0UsfR4xKtjMvO9kDKTnUOEPiIcHSCCkTW4kTCG89zdzsWu7UlZsxeYJdBt0kVJSOl1YavYgqqUX0rn8zfc2qDiPfrlcrYNaUFA1FuH8bRiEVzqka7KEQuX3zTuzwUt8o9plD2Qr6AbQV0utLIc1NlenyKpN7WpqYT0frGSYxKVWN8vKN6XnFRqDY3Lk0jozghV5PcbO2qo+4YX8rNa+SQD/hHYXwnYS4cVEtohnlIymHVtG9yDb6xloMYHoL+f9pqimIq3HbmtIqQRV6qBq9x6XMOuVp/l4gCI02VLnxIpAbHTpbp77s+L/zluI2z38xi6dt7j+H06peUpGoIe1FxjXbn87ZiTvg7xSmHI9j/7FmXoQ8IOGQDz7ue94I4iHzsuZBCwUrdwxztWxrWrUq210wPXgI51SGDskISfC/abVN1pVbOqW7+WMQDDj6HmKE9HGWvG5hLr766UnLI3OmQ+j5W714gnoc+1UK8LL8x5QI5K4Ta80thNGXB8VX05MeZFNBNJ2XnPm0x/IECkPNEquEROn1Rvtl4kpYaXUxIsZhE7MSuXkQ5jvWK6x92PpHoIrvl9Sd4a5iMtLjpeIdVoq0qrQWlwKVRK3E+a7DsdtT3atLxiaxQwc6Yryr/4vqlkVSRZtBNnrfFW0g1ZLCWO5qR7Xw5uuBbfEuAqpLm7AvkY2rfu1DqLCbyFMRl42v412YbhVZKIm1bYj53vZnUd5VoXSJVpUIPa2PAtyaeu1xt16oWrNa7v5g23BrUJ+LlODiD0dTBJvgnB/WOTeOHzpQOeDboqf05Db3f22N0tJqHKKK6rA6lmE2ECmD9x0+AW9G8dpRTveTx8kP8HIbN+wRzT+rVUVR6OeGEDLTCHN9mPbzvaRYYDa4paM6NpN1AMdqJH+zApz9gYWH4GHBEXTfuBGNDTrtx8aQOIe/Wsd3JHMaa85wEagaMxOYL4d9 Tc4+VXBK j3W2y7Q8suYlZb4CHV42JSNkAF6bhSJslO1FxB0NSBcdLFWpsfqvmEnSerpzgxs6g2TY6YyQdiKD6sCU9/P/YiiDqeoSZK6FC3/E0Mn3v3Qr9fJ+KPYQtp/VLjGGrIi0+P19A1/a3Dow0VUJtJNs218TGuJQG5rAKiJ19xD8psh8CcR6iJnONp4B61LnhLCkxlDBZI6oAlIPBFVfK3WHEw5h2OpTJJAH4WKWVaL8RvWV1qFHL9PxGaDeXGo+xj/DYuRLZvn//DlYa80USOIqzcKNdMc9FrBHRZyHgIAVaK/zy1bIcTIGNXwu1KZeTxonzeySHf+rJSxbdDKTE42pmxPjTy9P+ZHza/eER/kHFKrLc5aj0sLcXPlMvamAw/eN1NIy16IEJe3r+xxd/naoku706q+HuI+1sv3RmtLVi24066b8qyG/Ye/L6lPf1qlP/5ttWQ+ORf0PAsizTebIYIhxwHa82xxt1kw+0436aXmFIO1ypxIBjSlu2KSn2WjJrOrofg3o7ta1OZ3dnQSdUIMtVuZoiOhiWoRjth27BnyR0f/bZH/M7mqUYWUPaE+M43mPH78KSz7v+jH7wZ5uI/gA6+O0stkmY04TTI32Tb+wLqZPptr4asbWI2N29WSfNKgrGuwMl7/ewYxHDFDW4Woi7ZQYkop2Basge X-Bogosity: Ham, tests=bogofilter, spamicity=0.058243, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 30, 2024 at 10:37:15AM -0800, Nhat Pham wrote: > On Mon, Jan 29, 2024 at 5:02=E2=80=AFPM Yosry Ahmed wrote: > > > > On Mon, Jan 29, 2024 at 02:45:40PM -0800, Nhat Pham wrote: > > > Make it easier for contributors to find the zswap maintainers when th= ey > > > update the zswap tests. > > > > > > Signed-off-by: Nhat Pham > > > > I guess I had to check the zswap tests at some point :) >=20 > We sorely need more zswap tests :) >=20 > I'm one of the offenders of adding new features without including > tests, so no judging anyone of course, and admittedly zswap is quite > intertwined with other parts of MM, so it's kinda hard to write > unit-ish tests for zswap only. I often had to resort to scripting > stress tests to iron out bugs. >=20 > But there are still tests that we can write to verify public API > (cgroup's zswap options come to mind), simple tests that cover crucial > code paths, etc. that we should probably add in. At the very least > this can be a quick/sanity check for developing and backporting > patches into the production system. Agreed. I am yet to take a close look at the existing tests tbh, but I took a quick look before and there is room for improvement (and little bandwidth to act on it).