From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 108AFC46CD2 for ; Tue, 30 Jan 2024 21:51:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B5246B0085; Tue, 30 Jan 2024 16:51:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 93E936B0087; Tue, 30 Jan 2024 16:51:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B7F46B0088; Tue, 30 Jan 2024 16:51:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 671486B0085 for ; Tue, 30 Jan 2024 16:51:34 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DEDF940404 for ; Tue, 30 Jan 2024 21:51:33 +0000 (UTC) X-FDA: 81737324466.24.280BD12 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf22.hostedemail.com (Postfix) with ESMTP id E2D59C0015 for ; Tue, 30 Jan 2024 21:51:31 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=mia3lWTV; spf=pass (imf22.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706651492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Np9jYGYfYb8N8NYn/XtRXhSjDUyxZMfM0XTBuDl+Ozs=; b=t6QjRmXfAtE7YH0MztVSMgVHHO0LZccnhc0EAC5MT3pQAkjmgaqePRb+djaIa+J2sCQYlE QJv/IpvnRHq0kJoyK20wz9q7i4AcwwLCLlGGKf/vGaVowQOaiMuDXpE3t0BgTjehZMjEnU Mt7BoEJ4QWcX7rNeqUrD7pdM+E3scec= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=mia3lWTV; spf=pass (imf22.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706651492; a=rsa-sha256; cv=none; b=gOWTIDtYP/irEWMz8zas8A8UVHoBpP8lX1HBeaY1tdk6FTEDHcLNKkiWW9XpnwypG4OEUA ER0sY+X1Lug1rNboJk4Rh5s8x0X6447iYlVSW3CH3iY/PleZQvXa95flHy0tDiTpZDFpvk VZUAtJeuvChPeStuYOEozNflZLsL6FY= Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-295d22bd3afso357179a91.1 for ; Tue, 30 Jan 2024 13:51:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1706651490; x=1707256290; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Np9jYGYfYb8N8NYn/XtRXhSjDUyxZMfM0XTBuDl+Ozs=; b=mia3lWTVejmLt8Zexgsce3jYa+aWVYtJUXpaDPjCEjwE/C0cF9p5qBMfQUGA6bLJ9L O7OoHovg1ThA2Ih1Ezn3C6Lxw0NPB4cXMqDkLSzVdtqsPXDBZfKGAK/1mAJN3xMCvIVS Kp9NDdSyGcfXqAIXi//AcPyoQDummMXh9eDYevnTX/rV4z4rfbRZnKAmdSEp396hVVp8 VXdPGvVo7OWCBYKYAop0FXQC2lVa7NH6Zw5XGr3sMxFDbyqs/ClcfF4SbIyMumz9GA77 jPBVqQpRyWck6v9zyCfBFlO49u4fxz3lH1PWlRUZ698dSTs5PVfHt/fx/osH/fLxe9oA Gl0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706651490; x=1707256290; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Np9jYGYfYb8N8NYn/XtRXhSjDUyxZMfM0XTBuDl+Ozs=; b=N0gZ5LHAHgTbfUssmOLcAkHiGmmeKlZoG/bfMfsJVDpqRFRTAfms9/OsK7iJSSUIKV OhfgZ2QKw7bXaMF+LKMXyYrXxzcRNfcQY3YFvwDkFwsUMCKUOKZs9eN7mq4k5Jjhynzg atRALdmYfVgmWWh3NMMPc+9Vb5S8wigeRmfWlv5b1l65iyRe2NvyTWsGaHKgxaBZbCe+ pkUrn0KBkc5smFP9w6cScnR5MJ2V374nKS3vAR5E5da1Z0nf+CIDWiFgpTR1weNmS23R hkBeg7RuSf4nEd/7lr8MXXpscUsVjCeD5MnxOzKlFqFEQfd8ihyulk3Tu0nzHlBoW/UV PAXw== X-Gm-Message-State: AOJu0YwXQQRHq73iBDiqbDcoZn2itVMmkrm91CARN1SvNw5EUgSZ/ktk 8Xerx6PTEN/o5RUT1x9nmwm4BmLAprzm6+wGGg64pVHlqU8hu+6AtRFkJbOJBFI= X-Google-Smtp-Source: AGHT+IEwtwQoylWlOGq8TqPSvs3bul1pVTRd8p25SneMALbfVbul/65KMmvpPziXy2wknL2Wg6OzKg== X-Received: by 2002:a17:90a:17a2:b0:28f:f1c0:3d21 with SMTP id q31-20020a17090a17a200b0028ff1c03d21mr5388368pja.41.1706651490637; Tue, 30 Jan 2024 13:51:30 -0800 (PST) Received: from ghost ([12.44.203.122]) by smtp.gmail.com with ESMTPSA id nb5-20020a17090b35c500b0029464b5fcdbsm8657589pjb.42.2024.01.30.13.51.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 13:51:30 -0800 (PST) Date: Tue, 30 Jan 2024 13:51:28 -0800 From: Charlie Jenkins To: Yangyu Chen Cc: Alexandre Ghiti , Paul Walmsley , Palmer Dabbelt , Albert Ou , Shuah Khan , Jonathan Corbet , linux-mm@kvack.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v2 1/3] riscv: mm: Use hint address in mmap if available Message-ID: References: <20240130-use_mmap_hint_address-v2-0-f34ebfd33053@rivosinc.com> <20240130-use_mmap_hint_address-v2-1-f34ebfd33053@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: E2D59C0015 X-Rspam-User: X-Stat-Signature: 3kkkpcj3ibrdc97jcmi4okr36p3w8ur3 X-Rspamd-Server: rspam01 X-HE-Tag: 1706651491-654823 X-HE-Meta: U2FsdGVkX19wqBbpKsZTR0YI6rZUDbGH+H329vgt9sF4ZawYHbeUdoa++46GAQbdRfsRv0+XKHroQUpNgr+QbhNbnFhG4o61CUrT2VxfsbiX2GqF05uKlxSBoawcguj32Xpk9baYrdqVqjGOQYCllMTrczLcDKirSK3CiNZNv4Nv4SJiEkAShMT+MmQD33qUt796SP0sggxOLSUIlODs6JFVQcZBWedvZCkW/35/kpCG/oncHjWJLnUix24abWp+jQSxhPJOiY5e5SD9/ck23VRAnuQ96FcN0zpQYsi213yj0+Ql6COrZ+y/C2dJpQ7bP7BTyYPtTZR5tBzIFu5yFvcuRqCEMGrmcrNUoahnYUOHkAi/yyaMkGz7Ig8prExycOe5Q+gXBnDMBuFjA2BAXKLtT8/OeVbPAOjtBlQrJQjC0vvtwht3uFWFBdRwygY5NxEi5DQG5BLezGhdX7AfeUSAlKpWQNagtT2lkJYAeydf9yg0lU7NeZDNgnGrx+4UlYb7+o9vENvq14xbm3eRttWNNUxSO8Y2FzI30Jrhi4BzqeTd2ToKDfwydjvjvjWpzxRxwoJBgAclNN7ryAQ9k+wHnPrS6pV0eTF9l/j1zyQJB+lCQzJ7Tl7HtySwbaqizkUL8FHb/UWjTJHxRB64I0cNiA5urUn35/EvH7aYNWneGSzHL+WvyB7Zvn/uAl4njhdS7LphqEvPnrX2S1hksJoVJCi73kWGjhARKwfIxBnUpPdBOkzUVuCcbLTgjVr/nEQrI5fzz2pa00/D+XzvqRUieECGK/TGdaIIRaMo5dgrAAfJuB9rFwOPOC9mQFO/0h1qLlmdBelhaUKVWQa0PiL2nsR1fYFbrx/0T7Ghd5UpHtHCZBFeLrw/+RJD/Fc/Mn+9N4mm92MUbvDo9vmlnV08+p/1D3Uap5tnNMvYC+dYPXezMC3FgoUQBqsQa8CAfja4nW1bPaor5y1u6DK 4HyJY4bt tKpNDpLn+OBjM1qBiTRemmP4Z+BKlz/7YGh0skZaXlwx4EsV6Wu5Nk33UF568kYM/E+llM4svfImcapPC1xfl2w3xeEQ+utx+AWXLS56/nQdNh9GXbM1+VkPpwOKkuU/lxATyfRTp4jaZ37cf/Pu2bKYTl5hiu1AGoVlrHD4VAwtd55W2r5HuF9gpVp36Y3E4VcsLOBPpgFxA4YZVUpBsAQ/HWQqj0uFKCvpID+nIxFWE3iE/Fa44MM7Ogy7aoUz4tpm0YVFcY63Jmc5KiQCSdGvRae5K2Wv0NvlzR5dqFyDqgun71DPUzLq3LhBUuJNA5bYHQQ7XBCW4orURdcV2sP+Gz8JNjqStoNoWvMvPAd9rYINJgYXUivYCPjIsVzHxqiT+2ZyZaTZkx4hG4WPMZzmM0uk4164a0xCOW/KWmgmUJk+sso7DsevIcv1Jo8FLyb7R5wutnX016zbJUIKuOI1BCxfgNTZ6RioSt13vKh2B0mg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000896, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 31, 2024 at 03:15:16AM +0800, Yangyu Chen wrote: > On Tue, 2024-01-30 at 11:04 -0800, Charlie Jenkins wrote: > > On riscv it is guaranteed that the address returned by mmap is less > > than > > the hint address. Allow mmap to return an address all the way up to > > addr, if provided, rather than just up to the lower address space. > > > > This provides a performance benefit as well, allowing mmap to exit > > after > > checking that the address is in range rather than searching for a > > valid > > address. > > > > It is possible to provide an address that uses at most the same > > number > > of bits, however it is significantly more computationally expensive > > to > > provide that number rather than setting the max to be the hint > > address. > > There is the instruction clz/clzw in Zbb that returns the highest set > > bit > > which could be used to performantly implement this, but it would > > still > > be slower than the current implementation. At worst case, half of the > > address would not be able to be allocated when a hint address is > > provided. > > > > Signed-off-by: Charlie Jenkins > > --- > >  arch/riscv/include/asm/processor.h | 22 +++++++++------------- > >  1 file changed, 9 insertions(+), 13 deletions(-) > > > > diff --git a/arch/riscv/include/asm/processor.h > > b/arch/riscv/include/asm/processor.h > > index f19f861cda54..5d966ae81a58 100644 > > --- a/arch/riscv/include/asm/processor.h > > +++ b/arch/riscv/include/asm/processor.h > > @@ -22,14 +22,12 @@ > >  ({ \ > >   unsigned long > > mmap_end; \ > >   typeof(addr) _addr = (addr); \ > > - if ((_addr) == 0 || (IS_ENABLED(CONFIG_COMPAT) && > > is_compat_task())) \ > > - mmap_end = STACK_TOP_MAX; \ > > - else if ((_addr) >= VA_USER_SV57) \ > > - mmap_end = STACK_TOP_MAX; \ > > - else if ((((_addr) >= VA_USER_SV48)) && (VA_BITS >= > > VA_BITS_SV48)) \ > > - mmap_end = VA_USER_SV48; \ > > + if ((_addr) == 0 || \ > > +     (IS_ENABLED(CONFIG_COMPAT) && is_compat_task()) || \ > > +     ((_addr + len) > BIT(VA_BITS - > > 1))) \ > > + mmap_end = STACK_TOP_MAX \ > >   else \ > > - mmap_end = VA_USER_SV39; \ > > + mmap_end = (_addr + len); \ > >   mmap_end; \ > >  }) > >   > > @@ -39,14 +37,12 @@ > >   typeof(addr) _addr = (addr); \ > >   typeof(base) _base = (base); \ > >   unsigned long rnd_gap = DEFAULT_MAP_WINDOW - (_base); \ > > - if ((_addr) == 0 || (IS_ENABLED(CONFIG_COMPAT) && > > is_compat_task())) \ > > + if ((_addr) == 0 || \ > > +     (IS_ENABLED(CONFIG_COMPAT) && is_compat_task()) || \ > > +     ((_addr + len) > BIT(VA_BITS - > > 1))) \ > >   mmap_base = (_base); \ > > - else if (((_addr) >= VA_USER_SV57) && (VA_BITS >= > > VA_BITS_SV57)) \ > > - mmap_base = VA_USER_SV57 - rnd_gap; \ > > - else if ((((_addr) >= VA_USER_SV48)) && (VA_BITS >= > > VA_BITS_SV48)) \ > > - mmap_base = VA_USER_SV48 - rnd_gap; \ > >   else \ > > - mmap_base = VA_USER_SV39 - rnd_gap; \ > > + mmap_base = (_addr + len) - rnd_gap; \ > > Please mind that rnd_gap can be non-zero, in this case, the map will > fail. It will be better to let mmap_base = min((_addr + len), (base) + > TASK_SIZE - DEFAULT_MAP_WINDOW) . Why would an rnd_gap that is non-zero cause mmap to fail? mmap will fail if rnd_gap is greater than (_addr + len). That is expected and should be interpreted as no address was available in the requested address space. mmap_base is used if the hint address is not available. I do see that I fumbled the test cases in this patch so I will fix that in a v3. - Charlie > > >   mmap_base; \ > >  }) > >   > > >