From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E39B8C48286 for ; Thu, 1 Feb 2024 20:34:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 713526B0075; Thu, 1 Feb 2024 15:34:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C38B6B0078; Thu, 1 Feb 2024 15:34:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 58B0F6B007B; Thu, 1 Feb 2024 15:34:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 462E46B0078 for ; Thu, 1 Feb 2024 15:34:38 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 14CD5A1D2C for ; Thu, 1 Feb 2024 20:34:38 +0000 (UTC) X-FDA: 81744388236.18.253E23A Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id A9DDE1C0015; Thu, 1 Feb 2024 20:34:35 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ItybdaiD; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706819676; a=rsa-sha256; cv=none; b=wnJrCSouDtCSGAc8QEYEj0/KPlsB9XeSb4xs96Yf3ZnpCq3I3kNSm7gMjNVvyF8ZcStwp3 +F6xmevmHEFgPY2nRvc4bcUi+Uc9i3tDub/bnOrAQVGfMOd/BvFmDAt6X/wTkS0WnL+1ku NQQT+gWeKijfNpqqLUF97Ihw5wOVbaE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ItybdaiD; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706819676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qoxvFkY910Gqu3IoCO6Ky1UpafCyAu20SH1jpKymbD8=; b=DoWVts9axX8Bdac1e8z8/YX8rLT1cnxgAP72B08nmeWtEbxKgjHya/Ekr7Av8pkziHk8Wj YLl4UFyjmwowpu0+oQ2kJmerRDWN5H5WAs7ryTDsOmzqjvOXw06n+Y/EWLjK3eqQcTkIz9 VtrM6nm/FMtWgS5k5WK4kEFywSvoRUI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qoxvFkY910Gqu3IoCO6Ky1UpafCyAu20SH1jpKymbD8=; b=ItybdaiD6RA+Cso6v5t8YNJnOw R+YdqPDEpKQxaBkjfZ9e9D7S5JwdMjflSqezj4N6TxAtE6peyaqrl6e63mKUNjJ4kUY5YnwYFHCRp n3/Ceqa4moJc4sscJemJun665LZZyX2/igBC81TRbcoPQk3vfUixh2XCN6hIYgpmKSpFsf1lK+zCR 1Z/vVW+4S932eXzR6pvd24XVcebnHV16yy+UDQaEtGgoTOLxNm6rtEEByxAU480zNA6+CAwsvKA4k Wgre2TbjX31UExdM78KXII24CWH9IdabTPN1IihcgtrvMUAHhQaKPJsAJZZwnP533ONc3XGQ5HYO7 gkwHf5Eg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rVdlZ-0000000GkUx-0PEX; Thu, 01 Feb 2024 20:34:33 +0000 Date: Thu, 1 Feb 2024 20:34:33 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Andrew Morton , linux-mm@kvack.org, Tony Luck , Naoya Horiguchi , Miaohe Lin , David Hildenbrand , Muchun Song , Benjamin LaHaise , jglisse@redhat.com, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH rfc 6/9] mm: migrate: support poisoned recover from migrate folio Message-ID: References: <20240129070934.3717659-1-wangkefeng.wang@huawei.com> <20240129070934.3717659-7-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240129070934.3717659-7-wangkefeng.wang@huawei.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A9DDE1C0015 X-Stat-Signature: tmkooy76ouftpmf958qa1e4u31yerr5b X-Rspam-User: X-HE-Tag: 1706819675-505183 X-HE-Meta: U2FsdGVkX1+YehgvyJqWxYRrA9UriBvYf0UX1yGYm4a3SLvDbH2/kbhQGLPV/nJupbVsOGRIYSptCH73/EZuWQIUr2qdMwYCaUH6dVkK722VaaYr8QAW0qHumwm25BfJU2TXV6qBSNSYTszckYMfAQotA5g/5ctq4tDNPtYm2M1mYGVp+LynIhBMw+40iaRtHZsX/IIb/hgNapZ32EowLZRWMRFm4eBDImaPz/3aSdY2/GUB/ehpJTGikx7mcDYOG6/UoXxFtKDLnoy5rQnajfi+LgRuZ0h+lHMtk1VCARvArhai/fykqxDJjOLBArzVuzbOlp8A3s1P2j9nI2NyvnWX1L/ZchS28FCUvD3zR7HRrXhjfBxFxgO+Z8Qr0cc7WOFdxLNlbjFeXE6SJzu3HBD+Mm9ffGSgSTJ2f0PqwOSwi88/VH6/JWSRFgUoAIR1o1Zs/MSF959m15irHdE1gE6l349SPFp9hyGuGvC9PEx3qpwPRtaRWObsUIPpj24ZEcswhWIq42aeDllHkvzgnDL9k5BEs4pbOJBrOvhjgH6JW9rlSh3jv1ownItAPZ+dvuxQbVKO54pnKqYlXPBRWhXtiuRGIO9YBX4UIt1IgUt7BEf5cK3TzI8fTiJGi4kG23WE+7BS+jFdf9zHGyz9ZfG9fXyBXy5Yu6bCC+IGBccbVXoLgPxYslDlaPvbfdCxFs+l8L1QtLGF4Rkxhgz3m2YBGfBt7gBbplgLBmGUAruqtvibBOwovId4FutlO74HL3DYBlG6in6jGsrFr7X8Rz/aQ2PYoMraeAjRgj/ltW2hVoTATWN7N/ao3F1GYwX7mpp9fK+7FiNP9PqUjtwN1xnBwkG4KiUkR40qqwo6Hx1zfkkAopy9W1wzCJkbFedZUFoQ2Ccw/ptbt77jh2Wc4n4fIM9JT4cfMfNp2dVK/w+nC2n8LFkFWzHe9Jggcjc6MMoREXH+0kpCH8kHg7V UiksYehn rtgYdrBtQKiLJU3eer58bpFkR/B6aqXZ8LUmMW6ZJYwCKIG/cjL39mYAbyX29B+7hY58WDGFfkB0q1WZcsh6qwxNbOocS4lEZf9XyxNEOq2LfQixyvSwpC1WWHcpLCftKg7tr1k6D/2RSwGaOZiTN/ektgbPUivZWymqg X-Bogosity: Ham, tests=bogofilter, spamicity=0.004467, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 03:09:31PM +0800, Kefeng Wang wrote: > In order to support poisoned folio copy recover from migrate folio, > let's use folio_mc_copy() and move it in the begin of the function > of __migrate_folio(), which could simply error handling since there > is no turning back if folio_migrate_mapping() return success, the > downside is the folio copied even though folio_migrate_mapping() > return fail, a small optimization is to check whether folio does > not have extra refs before we do more work ahead in __migrate_folio(), > which could help us avoid unnecessary folio copy. OK, I see why you've done it this way. Would it make more sense if we pulled the folio refcount freezing out of folio_migrate_mapping() into its callers? That way folio_migrate_mapping() could never fail.