From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2F48C48BC3 for ; Wed, 14 Feb 2024 20:11:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4812D8D0017; Wed, 14 Feb 2024 15:11:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4093C8D0001; Wed, 14 Feb 2024 15:11:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 285CD8D0017; Wed, 14 Feb 2024 15:11:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 136AE8D0001 for ; Wed, 14 Feb 2024 15:11:46 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BD315C0478 for ; Wed, 14 Feb 2024 20:11:45 +0000 (UTC) X-FDA: 81791504970.14.5F10526 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 0105EA0016 for ; Wed, 14 Feb 2024 20:11:40 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RR1NvtO6; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707941503; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nzG+mcwtKVReimCU6zx6inAB8xN7+k5Rvm7slPc1wIQ=; b=q5KNzjcr2z2dmVfrxjwtKzHSLHeLDGjvrEi76b+/zzF1KwFaeDkEP7vphrT2nsQkGHlg6+ f3la3WXprFFYNMaPhDqgU2gOCBOxf3Z/ilwCoZW64/3/xh40y5sV3TvUQo0hBbdDSQSW+J upWGmdMhrQ2GiibFDdUqXaDZhm7e2Gc= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=RR1NvtO6; dmarc=none; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707941503; a=rsa-sha256; cv=none; b=SReGSzU4MOkvBwJ4MG9XG1s8fHUj+5viAZZPluPgaKmZzQvHfSFOFg/FEpD1wIACsbkgGq +mOFAquOtnvnEuMbJKapSH6Ew+cjnbDpTHzMh9PgKCSgGS1cihvnJOZC5xtGTfFj0tRJ7H miqXaVJ5sFN7nuJNqlHq1zu/ujG3jGI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=nzG+mcwtKVReimCU6zx6inAB8xN7+k5Rvm7slPc1wIQ=; b=RR1NvtO6ycswu7Qr0ZPqrP4PWj LNdeaqOqje4bdXi5DGOLcJDnCljck4gLPwvxmpGg8C/jn79uWuGkbeFakgpo4KvpoMMRm70tWfZDc h3a/ClEjQy04HJCqcZoIa/UuoeMoErlzWJoYqeLBdkmpqNldKK5Ug+mvnI8Vi5gGJet7oyeLsxC8z +uOHoreKUHyO7UI0Eg000CpPo780XBDKMyscM4NHbSlGKzsohlEU4AXPBnnT0TbasI2aUH2uGAqAv VT5RE0ttZFCIN/1yTreaWG+Pgjj3ls1T3klTMs2e08Bnya7OFeXFa6z3SYcbhGwmuray0OLL9Q41J vX72BgkQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1raLb0-0000000HUak-0HCQ; Wed, 14 Feb 2024 20:11:06 +0000 Date: Wed, 14 Feb 2024 20:11:05 +0000 From: Matthew Wilcox To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org, Andy Shevchenko , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , "Michael S. Tsirkin" , Jason Wang , Noralf =?iso-8859-1?Q?Tr=F8nnes?= Subject: Re: [PATCH v3 01/35] lib/string_helpers: Add flags param to string_get_size() Message-ID: References: <20240212213922.783301-1-surenb@google.com> <20240212213922.783301-2-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240212213922.783301-2-surenb@google.com> X-Rspamd-Queue-Id: 0105EA0016 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: biux453zk9acqxunjbwbc5j4ti81u5i6 X-HE-Tag: 1707941500-650900 X-HE-Meta: U2FsdGVkX19xOkRG7aQqj5oGEdGsGBt8PFMUl1rMrYL5/zv6l7NmA6m9XHWJl4CmIPuJxcrrFKGqYyU+LT4Z2mcI8NzjJ/erjbti7/ACMm2H8cAaXfAp0/JJCH35se0SLCno92ey0oUOhodqKCAkL+waShVkaPiGbzMzyJF0YxfI3igGs2bmoaJ9o5FQS1vAlUE4ntSI0FBrvyC9VncpmYwKimhLB8+p+kQ2f21UH7YZEVNyvHf2bYxaaRxvBQyr0Jre8xRjf2otQjrYiwsKjbnv4750DT0cS9ZhUtwK1M1Ej0r4CZEJZ1OMxP6G3Ft7/Cr+YMlwQkfFuJ+UnnWR2bBD0gJI5oDcRlHqMk1mCFVeVlqBYykCLOqVixOZJQEeFtB/FXt+buKHUpv9w6XJheX7mrlbJWyh83+Ft9bzFcL5MBeNPF1eCKkHCRKzmyHXj3P7syZIvPCaZq9RZk+zWka8s6ijjBBU5g6rbOs0aSJo/VZCNj7nMKYqRcYrXEtMc11PAXUBFHIkRyOY0JnxsiQarHiGDhFHkQHseeOs6LYVZ2SvBwCTUgUqGoTi4uxcAKjzf1osZoQMve59nXehnq+qVPQi+usoYmh6uDoinpjLlQ88Xls9IQKw63Y5KoOhgBzPsKW6Da6GIhSWCOPrYRyObo9ky/xoZsFLGprGHPz+G0jTMlrfF6I/5LwQ16HytJ3Ln1mVv1Ultd/N8Q95fY7yt2nf1DBMLvLYaaZeJXaO8WlHceMm1BbFX9fsVlfDfalMkimEqWfqbSwZTuRLHfVnSDrsHuTMOiCRl0Cr+upRmUT9zt3pjpn40nxOBJQql/HYlM8rP0h5aj9WnngyhZNwtdpCi7dCylfoDG95GIjAjL/UxV5GLysi2fnh4oxlc/rIu8CYhkr+dOcDv+l7pN6XTEsUzQMTmI0BR0hrDdEJaKnJCkxjQ+PypxOt8tBmz6IzfVgaOaE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 12, 2024 at 01:38:47PM -0800, Suren Baghdasaryan wrote: > - string_get_size(size, 1, STRING_UNITS_2, buf, sizeof(buf)); > + string_get_size(size, 1, STRING_SIZE_BASE2, buf, sizeof(buf)); This patch could be a whole lot smaller if ... > +++ b/include/linux/string_helpers.h > @@ -17,14 +17,13 @@ static inline bool string_is_terminated(const char *s, int len) > return memchr(s, '\0', len) ? true : false; > } > > -/* Descriptions of the types of units to > - * print in */ > -enum string_size_units { > - STRING_UNITS_10, /* use powers of 10^3 (standard SI) */ > - STRING_UNITS_2, /* use binary powers of 2^10 */ > +enum string_size_flags { > + STRING_SIZE_BASE2 = (1 << 0), > + STRING_SIZE_NOSPACE = (1 << 1), > + STRING_SIZE_NOBYTES = (1 << 2), you just added: #define STRING_UNITS_10 0 #define STRING_UNITS_2 STRING_SIZE_BASE2 and you wouldn't need to change any of the callers.