From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A302EC48BC4 for ; Fri, 16 Feb 2024 13:53:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 36EA76B00A6; Fri, 16 Feb 2024 08:53:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 31E366B00A7; Fri, 16 Feb 2024 08:53:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20DC36B00A9; Fri, 16 Feb 2024 08:53:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 128D66B00A6 for ; Fri, 16 Feb 2024 08:53:22 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CA86AC0602 for ; Fri, 16 Feb 2024 13:53:21 +0000 (UTC) X-FDA: 81797809002.14.117CFE5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 56FAF180029 for ; Fri, 16 Feb 2024 13:53:17 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bHuV0+Ic; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708091599; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=173zbrHCTEPXtEmszW1jYj3MRJacOHFLh12fNSZQHo8=; b=GU/DARWWighvBCdTPVjRYRVXpDYiOm4Nz+T9v1s3G7OG/9E5I79XT4Cioowd0taYDBwujG rV4s6tW6Hb4wWWwE//gi7DUrfXvE6pjGP2IHX2rKeunEsch3ifiBmM75YRCRHyvCq1BGQN U8i3tWtLYO0lv2lrsGY+Ad4iBsbkqNs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708091599; a=rsa-sha256; cv=none; b=WPjKtuX+EezWNoIj4nGjn9h5iHnKWUn9AWRl9Km1ovvKVBQvui7BU8OhGXc0pwLrXMlAdQ BSATokuwarfCAiQpbYna2b9a5wwcz+PQKaZ1nqK5XpdUSyXyxzy59g355Dbj5tMaEhQgB/ LaivzhSv969oxbo2JfU/Z6iJNMiIxSw= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=bHuV0+Ic; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=173zbrHCTEPXtEmszW1jYj3MRJacOHFLh12fNSZQHo8=; b=bHuV0+Ic5LqJhynFqJ5YF53Wbu ozepYGZaIy7Gz1Sx3QMxQjBvaL5urDOClhLVjKsnibPzJjfeMYRmlhxyAh/TB3jezZ2cqAfMN9gMR kkgQNlwkeflEYbRjA6JGEABvW0zd1+yj2IA8RJ1Sr5djNuu9Zo3Rw3nNPODCX6UzS04U/K2RS8Obz aYcFePqraZE1vgvnIRZE+AWoYLm23yACx96HkSu6PLv1pOFC/O5kRUNAdz+/LdT7plzU+7p6ycgGw W/X3WatPg+J2wEoFiWrc73ZjwQVMR/tCjA+5Q8yV+5ZcoRhdgR1+cNSK2SVlQhxmZzqZJGA7rccZa F3B+lHAQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rayeM-00000004o7S-0EQs; Fri, 16 Feb 2024 13:53:10 +0000 Date: Fri, 16 Feb 2024 13:53:09 +0000 From: Matthew Wilcox To: Christoph Hellwig Cc: Chandan Babu R , "Darrick J. Wong" , Hugh Dickins , Andrew Morton , linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 05/20] shmem: export shmem_get_folio Message-ID: References: <20240129143502.189370-1-hch@lst.de> <20240129143502.189370-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240129143502.189370-6-hch@lst.de> X-Stat-Signature: 8748563f4xjw19y56xfrhieai45xgkp9 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 56FAF180029 X-Rspam-User: X-HE-Tag: 1708091597-987281 X-HE-Meta: U2FsdGVkX19+7x0hhZtXjKEcfrE6v9+ZjTbruuTcrI369BDSeNMBwf0aUlLa4SUqrqO6RiuYdQsEa9Js/Szmhm6VMXGJxmOsXjp5IlAsqfECTy9ouQJgYZnXp3ra8MCv8IatdNMecwY7FzwUSMpiY3xtITRWPxCCwq9gTaorOdLG0atwkrxZXCP7fs2zuTiidLpunZ6KnZ45QCLHEQnqDyKsyN8QKgfOZG9N2oOOrzoWvBEZYgLBmOYxt+NBhIuw2+zhEXU+wSvn4uuOlQY0p1U46NAkL4azLC3vvti6cGcTe/f+aUuUTmGR6cttaVbfmBPcFDThbYs8v3yl2Fh1yOCWWDDPIDQSki8VIIYw4NBDQrhpsjjmRUodSlRX2ibu1kI5g+PjCokEc+JN9F5c8F1I1BBtSAKnFumMrUghMpZsrapA9G51/nj4tnYhznrAUspsTk4WGC7M6BW/vdYgDUiYy39OFr4LuBzZP7lWw3x+YLpnedEUmt1rwGAtA/6XeQa50ScGzU25iP/U6yy3cnCDSoL98QEUNKCzbzapPepxYRfmlWHPD4tEKYLKbqU1EMc3SQyji576LwKWRKtLbPDgL/w5tjhx1rZTBKgO4JsfYiJ7gwns3VOjqV3o4v2h5TcceYIDhsdmaJdhQxqmyUTOLXHtBVdC1Ya2sOxb1VwgS27+0EoOefzL1uupqy6iN2GJxZj63PiQVNqlrNOkVzvVu6ek5jWnX/bp8Micxdq+E9ad73uOlCKh0kGGKjlbFoMUTomVeaT/MgVPn5hX7DxBjGxPrF70zYz7zRT8vF2jvVFwBFwBHUlhYre7dHACnF+qd9W03i6zIZzrxEvlQobB3InlGeHTV5gaM75YeW+w7jCWmXI7El9xF012i8HIXExfn5Us9OxBFiyBRMETm3zb5k/VshMg3GOD83BcqigHIye+rRkE++HBe1ZY4WCjBVJHJh96SoJXQ87zI5E Ewv3zRty x9feDtCuyGVdEMp7kdEI6fxMo2L3On152RQ6tL7d59KWqeXcS0F7bWRHjxvWjMwWTnqGTQeahALuTBUaIYCteeF/owkicaMolgYczfeBi/5dGmDUwbCKhGOJs0QY8zOVjGTYj3yTd4NDpKpPD7UEbhuLeG1BDWkrTmDXdqk8eIZLmw5duz42cX7F/zA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 29, 2024 at 03:34:47PM +0100, Christoph Hellwig wrote: > +/** > + * shmem_get_folio - find and get a reference to a shmem folio. > + * @inode: inode to search > + * @index: the page index. > + * @foliop: pointer to the found folio if one was found > + * @sgp: SGP_* flags to control behavior > + * > + * Looks up the page cache entry at @inode & @index. > + * > + * If this function returns a folio, it is returned with an increased refcount. > + * > + * Return: The found folio, %NULL if SGP_READ or SGP_NOALLOC was passed in @sgp > + * and no folio was found at @index, or an ERR_PTR() otherwise. I know I gave an R-b on this earlier, but Hugh made me look again, and this comment clearly does not reflect what the function does. Presumably it returns an errno and sets foliop if it returns 0? Also, should this function be called shmem_lock_folio() to mirror filemap_lock_folio()? > + */ > int shmem_get_folio(struct inode *inode, pgoff_t index, struct folio **foliop, > enum sgp_type sgp) > { > return shmem_get_folio_gfp(inode, index, foliop, sgp, > mapping_gfp_mask(inode->i_mapping), NULL, NULL); > } > +EXPORT_SYMBOL_GPL(shmem_get_folio);