From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A126AC4828F for ; Thu, 8 Feb 2024 19:32:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE95D6B009E; Thu, 8 Feb 2024 14:32:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E4B496B009F; Thu, 8 Feb 2024 14:32:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC5406B00A0; Thu, 8 Feb 2024 14:32:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B56BA6B009E for ; Thu, 8 Feb 2024 14:32:14 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 60490160FB6 for ; Thu, 8 Feb 2024 19:32:14 +0000 (UTC) X-FDA: 81769632588.03.A990248 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf04.hostedemail.com (Postfix) with ESMTP id 7A1C140010 for ; Thu, 8 Feb 2024 19:32:12 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BAx2dC5o; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf04.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707420732; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w3bEV6G7AILHzWRDb6GXrkF6SdkK3/w9panlonnMl9o=; b=uOWowwGEtgNO8PZ1WIyBEEARWiCf6lDkUpJK4aOMkd7bLZ49Xljs9iRvC+f1cU9jGcjatI Z6b76QrT834duf1ejAe7j0ulCmOArDNWHKGG6Z8Mo4WbkVkGoThCMBlD9XE8S5wATr9I8f 7vqEbwFS98ewybre2Qc2ZiTg9f6iG/U= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BAx2dC5o; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none); spf=pass (imf04.hostedemail.com: domain of htejun@gmail.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=htejun@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707420732; a=rsa-sha256; cv=none; b=SPbrlcIpdYyBZBMGn/mUP5A1+LOFtSMno+PRpK1N+uzORicFTwBj8Xtv5xtysQKUpGPESn NPy0sgZ8kQjN4FPyVY/NU6nzP1ID0vePUoQQEXnlMz06AB9mjzYbwifZ/AqpUCfQiXPvu7 VbaC+e2tWgZYWciF9YSWWRfHr9UZqGc= Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6de3141f041so183578b3a.0 for ; Thu, 08 Feb 2024 11:32:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1707420731; x=1708025531; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=w3bEV6G7AILHzWRDb6GXrkF6SdkK3/w9panlonnMl9o=; b=BAx2dC5oJqfXs7+988f1rNiLDrkWgZ8GQT9k+CujxAAJvH9zAHGb4ByV2NVd/o0duO AetXkVmvrKVu//OlGIU+C5Bcnv/tEAESshPDVqjOrKHbLyhE/BF3d2YUempaBD7b9oPw fKGj4sbA+YaltVKO0gPu/08xBddXjb68jA+jYq0BA/ZwIBkiihJ/h266pHv26DlrzRbM pVbIkohKxY84Bo2k/QV9pdfMVw4vc1fGsfI3X1e2aH6/LmlYci8Sthgd91I2hvYaXuSY HUmmx6GIvgHDvKx3Dxw1l8e9q19Etact6mQUrXz/dkm1aaAwziUCrFJsTsv2ICtdXhzH u3Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707420731; x=1708025531; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w3bEV6G7AILHzWRDb6GXrkF6SdkK3/w9panlonnMl9o=; b=Ca3+n8d5u7ofpfz9j4KOJjw4okbPSHgAD8YxgnztgPkFyvRDPJLc8kNIiWMfheEZ2D L2kUk4q3Lr9Av0UFSIFK8OkQ6o1OgYkKOvYoFTuA3whh51ocAMR4++O3fkWiGaNhCpRr eNI+bpivJCe917+4YFFE1463y1PBT2xPPoMFDJcsU/QC6SVkDVu2ZdIxIPv1v8G7K7ji 9znU2W1iuzwlY4xB2Eehyhg4zuAm9X3sGn5P/E2IFVPr+uhzKZ26CtOgs1Y+FB1HXwmj oNCqPlXZdjBc0p//zxiUTXcQoXzxvCFGSKXUuyiwh6bNZyDPeqX0J8hBowOhJMBG7kOv Nm0Q== X-Gm-Message-State: AOJu0YyXeeRFSn+FP/l5mOM1rEzkxP6T+LYrsIXsbHjECgobXqpbMoZ9 dugP33NCt0z/vBOXEaAI8OBEizp3oqSY3va89lg9J0ZhmAnEmuZN X-Google-Smtp-Source: AGHT+IFUFtBkgN+XYjnOixZNsmqmk71LfGanz5wkj3aYHGe4rvLwzdB8rEWYqLYv0r00wRAB8jL57g== X-Received: by 2002:a05:6a20:9753:b0:19e:a85b:854b with SMTP id hs19-20020a056a20975300b0019ea85b854bmr428329pzc.48.1707420730987; Thu, 08 Feb 2024 11:32:10 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWXucN7a4KrzdxMiZ9FwIbyeCimIkQ5zGfEKnCcFqDC+Zwl9Hd4VhfAD3KVXDu+16ImUOx7wwor0VQkK/PB9gg5lMggl14EScXE3NpTyWL7pQHW08DcLOdjYpUUZPxhwkv23Qkj1tGM8HSwFPn3Dn0GClUTkkz1uMFjAqQGaEe4aTRzox7DlLh1ONRhQh9SV+/B1DfSDEJml4YN3l9ak42liXHGMhsuZPvzJOc87DmQLk90ez173/Cc5RcL03849dtAgVUJ6NAR4X6zZjp0LJmiGq5Pd65x6YmZ7WOEi7OaM2Z9piTTY5zm+PTP2p4= Received: from localhost ([2620:10d:c090:400::4:3c45]) by smtp.gmail.com with ESMTPSA id t6-20020a62d146000000b006db05eb1301sm119360pfl.21.2024.02.08.11.32.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 11:32:10 -0800 (PST) Date: Thu, 8 Feb 2024 09:32:09 -1000 From: Tejun Heo To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, hcochran@kernelspring.com, mszeredi@redhat.com, axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] mm: correct calculation of cgroup wb's bg_thresh in wb_over_bg_thresh Message-ID: References: <20240123183332.876854-1-shikemeng@huaweicloud.com> <20240123183332.876854-3-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7A1C140010 X-Stat-Signature: wkmk48o6z8owch8dmjrxq53qusq1fp6b X-Rspam-User: X-HE-Tag: 1707420732-915106 X-HE-Meta: U2FsdGVkX19F8vMtICrZnGyDPlR/gqrBHBJlQNTe5WUQdlXDSF734Nfsfh/GOTdxbJXPx3DmfIDaqYem9f6lgThf7ysmwRpeCcRO+zdcv5F7nFuzCzDsZ5HK5kZT95SP6NdcLf+Ppg/qOr2XB65lCW0nGuqV2ToZI5B/jt+WYKpJlUG/gsMAAEN9IfxgN++cMlyuecQSG8AyyJkEbxesT5bJr1058JrenFSIl67mEVXBpyPA1j+HTEZvXeVPZfrsRwY3jKcgaueJDvRzXori/eSLQVmPjLZ+RC6KJDQkYmwOUvqWnGWNQM7aKKC7HALKl5kB7BOe++FfZfVj6v96gLt7s0TrjDlrRPZmnsurRzam3f5MtmdTgMpGsrhGdBW82NEH0gIoy3+umV3Hoq0DdKWOKytIANjrdx9nVF+NyAfyGrwQrKi6lhNkgMxfmPvrCRr69HPm/95jKoU+Wf8dDVOwz5PIagb9BWfd5WGsPfa4QruP8N38DcoelgO2BqHubElbDigDov8s2cdHI2CFvunGBCpM70nQeEYOX9PQOYeT7UJR/ua0ENl3OTUGesKhjDlQnkJlDoF4tsZhmySnO8dkQvVDCdR4JGRguNJNp/e5Fu16YclvtAahNEQc5fyQSNiF/pLy9RdHTorY/IpbSqBRZskpO7nXDA1V2ntVvsEgxt4mtw7IeufRHPtG39L6BYIyiI5iZwm0BPkoGM0AXswSr85U3sjNURjmJptfVbkUrfQQ/Rg9W49Vb0c1CyfzmZqZaUJIx+/h+b/m83iTJ332LiaSj4LS1tqxScaDTjM0kNOWRDVuNT5gXF7ig4tjOPzfHVzE1+5UXhcSBDh1RYYsFIMfzNNtM3kp2lKRiLgAE5sbZaq6CGy6AAqH8FMQma6GBw57k2gcVwthl7qZwwyCYD93s7fbaPeGBHu8yW8jo0M0xxSDSWxrDKrP9CvaU7UVdWaGpoBvWeN2rTa PtfvdVlK ffnSD9imF/hJ6cAiCmdfawsSaQ02PVUJ06EXVTSHgjV9hs56+r68Az0yyW8uNY2jBXxBSQ5Mpkjqs9ylnwdehmUDsUKVfBc5FiAT7Tqd690QyOAv8r4p8FGnDb955iPdafnWDLO3usYfNu3yQGw6dfb8Lx4/YJAMrAzAXz+9SfT2nZzDVBRtD/c34p/uvRev6IdVJpCdsfJmE57H4IQUbu8QXP5wODJ4e1BXuWwGZjweK2P5uJpwP6WgiI0Nqus7rh+lM/KIfQeeQnu14RG8VP+m4T7KxO+/JFtwJGav9SxmMUY+Sskz7ecGLi9LI+aVi6HIdUacvEE2jC1BCw2bw2jimnBKUwpxsH0W9nnmWL8LRCfxMub9wptu9OKDWO1OXVZXpFjZVcQHVD/Fx9tiCsYdOBNrK2JfVzQ92yvlqwIDQKm9umW/m2cEmpRlU8duFf4/W4qoLo+Zr3mrJQw4x+HaMgLqiXKEUM6jjnpoppwU2iTVRzuqURG/D800RUNDe5SLqF/C7yFM9iRBNPCbdB0GhCKkm+dPOr0sLiKSIzxgJcvpdUCjNH11rRJf8yLSITis1sOF9xpCn8ca/6D9w1b3T6AfVknBIRdHwqQ8QfVNX9gGnbsXbk2vW69T6dwIH1ivOgDIqFPdlEsv0xbpsoA0AV9RGty1ebmki X-Bogosity: Ham, tests=bogofilter, spamicity=0.002465, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, Kemeng. On Thu, Feb 08, 2024 at 05:26:10PM +0800, Kemeng Shi wrote: > Hi Tejun, sorry for the delay as I found there is a issue that keep triggering > writeback even the dirty page is under dirty background threshold. The issue > make it difficult to observe the expected improvment from this patch. I try to > fix it in [1] and test this patch based on the fix patches. > Run test as following: Ah, that looks promising and thanks a lot for looking into this. It's great to have someone actually poring over the code and behavior. Understanding the wb and cgroup wb behaviors have always been challenging because the only thing we have is the tracepoints and it's really tedious and difficult to build an overall understanding from the trace outputs. Can I persuade you into writing a drgn monitoring script similar to e.g. tools/workqueues/wq_monitor.py? I think there's a pretty good chance the visibility can be improved substantially. Thanks. -- tejun