Re: [PATCH v7 1/4] lib/stackdepot: Move stack_record struct definition into the header

Oscar Salvador
2024-02-09T21:32:38Z

On Fri, Feb 09, 2024 at 08:45:21AM +0100, Marco Elver wrote:
> > -#define DEPOT_HANDLE_BITS (sizeof(depot_stack_handle_t) * 8)
> > -
> > -#define DEPOT_POOL_ORDER 2 /* Pool size order, 4 pages */
> > -#define DEPOT_POOL_SIZE (1LL << (PAGE_SHIFT + DEPOT_POOL_ORDER))
> > -#define DEPOT_STACK_ALIGN 4
> > -#define DEPOT_OFFSET_BITS (DEPOT_POOL_ORDER + PAGE_SHIFT - DEPOT_STACK_ALIGN)
> > -#define DEPOT_POOL_INDEX_BITS (DEPOT_HANDLE_BITS - DEPOT_OFFSET_BITS - \
> > - STACK_DEPOT_EXTRA_BITS)
> > #if IS_ENABLED(CONFIG_KMSAN) && CONFIG_STACKDEPOT_MAX_FRAMES >= 32
> > /*
> > * KMSAN is frequently used in fuzzing scenarios and thus saves a lot of stack
>
> ^^ This hunk no longer exists, try to rebase against the version in -next.
>
> Other than that, this looks fine.

Yeah, I noticed it later.
I already synced the last -next and I have rebased it on top.

Thanks

--
Oscar Salvador
SUSE Labs