From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C176DC48BC1 for ; Wed, 14 Feb 2024 16:02:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 290998D0013; Wed, 14 Feb 2024 11:02:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 23FA98D0012; Wed, 14 Feb 2024 11:02:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 092A38D0013; Wed, 14 Feb 2024 11:02:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id EAE418D0012 for ; Wed, 14 Feb 2024 11:02:34 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3A739140E08 for ; Wed, 14 Feb 2024 16:02:34 +0000 (UTC) X-FDA: 81790877028.22.61419E9 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf06.hostedemail.com (Postfix) with ESMTP id F38C1180051 for ; Wed, 14 Feb 2024 16:02:30 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=pWIk5zuX; dkim=pass header.d=suse.com header.s=susede1 header.b=rrdpvnmv; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707926551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pPXp/+cRrehfUHk2IR8IXdxKLmNDOpV5ikCDlFNmYEA=; b=jyBGPTKU85G0UcHVcgqT1wZxrBx1Gr3WvHP9WtASegDfYpbMzDJObNN2B6sCP9TFl0wq17 niEAzQjB7aP8dXmAzhQgGf10WJjHArIS9W+ZSsEclO8X6XLF72qUKDL2Qo4Hbpc4K6YH0Q mpiUzLNQNgPUivyKVo5CFIpEpxoY+/U= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=pWIk5zuX; dkim=pass header.d=suse.com header.s=susede1 header.b=rrdpvnmv; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf06.hostedemail.com: domain of mhocko@suse.com designates 195.135.223.131 as permitted sender) smtp.mailfrom=mhocko@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707926551; a=rsa-sha256; cv=none; b=rPtlzeQqrqcWQ9StMxDkkI8XU9Ywx9vrP/ul0p+nb7YCrxmpuH9KU+67gGgoMK6RaaeoE2 RIOQRi2Lc5S4RbWpl6voPKCii90IUHCWyr9jtyrswDhlJm58EbfA6ts+1kNIYgpXSIc2t5 1H+1DLYuwT2TBOQfDmdv9OwoBp/fx+g= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CB6651F810; Wed, 14 Feb 2024 16:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1707926549; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pPXp/+cRrehfUHk2IR8IXdxKLmNDOpV5ikCDlFNmYEA=; b=pWIk5zuXuhl6gONhU7unHCikdmp3ePqIfuVV/fRNzIjAZJu5zNcFPcZb7aimaNy3pgSpvQ e3UGg7VHm+WzAzqFDPrnxAC3HZzgq5o4PcFY5z8ynJaPVtrYZ0HV43hukomLVaPd0BfiMD VMJL5ZQsV6ebPnwnr8MqbkkfZka139g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1707926548; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pPXp/+cRrehfUHk2IR8IXdxKLmNDOpV5ikCDlFNmYEA=; b=rrdpvnmvQplLj7Zw7mnKjtggZIVn2c3JHRtqp2UICpidV2uBqb6O4HFDkvPZAqOCRMfAzk tayx2Yu8HmqHmbhsuk34DEtn1oEM6AWyk6PjCzgAShPTp4CJ6UKzhZSk2OrDA12CxO8k7u nH3aZJD6781ON3G/cdM1hEKsMcMd+oY= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A66B913A72; Wed, 14 Feb 2024 16:02:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id BzUCKBTkzGW2MAAAD6G6ig (envelope-from ); Wed, 14 Feb 2024 16:02:28 +0000 Date: Wed, 14 Feb 2024 17:02:28 +0100 From: Michal Hocko To: Kent Overstreet Cc: Johannes Weiner , Suren Baghdasaryan , akpm@linux-foundation.org, vbabka@suse.cz, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v3 00/35] Memory allocation profiling Message-ID: References: <20240212213922.783301-1-surenb@google.com> <20240214062020.GA989328@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spamd-Bar: / X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: F38C1180051 X-Stat-Signature: 5h1iiosg4cfgc9wy6s6nw4fjdymsa47x X-HE-Tag: 1707926550-721555 X-HE-Meta: U2FsdGVkX1+lkgOCPojun4c2WkpzY8dH/9nnRQ69l5V0Z3EI01Bb57H9XwTbb3Wk6A6XSHwPbPjUumE3Z80X4a9JpyLqx6Hdulq3Lp/4UZRMYuePwesSg5IdthWpWAhvwmPz//a1TaIIz8pUXpyp/EFmvy6HTllPwhutzBUHxCZn1eksy+iwgQiFrgkiEFvgCJizcuaAFXaVTLZ6l0GmbLuypFjS2k2XrrscFsSo8SxFgNHAOGdX7ejfHA8PrtUw0zsC+BRCHbv+lg29VzbJO5vkt6M2MqwL+zquXdK74E3ozQx4cqx2WOEQdkmEG7v4mw4LIGM9TdA0LhciHcxKLTxqtkdkcCA6FIDpnJcQpgSpziB9+zPVUfcJTDQmKkYu0tF7BLy/e9WVKICmpkFG+Yeyp0QoiefMwsetoUQoNqqVh84HQSeHEysPcZosAFtSPOKZOYex+pYdBgWb0sB+vHE3OmYTGC4cfHv9SzsdgMnL0bfCGo3qTfSXM/OzaNWy246vP+jmCah1XHKcilCCipVk6paNs9sejA3niaO4tGa/VoBQuWdLC3/So5YhzuIIiYKpV1VN84dts9ZBQ/zrAhTo2OEyulqkEuRZARKvnI56t2v7RF0GnoaQNWlCzRHI05rl+jhbmX++9ntYd2Tad9eXqXsscd6NGa+Obxv5Wp7VtgKJzto/y9v8nqfvy/q1H6Jdg/0niZ4HsBa2BlmQESvivxmuOkAocvstJf6xmT0/qNwyyIuuo/r59NWfsKdk26dlEP436IEVitPK9heFwNQo8SiF0qy/haMvtFdMdTJdEQkUiPLhEIH0JKvqqxVgBsLmLYWG8e9wyIAbanehIVXP5FCIz2V/kN5jKPy4qhWZX1OxHlfbY7QcYCKgtprfeG8pXXSGUkoYuO7z1XSlGZCr5DPhnHCf7VmFOKg5EHb0FfrIIHJkbZGRpdvaJTM7QOYXL5qEp1qmiOD0H3c dvnpBZtb +VAkHmDQ15U3DbyyPK6/lx6AepsUlEyhkIcN4E1ESSb07DLaPGhoqMSgXXZh31DPyN7LGYP3lWX6VKypHayW0hhliWZjmexhf1QSnQToC80keLkHcdIVOab9no9mxE9YRD9/EbAVVctnYWz/gwhMU8xfpmVRycaAQrQQbk+1YT79pvDU/Iox3PQwEg/CUUaU7qvLwsABjIi6yCGMD6O2ncugJvU4Rm7KPCLZsJec3FrZ5V9PPQOMTaWdSbm3DA1zPY78qlay3tjn2uuX0rN+8lnYkVybzI7L0dxvf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 14-02-24 10:01:14, Kent Overstreet wrote: > On Wed, Feb 14, 2024 at 03:46:33PM +0100, Michal Hocko wrote: > > On Wed 14-02-24 01:20:20, Johannes Weiner wrote: > > [...] > > > I agree we should discuss how the annotations are implemented on a > > > technical basis, but my take is that we need something like this. > > > > I do not think there is any disagreement on usefulness of a better > > memory allocation tracking. At least for me the primary problem is the > > implementation. At LFSMM last year we have heard that existing tracing > > infrastructure hasn't really been explored much. Cover letter doesn't > > really talk much about those alternatives so it is really hard to > > evaluate whether the proposed solution is indeed our best way to > > approach this. > > Michal, we covered this before. It is a good practice to summarize previous discussions in the cover letter. Especially when there are different approaches discussed over a longer time period or when the topic is controversial. I do not see anything like that here. Neither for the existing tracing infrastructure, page owner nor performance concerns discussed before etc. Look, I do not want to nit pick or insist on formalisms but having those data points layed out would make any further discussion much more smooth. -- Michal Hocko SUSE Labs