From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67F86C48BC3 for ; Tue, 20 Feb 2024 17:34:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED2C36B006E; Tue, 20 Feb 2024 12:34:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E82EA6B007B; Tue, 20 Feb 2024 12:34:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D25376B0082; Tue, 20 Feb 2024 12:34:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C27E56B006E for ; Tue, 20 Feb 2024 12:34:50 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 902121C084F for ; Tue, 20 Feb 2024 17:34:50 +0000 (UTC) X-FDA: 81812882340.26.3356B46 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf22.hostedemail.com (Postfix) with ESMTP id A7847C001D for ; Tue, 20 Feb 2024 17:34:48 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lc+GKFW8; spf=pass (imf22.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708450488; a=rsa-sha256; cv=none; b=mI7iRQevjQm4q7NjlYHn6r5vJFgUkwoAui9+r8v7AGPWjvfFhL51EK/shKN5L7g6Zy4OD1 tHrTkFQetHAOVXIUzcVacMJEVcIWlMd6DCuRxeduxDGkQ6kxncPOHJojMHMh+AbfsA7UYe lvI5v+4E4KTt+4L7BUbA35LKqJA3pac= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lc+GKFW8; spf=pass (imf22.hostedemail.com: domain of htejun@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=htejun@gmail.com; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=kernel.org (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708450488; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g0gLcb+UZQZKvdtR+xNRyRYfChy0U5BQPT68m+rMTnQ=; b=6SxNF7le84RJSAgJc1+itAB0sx6JTW1C9iwsw0qf0pyuJzF+DuqwNq71tEFxIW863TslaN En4AA0XRINJ7NsfAhWeja4STGZS/e8Ci7sqqEpPnAxe7kA9R2Df9gXsj58zD2ITIKX109N oqXYmfY/qKKsosMSEEsgStC5sS8NEJw= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d944e8f367so46241575ad.0 for ; Tue, 20 Feb 2024 09:34:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708450487; x=1709055287; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=g0gLcb+UZQZKvdtR+xNRyRYfChy0U5BQPT68m+rMTnQ=; b=lc+GKFW8m3ztXJWbTzzDJ00rvyQbe/D7uGKOytOJ6uEDa0bwyouSrmEDmmWBmWhXQP tgBXLYqXCBOojkVWRgiMYh3pGwO6Y2LlZ1+WV7B9rs2hj94gglK7A6z/aLGyfCiPufvE Gr5KftoA9dEBGihmEsmZ5oex69Nu4ZFMyojNNm75tE1Mr8GMKW2a6/SkExEaoA0+JDlk amHcEZW6RS/xtwiyc3G96YnYKHF5szT6bz9TL/PznKw4wVENEYr4hefYVSiRiVgFMpPD aIAIQlQpVXCaT4mLtCvn++uXzSPENKKSOfhROyIrV/rxxESWdWg9XTk5/cMgDPnJ3Xxp 2VEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708450487; x=1709055287; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g0gLcb+UZQZKvdtR+xNRyRYfChy0U5BQPT68m+rMTnQ=; b=fWa+dYi9DUe2sHYVrNjVMQ2Op4U0161tm2bwVH4jm2oOlyEGcPoujHFgzrtSGw+nlc xvFxXza0asPAwRdzaLy33NgCLhDFD5+53yiePpj7tAlIvTQrRh9ovZbCys0/XPdX7RPh GspIjWTbygmb0LhKJwGTMeIoJiGeBodQhbeQgTbZP3E4XEG8fxsGH94xpNAMf6fRmBbv nvh3pb4oKVYemil9wz8sXc3fZUeDvS8/1r202DxGfvWgFOq53zDKiynim366Txytz9// P97ZzkNcs25DhhEX239inT3p0TLAWDberFwc0mWLZqHm3LLHcRwBl+dOeBJrMQWqM2kv hMVw== X-Forwarded-Encrypted: i=1; AJvYcCXs5jN551n2KCi78flY/sISBiB2wgQ5hbyG7a361HPMV4ZC4dotQ55lCGUPMCTbaetd41B5Oy1xzTV2uAoK7ooAzOI= X-Gm-Message-State: AOJu0YwYqn8P0jQzgPb41mnam+7dEg54irvDJD9Cj6LbLio1kTwumwP8 kwXaIwy93GOeKgAq7MmLtWjGhQEgSosZuzMfulg3BgcFR+QEA6fj X-Google-Smtp-Source: AGHT+IFWZ6D5sKzLckyDo+c4DpeZng9yQSbbwRxo4VXbopwXEM5SxqojmMb0zvmEoniSNOz/L5MSUw== X-Received: by 2002:a17:902:ab94:b0:1db:d843:7246 with SMTP id f20-20020a170902ab9400b001dbd8437246mr6872177plr.51.1708450487274; Tue, 20 Feb 2024 09:34:47 -0800 (PST) Received: from localhost (dhcp-141-239-158-86.hawaiiantel.net. [141.239.158.86]) by smtp.gmail.com with ESMTPSA id jb12-20020a170903258c00b001d9c1d8a401sm6468490plb.191.2024.02.20.09.34.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 09:34:46 -0800 (PST) Date: Tue, 20 Feb 2024 07:34:45 -1000 From: Tejun Heo To: Kemeng Shi Cc: willy@infradead.org, akpm@linux-foundation.org, hcochran@kernelspring.com, mszeredi@redhat.com, axboe@kernel.dk, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] mm: correct calculation of cgroup wb's bg_thresh in wb_over_bg_thresh Message-ID: References: <20240123183332.876854-1-shikemeng@huaweicloud.com> <20240123183332.876854-3-shikemeng@huaweicloud.com> <6505a0c5-5e22-3b25-65f5-2b44e885785d@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6505a0c5-5e22-3b25-65f5-2b44e885785d@huaweicloud.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A7847C001D X-Stat-Signature: pwhe7uq7b3gsp1pzkijwfo7rzwdkk1gh X-Rspam-User: X-HE-Tag: 1708450488-839989 X-HE-Meta: U2FsdGVkX1/3wBKw+yudq7X2pvl6OtXLA5Ln8R534DEUy5bo1NpKfmU7ttqQaiLpJZ7YS1L3u0o6Y38Gx+zV1SDCkAnG0r7cRCP5o9LK/v3+oz3POTS5SPYKoqrjZZU1GV1qxN/27gt1Olj+wSY11n/YCzhTA6fRB3GqarGC30n/cVZHmPx0Qz9nJu/0dcuhwTpuOQ4P+91K4D24MoBRkHYB1vvQafy179OM7sMBRnCk51hZKao5rZVlLm7m7OgQPnbLq71bJ3FaspVOvyEvi12jLDMztImhpHHyI6DdnwmvAsfRnCqH92vDsr8VSVkm5xEtWjEgLXFrKZnyOivIKDmLB7fRUPHSCgBfWUsiLJE/i8oeTWmKaSUAZ6OzpGGJ0xGGPB6ZaRrZH+CD7UjzeL8MYo4TQXUhsiByUQSdH7P511fSrIB1v066VzM4SHu1FvIXe9SYh5zfizNyndGrrAAO/xcGabJuPAPFwLPgdfDYx7mnkSsFwh6nk0ynbuJxpgK9i7oYoFghqRtn/J5BjXudx/ibxZFJ8AcLBqH9DqAbzm4ghAOOO0P6fjsjNsQv72pdKZGcq8Zjomz0o1GTj0kIRvkv/XnsozEhk6ghL9nlYiivPmlAZmK4XxC4LKTePvjthBqgYKJSD5KFJs7YSqc2atmdI+ZhzGrsiToX6e9pmzuWC4WQ5cURVxO3SPSs3UZNKU6r0TdcdaFQMY2Qa3t9rBfRJYajhViJ6AHDwtXMXbnAXQGt5tRMU4/AT3LUPaNYQLsX5xJS8ku0i58dn0leg2IT/daTKbeWKJRWgT5qCkpvryMCI+V/LDKEiqDFwzsTHUDPzVRNzfSfAeJo82P5IUyT2WYTFi7ne/pAKuoRjysNmLEChs1p7Uoch9s69G7bE8O/gi2Mi+jPdpmIFDNGFGxL6s89e76evSy+93vKtVylj5PuB87sKmO/wFINyn7bL38ENKaNdBh8VmM V9JrjFIx 4+4UyPb2zWUYVt0D+6CFqd7sAr7qcpynApqGNyQ4bZ23xMlyxj7iARW+oUBohmt68MjsnkszF08I3tg5JN1Jm75ZJraDRkN2EEqvBbGl2tiQzAMQ1zJjqRDHEGpq9Q+zewSizqCkokh7x17rtj0/niZ9V17WA3+ORgpJF/X//eqdi2pfdJlvKKvEGy5SxB3k5FasGiMpXDCuheHnQPnh7ohuKqMQFhgC2lW9INGp1tj08/+PeOH1UzsihcNM47pf4fW2Fs1Z3t0QBnBWBdSR6MyQiy4zR/9HcTtF9/X15LEHI8/OftQYV/9R41UTv2nXLaqmr1HI/UooNUDf0KvABqLHyRDaWl2x/ikGZn0xHCqtlBxrWii8IFIwm/xmjZXfogx5bPwkWL5s5uZjivQcxRvB5kQfvdgSQjJi7C9M1l313SaoeD2QyPnRLPBVCfalU1r4j2Jr2fYH1xozXrrzPAc9IUcbDodwXVRkdA41/nR2D5GE7Dq5Il0Ap9Gm4FBc492iEbBTJF0LQMJySMW8GTRuCTVNiQL5bNeZoYyOM77nIyOc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000374, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Sun, Feb 18, 2024 at 10:35:41AM +0800, Kemeng Shi wrote: > Hi Tejun, sorry for the late reply as I was on vacation these days. > I agree that visibility is poor so I have to add some printks to debug. > Actually, I have added per wb stats to improve the visibility as we > only have per bdi stats (/sys/kernel/debug/bdi/xxx:x/stats) now. And I > plan to submit it in a new series. > I'd like to add a script to improve visibility more but I can't ensure > the time to do it. I would submit the monitoring script with the per wb > stats if the time problem does not bother you. It has had poor visiblity for many many years, I don't think we're in any hurry. Thanks. -- tejun