From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14BF6C54E58 for ; Mon, 11 Mar 2024 17:08:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96A7A6B00B1; Mon, 11 Mar 2024 13:08:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91B2E6B00B5; Mon, 11 Mar 2024 13:08:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7944F6B00EB; Mon, 11 Mar 2024 13:08:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 690416B00B1 for ; Mon, 11 Mar 2024 13:08:18 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 11D521C0C5F for ; Mon, 11 Mar 2024 17:08:18 +0000 (UTC) X-FDA: 81885391476.10.B00373A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 4304EA0009 for ; Mon, 11 Mar 2024 17:08:16 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710176896; a=rsa-sha256; cv=none; b=j8ljv1iEYFYetz8ThuYty+1GH3ElgPv2T/VlY7ImiP7QHkxcgv0zFC8Qx1T+FeHy+w9Nmg tQ4mULRb+WnTKMcMa/FCybXj7WulnOy+Zx/csxV15sJU0Ov0blvSC+Qbxgz2u7fu9F62k0 s7qTHgRdDhg8KqShZkKspD5r35OViFE= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710176896; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c+XwZCPTrjfuBeIoZaqvmQ89fpV93dVEHUHFv6Ak+5k=; b=QY2AgG3IQPxnolzns3cAA1xenf3kAv3bBYOAJdIfxfbisfbK2BQbuvlS8R1ZbSJRuENWgI uBX0okNTcsIgfNhbrnhT8Qqak0HRIFwIyZ4EAsGtTaig5/M+WwwHKRZvzNVyBVV8IncDWf wTe/K/LVeJe66leCOhEav3Nje2lxKFE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 175D260F0D; Mon, 11 Mar 2024 17:08:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A02EC43390; Mon, 11 Mar 2024 17:08:10 +0000 (UTC) Date: Mon, 11 Mar 2024 17:08:08 +0000 From: Catalin Marinas To: Marek Szyprowski Cc: Mark Rutland , "Christoph Lameter (Ampere)" , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Viresh Kumar , Will Deacon , Jonathan.Cameron@huawei.com, Matteo.Carlini@arm.com, Valentin.Schneider@arm.com, akpm@linux-foundation.org, anshuman.khandual@arm.com, Eric Mackay , dave.kleikamp@oracle.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux@armlinux.org.uk, robin.murphy@arm.com, vanshikonda@os.amperecomputing.com, yang@os.amperecomputing.com, Nishanth Menon , Stephen Boyd Subject: Re: [PATCH v3] ARM64: Dynamically allocate cpumasks and increase supported CPUs to 512 Message-ID: References: <37099a57-b655-3b3a-56d0-5f7fbd49d7db@gentwo.org> <8abb1a69-6cbd-4a36-ab1d-d269cdafa391@samsung.com> <8c8aea4d-e911-44cd-bbec-ead4e44d338a@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c8aea4d-e911-44cd-bbec-ead4e44d338a@samsung.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4304EA0009 X-Stat-Signature: grpcj9i3p99qtg4n7d8xgjfctpw74rxf X-HE-Tag: 1710176896-645408 X-HE-Meta: U2FsdGVkX1+9e+3J4kkZ6a/SPVeYGtQ2+6bimqvYfICxlurWLr1tWdM81y4vbbvLUPi2eOPGOoyV/pvuantlRlyVYNpeclNG/2mq1HzFcNPMI0D0gbfu7xx/TjMel+l58aF2NBPKb3KVGQ5uUU3uXzRL4auTQqVm7NtDBjCU4ktQ0rMwCjn4vSi/OP44652FA1ZhUeEcf1O88UVlhYG7jolfn1sd4iyibmqkH1WWKEWEqM5yMTL2edxRsirHUp5seJCBo2XpNPFOMrscnmsdnDZ1IwIWLCsDHRDz9Cr9pHFklZADl8IdCa7S7rL7RxVqbIkC+oseC2ovGgqrhjTCyJOVyTT9DZN+lnD9aPNKjy0UFni3M9caPz4aM3r6pVVBuK00j+QPVtZZmtnlT+xK/R6FXzR6jT2TVqPeApBYu47H+KCRZGJF+3n+gmItPD5k2RpOH1CchK7ZrCykAYFxH4Fq6W6scSwkfdb7S68wyvq8eqNHeLvKpBpRJrQY31nhzkm1xmzeDYrOzb/dmY2OWfSPBFp2j5HUHkj+A4GsK1xjBDsIi01ELV93/EuPYIxgl8H6x6EsCYbl0HBoVFQEFmWDWCop/JCAoAtAvnxG/AFtAcsQCBv+DcnP3J+I15OPElMg958QZC5Dk+vChlmvOM/Jni3W69XRGK5hVP8lJpJUjstJQkMLTP0IF+xmF2bLeqm7OazgIV9jP6892zUXPSY5l8Wv+ZHkex4/LGPkKJI1mEa+XSa5emlZp6bkH3ua9q5dTKxW0G89IL5NnjKQNoLHoY4gnviNMvCIkNH9Kfkh2v3NVgHS+rxj0m58Ppau1dJwnc5r5XHGG/0XctykSU32MV+dgCws1tSyi8C3jzBoyw4eS4ViOasNivrofQMmfTWZ2Yi/9hGy6Vl2wPDN/br9uU/QwsmLrkKtLXIInTZRo3oS75YHPXH9Y4D4FrFnEqS+0K8QG0sYubJzhFH C7Pzdp8X pCRyaBsezEZ5OYPsEz87Y7uUq85K8JNdCsJz6ybdmauYx4+BEE+mnTTIMnMRWqsNp09YjlZASrWcjaKvp1UBp+0c2JM3/ywY6ReleEJmVYMBw0n0azNQ7KwUc3MYdCDt00TTCwJXL1CHNnvG6Jb3oN+hxm8Lic26BctV5Px5SMrBj5ht9Vz5LtK++TWjR76Q2U2UWyebBwGTMVdKBdOJnmEDL8GTnDCiuyCB2qRaW6mTwrGcQJxYL/lX7gsK58fnoYRuJe+qkpn3EqsC9fJuxodZzPZ/8JpkEIMqIJKMvY30TP1xv2eSiQgT0RSpFEXvcxiPTL3KM3Xt63G0+lgHz79dDscYhxn4Jxg7nh4stVR5c4Z0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 11, 2024 at 05:51:04PM +0100, Marek Szyprowski wrote: > On 11.03.2024 16:22, Catalin Marinas wrote: > > On Mon, Mar 11, 2024 at 03:56:37PM +0100, Marek Szyprowski wrote: > >> On 11.03.2024 13:12, Mark Rutland wrote: > >>> On Fri, Mar 08, 2024 at 09:08:59AM -0800, Christoph Lameter (Ampere) wrote: > >>>> On Fri, 8 Mar 2024, Marek Szyprowski wrote: > >>>>>>> It looks that cpufreq-dt and/or opp drivers needs some adjustments > >>>>>>> related with this change. > >>>>>> That's strange. Is this with defconfig? I wonder whether NR_CPUS being > >>>>>> larger caused the issue with this specific code. Otherwise > >>>>>> CPUMASK_OFFSTACK may not work that well on arm64. > >>>> cpumask handling must use the accessor functions provided in > >>>> include/linux/cpumask.h for declaring and accessing cpumasks. It is likely > >>>> related to the driver opencoding one of the accessors. > >>> I took a look at both the OPP code and the cpufreq-dt code and it looks like > >>> those are doign the right thing w.r.t. cpumask manipulation (i.e. they only use > >>> the cpumask accessors, and use the cpumask_var_*() functions to dynamically > >>> allocate/free cpumasks). Maybe I've missed something, but superficially those > >>> look right. > >>> > >>> Marek, can you try reverting this commit and trying defconfig + NR_CPUS=512? > >> Yes, with $subject reverted and CONFIG_NR_CPUS=512 everything works > >> fine, so it must be something else broken. > > Thanks for confirming. Would you mind testing the problematic commit > > with CONFIG_DEBUG_PER_CPU_MAPS enabled? If it doesn't show anything > > obvious that can be fixed quickly, I'll revert the commit and queue it > > again after -rc1 for 6.10 (I haven't sent 6.9 the pull request yet). > > I've enabled this option, but unfortunately it didn't reveal anything > more besides the warning and error I've posted in my initial report. I > will try to analyze this issue further, but I won't manage to do this today. No worries, thanks for giving this a try. -- Catalin