From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2FC3C54E60 for ; Mon, 11 Mar 2024 16:19:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 835526B00C3; Mon, 11 Mar 2024 12:19:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E4AD6B00C4; Mon, 11 Mar 2024 12:19:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 684CD6B00C5; Mon, 11 Mar 2024 12:19:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 505A76B00C3 for ; Mon, 11 Mar 2024 12:19:41 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1FFB4A0CC9 for ; Mon, 11 Mar 2024 16:19:41 +0000 (UTC) X-FDA: 81885268962.21.391AACC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 26A3D18000D for ; Mon, 11 Mar 2024 16:19:37 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ikhxUY0u; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710173978; a=rsa-sha256; cv=none; b=mxEm0KmoTnFDWzTmR96zqU+NxIsvd6J2eMkCbkummvy5JGldtxBTUSDsBO5eFToj+1vorp MPJt2eh2VjMzyOsV2u5UB+kKLaYR30oNC8WIH0tEglBvWR7FYNOutxMuGPcQ8s5RvT89OK Kk5rOXIz1qqqOayxZGjH3BjHUtgRBWw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ikhxUY0u; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710173978; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/oBCVAyg5PJ6txcGy/OlzYHp1Y1HFBlEoxbDyUxUl1s=; b=aBtX/SYYwm6P1504+h4m1bNrovDaDNYqnFrDMUyRmqm9BE+lMUfyWUARwzfYV2wblonqB2 xF9PXxkVeFJhkuRYFbfA2zDgIoP5/v0NR/d3I9L5lUqTyntqQGr7hHU+/ZXFh3+w0NfLaw xkig8DmqVnsbwW4EVcwhP/wmZbfkfJs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710173977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/oBCVAyg5PJ6txcGy/OlzYHp1Y1HFBlEoxbDyUxUl1s=; b=ikhxUY0uZDlPKWUW3pvQtTGvO/IdCD3iaeGPMOZ7asgnqNAqHhbYm7vygQ2GqzVWe7Vzqt YdhOJVT0o9nxteo73sSSJa8S70UxlDZBq4mM/HNBHM/mzFdLzxSjgTIdQ9sV2krfZGZAz9 4YMYDTzx8Fry153uJjfW5RvFHfb7YBA= Received: from mail-oa1-f72.google.com (mail-oa1-f72.google.com [209.85.160.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-691-S2rdMo7nOMaDdbcYuAlnxg-1; Mon, 11 Mar 2024 12:19:35 -0400 X-MC-Unique: S2rdMo7nOMaDdbcYuAlnxg-1 Received: by mail-oa1-f72.google.com with SMTP id 586e51a60fabf-221d6a92312so939512fac.1 for ; Mon, 11 Mar 2024 09:19:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710173975; x=1710778775; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/oBCVAyg5PJ6txcGy/OlzYHp1Y1HFBlEoxbDyUxUl1s=; b=ngkn9N46fNcvsWA2+d4i4jafoMU3zFO4ZSsuWiqUnDJ5VRvepTUVQ598bwM0aLdK4Y nzBDCTM/RkG9Mt+UiJdTMt5p40J07pP5WXUw7+wrHMnhQdJ8R1lqk4c0d3ahc79gUdNT KDjEN43mPJBTKztyM5kzp+0wNl2O8YzetZwYydW26GpgFCthvaxR5OTt0NNa7ZBnMQ9P 6697Ay2eJbQZvDiTwENqBrbMbzNr2JfUeyblTsk/MvkN85NG7SZ7Q16A7fxtCugdp5yj TmN0vyq97VyotuC/PjVjBx5JR+mjmZEh6PvcbHE32EKbi33EeGFcAV8WWqxCzeT4WKrA ALOQ== X-Forwarded-Encrypted: i=1; AJvYcCXQNYtrfh+AQ6Gf6EmHu36g7b3MOKQoN4/cBg5IlIbTIZMkp0Uy5pjupEJmbZZn6b/dqoFI+hDmy3+wXy21hrnuxkU= X-Gm-Message-State: AOJu0Yy996o12nX7LcW+x02AmHo2o6xi/nF6PrDTiWgrKYXgC61DX2K+ X27nCnVAiS5Y1KN7Xrh/LmmefV/VolKqwFwcKqLiYUjmR0JqjRs61BBmS+AoR0+Tx7qi6GUmYwn jqnwg2cIR+kRSOXnkgry55sJp4Uz0oAn/MaPPQzw1LBnhZj4T X-Received: by 2002:a05:6870:2185:b0:221:c9e7:7220 with SMTP id l5-20020a056870218500b00221c9e77220mr6362387oae.3.1710173975209; Mon, 11 Mar 2024 09:19:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF9rh3+Tgb3foOECTEe64qt+J/5fCOyDC/WMYulhyWAQOCTiohXg4S1OQ/42kgI4Ls7qjm3QA== X-Received: by 2002:a05:6870:2185:b0:221:c9e7:7220 with SMTP id l5-20020a056870218500b00221c9e77220mr6362373oae.3.1710173974880; Mon, 11 Mar 2024 09:19:34 -0700 (PDT) Received: from x1n (cpe688f2e2cb7c3-cm688f2e2cb7c0.cpe.net.cable.rogers.com. [99.254.121.117]) by smtp.gmail.com with ESMTPSA id g13-20020a05620a13cd00b0078825a5ac3asm2819476qkl.45.2024.03.11.09.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 09:19:34 -0700 (PDT) Date: Mon, 11 Mar 2024 12:19:32 -0400 From: Peter Xu To: kernel test robot Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Andrew Morton , Jason Gunthorpe , "Mike Rapoport (IBM)" Subject: Re: [linux-next:master 12265/12944] arch/arm64/include/asm/pgtable.h:904:16: error: implicit declaration of function 'pud_leaf'; did you mean 'pmd_leaf'? Message-ID: References: <202403101607.a42gaLOS-lkp@intel.com> MIME-Version: 1.0 In-Reply-To: <202403101607.a42gaLOS-lkp@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 26A3D18000D X-Stat-Signature: ja16inch8sfocxoqworfj9f4ddrzm7x1 X-HE-Tag: 1710173977-491023 X-HE-Meta: U2FsdGVkX1+WZO+j3dA7KuKR45ibo/CrazPocVqDp5iotGN0B7O2G8UjUDZ6Tdwx8EXTm5c+97AjTnzO533OqTBgTpUbLg5ZRYue9gZRUzHDjgOJKdaDOU0HuFv4tu1DuRQhEWxEWuDvmsjMjZ+auV9+M7jjbjNZjmjkkOS1inJOq7gsADrJrVvC7R5o9N3pWCCgroOZHSTKtcwDl4YMJCS2r85fXmGWU4z5Orieh3sYHdvaOZ/JGwd8I2JlsYm/jLuPbriGPdlUFL6ccX2aNxHTYiP+322pu3j5qjsVejrblbsuChtbbfLLNRcqT1+xaPBsX+s62eRtisFe187qJGgJn00OiCgxOPNIX7LQlkk5JbdNyX//BoLTLsyosMG4+zIzCv24I+hr+MvVqw2j73K6RtrvUpLm2p/S6WeU5Oi28IO7/zoi3BRxPbzUF6gRVqA2DgVdKLZ+pVp77exH7+jTBDFvOYCsJSRNDQ6mgqjtuJvUkAfb39q4ZVkduGoZVuR2j6Gr2EbGZA21WtbTfqer0WLKgCHb6mvpHFYAL8VG6KNjkCdDh6xyo6bBeLEE2/3BRbMecfoaO2dfASt3cbnRF2XC0dbSc7fwC7zXnl8fkKTxM9Nupi+PYx4EHJcm+vvgBxRBO5xR7we/Z6crOE3ImGNwyB3LZRkQ+/V8aciQxm4axFarGRV0EAMKywtYj7gUnYBkkFsaDX72XI+xK8mdAn/FL6SdKzPVW2LSjOu31MHfxv0B9evOrdW/lKKNd4oUq4iDXK6KBmJLJCikskAmP+J1uSzf9fu4LqQCS+C6xukrm//sovWnuY3IaDxMFkhVOiaHya0PWfQsQalay3/GhvlATJRPBcPBjcsItCDsvR1m0hI17T45+DuJy1CZipns0mJ85tIFWfv0UdRej2f1SM9sNW85nE1uO//brECm4TPaiv6fXV7wuMnWVwXrsxSiai1XStxT3iwIDyc daRsaRdJ 5VujGSHipy1pIaPGc6o5UPevyF1NSlT/j1T7N9pe/zJZC5TwGaH/5EWoILS+ygnr+2ujYn1PgqsZNDrJLsPsJyhYjKMAmYQO52mUo45D18hpZXYbwBFLjDSvRSQrUvqSPi8II4Mk3v5YqwRyxZiau0fwNlAXdbaJ5g10uzWbaFsZfzoStjSrux/rogwIhMgN1UnBbDisb/exRa14fwOp88ZIXrUAd2i2kiZD/t+0aOFcqHeGUD/CW8Gz+gvEo+voSOrcbQfyZXgU1ufwsa54Er69mstqlaGK2vFaJHfZWgNxLxg84+U2pNwpQy+Bejl5gSjufuEpuPN/3OV45vFvZC96+UP0dawHUfx1wTOyqjn9fXBDNtGz+uq0kLyusNqoSho1tyLx3hphFC2X8z5l+ZNf5oJVFjdjK6cbEi51hyhrfuAA5hYKAQY7WyZFkeXwTdEF9homLsv1P0qAkB6rwmLh8vPFFJsod0+aYKeKfKMYIqTgZFM5oqb3oi/o+uFK7JdKrtWTJ3kMHigpVLLMJJ+1l2OncEVk3K0xWDkHpu6vZw+SW6PJPcgGOFwgN9KGTCX768yg17u6iKpcmDVwCPp+lDKpyo1eXbYsGpwnhjpTnu5GuMVZj4hFT4av9ugwPlpI3GidS/xsK7d9GUwu0LOkg/RO8/4qhbLwO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Mar 10, 2024 at 04:10:37PM +0800, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 8ffc8b1bbd505e27e2c8439d326b6059c906c9dd > commit: 924bd6a8c96767a05323d575bdefd664631dce73 [12265/12944] mm/x86: drop two unnecessary pud_leaf() definitions > config: arm64-randconfig-r031-20230409 (https://download.01.org/0day-ci/archive/20240310/202403101607.a42gaLOS-lkp@intel.com/config) > compiler: aarch64-linux-gcc (GCC) 13.2.0 > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240310/202403101607.a42gaLOS-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202403101607.a42gaLOS-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > In file included from include/linux/pgtable.h:6, > from arch/arm64/include/asm/io.h:12, > from include/linux/io.h:13, > from include/acpi/acpi_io.h:5, > from include/linux/acpi.h:39, > from include/acpi/apei.h:9, > from include/acpi/ghes.h:5, > from include/linux/arm_sdei.h:8, > from arch/arm64/kernel/asm-offsets.c:10: > arch/arm64/include/asm/pgtable.h: In function 'pud_user_accessible_page': > >> arch/arm64/include/asm/pgtable.h:904:16: error: implicit declaration of function 'pud_leaf'; did you mean 'pmd_leaf'? [-Werror=implicit-function-declaration] > 904 | return pud_leaf(pud) && (pud_user(pud) || pud_user_exec(pud)); > | ^~~~~~~~ > | pmd_leaf > cc1: some warnings being treated as errors > make[3]: *** [scripts/Makefile.build:116: arch/arm64/kernel/asm-offsets.s] Error 1 > make[3]: Target 'prepare' not remade because of errors. > make[2]: *** [Makefile:1199: prepare0] Error 2 > make[2]: Target 'prepare' not remade because of errors. > make[1]: *** [Makefile:240: __sub-make] Error 2 > make[1]: Target 'prepare' not remade because of errors. > make: *** [Makefile:240: __sub-make] Error 2 > make: Target 'prepare' not remade because of errors. > > > vim +904 arch/arm64/include/asm/pgtable.h > > ed928a3402d8a2 Tong Tiangen 2022-05-17 901 > ed928a3402d8a2 Tong Tiangen 2022-05-17 902 static inline bool pud_user_accessible_page(pud_t pud) > ed928a3402d8a2 Tong Tiangen 2022-05-17 903 { > 730a11f982e61a Liu Shixin 2022-11-22 @904 return pud_leaf(pud) && (pud_user(pud) || pud_user_exec(pud)); > ed928a3402d8a2 Tong Tiangen 2022-05-17 905 } > ed928a3402d8a2 Tong Tiangen 2022-05-17 906 #endif > ed928a3402d8a2 Tong Tiangen 2022-05-17 907 > > :::::: The code at line 904 was first introduced by commit > :::::: 730a11f982e61aaef758ab552dfb7c30de79e99b arm64/mm: add pud_user_exec() check in pud_user_accessible_page() > > :::::: TO: Liu Shixin > :::::: CC: Will Deacon > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki > There's another possibly relevant report for riscv: https://lore.kernel.org/r/202403090900.OwPqmRuI-lkp@intel.com I think I messed up the nopmd use case. Since this commit already landed mm-stable, I assume there's no way I provide a fixup. I attached a formal patch below, but I don't know how to test it myself, and I'm not 100% confident. Before I post a formal patch, can anyone let me know how I can kickoff the test bot to test the patch (or help me do the kickoff)? Thanks, ======8<======= >From acc5598c7af0b7c9a486a49b8c562bb351e8d35b Mon Sep 17 00:00:00 2001 From: Peter Xu Date: Mon, 11 Mar 2024 12:10:45 -0400 Subject: [PATCH] mm: Recover pud_leaf() definitions in nopmd case This reverts one change in commit 924bd6a8c96767a05323d575bdefd664631dce73. One issue with that is it broke nopmd builds for at least both arm64 and riscv (CONFIG_PGTABLE_LEVELS=2). The other issue is it was overlooked that it's a common change rather than x86 specific (relevant to the commit message of the commit). Normally there's no need for empty definition of pXd_leaf() because of the fallback functions, however this logic may not apply to pgtable-nopmd.h, because that's a header that can even be used by arch *pgtable.h headers, which can use the *_leaf() definitions _before_ the fallback functions are defined. Leave it there to pass PGTABLE_LEVELS=2 builds. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202403090900.OwPqmRuI-lkp@intel.com/ Closes: https://lore.kernel.org/oe-kbuild-all/202403101607.a42gaLOS-lkp@intel.com/ Fixes: 924bd6a8c967 ("mm/x86: drop two unnecessary pud_leaf() definitions") Signed-off-by: Peter Xu --- include/asm-generic/pgtable-nopmd.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/asm-generic/pgtable-nopmd.h b/include/asm-generic/pgtable-nopmd.h index fa27e16bbe1b..8ffd64e7a24c 100644 --- a/include/asm-generic/pgtable-nopmd.h +++ b/include/asm-generic/pgtable-nopmd.h @@ -31,6 +31,7 @@ static inline int pud_none(pud_t pud) { return 0; } static inline int pud_bad(pud_t pud) { return 0; } static inline int pud_present(pud_t pud) { return 1; } static inline int pud_user(pud_t pud) { return 0; } +static inline int pud_leaf(pud_t pud) { return 0; } static inline void pud_clear(pud_t *pud) { } #define pmd_ERROR(pmd) (pud_ERROR((pmd).pud)) -- 2.44.0