From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D42BEC54798 for ; Thu, 29 Feb 2024 19:37:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EBB2C6B009D; Thu, 29 Feb 2024 14:37:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E6B536B009E; Thu, 29 Feb 2024 14:37:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D33796B009F; Thu, 29 Feb 2024 14:37:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C0AD66B009D for ; Thu, 29 Feb 2024 14:37:22 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9C3681A03FC for ; Thu, 29 Feb 2024 19:37:22 +0000 (UTC) X-FDA: 81845850324.29.D6468C3 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 54A0E2000F for ; Thu, 29 Feb 2024 19:37:19 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LfHiOuS3; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709235440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8uNmGuKJqG0ZLwvelugqTwty9eAp95ps/IXd1VUbjRE=; b=mwNURjr12QNyfOOnsHbNfplIn/WdziMAuX6lPZNra7kSzfsPSM1yrXODuawCpCSBpL9kbo uF1CDNGoTfwAQA2vpWJYu6joazkqF4G7ieP7NNz7Zqde2TAX3f49xpYCwPLRMZlhZutElv 14AcGAREiSmyiZo0TiuaLH2l8/NBms8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LfHiOuS3; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709235440; a=rsa-sha256; cv=none; b=v0rGskIPpqcIqSHfGz0wJl5/tCxxzhVLA25adaQD0sdUcDGjbKCfaowkg8289TgiDBoltL 9tbppaYEWhwCV67UOFFcZcVYOdplcTGOzw+Ytq6ISYDU5qY33p5Pp3uLGCrrCegUPoy3LB 1e17duCHFhiBhAVnwZTpL5SSpaQKLFM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8uNmGuKJqG0ZLwvelugqTwty9eAp95ps/IXd1VUbjRE=; b=LfHiOuS377ugSXr21HSPLjoGds rRHRotHB6Z2K+UknnXnK+QSxqb+aTii8MgmSzXW1sRNBptAvRcgkCTNz6J+ZbnsCs2gOL69/7CQwh HbpeH4t5yDhGvqmnlTjCTBFsDyp9akGVrkIGj6y3BedRK3Vygt5msrjSPEYVN6VtIWpZchOzssQ/V WR1aOx0+dyY/SjdSpU3JUwI4U2i/3gjC67frvRbY1ZlyHhnna281LjFJ9s/SzckoOzX+rHWRnRD4q DbfpzdwBNaELy6OKw8HL8OqWb7AQNPVnsIkMg3yiwsLXR6E9Xx/G6dwkxCxOWFcKJ/oDRVozID8PI 7uk/dp4Q==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfmDP-00000008qqb-3bC7; Thu, 29 Feb 2024 19:37:11 +0000 Date: Thu, 29 Feb 2024 19:37:11 +0000 From: Matthew Wilcox To: Greg Edwards Cc: Jens Axboe , Andrew Morton , "Kirill A . Shutemov" , Hugh Dickins , linux-mm@kvack.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, qemu-devel@nongnu.org Subject: Re: [PATCH] block: Remove special-casing of compound pages Message-ID: References: <20230814144100.596749-1-willy@infradead.org> <170198306635.1954272.10907610290128291539.b4-ty@kernel.dk> <20240229182513.GA17355@bobdog.home.arpa> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240229182513.GA17355@bobdog.home.arpa> X-Rspamd-Queue-Id: 54A0E2000F X-Rspam-User: X-Stat-Signature: z79hu7zeodi1icnkdppurxhif6qiyh1h X-Rspamd-Server: rspam01 X-HE-Tag: 1709235439-286505 X-HE-Meta: U2FsdGVkX18l7RmPyk15RIl2PAIWsg/PoaUy7IMVTlwsyWkRccN+EsE2ZQz0pkhaEx32BM/l5MWiD0yrqfIwkhRhWIGk1g441t+H7fR/+jn1x757ES7tpW3Tp4RE8JRKw8juYCfdwp1HiwIF2ySQjK78Q9M+wyFUwmaFP9QsuQDb/q5LNApPrPBLvzbiHViNKicqkvL1cNSIMT6bRheC3IR+hBzJAGE2WJFAu5j18zrAyaWWMMZqi1CaWAxZUxUE+fLqbG27zeSGFB6vjyLAIFYjm9vJNDtFJzhd73OBRy6hfKcr72dxrf1fd9UsMO69zhH8AJs/TpeuDIeoyf4Etfhu4fSrjuah5UalLxTs44fJu26AJQ5QDpsdgKFCQn47O6P1PquPwWHp47mStfRewZBVkkOro3OBuB/WslKx+K0d9DX5TVp+Nyru59xHH7g2Aii3MVJQBU9wdKNuEGx5tZCtjGIJFVv3O8I1uA0U3vQcblGFSHz7SESjeUC2o/K3XUgdgHNssmN6ypGTPmU1IqULcnr0svjJWB197bJVHS7mMP2IcElkteaPlzfGYAx5/9naiKQx6IJtMlPC+7RpyInSyRzbHdj61ZN/WDB6w+C1YbGBdy8pKsC2PHvlMELEic4keirTOQABlwi3wjvnSIWoAlVR3WeMV/syivuM7DRTIsfEZV6qVxrYcXdsar241kxVQD0VhwldnTazy5yK+dXQeKF63xOXOYuadrD7mOp3aVT3ZTnpoJOiCc/Il/EY1DKmsE9JvTvm0KqMy8gaOZ1aAuyZ3h9Fb2qg7jQybqXRxdwg5y/4cVhEoDkKNFirfO3vMgGOJ0fDeDfvGg/QrQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 29, 2024 at 11:25:13AM -0700, Greg Edwards wrote: > > [1/1] block: Remove special-casing of compound pages > > commit: 1b151e2435fc3a9b10c8946c6aebe9f3e1938c55 > > This commit results in a change of behavior for QEMU VMs backed by hugepages > that open their VM disk image file with O_DIRECT (QEMU cache=none or > cache.direct=on options). When the VM shuts down and the QEMU process exits, > one or two hugepages may fail to free correctly. It appears to be a race, as > it doesn't happen every time. Hi Greg, By sheer coincidence the very next email after this one was: https://lore.kernel.org/linux-mm/86e592a9-98d4-4cff-a646-0c0084328356@cybernetics.com/T/#u Can you try Tony's patch and see if it fixes your problem? I haven't even begun to analyse either your email or his patch, but there's a strong likelihood that they're the same thing.