From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52FAAC48BF6 for ; Fri, 1 Mar 2024 00:30:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A3C16B00AD; Thu, 29 Feb 2024 19:30:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 72D036B00AE; Thu, 29 Feb 2024 19:30:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5CDC96B00B0; Thu, 29 Feb 2024 19:30:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 45FF86B00AD for ; Thu, 29 Feb 2024 19:30:58 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E0774160139 for ; Fri, 1 Mar 2024 00:30:57 +0000 (UTC) X-FDA: 81846590154.19.A63E82B Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf06.hostedemail.com (Postfix) with ESMTP id 0DF1018001C for ; Fri, 1 Mar 2024 00:30:55 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=chrisdown.name header.s=google header.b=tEoOZjgY; dmarc=pass (policy=quarantine) header.from=chrisdown.name; spf=pass (imf06.hostedemail.com: domain of chris@chrisdown.name designates 209.85.221.50 as permitted sender) smtp.mailfrom=chris@chrisdown.name ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709253056; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/6TCxBl7DrW+C2Xnhe2LFnZv9gvBSqtviEifvQbUuYg=; b=4qgVREw9sHmOZZB4lyN/6zDWRr44uVns4I5pOE/rfE/dII1xAv2Gn5pYfwC3cl8EMaIhcy x8H1khNgh+9ex2uDGXzHF6zEoM2J6Hirdkh5ZLKxKmstALzI4j4cCWZUJt/a1Jbg1Hs5Eb uu2WC1091nlmrj3Ex214Axny/El3BVo= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=chrisdown.name header.s=google header.b=tEoOZjgY; dmarc=pass (policy=quarantine) header.from=chrisdown.name; spf=pass (imf06.hostedemail.com: domain of chris@chrisdown.name designates 209.85.221.50 as permitted sender) smtp.mailfrom=chris@chrisdown.name ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709253056; a=rsa-sha256; cv=none; b=j+v5Y3nwrVdnW49l7az7jJOBQk5jOXsFB6/HJJ/mBvWk+Wp+7Cj7kqBG2s/+vlQq5QfwMs 4bBkY4bozRQnw0iOlf30/trHVLbou0HUL9hXkczsTtrQZy8mBYacdadJ6/upXviarIT2DF 3Xf+z0KBEUfZMCpQ3CFkAeHeWp+yB0E= Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-33de6da5565so832856f8f.2 for ; Thu, 29 Feb 2024 16:30:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; t=1709253054; x=1709857854; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/6TCxBl7DrW+C2Xnhe2LFnZv9gvBSqtviEifvQbUuYg=; b=tEoOZjgYCY6Ob0bmc3KOKn72dZNRGGwyW9kq10FK4OKkBCiO2ZfOq/sJwpK8j161AN 0TkZXjUqF9dSZZPwEoznmUc5OSZKivGxqMpWyH39y8pEpp5fuGHgq19XkIxy/c10tKKn kdYhlaVSBb1ye6aE6WKDgTw4kqdKA8MfJUops= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709253054; x=1709857854; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/6TCxBl7DrW+C2Xnhe2LFnZv9gvBSqtviEifvQbUuYg=; b=UPH8yQl0Duv1ONnGuHWOHq+bzawASRi3B/01IavT6KD1/DP7r0LSKsWZDxeGGcyD6z 1LWRI42nTNyrCtzInrn1DHRxPULbYNlJplJpc0/ZVrZqh/QC3hrVhX8w64g5swjLtqUk YxZGGHNkwsVnPjPsKrF2IialLsIZMTwvEpbRBZhtdIbvn2uXLKrGncCwCw6YDw1OmrqQ aQi95iNZAAunAf9rqV05IsAdr5yzehs7/8dfHUJiQVastVFCNmJdx6bJbNaPbvEyLuWm e4EHQLuT5mb9/mn8LoCgTkUJX/T8u0b+kdNr4L/cvG4PB2D6gSccympQt1Q13zXrEODz BgTQ== X-Forwarded-Encrypted: i=1; AJvYcCXFGAo064UJQe96RGox0cIbhNEnojBtYL2rFWcTkukDernWumn37iSbO4GxYAh3bVMPJCBU5Jh8YYtsPKSA4txo+rk= X-Gm-Message-State: AOJu0YwcJb2AcGchPze5ys4eTWDhc27bk3zu+wQPzNmNyJ7dLb1iuMm/ x7ETt5+zeqJGkEjzNRFjlZk+IHR+b/XaH73UzDc4MQT4hlwl9rSrEJ4mkH1zl5E= X-Google-Smtp-Source: AGHT+IEv1uPho1CWNYAKQSRLMXcGe87GuCLOXmnROkVz7nCRqDB0yheMv+Ev9X+OmGA3atwHmJZhPA== X-Received: by 2002:a5d:6a08:0:b0:33e:fd3:8f4c with SMTP id m8-20020a5d6a08000000b0033e0fd38f4cmr101442wru.1.1709253054310; Thu, 29 Feb 2024 16:30:54 -0800 (PST) Received: from localhost ([93.115.193.42]) by smtp.gmail.com with ESMTPSA id n3-20020a5d4203000000b0033e12a67fb3sm2331728wrq.50.2024.02.29.16.30.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 16:30:53 -0800 (PST) Date: Fri, 1 Mar 2024 00:30:53 +0000 From: Chris Down To: Axel Rasmussen Cc: cgroups@vger.kernel.org, hannes@cmpxchg.org, kernel-team@fb.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, yuzhao@google.com Subject: Re: MGLRU premature memcg OOM on slow writes Message-ID: References: <20240229235134.2447718-1-axelrasmussen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20240229235134.2447718-1-axelrasmussen@google.com> User-Agent: Mutt/2.2.12 (2023-09-09) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0DF1018001C X-Stat-Signature: dd57ia311w8skjy1qb764xeua5yc8uqk X-Rspam-User: X-HE-Tag: 1709253055-88888 X-HE-Meta: U2FsdGVkX18VNVlm0fWKZd99ymj5wZF3ML0zGZXWYtoZmOOdGUw7GCmP/MJBOXf2xltD19d+qDUGwZjTOqyObLUhZoBWyb0UF6ExpXrDx3pj+azwixddJZjCvzGTxQvcKRw3ijc/Shy6HRq2kZMad1qeCxdVBHArKqkGv9FM82zIc5gGDsxTEroxFS1M+C+/hLwXMjI+KeJ3FQ50WseNSnuXgh4j62sLyTnxON79ibPNb1Wv7ce0BmpxYwo4vtZ82Ntu+3mvOzB/hjZI2RvRdsssxLCMAqvJXfxsEYSr0kxXg9uXI0sSI6aPdXdLBsx7M+KglAlHnGRUldXilg2y9ccQkxNtCEhOLdfpEEsCp/Ts/G7WrDwuY9tdyQ+RFTcD1Yu1OvzYbXFxdoXCh3cz/iyVua2E/kNZ4kxy8R5JH6VPvWEo7ZbcdllaeMKg4PclvQhRxw/Yo2AYgxvgxu4I2hX5kNbxIMopolzmcmu4eIEfFn0mLUn6kMg1kKuowiEYnoAsvIbMT0acG1ALZDY2PQBSAtqTyvBD8y+ivmRlN9pgz/jhjpSpPFrwPvyDqzpK2dT23++ZXANvltzXTp+1evXye8A4v7/jtfr+aA/SLdelAdOhws1R0sHn/dBIsijrbJXTSLS7qEsmyjeZTlHbJH0fcwYkEKnzW+yqOt2dKwDINazOCZfQx4/Nb7a+Ja47LPlQ2vldMFIuNEOEJYFLcK3p+ltDFWto7Zf/rNJs8Hoe+8XjQOReZ3Vw40+6HROtH2y3hhxLd1EVI/vtH6U0OYxPc4KcTGIcxPI2GUcluVM8CPWFM5N+RlzUtzNR4FeA19KGImrQq5E7oa9OzNbtpJpHdJS9Mb6LJNxpvEhNGqI8vlAoAQlpTLnxjK3hFAjGsxJ/UL+yGzoLuK/K4Mkd0EEnc2efHtwACavl2tS8Ul+KYXbs98w0mllcq2w2i7nldSOsQltEY2y0bvpn5Jl bOLpuHE9 mYCribFO9hDj4VHM/wPItnQtSibAbx13/OJv/PbJl7CMz0AAWg/P0ucdtjA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.130265, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Axel Rasmussen writes: >A couple of dumb questions. In your test, do you have any of the following >configured / enabled? > >/proc/sys/vm/laptop_mode >memory.low >memory.min None of these are enabled. The issue is trivially reproducible by writing to any slow device with memory.max enabled, but from the code it looks like MGLRU is also susceptible to this on global reclaim (although it's less likely due to page diversity). >Besides that, it looks like the place non-MGLRU reclaim wakes up the >flushers is in shrink_inactive_list() (which calls wakeup_flusher_threads()). >Since MGLRU calls shrink_folio_list() directly (from evict_folios()), I agree it >looks like it simply will not do this. > >Yosry pointed out [1], where MGLRU used to call this but stopped doing that. It >makes sense to me at least that doing writeback every time we age is too >aggressive, but doing it in evict_folios() makes some sense to me, basically to >copy the behavior the non-MGLRU path (shrink_inactive_list()) has. Thanks! We may also need reclaim_throttle(), depending on how you implement it. Current non-MGLRU behaviour on slow storage is also highly suspect in terms of (lack of) throttling after moving away from VMSCAN_THROTTLE_WRITEBACK, but one thing at a time :-)