From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D1B8C5475B for ; Wed, 6 Mar 2024 06:28:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C674E6B0081; Wed, 6 Mar 2024 01:28:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C17766B0082; Wed, 6 Mar 2024 01:28:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADEF86B0083; Wed, 6 Mar 2024 01:28:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9F40F6B0081 for ; Wed, 6 Mar 2024 01:28:14 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7BE0040453 for ; Wed, 6 Mar 2024 06:28:14 +0000 (UTC) X-FDA: 81865634508.09.A208709 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf04.hostedemail.com (Postfix) with ESMTP id D687E4001E for ; Wed, 6 Mar 2024 06:28:12 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oKNIDLuN; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709706492; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hwa0/quFCR8D6kev5xZSuxkWp48HectjvQcd9pPZ5kg=; b=J+9fUlxSuF+eWvbFQ6TRSUAVGrhnnRdfmFVghp6jv+GRIZOihcE4GqlBBB4HIH695VS0P7 0+9gKyeKgG0iAMBIRmeT5c/Usg2fzdUBiKHlkw9FdEvexDG8WbQd8lDh8R3UazN1TEReip A1AKcyUoSqKN8VVZNeeB8UQpIE4Q1yU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=oKNIDLuN; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf04.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709706492; a=rsa-sha256; cv=none; b=Z+7LWBshdjKzYHMsoLb3+niDriyNDaeB4aUYhGQBlBYBG3iAQUktwkz2BpPlvFUOCwgeII H0DriDnOZA1/sw5CLrY2Z+qqipEDbjSpyKdcZpTT7T1ax5aKC6BN72pTAhlbpU78iAlA7O UW9QeKwxKTSUOJq2H6EWfc5O8FoyFus= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D4A94618CB; Wed, 6 Mar 2024 06:28:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B91E1C433F1; Wed, 6 Mar 2024 06:28:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709706491; bh=V1Mfq7Y3AfGZ+fTn0cuNK5g8OD2Cj2Hf0foPZDXtLP8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oKNIDLuN1zcY9zNB8rL62xeb/R+s5Gzot2AtdqSnRtFkZGmCVsAO4jRtML4UfdAEe pUqr2Rdg77iw5wNSF9UF+HiEAQCgZtNyoJfL9RIM1UoqbWFIuG/s3owFFls+0ptqtM /wCULQejCsKlUfHMnEPjWlMU8WNNPjZayaSuhoMrb3b3ZQ889cQsfe5w66uKXN7K0T dlirD+YfaP2xoM1QZxAVly75hKm/AZZ4AdXsGYColI/iqY4iIJuXNO5U97O3g/WYuZ QMJZKeR5k6quh8zJ5keTU8L/HDykc2GpgeWTm4muXBQke04hp0lO0s+4oQsB6O+5jy buAMbCC9wt+Ng== Date: Wed, 6 Mar 2024 08:27:17 +0200 From: Mike Rapoport To: peterx@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Christophe Leroy , x86@kernel.org, "Kirill A . Shutemov" , Jason Gunthorpe , Yang Shi , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Muchun Song , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen Subject: Re: [PATCH v3 05/10] mm/x86: Drop two unnecessary pud_leaf() definitions Message-ID: References: <20240305043750.93762-1-peterx@redhat.com> <20240305043750.93762-6-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240305043750.93762-6-peterx@redhat.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D687E4001E X-Stat-Signature: ehhbd6xzzwtf81nnsj5suwb6gn9ub4fa X-HE-Tag: 1709706492-562346 X-HE-Meta: U2FsdGVkX1+Gf2K+exqtU74HiLW1TbtkQd8MUS36ujBkK9QFAvgZ0tqmFEXndgf/kMU2Rern6ePOkOK6btJNgeWSUgsL2BbMCuLoUCslfPwcm9C2kF5AWaQXhsFFFyLVb1oejW9DIJsx6WndfheLMaF0ofEZKO+mFGN/J62TGfhECyqkyIu9Cxl5oiG/pWSzVFMi67Wm9j0pX3lYB5sO6+CtuP0MSiBLb9tjiyhdpubDnBEEodGc5BkDk5BPgx2faMEJe1THzhJEckpRd6iOkkWXQCqOU5WPGOXbshwoHZ9M/Lz0pv9z3IHCe9yWDM51k4xH/MJUtxvV2Gcki6GFV0zruTjkqOaNfDY/OEz9EH/txcrNCP5P9aO5kPGB77OAvMsvsw+lu8NOk65BlXbkI0gG5IoDyByg9ZSE/fpEgnaU2CNk8VUdPiuUNvTrWiMcPmIiADa8EoLZPLb7i6qDPt9LOxh9nXsvvFn9g4kKrvkX7JPo1nEzlOE3y+lXFosNAPzEpSrL4HzbxgTYiaj080zz5yCxlQINqsH4HtoLLn62/uFAwG5UgpgTAB3E88gFXujmKbthpNx1B3nvFMDsdqCgKhWQJqV2bRRVJIh/HbSRAVbZJcW8DEhmFpSt9VmeSvoQgVtieDhggu61gVFv52glMUaAEAbtLCXJx3qUjXuhB52mmzLxRzCTOfBEyxPOl0kVffuXqahidxaiHAfscT/e7cGRgT5LV6BvmaKc4p1T7vYE9UZ5nYMhilTjW0uH9ruBZnMwe1aPpsgQK2yBqQ9/FIPhPySMp6PvY3eLzKwnLLsdO5kU8YebtYX/DiHW2PbOdKJf2/stRQPfUIw1jKg8+3rAuwwfR3C89x+8aNB7xj5wd2KGlJ5/lOixm2K7V/fSrCwx3D1UKH4jXslgNp1I6xhhlZCDharUw0PmXgU8+JJ5f/YcJdcqnBhqgMZU9dJY5ALzDKjX4PHmUww mwQm5Lp5 GMbCE4w95JX8oTABIpEdFhZkxoBhjdWbHmVn0CZS7HYgqvFfVtI04XI4nZSTabSTvK4mYkymrF87IZg0Icu5f91TUftWRg1IEKtFZLwnZiDh8nDDKiuRrRxy9sLLSvUUHEzSNz3N58+ypU1oSOgrqyPaL4snxpLQya0d7bTketjQjZ65PeFlER1BORWRa5ZoTZK+xsTySuY7FoLIutwHshjDMJANh1yFsouGdEMunLkU2PM91rMt2l6OSwkd1jmxyGIliI/fOlYD64kTDgYyT9nAvvTvVRttNnf7dKDMQNYP/8M+6zgtwfWpAtGt5OAqmVFtYFR6XlyAosFlAAkPdObG/BUKInibleteFA2Th0lb81F2SrvUXfNCc+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 05, 2024 at 12:37:45PM +0800, peterx@redhat.com wrote: > From: Peter Xu > > pud_leaf() has a fallback macro defined in include/linux/pgtable.h already. > Drop the extra two for x86. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: Dave Hansen > Cc: x86@kernel.org > Reviewed-by: Jason Gunthorpe > Acked-by: Thomas Gleixner > Signed-off-by: Peter Xu Reviewed-by: Mike Rapoport (IBM) > --- > arch/x86/include/asm/pgtable.h | 1 - > include/asm-generic/pgtable-nopmd.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h > index d6e993a5659f..9db7a38a0e9f 100644 > --- a/arch/x86/include/asm/pgtable.h > +++ b/arch/x86/include/asm/pgtable.h > @@ -1097,7 +1097,6 @@ static inline int pud_bad(pud_t pud) > return (pud_flags(pud) & ~(_KERNPG_TABLE | _PAGE_USER)) != 0; > } > #else > -#define pud_leaf pud_large > static inline int pud_large(pud_t pud) > { > return 0; > diff --git a/include/asm-generic/pgtable-nopmd.h b/include/asm-generic/pgtable-nopmd.h > index 8ffd64e7a24c..fa27e16bbe1b 100644 > --- a/include/asm-generic/pgtable-nopmd.h > +++ b/include/asm-generic/pgtable-nopmd.h > @@ -31,7 +31,6 @@ static inline int pud_none(pud_t pud) { return 0; } > static inline int pud_bad(pud_t pud) { return 0; } > static inline int pud_present(pud_t pud) { return 1; } > static inline int pud_user(pud_t pud) { return 0; } > -static inline int pud_leaf(pud_t pud) { return 0; } > static inline void pud_clear(pud_t *pud) { } > #define pmd_ERROR(pmd) (pud_ERROR((pmd).pud)) > > -- > 2.44.0 > > -- Sincerely yours, Mike.