From: Matthew Wilcox <willy@infradead.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Jan Kara <jack@suse.cz>, Mikulas Patocka <mpatocka@redhat.com>,
Hugh Dickins <hughd@google.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] tmpfs: don't interrupt fallocate with EINTR
Date: Thu, 7 Mar 2024 14:59:43 +0000 [thread overview]
Message-ID: <ZenWX_WymceGgtrw@casper.infradead.org> (raw)
In-Reply-To: <20240307-kultur-ankam-39d311604493@brauner>
On Thu, Mar 07, 2024 at 11:45:59AM +0100, Christian Brauner wrote:
> Right now fallocate() is restartable. You could get EINTR and then
> retry. Changing this to fatal_signal_pending() would mean that this
> property is lost. The task will have to be wiped.
People made much the same argument when I removed the nfs 'intr'
mount option. It hasn't actually caused any issues that I've seen.
> If this is only done for the sake of the OOM killer then we can probably
> try and change it. But then we'd need to also reflect that on the
> manpage.
It's part of POSIX, I wouldn't remove the manpage. I think it's a QoI
issue; we should only check for fatal signals.
next prev parent reply other threads:[~2024-03-07 14:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ef5c3b-fcd0-db5c-8d4-eeae79e62267@redhat.com>
2024-03-05 8:42 ` [PATCH] tmpfs: don't interrupt fallocate with EINTR Christian Brauner
2024-03-05 9:34 ` Mikulas Patocka
2024-03-05 10:10 ` Christian Brauner
2024-03-05 14:03 ` Mikulas Patocka
2024-03-07 10:47 ` Christian Brauner
2024-03-06 17:49 ` Jan Kara
2024-03-07 10:45 ` Christian Brauner
2024-03-07 14:59 ` Matthew Wilcox [this message]
2024-05-15 22:10 Jan Kara
2024-05-15 23:09 ` Matthew Wilcox
2024-06-03 14:35 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZenWX_WymceGgtrw@casper.infradead.org \
--to=willy@infradead.org \
--cc=brauner@kernel.org \
--cc=hughd@google.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpatocka@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).