From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D055C54798 for ; Thu, 7 Mar 2024 14:59:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 919776B01A2; Thu, 7 Mar 2024 09:59:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C9636B01A1; Thu, 7 Mar 2024 09:59:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76A056B01A2; Thu, 7 Mar 2024 09:59:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5F08E6B019F for ; Thu, 7 Mar 2024 09:59:53 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 4337341194 for ; Thu, 7 Mar 2024 14:59:49 +0000 (UTC) X-FDA: 81870552498.14.C8D9082 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf13.hostedemail.com (Postfix) with ESMTP id 168C420026 for ; Thu, 7 Mar 2024 14:59:46 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YafQAxVY; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709823587; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wUJp+ma+FxPhkWdylQUE2obPA+/tXu3/YIlPPLbfesY=; b=KbvteUN6AuiUWau7x9kQFybCagMj3iAe6a3BcjSOjECFKc401rQ8q+ahBUTfpN8b+zDKCX Yz2kPR0CWAiinjoHIms5dloVAwClPmZQzrlVnG3PTBN2DVgYBv19evRTmy1V2nLNymUUQd pOiCZyTRNO0KrwSSJSG10pNCLKe80XM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=YafQAxVY; spf=none (imf13.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709823587; a=rsa-sha256; cv=none; b=UVVdfqpJxKzHDJyrNYcPVUuNlcGPHHxRVk+dZw97KEI53SudkWo70xH0qGM0M5JCIIdAUV lxNGUcP0JnA5TJ1VAdWNgSqDsUAw4OMwGyoM0eywCLZHM7T1YxC7XKWEuuXyhzuGCjSKvA La/jZQpesgro8CfDZVr8OL8QgMzBfVU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wUJp+ma+FxPhkWdylQUE2obPA+/tXu3/YIlPPLbfesY=; b=YafQAxVYfB0YV+X0BAxM2t542D jR4HX7yaCzYZaKgTNj9XZrPHOBvR7DEDim42VHob7JwoNgjRPi1ol2IfE49qFV5hs/25lQLGabAqg QY6Ee8ggWkcYyDTXC6ysQ2X2/9yMWIb7Oc+Ba1BLxE1WMCdJhhu5i7/5bYPTpArW0/qQ3Qy0vB5QT Dw/fWG11uhQ4wAXjkioLqXZfFEyLftQNDWW4MMBE/7qH7m83EqP3LC3OCsp1UpupUZZ5gklUIta7h CNBqAdBMKryCEQT3BgW3xcjdif1Xjm26WhctYfPtWIJIaBXbqzTRxj2e3Bvfi9ZVRKmC87hmTwLlr Xfk5jj9g==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1riFDj-00000009MsO-1zsy; Thu, 07 Mar 2024 14:59:43 +0000 Date: Thu, 7 Mar 2024 14:59:43 +0000 From: Matthew Wilcox To: Christian Brauner Cc: Jan Kara , Mikulas Patocka , Hugh Dickins , Alexander Viro , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] tmpfs: don't interrupt fallocate with EINTR Message-ID: References: <20240305-abgas-tierzucht-1c60219b7839@brauner> <20240306174911.ixwy2kto33cfjueq@quack3> <20240307-kultur-ankam-39d311604493@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240307-kultur-ankam-39d311604493@brauner> X-Rspamd-Queue-Id: 168C420026 X-Rspam-User: X-Stat-Signature: hmy1rbmuo85bce7ije9tbg3utizxsax3 X-Rspamd-Server: rspam01 X-HE-Tag: 1709823586-875747 X-HE-Meta: U2FsdGVkX1/Enk/5O40IrvhW/MMTTHfyoKmmJKxkLMLeKfLieLtO3hX+9/CUS+Yr/5mBYytJPD1kjdc5D+RPzKEVWyMjplyCqOhFgoFAsmsNWL4QbpkBTnq/eX47QmX2Zw7K+hrSxJY0Z1e+Kusoj/7sbhz6+nn4hHpUziD4DosCouZudDLGz4I8m/8h34bqslRreS3ruA/VAro+jWFjgqiOlu94QpvWAu4+jDnTlhuIpFEUsS0x5yilEhYxfaIcrdqtzWuoaBhLQjA9wxQGds/8iD8QFC/XrL1kd2ywLskUzMdxUjJ2CLkdGw46u/E0ySg5uOm1AZHsrVPA9TeyywSNxms6LLB1e3XvQw1AmNWGOjo3M5pXnMraokQoDU1Uc4YVTCVTwKqVgcQFog94lwGfldCn+ie7PMlLRfjtLvJxOQcJfJ663SpvIUP1i+qknsXXGK5HL/oTZVZzTg9yJF3/K+yPagNW/uW8PTtQeawOuhoTZe4zAWzcHfA4vKBcHCc60RdVnrWOLqA0YFUpr6MQNi095RxWpjdL5GKBHefY3HbqZNvAJJD7IRjTF/6QBkueOYYDxq9XbCiKU/1L1qJC04COSuFkexSPFT13d7NK+wtiUedN+c7KG0OO4rtY3a+e0CCxNTzdzLU2iM/xKLSyA3VTP5qw3LjFNtVYhddhrQ5DGYJWk82pqz7EBRvPlLLaXmsFhkMCY0IDqhG0xecsYtnOWVDaNlLYJauUtOmkZ3KIbSs+go5dtWSMPTpCxmpn3mTBfacfRg7vTW7Bdelw5gse4eBm6FDH+3UR/8shPJ3SqZXyvYpKJJX3pbvXR5Ro8MF0JXIp5UAd4qgMfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 07, 2024 at 11:45:59AM +0100, Christian Brauner wrote: > Right now fallocate() is restartable. You could get EINTR and then > retry. Changing this to fatal_signal_pending() would mean that this > property is lost. The task will have to be wiped. People made much the same argument when I removed the nfs 'intr' mount option. It hasn't actually caused any issues that I've seen. > If this is only done for the sake of the OOM killer then we can probably > try and change it. But then we'd need to also reflect that on the > manpage. It's part of POSIX, I wouldn't remove the manpage. I think it's a QoI issue; we should only check for fatal signals.