From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C93EC54798 for ; Thu, 7 Mar 2024 20:27:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D93176B02A1; Thu, 7 Mar 2024 15:27:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D435E6B02A2; Thu, 7 Mar 2024 15:27:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C0BBF6B02A3; Thu, 7 Mar 2024 15:27:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B041F6B02A1 for ; Thu, 7 Mar 2024 15:27:50 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 560871C0A66 for ; Thu, 7 Mar 2024 20:27:50 +0000 (UTC) X-FDA: 81871379100.03.6FFA063 Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by imf30.hostedemail.com (Postfix) with ESMTP id 373CD80012 for ; Thu, 7 Mar 2024 20:27:48 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CrzpnLrb; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 3QyPqZQoKCGgeUYXeGNSKJMUUMRK.IUSROTad-SSQbGIQ.UXM@flex--yosryahmed.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3QyPqZQoKCGgeUYXeGNSKJMUUMRK.IUSROTad-SSQbGIQ.UXM@flex--yosryahmed.bounces.google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709843268; a=rsa-sha256; cv=none; b=hwbyTKDLKTe1unJf6BfrFeH4CFHxvcy7V/Y4MGsZef8JMWbuaiG173zAwrSZ+EL9v9O8qq ZaizTRhpPv4tk7CI6gYtdfRAvGp8zhccBUCy9db0RgNNSdqp6UT/q7ttYcZkftPxgQ7Kgt yPFVkbDNVN/Z8mwhf6pqrE8qMn3Dcyw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=CrzpnLrb; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf30.hostedemail.com: domain of 3QyPqZQoKCGgeUYXeGNSKJMUUMRK.IUSROTad-SSQbGIQ.UXM@flex--yosryahmed.bounces.google.com designates 209.85.128.201 as permitted sender) smtp.mailfrom=3QyPqZQoKCGgeUYXeGNSKJMUUMRK.IUSROTad-SSQbGIQ.UXM@flex--yosryahmed.bounces.google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709843268; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=chSC2pZv+hcOkTZmm/t1zZxe+FTdRWOu1T96ZyxWt3E=; b=6rtXtETs4ohOkAYJcIhEfUfX6G3WVjuPHsU0hHOPx+6p6y3MrFOoCuOzL6n7Bqo5H3xWUa yprhjzHF5zZ0CrrjGhoY1isYH5+t0cHqPAde7Ky6rCeNrB4JdqxCeivH1Bf0OUJQz35Hef WeQplaiLMAETaiu+R8srKYUDBPvSWE4= Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-609d95434daso23508367b3.1 for ; Thu, 07 Mar 2024 12:27:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1709843268; x=1710448068; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=chSC2pZv+hcOkTZmm/t1zZxe+FTdRWOu1T96ZyxWt3E=; b=CrzpnLrb4C5BZZW6QfDwDJhZpLNc3TpKZ+Byq9nOSOcIbjGUeOnj/P3DywNp9cNNCX gg4xwJ6O/jftuV3gSqheoPONN3UJFHoE0cn5n9IGyXBQTVqg4k0vXTqDNYQzj59NF2B0 yJ/7s4Jfbe7JNIiwq8ytBGQEm83lI5oM39c1blsY5uJlR2Y9m4JYR8nW12bXZPpgiTwO CS4YE+IGWYRIusozdKftTHn/DLmLFNh1kqKK0LHFRE3YKgLCVMqazW3ikEmtJw6uyQ6C JKWOC8eMf+Wy71zTSgdrZAXIDceRanyp4glxWZT7vmJxcuI7qIXh9A2p1VeATXE+rZf1 XTkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709843268; x=1710448068; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=chSC2pZv+hcOkTZmm/t1zZxe+FTdRWOu1T96ZyxWt3E=; b=iADiEDwvJBRZRPq5FbLM00mjj1CqdKbv2F6u4SaIhSytE42AqPD3D5YC9spSHsTh9j 2NAV7whhBqmXoRFh6J9F3j6abc8+i2CzVzkbwFKrC+d2nx69i51vYXeART0aseNyK6at +jpH0gyy6KNRs/uWcOdKJxl0Ea6FQc2bDGXi1cwBzBlW8wknQLJ53pTL/F7/dDERQoYq gzPhx/tGiDl9/w+7IrryvEht9S2T3fnK00D3/nxfh2GBtyLmFryXRfyaL+ZKp+mtWzM8 /jZIDHJ/cjeQp/77AXXwhNfowgkJ5JmSRrKtONeoh/A5ojVHYMkVEnsQLgxpOLd9cgOw OfBw== X-Forwarded-Encrypted: i=1; AJvYcCWXppwFJvI4SsGnb3DiWpvYA28m88PdNyW996HHdeckZbyma3cOW68v1EfkmDKKbgucyzuZ7PbNWwlWMAIozwYKf0U= X-Gm-Message-State: AOJu0YwmWF7Y8q+1GAI3/LGF0N8YozmtfJTbjlrSeTSHa5yDVP/x/rh3 p/tUT6lBLZ/tpItC+GNZGygEOWcDpWUXpdWzwgXohFjgv1m0vCQL0b51Pax09MZULuKN+HmCGuY youww6a9Kixzhk0m4zQ== X-Google-Smtp-Source: AGHT+IFTT1OGsSLJa8Haf9ZMonPRGBBE0gN7hzSylYNaonZDzLqJHga59YTrDvVijT48cQtbb9tyXsm2dRp19qFP X-Received: from yosry.c.googlers.com ([fda3:e722:ac3:cc00:20:ed76:c0a8:29b4]) (user=yosryahmed job=sendgmr) by 2002:a05:690c:3702:b0:608:1b39:245c with SMTP id fv2-20020a05690c370200b006081b39245cmr5389081ywb.9.1709843267801; Thu, 07 Mar 2024 12:27:47 -0800 (PST) Date: Thu, 7 Mar 2024 20:27:45 +0000 In-Reply-To: Mime-Version: 1.0 References: <20240307133916.3782068-1-yosryahmed@google.com> <20240307133916.3782068-4-yosryahmed@google.com> Message-ID: Subject: Re: [RFC PATCH 3/3] x86/mm: cleanup prctl_enable_tagged_addr() nr_bits error checking From: Yosry Ahmed To: "Kirill A. Shutemov" Cc: Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , Peter Zijlstra , Andy Lutomirski , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 373CD80012 X-Stat-Signature: ka1umzzjwmxppoqfr89pfe53bw84cpqx X-HE-Tag: 1709843268-983630 X-HE-Meta: U2FsdGVkX1+1moAx+KeYDEWW10gqRVf4ZoyJlNgrd3TpnCHSPjv0m5mB+rHzYiHGE6MUwhyU9af5rmnZnI3F++GqHmtWs8R0PCPpLeX2BRvrHMUD8S/TMNqoDic5mMse86hMfT2k+yuE6gt0c0aB19Aw27YTpHLPzK2Sfz+JpBzynWMd3paUOG7Tfl5sR+K6/RAQBc0d8QWbP00xocBuhbIpMSzSwXe3/sE3Qr7lViPrsfqXxgbfj85iR5Lq1629eftedgRhjOW3CF+iXJ+WECttx/ntoM1pYCalOMYIcZc+duM48ehYl2pUqyjS+pwF7p+MsK6y4iwGzpSnRzUVwJO6njzFYVKORXfmdWLKkPlTuqUs2eyAJ7FL2N4anLbSywnsynPwghXYLIB5gm0XtgVAczMHLYXcofatX11dai18bwvB/0K/dYmaomCpcNY8KLCAe7frfv/nDF+qUYqrTNBARxw9ZVFyfrAougs50tcOAJrL2/neIfTdGkZqfdymu8Jb4sO+VvyYMPjIh9V0QBhwG5stKE1byjiv5okaXJ3nSaqQzVrSFYhVGVhuL27fjUd9Bi/v0LNPsaFt1ryTAK/mLnNk1pnAVjK27gDB1JPRHd0qEBqOUChbnE3oN8RMu5Eq/9h0M7Kx0t9ZCVMu7V2+3B9tEW8q2rlC+wHVP5QITvOzpxjAUVFNs11yHlRGyZKEwJxJB+GsWh+eLwqK69QWil0oKX9dODmBK6qsPnYvo5ZuXXdgJkuI+Mz2CSXhLslJ/Ka6cA/CM/oG4Pir0Y0UtixbYOGd8UTrgdD8U/dPUWYxa6/nUj2CCHt5p6ElooCG22/unekAiYOEagsgIeyBQ/kWqb8htbJFhvDRwkI5qjvFIdCsz0h1eCPGQU8ctynEQi0+/mUWn3Gc9NJT0Xb+ISgrANeBybFx/CAfPTdW92dJjz8LpAIb+SCHTm8tjaJEkxN1/YbrodP5SOX baBK4iht pXoOKGa6pPReeSUD6B5KONQxH+Kteb4lPIueSxYJV6mXXVDyYNb6ucWXbTDjPy4ka+uWgncZdXMfOxS3ec7xUvtCCXQr1Nur6wzhjJbHZmLiPsLDT70sPUyVJdRGtPeI4Jp4FHxCxtCjf9rS6wL4B1sIcLSB9Gj4iFaGOzTLzByKRfeO3WkRipCUp2NSb0VHxWrR6hFUnuCSWXoO9F6q/lxolXAJKmLPeYvWeRdiBAlR9Mw1SZPgXUgrsyWdVBwC/tWFyJNyMqkYFF2eXAfF4RT685gxC+QJV2WpwdNdS+cUufWDxVxva4g2cegmJlP3pp4EfJLdWsCrflnoKTck3PIHSlHXlcAx9b9SSA1ot2fe1afN9wlcJ00mUSpyVcmr0Sg6o3cBuqO0g360cYYLLb/90wJzJRAGS5wap22JwDTU3r6w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Mar 07, 2024 at 07:31:44PM +0200, Kirill A. Shutemov wrote: > On Thu, Mar 07, 2024 at 01:39:16PM +0000, Yosry Ahmed wrote: > > In prctl_enable_tagged_addr(), we check that nr_bits is in the correct > > range, but we do so in a twisted if/else block where the correct case is > > sandwiched between two error cases doing exactly the same thing. > > > > Simplify the if condition and pull the correct case outside with the > > rest of the success code path. > > I'm okay either way. > > I structured the code this way as I had separate patch that adds also > LAM_U48. But it is unlikely to get upstreamed. I see, thanks for the context. For now, I think this makes the code a little bit clearer.