From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57483C54E4A for ; Thu, 7 Mar 2024 21:17:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0BA16B02C1; Thu, 7 Mar 2024 16:17:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DBB636B02C2; Thu, 7 Mar 2024 16:17:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAA456B02C3; Thu, 7 Mar 2024 16:17:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B79516B02C1 for ; Thu, 7 Mar 2024 16:17:01 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 86AEF1A1083 for ; Thu, 7 Mar 2024 21:17:01 +0000 (UTC) X-FDA: 81871503042.05.2CB9299 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id CF526120006 for ; Thu, 7 Mar 2024 21:16:58 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=k7ifVcaL; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709846219; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YLrGgC0vWLDLvmPLYNlF6FQ/HNOeG7Dt9Zq/LKWCu00=; b=6471vB4/DENh5TesswM4goJ1FutdWvHuVAaaH9K48NqP46HEoqmkph77WRUe2+QYq/yw9S vMKPPv7jFCHl3nXZQsYkUYQLqEjBDR5AMPWEENeEfTpG4VyZDsYpTmWxwRDzuGtgtYVJuT cX+bwNDKIEMBsCaLLGRnv48OzhavfOY= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=k7ifVcaL; dmarc=none; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709846219; a=rsa-sha256; cv=none; b=gQlH0aM97RIpf01ZhWCzzORfYUD2JKSKRiGXXvy06CCjMPcD0tjj6A5q8mkW5mlJw7fB6Z 5ahItIJg4Jg5tqAenwQ4vBwESCe5Gjl8CjMFqToTVW1DzrUgy6FAHvFu356Kj4ke9OWBds 3EUHhE5DkULVRwcNrb/YBuTZmXydGB8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YLrGgC0vWLDLvmPLYNlF6FQ/HNOeG7Dt9Zq/LKWCu00=; b=k7ifVcaLmB1YJO/B6SrQrs1nAv HMbdj4E9WdMLu3m5qk9fKkouoU8LxNPsorjPWeOCobaHJavt2zKxefETs/aFWKTJ+pZMFt7XELOvL yWYCVKbd4esXG7P/Vij4DfTpnN49OGGBDBQbqTGoS2ty27vCUnkb9H9VXIelscGDzgrYHJr6ONDzB v0OFGyvh4po3bM+ZJ3kr5agU2/xMotCXTQ0FB+WrZl+UMJSwKgN9Q/7nSZpj7xvb+RdskDsj6pSEd yk/vU67bap9dRfxWBu440lLEFxNik1JvV+ihr+s2RyiRoyL6bTGJV/wvizQ/8vd57F5m1or85P91G 2LCuonwQ==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1riL6m-00000009zWh-3dt5; Thu, 07 Mar 2024 21:16:56 +0000 Date: Thu, 7 Mar 2024 21:16:56 +0000 From: Matthew Wilcox To: Miaohe Lin Cc: Oscar Salvador , Linux-MM Subject: Re: [PATCH 0/5] Remove some races around folio_test_hugetlb Message-ID: References: <20240301214712.2853147-1-willy@infradead.org> <82f585d5-052e-075d-0a08-fbf6e672d42c@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82f585d5-052e-075d-0a08-fbf6e672d42c@huawei.com> X-Rspamd-Queue-Id: CF526120006 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: aru6yw973yzqpju1fq9h1idsft7hs671 X-HE-Tag: 1709846218-765825 X-HE-Meta: U2FsdGVkX183dFc+rDxRwPjowui/8GubdcBcvCORkmgdEjweMao/dhPic5sBqRMcOAR+bzwTGiV7+Xglg2MXb6ytjsEwJIzNgGJSNrXFlk0EbBKN+2eVztuZKq1ueK89fEKYGAruw4z48ryEVjLMuvjgKxFG81NvYvAsu8l2v+rV4PBZy9SRejyp6xrfz/JQFhbbtNmUWehyMTT9ISQi05goxfHh4cUmnnY8avDqCfhxLVIwq9VSI63WsoWQ6wpbFbLTNtLXwgsorO9oSbjYEu3sqPSXDcuTZ5BD+jJa364h/oiBs5fVJ/uolUCUf0Ev9qUSGYsUtIg2nlre0Q1AO0Tk4qCbTnOM2pzawt3c9sC2BWbDgihFfWJ+vuZnmlQmK/p+4STUM8ACvr0CykvS5QJQZUSEV7zuW33P6w/i9Z0mhayQ4pMlhXOU6m+WZ7aqw6LkD2kCPRayq8JRN/bu9xIZ4CtYSaL/M1oYpZSp0g5WLki4cEfW994Zj+ZkgVwyNA2JxOCNHvF18KAob1LzrZJBVwi8bZnWrepgZAtdy1LsRjXyDVIiTywRFt31w1XRY4fhfHiTsn9YH757I0L+uGOi9aha/CUVGcLMVdz8PNpdZEikDRKJWXDrlHOik3hnGQsEaBzUyivs5L9rNDD+jQi52hXQxt+QR+sqiPJn5pLQL6GX803u+5Xyc7oFox4gn08xVZAXgB2P/BhFmiI3B6M7rl/GY2sxcEwcPOIHWQoNhTBVz8GVWjbhArofSUJo2i39Tj67cXsPb1fLRj+EZLL/t27fV2vcGvqBA9ncdmdr+cPzbEmKt6Qcq6LpiTGErxBEOH33e74qQnWVRMT5f8QUT/1ZOOUSypC8YpNV76GhhWz3rtOoDcsCHnkFhPglNJGJiuY737ZVsc6GQ94TQs0QIC25+wvoAQ76aqv5YuKHZKROqTI3kfW0fZ7SAv/k9hRoFBWR0GO3I1a2+04 eqWUMa9i +DKG9qXlEvHU/3esNiQBJ4SDmP8U88NKMeK+nkptBeQmehm0X8Pfo4VY467QtAk160Bq3MmpZaaMdj0ZS/oJVEXnTL3eYWzcmADF3J3jFPfswxkdS98RuE3NPcqsMcxMQ3WzGlj8KKNoyuWkxeOwbxDraKu8aaTWfFuDju4Ox63hmTl7WohZ++pAviQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 06, 2024 at 03:58:31PM +0800, Miaohe Lin wrote: > > - We could grab a reference. That would probaby be unwelcome. > > - We can grab a snapshot. Might be a bit overkill. > > - We can grab the parts of the page/folio we need and open-code our > > tests. This actually seems easiest. > > Option 3 should be the easiest way to fix the issue though it seems the code would be slightly ugly. > Will you send a formal patch? Yes; I just want to get the reliable folio_test_hugetlb done first, and then I have a patch series ready to go. The timing is a bit suspect too; I'd like to give this a few weeks in -next before it gets merged and the merge window starts on Monday. So I think I'll wait until after the merge window to get this sent out. > >