From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C43C47DD9 for ; Fri, 22 Mar 2024 15:57:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 591506B0095; Fri, 22 Mar 2024 11:57:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 541796B0096; Fri, 22 Mar 2024 11:57:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 430576B0098; Fri, 22 Mar 2024 11:57:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 34A5A6B0095 for ; Fri, 22 Mar 2024 11:57:43 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 080C4160BE6 for ; Fri, 22 Mar 2024 15:57:43 +0000 (UTC) X-FDA: 81925130406.06.F629380 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id C64DB1C0013 for ; Fri, 22 Mar 2024 15:57:40 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Dfip3h9f; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711123061; a=rsa-sha256; cv=none; b=d00X2xbPH6fl1rzADMqm9/TwsF2Mll1pN0hCjdP6cqF8s1WDjwjgjEV96SkQUAQdWtwBrM gvPDfPnXLnOSLr+vVC29ud+AGFp8VlyE+E8R2I0wMXtOOuRg91BK0M/3RyCX3AesxQcRhv c9/X40JdBWA1waOB2BsM6PPdO2gHrQE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Dfip3h9f; dmarc=none; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711123061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/oQUXIBl53Mlil81fCqMW0brlHyo5VL3xpRRddwKmb8=; b=jdiT/Dv8uAFoc5najTP/pEE+owUKZVIoYCNhRdHm7Ogx6TPsRxHeuYZuIGQvHUxh7+dreN 2LnngdEpa7yLMjFsgiG4hSx8qln2i+C6Dv/FlkfAkPkdKEQzGT0K+UgmDZJYheeHTt/2Oy v8+2WdOMc7Dz24XEzs7BXXJIWy9zohQ= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/oQUXIBl53Mlil81fCqMW0brlHyo5VL3xpRRddwKmb8=; b=Dfip3h9f5/k0lWKkF1ww8fpTV3 bCMypAP8UClKRcLyeJVSWZGvIzPtfVBu4HnSFG7loJHHQQaO2XfczYPNzps7ExwUQGNN0UfUED2Xv 3KFusmZyHloi45rJNxFvk2M8poTv2wvl4Io1bNgeRh5CKH/28mMlxHQFHPATVTknJaUie7LomR+AB YoOfHSobuCyquO/pow5Ba7Xqj46OnNMGrSVLmoYGVGSzivv2Lsvt8rrrtJxurm66/hL+/eDDVzeeq aOhkE83l0giNxVTzF6fHRqk7AAis8A/5NKAP9157seT2YrE3Qh3dT6yuAi9lMogyuTAeXqFgNi7eJ 2c/P6X6g==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnhGy-00000009j4x-1CCr; Fri, 22 Mar 2024 15:57:36 +0000 Date: Fri, 22 Mar 2024 15:57:36 +0000 From: Matthew Wilcox To: alexs@kernel.org Cc: Andrea Arcangeli , Izik Eidus , david@redhat.com, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Chris Wright Subject: Re: [PATCH v2 05/14] mm/ksm: use folio in stable_node_dup Message-ID: References: <20240322083703.232364-1-alexs@kernel.org> <20240322083703.232364-6-alexs@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240322083703.232364-6-alexs@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: C64DB1C0013 X-Stat-Signature: okpmokjk7igyjksgj6t4i5d8ffnbur8o X-HE-Tag: 1711123060-920277 X-HE-Meta: U2FsdGVkX1+r6Jy2J6cPNVp1LZuGks4q+a2aQh4hiMes9Hvm3ohgPeeQXcZ+ICrepGcGUXImVKYYB5XUhjal+4Uxk+kkrD36Qn/JabeGjU/zwGFE0Fwp7VhUMhV8wBGno8spvJpQ528G7StZ07wgFTE+sRIAj8ogpbysUyDP2Twv8yoPQraLWREhv0IRLX7Pr3DnGFmsyKQpNdZZh2MchPRRybo/CZuPnVj6/xyc1ldgH0eMofROWsVI+e/RUDNHk36o4gQwj7degRiaENiw5SY7G519LAi7C5wio0gus3og/qS2ZiaL+USezMSCvUCJDG+BtGbE8RRRZ3eEp3OBd5YAXHHLBOy2gFrSZ1Z672KkfNX8Q25gsfeJTbOjL9sKAWZXaJwCAsNYhOk7ZCYmUXb7CmDgDWce4iumsq428jopqd7/nnDZPPv+eNEMRL9dLdr99d+JrdiXZZoWkJOl5JAzL43G6kFfeh3NnZWyFwEfvhpGjoKJ76FWRnJcAkOMH5lC4P0Dgb0n9KqmIyAwKxEsKpQn9xWV20k/l3Q95jkCeL4CYWWo0EyaIpgbI7m5bdkDmpCKHj7cD7dmCSMrhcMEQBtXpQ9jgF4ac5YgK1FOmr6gasZHwFSGLhPu2d7SEqBMUsuVdmo/OHRzXD1/l0p0XiFr15Z/oYe1DJTGV5FWHZp/Uf4HApq3jZlgqI7tBHz/7evhrsYox39rV6uTqsT7Lo9vqI7m6o3ZyId/kKHzQr0WdXCuHVfwtPIitqyp+HH/AYTGc+JqaUeEj0Z1D6t/BeZyMmtC58yQ+e84Uf7cwvxfEk9BKyOxzyXiJxaTXhhR6febY6Gc/Cswa0F3ix6+JNVAKtgTcDOOEuHxFJihm50hNToH2pZjBTsgqHo2FM0VdTKZMh59r5FhnUNZo+XqzuLddF8dS9Y/gXMRExZNjnvRIuMkptJWKjV5b35iu6MBN6HekMxe8Os1TY4 AtvR88q7 hO+OrVLLUTHxHjH7YSeMwT4w+EJ/mEbwq2wWH3jxHh6Lx5hrB0wKpOw9Ql/Mwjr2pcR8t7cZQgO7B7zGQIPb4lmEVJ0DjqYFglYe86fFgksRqjEu6JYqmkCpUrJh4bku+TJyBIJu7UzvwqiwBlx21ICu7NUDxvlw7bg3rxGZWPRTRflC3qVMAO1UIGfq+FmqdyolkQrsOvum2WeiL5acpen9iEONAsyNocCKl8RbNOMXALZCn33SYetxFCw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 22, 2024 at 04:36:52PM +0800, alexs@kernel.org wrote: > -static struct page *stable_node_dup(struct ksm_stable_node **_stable_node_dup, > - struct ksm_stable_node **_stable_node, > - struct rb_root *root, > - bool prune_stale_stable_nodes) > +static void *stable_node_dup(struct ksm_stable_node **_stable_node_dup, > + struct ksm_stable_node **_stable_node, > + struct rb_root *root, > + bool prune_stale_stable_nodes) Do we really have to go through this void * stage? Also, please stop reindenting the arguments. I tend to just switch to two tabs, but lining them up with the opening bracket leads to extra churn. Either leave them alone for the entire series or switch _once_.