From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D45FFC54E71 for ; Fri, 22 Mar 2024 19:03:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69A9E6B008A; Fri, 22 Mar 2024 15:03:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FC2F6B008C; Fri, 22 Mar 2024 15:03:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 475F96B0092; Fri, 22 Mar 2024 15:03:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2C2126B008A for ; Fri, 22 Mar 2024 15:03:13 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C24B51A04CE for ; Fri, 22 Mar 2024 19:03:12 +0000 (UTC) X-FDA: 81925597824.18.A70A452 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf04.hostedemail.com (Postfix) with ESMTP id AEBC040014 for ; Fri, 22 Mar 2024 19:03:09 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mdo1wyOZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711134189; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jiOEI1u/n39JDbCsmzZGRMVeyG9x02q5oeFVqSaOL9U=; b=U2rYWdm0KIdcCaGOx2dMa5Umqo6dHVzVogCiYzEaPexjT2SSbFcQ9RqlvRh3wC5CO8YjOg qhSdZ8DBzDpLA3UDM268XbDwbbi2o4ys7GvrZsFl1+GRj++Hqg5IHaY54aOHBCBrCpuz9a Upuwv1yVPdhONm/e/8KFLjto7EwoE3E= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=mdo1wyOZ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.171 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711134189; a=rsa-sha256; cv=none; b=JCoWXeSOe/pID7FIqDHnjllJhOwrI6EktF1Uf7gLxMlpLv5LWA4IuLuMFz6mmJ6p2dxaJc fCAzVWpQaN2fQc6cDFXOXJk5zK9StYlQIfVIRGQAzPXB95KswfQq33kf7WLrhGH4E094ih GFRw3v8t22gChbpmGhhN86B+hqxcn3s= Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-2d2509c66daso32277011fa.3 for ; Fri, 22 Mar 2024 12:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711134188; x=1711738988; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=jiOEI1u/n39JDbCsmzZGRMVeyG9x02q5oeFVqSaOL9U=; b=mdo1wyOZe64dGx0aPkiqkgBnoStT5jkb2vQ3Vsocljb/WjL7zxu9/mWH6duinboHAU AjAwN6x82oOYVz6EBUqAxbu0by4yJ8k8l+I8zbvw69QWrVbEY6GCixeQY2J7CXoh96Mh sAedTkWULvQ5ztnV24k4sH21efTFFrTK2ozpJbqa/cVDuEfbt8jmhWt4nAB3n3VFMWS7 BDZn7dLXbiCnuBTFrzVqMG7wLj2KG16N7AYiKH/a4/jupDT4Gybl6zb4IjAMrGuaLPIU kDfY1qTEgrB8SJhdYPlGHSGoO/xWwpB+AFVak1i+GSFl+YzthIYtAKbLc7tGr7TdqBxy x+Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711134188; x=1711738988; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jiOEI1u/n39JDbCsmzZGRMVeyG9x02q5oeFVqSaOL9U=; b=qZI/XWJOIsMyqyDJQa13br0JDh+bOiqvy3do60BhrM2CEwQPAlwk7p/rlE0eB9zjqW n66aSluWadcL8yCXtisXldyYAhoSdgE2Tf7qSNVGsbxDXG+M3U+zjaGiEXGbkaZEARxp k+K6m3OoqCz7uL/3u4PdgLG/7H3AO5d3E406iXnY/Dl5j55KwudWyPmQodzsSSyJa6sg vOatMGH6ISoFsRtNE8q2Wu6txMqfbQ0ZW8DbV7A38LOz1BNaVs08VOdDzNesZ7eze2Ie qPFdvOFn5COUhWkZCTKZ4SzNaw/uRT95TmIOWHj4by6cnk9qLtmKCrgdeBeDln7gIQ/v 4IRQ== X-Forwarded-Encrypted: i=1; AJvYcCXsKEUjRguP6DZvusfJoNOf/XZyCJVjEpyqLr3A/mHB3Uk4scb4vwe9ag7K9WFjhAjl6ZDy05TelMrbumTL+uwTYZw= X-Gm-Message-State: AOJu0Ywy0LpDwj89HlFRlJqc1CJimamwqM5mxwmJrz4mpouSQsu6D7LQ YouIg++bSzmIQNtYjXSCLRfUImTwAEdm8GQWl5TZy+rAqOXGfIZ6 X-Google-Smtp-Source: AGHT+IF7g+XE2LFCeky3tKyYVvoigiOqtzZ7ycIK7Nwa6aTRCRmD7Z7+zSyR3QnEiNbdOr7eKNHLIw== X-Received: by 2002:a19:e056:0:b0:513:5951:61a4 with SMTP id g22-20020a19e056000000b00513595161a4mr232407lfj.6.1711134187309; Fri, 22 Mar 2024 12:03:07 -0700 (PDT) Received: from pc636 (host-185-121-47-193.sydskane.nu. [185.121.47.193]) by smtp.gmail.com with ESMTPSA id j15-20020a056512344f00b00513b1dec266sm14013lfr.245.2024.03.22.12.03.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 Mar 2024 12:03:06 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 22 Mar 2024 20:03:04 +0100 To: Guenter Roeck Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He , Lorenzo Stoakes , Christoph Hellwig , Matthew Wilcox , "Liam R . Howlett" , Dave Chinner , "Paul E . McKenney" , Joel Fernandes , Oleksiy Avramchenko Subject: Re: [PATCH v3 07/11] mm: vmalloc: Offload free_vmap_area_lock lock Message-ID: References: <20240102184633.748113-1-urezki@gmail.com> <20240102184633.748113-8-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: AEBC040014 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: sq17orzu7oucf466bocn8tye6oqnuywj X-HE-Tag: 1711134189-964818 X-HE-Meta: U2FsdGVkX1/TPZrWxW2xjIbEpzPJgvELoPaWVTQzCIrN41N+TvOLI8DhVS8XRT2qh0HFADY/dumisvYbZyaYVg7Q1VSD7BxG9iHSDBsDMQvbock70EqbOros6vuurwnR6dFU/87YMk3z8kf/UIKwANCfEoQB3+BjCHB+2h3tSiUwZ24bH7WkpBubc03f4R8QVaNS7WBxl2/Agkj+TYgQeW1tTpFpFD2pQFOYhD25PG9QGuiW8+fbk9Mlsv2hvYP2wRHBevbHgszaErQQG6/myH0/IiEf8MM5IyDHBkAB3XwzR8ynzxlsvP3v1jjTZgGf1cpEZJY2DYTX30NgSPTNq02d+HWNOjEGaLLRHWvCQATPTISeQkZDOuSb+Kxdrn+bxyWIO+jnaIwwuAwwPLDtDlCIRXHK0ms+FLh/59B1sByuALVZoPHnZW+A27VhZgFmNWbq+6FMeTVH+iEIOHV3ILJKoXxnQYjPmR2UU7ZOEhz4TQrVEnThDfzDiNucBq/8tMNRF7KoIQ+f178W6WE7S694MTnOMLU6fFhjsK4XcU8VcyV7TAIB3h+ThWjAjZytoPhX5yz9a9Oa7lYq+z1mMP23hr2x/g/f3+R0pT5imG61h9TMiDeuyV7huHPgt7SiCrrOir9z7Jcc1ZpMUbRQSBMuRLR0jnzggCf0Sw6q+5SvvpLv7wPyw5gYDPEH9Y/Ll5SB8x7H0NQJksXCAGUQCJ/Fj7yB0qmzr+eSAU7LqqtEhREJGHhIzKJrpeDs47VuknpvKF7hD+cm46WYI8zhR1yiMw7G9TtBY6nj/G9WpcWtYBJD49RS3U0RdaxUKuRtccI0O4XB3Hxn5Hzo2cPE5TisezNdTMxvnlB/6ac+QacetNNl0FM3q4pu0bdom6kBpE/tT4Q/a75YVvNlQ7rWrmq7KVwm82cIqOkhikY36rFRLjQAjf+c0Btl2nSre7ExfBZbc3sAg4LmoaHz65L MJfbxy7C i1xrcyAvNBeGfm0uFZiFb3yJ87H+BpgFJ3joJGUfMOzVgbkZ5xZGhIAVJY/48QGLHk+8HIuIqVghrn/axR07V7gaw57GvBrJlj1lWbCw3b4C/RxbAd6f9zXnHt8Mr7A+6G9xXXApKecq76prnYhwacCx6ucYMSlGIDb/+uNp3W4H5Ii1hbeMc5BZHWxfPY0lZ4UlANRyrf1dZjEh8eEPKHXa3OQakIeEpeXjibg4riPZN/S+jMHkSvuQsrbppaNx5D2UlxKHnPMpOxtg5ppcP8RFV887jdqPwoyEoT0sR+tJ2PRIWyPZtpkK1ZiaKdY2MEB9FQPcXMJB3sbWnQtceb255CRng5i3P7ef90yTq3hu01ruMBdwpY5L09TWq+F4X4dHtXskjBYtuGKW+lPl/8qDLChZ7xDlDTiYXjm5Hj0eFgn5BZF+WugWgVtLoNbFHDVB2o0BdtoPhchzw23z/oIUARsZQJpo4skIKay3/ZfaMnkIP1oVCXT3h9H8yHL5jBtfJbpqYtDAZopQ7x5eurRi8XCrSFrhb+7IVqAGsmqCSwTg3Yq6lRyaqHYx4GA44BxwKwypg8UqPVSK7wD8O9RLjYUO/GBgKrqnz/sxSuasK1bZoCh/smHtvH9BRtAPOb7QOi/iETZjnoTBw7e1W7Xh1P2WMNDDNTe0261O0aUbUkQdL9a17g5Dt7A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 22, 2024 at 11:21:02AM -0700, Guenter Roeck wrote: > Hi, > > On Tue, Jan 02, 2024 at 07:46:29PM +0100, Uladzislau Rezki (Sony) wrote: > > Concurrent access to a global vmap space is a bottle-neck. > > We can simulate a high contention by running a vmalloc test > > suite. > > > > To address it, introduce an effective vmap node logic. Each > > node behaves as independent entity. When a node is accessed > > it serves a request directly(if possible) from its pool. > > > > This model has a size based pool for requests, i.e. pools are > > serialized and populated based on object size and real demand. > > A maximum object size that pool can handle is set to 256 pages. > > > > This technique reduces a pressure on the global vmap lock. > > > > Signed-off-by: Uladzislau Rezki (Sony) > > This patch results in a persistent "spinlock bad magic" message > when booting s390 images with spinlock debugging enabled. > > [ 0.465445] BUG: spinlock bad magic on CPU#0, swapper/0 > [ 0.465490] lock: single+0x1860/0x1958, .magic: 00000000, .owner: /-1, .owner_cpu: 0 > [ 0.466067] CPU: 0 PID: 0 Comm: swapper Not tainted 6.8.0-12955-g8e938e398669 #1 > [ 0.466188] Hardware name: QEMU 8561 QEMU (KVM/Linux) > [ 0.466270] Call Trace: > [ 0.466470] [<00000000011f26c8>] dump_stack_lvl+0x98/0xd8 > [ 0.466516] [<00000000001dcc6a>] do_raw_spin_lock+0x8a/0x108 > [ 0.466545] [<000000000042146c>] find_vmap_area+0x6c/0x108 > [ 0.466572] [<000000000042175a>] find_vm_area+0x22/0x40 > [ 0.466597] [<000000000012f152>] __set_memory+0x132/0x150 > [ 0.466624] [<0000000001cc0398>] vmem_map_init+0x40/0x118 > [ 0.466651] [<0000000001cc0092>] paging_init+0x22/0x68 > [ 0.466677] [<0000000001cbbed2>] setup_arch+0x52a/0x708 > [ 0.466702] [<0000000001cb6140>] start_kernel+0x80/0x5c8 > [ 0.466727] [<0000000000100036>] startup_continue+0x36/0x40 > > Bisect results and decoded stacktrace below. > > The uninitialized spinlock is &vn->busy.lock. > Debugging shows that this lock is actually never initialized. > It is. Once the vmalloc_init() "main entry" function is called from the: start_kernel() mm_core_init() vmalloc_init() > [ 0.464684] ####### locking 0000000002280fb8 > [ 0.464862] BUG: spinlock bad magic on CPU#0, swapper/0 > ... > [ 0.464684] ####### locking 0000000002280fb8 > [ 0.477479] ####### locking 0000000002280fb8 > [ 0.478166] ####### locking 0000000002280fb8 > [ 0.478218] ####### locking 0000000002280fb8 > ... > [ 0.718250] #### busy lock init 0000000002871860 > [ 0.718328] #### busy lock init 00000000028731b8 > > Only the initialized locks are used after the call to vmap_init_nodes(). > Right, when the vmap space and vmalloc is initialized. > Guenter > > --- > # bad: [8e938e39866920ddc266898e6ae1fffc5c8f51aa] Merge tag '6.9-rc-smb3-client-fixes-part2' of git://git.samba.org/sfrench/cifs-2.6 > # good: [e8f897f4afef0031fe618a8e94127a0934896aba] Linux 6.8 > git bisect start 'HEAD' 'v6.8' > # good: [e56bc745fa1de77abc2ad8debc4b1b83e0426c49] smb311: additional compression flag defined in updated protocol spec > git bisect good e56bc745fa1de77abc2ad8debc4b1b83e0426c49 > # bad: [902861e34c401696ed9ad17a54c8790e7e8e3069] Merge tag 'mm-stable-2024-03-13-20-04' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > git bisect bad 902861e34c401696ed9ad17a54c8790e7e8e3069 > # good: [480e035fc4c714fb5536e64ab9db04fedc89e910] Merge tag 'drm-next-2024-03-13' of https://gitlab.freedesktop.org/drm/kernel > git bisect good 480e035fc4c714fb5536e64ab9db04fedc89e910 > # good: [fe46a7dd189e25604716c03576d05ac8a5209743] Merge tag 'sound-6.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound > git bisect good fe46a7dd189e25604716c03576d05ac8a5209743 > # bad: [435a75548109f19e5b5b14ae35b9acb063c084e9] mm: use folio more widely in __split_huge_page > git bisect bad 435a75548109f19e5b5b14ae35b9acb063c084e9 > # good: [4d5bf0b6183f79ea361dd506365d2a471270735c] mm/mmu_gather: add tlb_remove_tlb_entries() > git bisect good 4d5bf0b6183f79ea361dd506365d2a471270735c > # bad: [4daacfe8f99f4b4cef562649d56c48642981f46e] mm/damon/sysfs-schemes: support PSI-based quota auto-tune > git bisect bad 4daacfe8f99f4b4cef562649d56c48642981f46e > # good: [217b2119b9e260609958db413876f211038f00ee] mm,page_owner: implement the tracking of the stacks count > git bisect good 217b2119b9e260609958db413876f211038f00ee > # bad: [40254101d87870b2e5ac3ddc28af40aa04c48486] arm64, crash: wrap crash dumping code into crash related ifdefs > git bisect bad 40254101d87870b2e5ac3ddc28af40aa04c48486 > # bad: [53becf32aec1c8049b854f0c31a11df5ed75df6f] mm: vmalloc: support multiple nodes in vread_iter > git bisect bad 53becf32aec1c8049b854f0c31a11df5ed75df6f > # good: [7fa8cee003166ef6db0bba70d610dbf173543811] mm: vmalloc: move vmap_init_free_space() down in vmalloc.c > git bisect good 7fa8cee003166ef6db0bba70d610dbf173543811 > # good: [282631cb2447318e2a55b41a665dbe8571c46d70] mm: vmalloc: remove global purge_vmap_area_root rb-tree > git bisect good 282631cb2447318e2a55b41a665dbe8571c46d70 > # bad: [96aa8437d169b8e030a98e2b74fd9a8ee9d3be7e] mm: vmalloc: add a scan area of VA only once > git bisect bad 96aa8437d169b8e030a98e2b74fd9a8ee9d3be7e > # bad: [72210662c5a2b6005f6daea7fe293a0dc573e1a5] mm: vmalloc: offload free_vmap_area_lock lock > git bisect bad 72210662c5a2b6005f6daea7fe293a0dc573e1a5 > # first bad commit: [72210662c5a2b6005f6daea7fe293a0dc573e1a5] mm: vmalloc: offload free_vmap_area_lock lock > > --- > [ 0.465490] lock: single+0x1860/0x1958, .magic: 00000000, .owner: /-1, .owner_cpu: 0 > [ 0.466067] CPU: 0 PID: 0 Comm: swapper Not tainted 6.8.0-12955-g8e938e398669 #1 > [ 0.466188] Hardware name: QEMU 8561 QEMU (KVM/Linux) > [ 0.466270] Call Trace: > [ 0.466470] dump_stack_lvl (lib/dump_stack.c:117) > [ 0.466516] do_raw_spin_lock (kernel/locking/spinlock_debug.c:87 kernel/locking/spinlock_debug.c:115) > [ 0.466545] find_vmap_area (mm/vmalloc.c:1059 mm/vmalloc.c:2364) > [ 0.466572] find_vm_area (mm/vmalloc.c:3150) > [ 0.466597] __set_memory (arch/s390/mm/pageattr.c:360 arch/s390/mm/pageattr.c:393) > [ 0.466624] vmem_map_init (./arch/s390/include/asm/set_memory.h:55 arch/s390/mm/vmem.c:660) > [ 0.466651] paging_init (arch/s390/mm/init.c:97) > [ 0.466677] setup_arch (arch/s390/kernel/setup.c:972) > [ 0.466702] start_kernel (init/main.c:899) > [ 0.466727] startup_continue (arch/s390/kernel/head64.S:35) > [ 0.466811] INFO: lockdep is turned off. > diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 22aa63f4ef63..0d77d171b5d9 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -2343,6 +2343,9 @@ struct vmap_area *find_vmap_area(unsigned long addr) struct vmap_area *va; int i, j; + if (unlikely(!vmap_initialized)) + return NULL; + /* * An addr_to_node_id(addr) converts an address to a node index * where a VA is located. If VA spans several zones and passed Could you please test it? -- Uladzislau Rezki