From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6E45C54E64 for ; Sat, 23 Mar 2024 03:38:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C7726B0092; Fri, 22 Mar 2024 23:38:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 077826B0093; Fri, 22 Mar 2024 23:38:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E80FC6B0095; Fri, 22 Mar 2024 23:38:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D5BB26B0092 for ; Fri, 22 Mar 2024 23:38:44 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C2B4AC0962 for ; Sat, 23 Mar 2024 03:38:43 +0000 (UTC) X-FDA: 81926896926.28.15573C5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 27B8A40016 for ; Sat, 23 Mar 2024 03:38:41 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=af2RyU43; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711165122; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LlUtxx4MKcpe94C+aEyNof/j9MR1zuOrpJuun+uWEcg=; b=z2KCwW7Ev0m2CKbvAyYX5s6WWovF/Qr4eX5op+X0UiZv18cPkDQ22H31OpmKVoXH5+TL6A uAXAYGuDMmWUpO0YowLRW0OFW5RFG89kbhCx3zWSN63aAyrPNPlON1gqaR3hKy7VjFdlOO 7xh1st8s1XHWxV5gHnQkTQXC08R1uRo= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=af2RyU43; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711165122; a=rsa-sha256; cv=none; b=MIQDT0hVGY7AncIQ0ZOmQx9AoPDaVFkRIrffnFRIf95ZbHYFQMblh5FSigf0zqvdP0hohg n8cF+ZZr7AMACP8Np2Cb2T5mzDDVgE2Nu3w4HWSm10nuURr5UHPbm3+B5aiLXY0IRnt+nK D6Wub369+loa92lGlNc9QkG7rmmiX6Y= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LlUtxx4MKcpe94C+aEyNof/j9MR1zuOrpJuun+uWEcg=; b=af2RyU43XXraGKNuDb6BZps0Zw axYU0B67WnrdQuphY6BQqqIp4qx1K6ewkb/pZR8zKhj8euv3qz3BvxZ2U2PatVEpqjZaBE8ncIy1h lq/oNYFVM6q+V9IYr0TH76SOHnBIZjlOjzXvwc9anOzeuzVBoI+N9eWWmfgveyh/MXRmMT6LZfZkA eWHq4lpwWFZIcOSAItCAGYSaE4x3qDLa52zciO0FE9/MtA41IEhoUhBzcFBFu4SxFXLnkmKJ2as9K iq5bvJ7vT9p3taYJ6p1KsOyCM/eooY9HC+yidWw9OhaPhTv6brroMCN8EbdJox6XNTqvtOC7ZZvjQ xyyfFo2g==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnsDN-0000000AtR3-3F26; Sat, 23 Mar 2024 03:38:37 +0000 Date: Sat, 23 Mar 2024 03:38:37 +0000 From: Matthew Wilcox To: alexs@kernel.org Cc: Andrea Arcangeli , Izik Eidus , david@redhat.com, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Chris Wright Subject: Re: [PATCH v2 13/14] mm/ksm: use folio_set_stable_node in try_to_merge_one_page Message-ID: References: <20240322083703.232364-1-alexs@kernel.org> <20240322083703.232364-14-alexs@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240322083703.232364-14-alexs@kernel.org> X-Rspamd-Queue-Id: 27B8A40016 X-Rspam-User: X-Stat-Signature: fx7i1ozu7ju88yey3uq9bfdb1m4q5rw4 X-Rspamd-Server: rspam01 X-HE-Tag: 1711165121-401761 X-HE-Meta: U2FsdGVkX19EUYZsacBD3WUK4pA4dmiZlvdc1CQbmVCSBkal+bWj/wsZTvGctKHv9QWc/TRclD7jYYTPEqSEbAUI3NOn2v3fcPFD2v5rRpIpG+9bGUuT2W6fCR630Z03cAANE3cglNZejpOwILNCZNIrpw3Vkvo6WY0PxJn5wutl3HEfuRgbdLgfVQLVnnmYbkHzyViAwhIwltx58DWE1zdrBq7YPS3JdKPlEs0ZthNCORXbxdq5Q8zr0/re8JTnw/r+QUoLr5Nyb+5CdVkJXa8FtY3YzVKKf1ZIni5brW4mPK6hPLf1J8KRSxH3bbaIf92zlpFhGH+8lkMGCruTlHv3OwBkfaGIAgzm2aODNDtUw8xCgUaJBHklrYkrtWxsvDJaoEdATXZZWEqlSgzkPCXk1Hiu/7ncAnm9+VMkylRdvGlUisz7qfu51rMHrjTZZ/rEC1fp/0Q9Dz+hZn4Q+9pzt58ty+gI5ZomM+UkoQMXjki8qTS/AWT3LmqOMv2IJtlc62w2WKqaIDmjm0GjOnzWgvQPDogoKKBV79xjfNTERtLJYr8Id/e8/VocOgShA+wnf+Sn+FK/rWjfnoDb58GOAjotTjiT4XjOKQHg6a7UON47NqHOwLG2BmEwQki0zksjocMCJ8jcID9Em7py+ArN7jGIpn/fAX2RNFDd09IPcEAoeolDBgQFTaiwKRaHi/FWfJ3jQSbOEhtjBDGoCePB8Fl+iKC40Bs0Pd0j90t81/1jFtUg/fI2f5cs7lwlx7jU5cXzCBFdrbuuSThZ79qYLqH56fQH+eW1ON0eaa4hSckwpTejl6KGF8njhhKrZWm1XFXG76B7LBUoCvYVx4+/B6UGQzon4sH835PEYGIfTUsODpeDg1CA/CC+EMtIkty1x5TfYEbQtyR7ToFkDrf5lmYatVRe2T+dhNJI1ReOLxrcg2YduHKp/8C8cQ6UvVC077AEl3GEe+aeW1w NCPFzSAj uYFiFcgePSbv1CJfA20o2l81eGQWq3dsXcIK3hl9+AgtyXHcn36szjXcL6vGgWw21uFKfsOMr2tFmp4maFqk8IvRuvPn7dsnNPzBt3owQRkCq27/NkTK04ePjYGpjVylum4Ouu68hnuB6gzHFO5mAP9vB6h5bNClT1V3fLufzMp1nmllzw+HbxEfA6twt9Wvk4MWHxVCI2ImH6v3q41vZyaYPHdQvxdJfBG+fqRsWEfMIZfRLviLTQazwoofs7UheQqvcTVr3WzEzAZIc/3d2A9M5Z+cQid7Dsuh99vra3rLwMJ2i/Z3r4F/GWOtoxGKibcHDuvvNKeqJZhVYkewxDx0o8Q5Im/BaeX45PkGCNK6GzEqea2mg30zfhqeqX0NE8js8LjdvYIxmlG1xemU8EYb987ASBwXRxvmc7n47pQCHmyCAFzv7Rc99R63Tya64ILz8ii6CB4zVJZAvCRL6WhF+Bw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 22, 2024 at 04:37:00PM +0800, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" > > Only single page could be reached where we set stable node after write > protect, so use folio converted func to replace page's. > > Signed-off-by: Alex Shi (tencent) > Cc: Izik Eidus > Cc: Matthew Wilcox > Cc: Andrea Arcangeli > Cc: Hugh Dickins > Cc: Chris Wright > --- > mm/ksm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 15a78a9bab59..d7c4cc4a0cc1 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -1518,7 +1518,7 @@ static int try_to_merge_one_page(struct vm_area_struct *vma, > * PageAnon+anon_vma to PageKsm+NULL stable_node: > * stable_tree_insert() will update stable_node. > */ > - set_page_stable_node(page, NULL); > + folio_set_stable_node(page_folio(page), NULL); > mark_page_accessed(page); I'd rather you did a conversion of try_to_merge_one_page() instead of just this. It'll be a fun one because you'll have to recalculate the folio after calling split_huge_page().