From: Catalin Marinas <catalin.marinas@arm.com>
To: "Christoph Lameter (Ampere)" <cl@linux.com>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Mark Rutland <mark.rutland@arm.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <vireshk@kernel.org>, Will Deacon <will@kernel.org>,
Jonathan.Cameron@huawei.com, Matteo.Carlini@arm.com,
Valentin.Schneider@arm.com, akpm@linux-foundation.org,
anshuman.khandual@arm.com, Eric Mackay <eric.mackay@oracle.com>,
dave.kleikamp@oracle.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
linux@armlinux.org.uk, robin.murphy@arm.com,
vanshikonda@os.amperecomputing.com, yang@os.amperecomputing.com,
Nishanth Menon <nm@ti.com>, Stephen Boyd <sboyd@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v3] ARM64: Dynamically allocate cpumasks and increase supported CPUs to 512
Date: Tue, 12 Mar 2024 17:55:49 +0000 [thread overview]
Message-ID: <ZfCXJRJSMK4tt_Cm@arm.com> (raw)
In-Reply-To: <bf1757ca-6d41-87e7-53dd-56146eef5693@linux.com>
On Tue, Mar 12, 2024 at 10:06:06AM -0700, Christoph Lameter (Ampere) wrote:
> On Mon, 11 Mar 2024, Christoph Lameter (Ampere) wrote:
>
> > This could be an issue in the ARM64 arch code itself where there maybe
> > an assumption elsewhere that a cpumask can always store up to NR_CPU
> > cpus and not only nr_cpu_ids as OFFSTACK does.
> >
> > How can I exercise the opp driver in order to recreate the problem?
> >
> > I assume the opp driver is ARM specific? x86 defaults to OFFSTACK so if
> > there is an issue with OFFSTACK in opp then it should fail with kernel
> > default configuration on that platform.
>
> I checked the ARM64 arch sources use of NR_CPUS and its all fine.
>
> Also verified in my testing logs that CONFIG_PM_OPP was set in all tests.
>
> No warnings in the kernel log during those tests.
>
> How to reproduce this?
I guess you need a platform with a dts that has an "operating-points-v2"
property. I don't have any around.
Sudeep was trying to trigger this code path earlier, not sure where he
got to.
--
Catalin
next prev parent reply other threads:[~2024-03-12 17:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 1:45 [PATCH v3] ARM64: Dynamically allocate cpumasks and increase supported CPUs to 512 Christoph Lameter (Ampere)
2024-03-07 17:49 ` Mark Rutland
2024-03-07 19:07 ` Catalin Marinas
2024-03-18 18:17 ` Catalin Marinas
[not found] ` <CGME20240308140130eucas1p1259c805a0b6491ce2f69c6fca0264b1f@eucas1p1.samsung.com>
2024-03-08 14:01 ` Marek Szyprowski
2024-03-08 14:51 ` Catalin Marinas
2024-03-08 16:21 ` Marek Szyprowski
2024-03-08 17:08 ` Christoph Lameter (Ampere)
2024-03-11 12:12 ` Mark Rutland
2024-03-11 14:56 ` Marek Szyprowski
2024-03-11 15:22 ` Catalin Marinas
2024-03-11 16:51 ` Marek Szyprowski
2024-03-11 17:08 ` Catalin Marinas
2024-03-11 18:55 ` Catalin Marinas
2024-03-11 21:07 ` Christoph Lameter (Ampere)
2024-03-12 17:06 ` Christoph Lameter (Ampere)
2024-03-12 17:55 ` Catalin Marinas [this message]
2024-03-13 14:35 ` Sudeep Holla
2024-03-13 16:22 ` Marek Szyprowski
2024-03-13 16:39 ` Christoph Lameter (Ampere)
2024-03-13 20:18 ` Marek Szyprowski
2024-03-13 17:13 ` Russell King (Oracle)
2024-03-14 8:39 ` Catalin Marinas
2024-03-14 12:28 ` Marek Szyprowski
2024-03-14 13:17 ` Russell King (Oracle)
2024-03-14 17:01 ` Christoph Lameter (Ampere)
2024-03-14 13:57 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZfCXJRJSMK4tt_Cm@arm.com \
--to=catalin.marinas@arm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Matteo.Carlini@arm.com \
--cc=Valentin.Schneider@arm.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=cl@linux.com \
--cc=dave.kleikamp@oracle.com \
--cc=eric.mackay@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sboyd@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=vanshikonda@os.amperecomputing.com \
--cc=vireshk@kernel.org \
--cc=will@kernel.org \
--cc=yang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).