From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E62C2C54E5D for ; Tue, 12 Mar 2024 18:32:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A8C38E0009; Tue, 12 Mar 2024 14:32:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 358498E0007; Tue, 12 Mar 2024 14:32:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D2278E0009; Tue, 12 Mar 2024 14:32:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 069F68E0007 for ; Tue, 12 Mar 2024 14:32:37 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CDCC5806CE for ; Tue, 12 Mar 2024 18:32:36 +0000 (UTC) X-FDA: 81889232712.24.712F9A7 Received: from mail-io1-f51.google.com (mail-io1-f51.google.com [209.85.166.51]) by imf08.hostedemail.com (Postfix) with ESMTP id AF658160019 for ; Tue, 12 Mar 2024 18:32:34 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WMbjGRzs; spf=pass (imf08.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.166.51 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710268354; a=rsa-sha256; cv=none; b=R9R33nDjlJfJ+Xfk2q8WCFRYI8Qc7l0Y7Q1kF42bvOJCzc83Yz6Dxws2RymjytcWYLI9eH bYn1u5Sgma69CidDWH9c41HSdPW2hbVRMeyrYM4HyhmOQI3ekOXerVyy0FI2BcRhhTnxng WgB/3YZljuxfUi9QAYLpSP70OhXmHeo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=WMbjGRzs; spf=pass (imf08.hostedemail.com: domain of nifan.cxl@gmail.com designates 209.85.166.51 as permitted sender) smtp.mailfrom=nifan.cxl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710268354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pqU8vwf+tbdTSkXAgzjKJdEijPq7ApphWIX0SIRCQzk=; b=qhQw00zJQ7KGpB6hExpeM3qe4PeqOw5CbIE5Ui0x+5YEHbL08rNHoCVRyW126DyQoE1EvB QUpja9umPGq08yly+m/661Na6IHZ0xNJrntrFobP8Ck5JXNpXD8Qh3adU+8j+U/Pqn5ZET Q8pEh2oVPTyqJToK9D10ge01ItWlqLI= Received: by mail-io1-f51.google.com with SMTP id ca18e2360f4ac-7bc332d3a8cso12156639f.2 for ; Tue, 12 Mar 2024 11:32:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710268354; x=1710873154; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=pqU8vwf+tbdTSkXAgzjKJdEijPq7ApphWIX0SIRCQzk=; b=WMbjGRzsitmZlM5ufIpEiVJfYLp4QpIZeSAiJxJyxk0+6285eR+6kFAs4L6nhHXzZt FMtKgNvW9JSMK2yo9HMIzW+tXtPvm/ag4+yuXxgt5AIG2Zj6VDth5hqYWTDsRfppifsa q8YYv+BD/tmKDObPQ7tBkUP71oh7YxxuQkFdY2LOM1LWb6BTs+EcgqDfFhNqZXaqYlEk UnmAaAgCGPwLnYX43DafL5Ru8Ye+qgUwuLo6Y7HRjR0iR7CkiVv2t0AcIzeKFEgOfCJe eAc6SzioSS0EMHexJ/5lCrMBFvH6YFTOWUX2YxF99f2S0aEK/nvImrzpWbZcJMl+8imC ztKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710268354; x=1710873154; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pqU8vwf+tbdTSkXAgzjKJdEijPq7ApphWIX0SIRCQzk=; b=TmLTiNkytkP1wJzXWH+WKLTrtR0pn/soEvVtKc7pzPcFy5iltvq8/m8xSOdTu2rfrq tzNLWgKPYW8xKWEw1eWtBWwpoEaeZmOtI1L2KPKsj0kmsx/chzkBwNcyYCD+jXcKnXc0 EqKAD7iJoG3nzwIxpyD2i5cuF4VW3rjqRm17BRRNMQNR92w1+NgcOkEOZb2+8ToiT6tR FxiFryAvRLge9Nlwle/AJn7Qo16cDDdM/nXwGUoUHdZi0/lklWFO9IdtnjTYOYl/ssP9 uK2pa40+VWpTx9O46uXlnfbBtpS1twGk72N7is34XpITLdYwfuWxOczDTKanfoQL0914 r0QA== X-Forwarded-Encrypted: i=1; AJvYcCUGBQHSKcFiVih46zxtygPdqEINFYqguIn1Q/INUKmpBo1GI3BlFaq24cLSLs5tVyufRknTlMAo9LGBOK+Y+ZVMMBA= X-Gm-Message-State: AOJu0YxcGuDfPOYM3WhaLYXPxlKX+Z3rqnzCsSDhQWqlC0E621tU/aYW VS2FobcIlTLNZ1Cz3uvBjnU/QNleT16CCtlhGQAI7+/N4jI4aNyr X-Google-Smtp-Source: AGHT+IHQ91EGeIfz2oaj8S9TucVWBSI/m7YsmBPoTA68buP0uVHpq6iN4yvUa+DL1kIPCUmvF0cgcw== X-Received: by 2002:a6b:5c12:0:b0:7c8:c9b8:f976 with SMTP id z18-20020a6b5c12000000b007c8c9b8f976mr1280322ioh.21.1710268353693; Tue, 12 Mar 2024 11:32:33 -0700 (PDT) Received: from debian ([50.205.20.42]) by smtp.gmail.com with ESMTPSA id c18-20020a02c9d2000000b00474fab2523dsm2436749jap.62.2024.03.12.11.32.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 11:32:33 -0700 (PDT) From: fan X-Google-Original-From: fan Date: Tue, 12 Mar 2024 11:32:17 -0700 To: shiju.jose@huawei.com Cc: linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, dave.jiang@intel.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, tony.luck@intel.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, rafael@kernel.org, lenb@kernel.org, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, mike.malvestuto@intel.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com Subject: Re: [RFC PATCH v7 10/12] ACPI:RAS2: Add common library for RAS2 PCC interfaces Message-ID: References: <20240223143723.1574-1-shiju.jose@huawei.com> <20240223143723.1574-11-shiju.jose@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240223143723.1574-11-shiju.jose@huawei.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: AF658160019 X-Stat-Signature: 8o3wn93jhg155athhc4xh3wee344a4zx X-Rspam-User: X-HE-Tag: 1710268354-451340 X-HE-Meta: U2FsdGVkX1/CEXwhZ0zGgXW72bBsXaqvkMcvZTr8p1IfCI30N+bf1Z0KPzczUh+vRToaU3s/2bWtdj4E/+GIxQWH149akK3T/tjwH6pGD2TklezXnc241o6hzm1iUsUwX2t/rM+veycMS/qbzUeM7cVH3+NNg12xYOsLY3bD1mfTehbzrw5KhqfAghDxb1iglixD8wjRNIRBJiPDOgyFAAgWN0VfoBOqZhzqLJM88Tc+eXotbBFFqU2ev8aWWZzpyUnKmENPbmDfFcvk69q48/ulTXHb1KeYLD1RbqkwIQpHm9lvUPjEGDnIzkdGbEET8d7psqg+ZflCtkmM7+jP2clcbjyrttbmzYAxgQMmRmZVsRykQA82TiDQku8307B8FzfPPzYD+ry+1zNo1A8+MDvu/1AJ9HCBWp9y8EjGbZcYmtu33h/32a3uQ2r/1Y6S5JCdxnTMiUG63ocRr891/QBDbNz/eZLOA2rwbhd8Q3xuX1ZVGCVdNsurbAOUyekNQ8lhoRx+DB2XhV2fVTOT/HYFufyiSNbzSgXADOjitGsupIQAuS5tpFooKtN5UOKE+LhIwEYscjATERR/HbLn1pXMQlOTQWH9f6Ez5vk/n+CjgaanuA0Wq5+aAXC7Fu6Q0bh7OrrUZTxnmwMU1d4xTAS4GtGBKhl1hDXY2op3EJ8laLaqiAWvBVyv6Zb7PicRlwEdjKDMmJAuHytxsh983A5SiVEP29QQ6jC/332fAPu1hKiqq1/AsxamAsel+qOksAhecZNohNc1hAY+svUEAtnkWvvBY1MqT3n4+dSIcLOmRGMMVmmKREgMeiRes0r5roK6WzVNJc5k57w5W7T4zt71VmLIGBHiCA/G+CeqKbtmgNGIRsi/5wgcXWtqbgwjSA5LPXeaXrLFk10MGn0J3m24MFZzgIKyvR9GSDQuXnPORDH8nxzlu+1gs19hWzrrWmW2P61im+gRQAtg1u4 qpbhk+Mi j/AoJVKQIiz8FC8gNYY++U2vUnZmUzRIcN2u3eOnCQzQa8r/rI0uycdMDVB9fpYlb2zpEs25ytDr+jOE+f33r5MM2CJmIzfoiJcEw62mfHc3/5i6NMvCNyAe/iXq7pkk1152Dw3XpIqUzJtXZiA9WD/8D20dDTZBMt5V/m1TD4Ius5xZY2eVmcKTBIxICsN5jqCcbfCLSiYftOEngBCeBdxcqQr/xMYhUOu4Ji26PdiQLoU0iypWYssLcIV/6Sp3LjspBPQfAUUUuPByBFLMNLgBoF1WlbyLlIGP8NFilfLFYOLBSl6tbr/w9XKAK0MHShREfEYZkDpFNpQ6LUmqfDxdkJxs7R5wWxK5AA5cFyiYR3Jlm/VICPnMwZvtpunKwB/FK9jBWlIFw5PerOZhm3qsOZO+b1UjV2+PGusuSF22Mgi1KXPaUo3vBHwh0xhAMPLO0hstO3wMrx3zzsvXs3FfHjb6mdFd8VZ+KvjfRRFrZz//JuzsVUNLBqeGEIA+lmzZ+cPe8YCzODTWGHhWoebyJBhNR5G93pt35 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 23, 2024 at 10:37:21PM +0800, shiju.jose@huawei.com wrote: > From: A Somasundaram > > The code contains PCC interfaces for RAS2 table, functions to send > RAS2 commands as per ACPI 6.5 & upwards revision. > > References for this implementation, > ACPI specification 6.5 section 5.2.21 for RAS2 table and chapter 14 > for PCC (Platform Communication Channel). > > Driver uses PCC interfaces to communicate to the ACPI HW. This code > implements PCC interfaces and the functions to send the RAS2 commands > to be used by OSPM. > > Signed-off-by: A Somasundaram > Co-developed-by: Shiju Jose > Signed-off-by: Shiju Jose > --- > drivers/acpi/Kconfig | 14 ++ > drivers/acpi/Makefile | 1 + > drivers/acpi/ras2_acpi_common.c | 272 ++++++++++++++++++++++++++++++++ > include/acpi/ras2_acpi.h | 59 +++++++ > 4 files changed, 346 insertions(+) > create mode 100755 drivers/acpi/ras2_acpi_common.c > create mode 100644 include/acpi/ras2_acpi.h > > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig > index 3c3f8037ebed..6f69c9976c4f 100644 > --- a/drivers/acpi/Kconfig > +++ b/drivers/acpi/Kconfig > @@ -284,6 +284,20 @@ config ACPI_CPPC_LIB > If your platform does not support CPPC in firmware, > leave this option disabled. > > +config ACPI_RAS2 > + bool "ACPI RAS2 driver" > + depends on ACPI_PROCESSOR > + select MAILBOX > + select PCC > + help > + The driver adds support for PCC (platform communication > + channel) interfaces to communicate with the ACPI complaint > + hardware platform supports RAS2(RAS2 Feature table). > + The driver adds support for RAS2(extraction of RAS2 > + tables from OS system table), PCC interfaces and OSPM interfaces > + to send RAS2 commands. Driver adds platform device which > + binds to the RAS2 memory driver. > + > config ACPI_PROCESSOR > tristate "Processor" > depends on X86 || ARM64 || LOONGARCH > diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile > index 12ef8180d272..b12fba9cff06 100644 > --- a/drivers/acpi/Makefile > +++ b/drivers/acpi/Makefile > @@ -105,6 +105,7 @@ obj-$(CONFIG_ACPI_CUSTOM_METHOD)+= custom_method.o > obj-$(CONFIG_ACPI_BGRT) += bgrt.o > obj-$(CONFIG_ACPI_CPPC_LIB) += cppc_acpi.o > obj-$(CONFIG_ACPI_SPCR_TABLE) += spcr.o > +obj-$(CONFIG_ACPI_RAS2) += ras2_acpi_common.o > obj-$(CONFIG_ACPI_DEBUGGER_USER) += acpi_dbg.o > obj-$(CONFIG_ACPI_PPTT) += pptt.o > obj-$(CONFIG_ACPI_PFRUT) += pfr_update.o pfr_telemetry.o > diff --git a/drivers/acpi/ras2_acpi_common.c b/drivers/acpi/ras2_acpi_common.c > new file mode 100755 > index 000000000000..c6e4ed96cd81 > --- /dev/null > +++ b/drivers/acpi/ras2_acpi_common.c > @@ -0,0 +1,272 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * ACPI RAS2 table processing common functions > + * > + * (C) Copyright 2014, 2015 Hewlett-Packard Enterprises. > + * > + * Copyright (c) 2024 HiSilicon Limited. > + * > + * Support for > + * RAS2 - ACPI 6.5 Specification, section 5.2.21 > + * PCC(Platform Communications Channel) - ACPI 6.5 Specification, > + * chapter 14. > + * > + * Code contains common functions for RAS2. > + * PCC(Platform communication channel) interfaces for the RAS2 > + * and the functions for sending RAS2 commands to the ACPI HW. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +static int ras2_check_pcc_chan(struct ras2_context *ras2_ctx) > +{ > + struct acpi_ras2_shared_memory __iomem *generic_comm_base = ras2_ctx->pcc_comm_addr; > + ktime_t next_deadline = ktime_add(ktime_get(), ras2_ctx->deadline); > + > + while (!ktime_after(ktime_get(), next_deadline)) { > + /* > + * As per ACPI spec, the PCC space wil be initialized by s/wil/will/ Fan > + * platform and should have set the command completion bit when > + * PCC can be used by OSPM > + */ > + if (readw_relaxed(&generic_comm_base->status) & RAS2_PCC_CMD_COMPLETE) > + return 0; > + /* > + * Reducing the bus traffic in case this loop takes longer than > + * a few retries. > + */ > + udelay(10); > + } > + > + return -EIO; > +} > + > +/** > + * ras2_send_pcc_cmd() - Send RAS2 command via PCC channel > + * @ras2_ctx: pointer to the ras2 context structure > + * @cmd: command to send > + * > + * Returns: 0 on success, an error otherwise > + */ > +int ras2_send_pcc_cmd(struct ras2_context *ras2_ctx, u16 cmd) > +{ > + int ret; > + struct acpi_ras2_shared_memory *generic_comm_base = > + (struct acpi_ras2_shared_memory *)ras2_ctx->pcc_comm_addr; > + static ktime_t last_cmd_cmpl_time, last_mpar_reset; > + struct mbox_chan *pcc_channel; > + static int mpar_count; > + unsigned int time_delta; > + > + if (cmd == RAS2_PCC_CMD_EXEC) { > + ret = ras2_check_pcc_chan(ras2_ctx); > + if (ret) > + return ret; > + } > + pcc_channel = ras2_ctx->pcc_chan->mchan; > + > + /* > + * Handle the Minimum Request Turnaround Time(MRTT) > + * "The minimum amount of time that OSPM must wait after the completion > + * of a command before issuing the next command, in microseconds" > + */ > + if (ras2_ctx->pcc_mrtt) { > + time_delta = ktime_us_delta(ktime_get(), last_cmd_cmpl_time); > + if (ras2_ctx->pcc_mrtt > time_delta) > + udelay(ras2_ctx->pcc_mrtt - time_delta); > + } > + > + /* > + * Handle the non-zero Maximum Periodic Access Rate(MPAR) > + * "The maximum number of periodic requests that the subspace channel can > + * support, reported in commands per minute. 0 indicates no limitation." > + * > + * This parameter should be ideally zero or large enough so that it can > + * handle maximum number of requests that all the cores in the system can > + * collectively generate. If it is not, we will follow the spec and just > + * not send the request to the platform after hitting the MPAR limit in > + * any 60s window > + */ > + if (ras2_ctx->pcc_mpar) { > + if (mpar_count == 0) { > + time_delta = ktime_ms_delta(ktime_get(), last_mpar_reset); > + if (time_delta < 60 * MSEC_PER_SEC) { > + dev_dbg(ras2_ctx->dev, > + "PCC cmd not sent due to MPAR limit"); > + return -EIO; > + } > + last_mpar_reset = ktime_get(); > + mpar_count = ras2_ctx->pcc_mpar; > + } > + mpar_count--; > + } > + > + /* Write to the shared comm region. */ > + writew_relaxed(cmd, &generic_comm_base->command); > + > + /* Flip CMD COMPLETE bit */ > + writew_relaxed(0, &generic_comm_base->status); > + > + /* Ring doorbell */ > + ret = mbox_send_message(pcc_channel, &cmd); > + if (ret < 0) { > + dev_err(ras2_ctx->dev, > + "Err sending PCC mbox message. cmd:%d, ret:%d\n", > + cmd, ret); > + return ret; > + } > + > + /* > + * For READs we need to ensure the cmd completed to ensure > + * the ensuing read()s can proceed. For WRITEs we dont care > + * because the actual write()s are done before coming here > + * and the next READ or WRITE will check if the channel > + * is busy/free at the entry of this call. > + * > + * If Minimum Request Turnaround Time is non-zero, we need > + * to record the completion time of both READ and WRITE > + * command for proper handling of MRTT, so we need to check > + * for pcc_mrtt in addition to CMD_READ > + */ > + if (cmd == RAS2_PCC_CMD_EXEC || ras2_ctx->pcc_mrtt) { > + ret = ras2_check_pcc_chan(ras2_ctx); > + if (ras2_ctx->pcc_mrtt) > + last_cmd_cmpl_time = ktime_get(); > + } > + > + if (pcc_channel->mbox->txdone_irq) > + mbox_chan_txdone(pcc_channel, ret); > + else > + mbox_client_txdone(pcc_channel, ret); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(ras2_send_pcc_cmd); > + > +/** > + * ras2_register_pcc_channel() - Register PCC channel > + * @ras2_ctx: pointer to the ras2 context structure > + * > + * Returns: 0 on success, an error otherwise > + */ > +int ras2_register_pcc_channel(struct ras2_context *ras2_ctx) > +{ > + u64 usecs_lat; > + unsigned int len; > + struct pcc_mbox_chan *pcc_chan; > + struct mbox_client *ras2_mbox_cl; > + struct acpi_pcct_hw_reduced *ras2_ss; > + > + ras2_mbox_cl = &ras2_ctx->mbox_client; > + if (!ras2_mbox_cl || ras2_ctx->pcc_subspace_idx < 0) > + return -EINVAL; > + > + pcc_chan = pcc_mbox_request_channel(ras2_mbox_cl, > + ras2_ctx->pcc_subspace_idx); > + > + if (IS_ERR(pcc_chan)) { > + dev_err(ras2_ctx->dev, > + "Failed to find PCC channel for subspace %d\n", > + ras2_ctx->pcc_subspace_idx); > + return -ENODEV; > + } > + ras2_ctx->pcc_chan = pcc_chan; > + /* > + * The PCC mailbox controller driver should > + * have parsed the PCCT (global table of all > + * PCC channels) and stored pointers to the > + * subspace communication region in con_priv. > + */ > + ras2_ss = pcc_chan->mchan->con_priv; > + > + if (!ras2_ss) { > + dev_err(ras2_ctx->dev, "No PCC subspace found for RAS2\n"); > + pcc_mbox_free_channel(ras2_ctx->pcc_chan); > + return -ENODEV; > + } > + > + /* > + * This is the shared communication region > + * for the OS and Platform to communicate over. > + */ > + ras2_ctx->comm_base_addr = ras2_ss->base_address; > + len = ras2_ss->length; > + dev_dbg(ras2_ctx->dev, "PCC subspace for RAS2=0x%llx len=%d\n", > + ras2_ctx->comm_base_addr, len); > + > + /* > + * ras2_ss->latency is just a Nominal value. In reality > + * the remote processor could be much slower to reply. > + * So add an arbitrary amount of wait on top of Nominal. > + */ > + usecs_lat = RAS2_NUM_RETRIES * ras2_ss->latency; > + ras2_ctx->deadline = ns_to_ktime(usecs_lat * NSEC_PER_USEC); > + ras2_ctx->pcc_mrtt = ras2_ss->min_turnaround_time; > + ras2_ctx->pcc_mpar = ras2_ss->max_access_rate; > + ras2_ctx->pcc_comm_addr = acpi_os_ioremap(ras2_ctx->comm_base_addr, > + len); > + dev_dbg(ras2_ctx->dev, "pcc_comm_addr=%p\n", > + ras2_ctx->pcc_comm_addr); > + > + /* Set flag so that we dont come here for each CPU. */ > + ras2_ctx->pcc_channel_acquired = true; > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(ras2_register_pcc_channel); > + > +/** > + * ras2_unregister_pcc_channel() - Unregister PCC channel > + * @ras2_ctx: pointer to the ras2 context structure > + * > + * Returns: 0 on success, an error otherwise > + */ > +int ras2_unregister_pcc_channel(struct ras2_context *ras2_ctx) > +{ > + if (!ras2_ctx->pcc_chan) > + return -EINVAL; > + > + pcc_mbox_free_channel(ras2_ctx->pcc_chan); > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(ras2_unregister_pcc_channel); > + > +/** > + * ras2_add_platform_device() - Add a platform device for RAS2 > + * @name: name of the device we're adding > + * @data: platform specific data for this platform device > + * @size: size of platform specific data > + * > + * Returns: pointer to platform device on success, an error otherwise > + */ > +struct platform_device *ras2_add_platform_device(char *name, const void *data, > + size_t size) > +{ > + int ret; > + struct platform_device *pdev; > + > + pdev = platform_device_alloc(name, PLATFORM_DEVID_AUTO); > + if (!pdev) > + return NULL; > + > + ret = platform_device_add_data(pdev, data, size); > + if (ret) > + goto dev_put; > + > + ret = platform_device_add(pdev); > + if (ret) > + goto dev_put; > + > + return pdev; > + > +dev_put: > + platform_device_put(pdev); > + > + return ERR_PTR(ret); > +} > diff --git a/include/acpi/ras2_acpi.h b/include/acpi/ras2_acpi.h > new file mode 100644 > index 000000000000..5e9ac788670a > --- /dev/null > +++ b/include/acpi/ras2_acpi.h > @@ -0,0 +1,59 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * RAS2 ACPI driver header file > + * > + * (C) Copyright 2014, 2015 Hewlett-Packard Enterprises > + * > + * Copyright (c) 2024 HiSilicon Limited > + */ > + > +#ifndef _RAS2_ACPI_H > +#define _RAS2_ACPI_H > + > +#include > +#include > +#include > +#include > +#include > + > +#define RAS2_PCC_CMD_COMPLETE 1 > + > +/* RAS2 specific PCC commands */ > +#define RAS2_PCC_CMD_EXEC 0x01 > + > +#define RAS2_FAILURE 0 > +#define RAS2_SUCCESS 1 > + > +/* > + * Arbitrary Retries for PCC commands because the > + * remote processor could be much slower to reply. > + */ > +#define RAS2_NUM_RETRIES 600 > + > +/* > + * Data structures for PCC communication and RAS2 table > + */ > +struct ras2_context { > + struct device *dev; > + int id; > + struct mbox_client mbox_client; > + struct pcc_mbox_chan *pcc_chan; > + void __iomem *pcc_comm_addr; > + u64 comm_base_addr; > + int pcc_subspace_idx; > + bool pcc_channel_acquired; > + ktime_t deadline; > + unsigned int pcc_mpar; > + unsigned int pcc_mrtt; > + /* Lock to provide mutually exclusive access to PCC channel */ > + spinlock_t spinlock; > + struct device *scrub_dev; > + const struct ras2_hw_scrub_ops *ops; > +}; > + > +struct platform_device *ras2_add_platform_device(char *name, const void *data, > + size_t size); > +int ras2_send_pcc_cmd(struct ras2_context *ras2_ctx, u16 cmd); > +int ras2_register_pcc_channel(struct ras2_context *ras2_ctx); > +int ras2_unregister_pcc_channel(struct ras2_context *ras2_ctx); > +#endif /* _RAS2_ACPI_H */ > -- > 2.34.1 >