From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF1FDC54E58 for ; Tue, 12 Mar 2024 19:33:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3924D8E0010; Tue, 12 Mar 2024 15:33:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2992A6B009B; Tue, 12 Mar 2024 15:33:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 13AC26B00A1; Tue, 12 Mar 2024 15:33:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F2FF16B007E for ; Tue, 12 Mar 2024 15:33:10 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9BA01C0D2C for ; Tue, 12 Mar 2024 19:33:10 +0000 (UTC) X-FDA: 81889385340.30.D4243BA Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 17A6318000B for ; Tue, 12 Mar 2024 19:33:08 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LqyDIbGj; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710271989; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kubIgq/GdbJcvxgMJi1o1EH2/AWxnGiUKA6KgBSz0r4=; b=yrWQ1kY+WQVZo1ySrrUg560eRZXVRiViNDI2Sp8LBws8rGCS2xGWl5ZrkskmwwLtvdvFHI XxPdejOkLYIEbxRlZvnxyBqx0AxEdmV8JOejekkSeC6WHkIN6KpZiMICe+dyjXRD4KSYrg kwtCP309GBqDWLielDR6N5ttCMs2rjg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LqyDIbGj; dmarc=none; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710271989; a=rsa-sha256; cv=none; b=3DReTNq8yCM1mB7aixx0l3GLd6f03amh0O6IyvMUwlTTq/IZ3qOwprUCMi2P/t4/H94W3d Sc8oWEsJG6yV+Cm4AlJKL7h8II8fQTtv2I4C7CDdFOke93BAIO3Uh9M67sFaOoVnBNH/bs qEaQt/FjV7ayizqfTvvk+q1UXDR2iFU= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kubIgq/GdbJcvxgMJi1o1EH2/AWxnGiUKA6KgBSz0r4=; b=LqyDIbGj41wCOr/hh8HuGexIVM hKJs36dID9db94U5lPlL9RGQn4OGs56qUagNn3RN+BuhkHxSkWAPv8LGx46v43R6a3VnNNgJxraVA +oXI0XYJZEqr19DPK5pVw8C/rg4Xr0YPEjUebI2nI6xHRWb1ToC+vCRSA18CirbJbRCLKk/Bkf0TN SCijgrPz2C4jqtXvHv5z24xlvun8gekZrgxKprK3c3AC1DesTU8q4ym1m+mKVMZWhm117BGtWNXrp CF25rtoQzkJ++o1FL6ZsOlOnOP2JVkBHTbKIYNyEXpjm2ktIWzW6KeM25jO7j79hGY9+U5WuRoC7w 0/+4mblg==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rk7rt-00000003k5Z-3F5B; Tue, 12 Mar 2024 19:32:57 +0000 Date: Tue, 12 Mar 2024 19:32:57 +0000 From: Matthew Wilcox To: Roman Gushchin Cc: Vlastimil Babka , Linus Torvalds , Josh Poimboeuf , Jeff Layton , Chuck Lever , Kees Cook , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , Alexander Viro , Christian Brauner , Jan Kara , linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH RFC 2/4] mm, slab: move slab_memcg hooks to mm/memcontrol.c Message-ID: References: <20240301-slab-memcg-v1-0-359328a46596@suse.cz> <20240301-slab-memcg-v1-2-359328a46596@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Stat-Signature: miczcsqkdmbhn9wcgp39bgtjrag8whze X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 17A6318000B X-HE-Tag: 1710271988-823747 X-HE-Meta: U2FsdGVkX1/kHJtv+cWs9g/nNa2gV3X7PGSmC16Ch/dbEidIRmi+4r9HQWMDgle73TN3y2m6zyunpwQfPawZtHmMnN4Bcqex0ilh+30anEg2XMH+ygZ3zJ8JdlL1AIm/f4TTeJ7S0Ll2Xb3UOqndgZv2m8yGy1+2OvZb440JoMysumv1fFC9POwdKDG9GyY1bcbnOWiJ25GSphTuc5Bry67O+Ih+71DraEOPlxyoTBx2efznOn3YkVsGjAWKMy8N0tW07f5kuLMAGyEr/otdZO7GrwrgUYl45MDr8F/9sXUgnOUxIv729C6rluzj8ZxTV1su87c9fRVp65tWpXWlndb75LetW7vBwUqtxVVU6jsesfz9CNirL17i3ukW99GJQbPV0eHRLmIMPUtZh3sQLHyZACu5PJ/BuL8dqTxATCGCmx+uDcs5fOdq0s2jhfELyCHJLVmgCh+WHX1Y8V3nt62SFta+bMANA6NsuFQbDzr5sqimsGnfeUcSfHtxUB35tnglfTIpDiuE2wg7INjzRnE5oDzZ0J3e6kgsP357pErsu8r7ne1/QuAv+xQSeepRRnsbfO4+Jzy+0eSp7jqfPNVNNysHgpaP2LDiXYXiz1L0LsD0ObA1i79cLP0MbX3GOn3GzrHmeIsI8xGtkMnvs6p9I5od3g+gWRao7+TpYLi7jG6fIG1W2xJZgWHAlJJUIzAvVMBEIf0RXUTMyyLsMEoGRCqHauz8L9TpKMhuTHkpLlAbQ0WZFtuIa+D2GNI43VHoMfXKqkBT3ich87aVlv5c48vc89PyoO/YxRkJMei34or+QBzq9b/zs+zUMewDX6nDamXaGRNpuBCzqBcgL5Pxi9MQAM9TMqBPbcnZSOnoYZdoiIAcQ93Lmhxehtagxs8zt2lX5dEYhRWZQpAgPSHgKqtpq5MLOd3pxi2ZCBAMugbv/AZtBtkd9Of0GBF9PFccwjO/XrE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 12, 2024 at 11:56:31AM -0700, Roman Gushchin wrote: > On Fri, Mar 01, 2024 at 06:07:09PM +0100, Vlastimil Babka wrote: > > The hooks make multiple calls to functions in mm/memcontrol.c, including > > to th current_obj_cgroup() marked __always_inline. It might be faster to > > make a single call to the hook in mm/memcontrol.c instead. The hooks > > also don't use almost anything from mm/slub.c. obj_full_size() can move > > with the hooks and cache_vmstat_idx() to the internal mm/slab.h > > > > Signed-off-by: Vlastimil Babka > > --- > > mm/memcontrol.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++++++ > > mm/slab.h | 10 ++++++ > > mm/slub.c | 100 -------------------------------------------------------- > > 3 files changed, 100 insertions(+), 100 deletions(-) > > Reviewed-by: Roman Gushchin > > Btw, even before your change: > $ cat mm/memcontrol.c | wc -l > 8318 > so I wonder if soon we might want to split it into some smaller parts. If we are going to split it, perhaps a mm/memcg-v1.c would make sense, because I certainly don't have a good idea about what's v1 and what's v2. And maybe we could even conditionally compile the v1 file ;-)