From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C79A1C5475B for ; Thu, 14 Mar 2024 03:51:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F9858007D; Wed, 13 Mar 2024 23:51:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A7BD80073; Wed, 13 Mar 2024 23:51:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED9098007D; Wed, 13 Mar 2024 23:51:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DEC4480073 for ; Wed, 13 Mar 2024 23:51:44 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id AB26B1A1150 for ; Thu, 14 Mar 2024 03:51:44 +0000 (UTC) X-FDA: 81894270528.03.6D01B34 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 74FA780015 for ; Thu, 14 Mar 2024 03:51:42 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tKmCdHbC; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710388303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E4qw+GY1h7gcuj7BsZx7TubbbqWTwBNYEqu/xCFTI0Y=; b=XW8qIDAECzHyvixCRFq3P9QEbC121noIaEBnvhZm4Ucdf7d55uaGCzKx4b2Q+o6BTElQX6 awVvVk6+ey0PMtuEML5txw5pFQapqQYM3Sqckl1aLdFVd5ZWubYwYTb67B/luzJR4Jkx8V 4g90QBw/AbU0rruuaCWTMiLFNd+PDSc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710388303; a=rsa-sha256; cv=none; b=ZGTz028bOYLRDA5KLVn+3+/CRwo/sUk9KZyJcXrtVM22kUWdDQ9IETFEYTEjza73JB9BsL C0kxfAc7hihKbvtTL0aZxeQ0Y2Xl2mAtGfOJDgrjzHcCqeI01X2QoYZkGan/YwPM0dUxqa IadURBnGkSIM6C/o7q9iJYwwkeB0X+c= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=tKmCdHbC; spf=none (imf30.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=E4qw+GY1h7gcuj7BsZx7TubbbqWTwBNYEqu/xCFTI0Y=; b=tKmCdHbCfvNv6NZPcWFhDxxQkw Wo/qXos7RFuyhaKWWBBU8uoSlidKHJg8us5jg/wig3MjujnRUwgfL80xj/lrKcNs+LSqZ4hxh9FOi j/9x0arGTqhezDDoquHMnZhPols+OEU9YjVfUWE3rlFpHfNlJwUx349Y6P0knQfk976wNRi+yBNWL 5FM8zR0laLJnnkyFVwtaG0Pb80XI4zHDvy6n7i+BpWle5PQc+AScGLJ3Ry+dSNCNEMM9sXumVspEV g399GV3IC1GGh0EeTw7KlqCuQ6SuMqHAgOxHUK0XQ/Bb6v7pVRdFUzRemFvJMW7A0rEXzNr/UXYwH heIjN0vw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkc7y-00000006yKl-0hav; Thu, 14 Mar 2024 03:51:34 +0000 Date: Thu, 14 Mar 2024 03:51:34 +0000 From: Matthew Wilcox To: Jane Chu Cc: Andrew Morton , ruansy.fnst@fujitsu.com, linux-mm@kvack.org, Miaohe Lin , Naoya Horiguchi , Dan Williams Subject: Re: [PATCH 1/8] mm/memory-failure: Remove fsdax_pgoff argument from __add_to_kill Message-ID: References: <20240229212036.2160900-1-willy@infradead.org> <20240229212036.2160900-2-willy@infradead.org> <35c987d6-e78e-41df-a157-cc764245fa30@oracle.com> <317bf68f-317a-486a-934c-18f2dca5fb2b@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <317bf68f-317a-486a-934c-18f2dca5fb2b@oracle.com> X-Stat-Signature: zp3y1191pd7p6w4e6u1seb3brh64pu7w X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 74FA780015 X-Rspam-User: X-HE-Tag: 1710388302-177911 X-HE-Meta: U2FsdGVkX18VnVNDQ4fh8yfrm0TVgeHf9GCsLUDv38aCJZ4yt+Djgpqh32zO0SMpJV8+B/zT3ANfOZF+09mWBv8lB9jkvTur4GPJTZOE418/de+j8Ra72pDYBS6fiGoa/MMkCw5nF47Uu7ptKejJUYV7sdo3ba7SstsymzLtvEHZiQnRPkxtYf5rGIApj7fL/AktKgJ3Y56S1HkSQj5x5z5XqyArPzh1pK2BezyBqn+mZmjlU62W7yIIWMh33Mo7WFHO07q0cE8sUul0vf/dHMMk8spIMX4aj+Ks2XGYHJdjItlcraBNoFzg0vQGHF4AaZvEFikUaOWQEytpwBLAGj0XavLSu2smv0xW5PeprrJr7OL7MwgTlWNpzZISt3xNJW6XG9Krj+kGEJ8U3EcjBp5cEWCySMgzB80Xo5n0Q1BOUbqnK6PLQUjNDS8/425ENQZqSpeQCzmhG03K7Qk82RRVuytloCSAU5emQh1fVJPsORrc70hs+9+qcdmMtFjEdfQYez45XXx0EE7CS1LIazbOP0ldo4SHE8cgt9oTKPeimFkCA52hjIn4H+KD0HRnbYfNnH9kH2S/NF7/pRwHg50HdAnlk+v/7cti3Q6C5nM5goCuUJ35Lk2LsBdxt3fGeR0ulbxqoC3vw2iKTgIgGi8fsPcsC8azX2DW0ZKj9TFJCsOnC0CXIFQgKZBj4o92HIs3PVV0URhzqFcUBvbc1PMB6CoDEe0g/Bk1kBMgNHqJYvt03EuBrh3zTftSHEwrClqW1hOJ80dD33R16O9aqJuB5eydjprGmppFASJokCNdorelWpPUJJccgITYYIm7w23UGf1pgd78ZQdCMoxFy9F+wNR8qKUM/MWiL3nf2rIPHdmr9csyixuWMaBq+HRU X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 13, 2024 at 11:11:04AM -0700, Jane Chu wrote: > On 3/12/2024 8:23 PM, Matthew Wilcox wrote: > > I don't understand what you're saying is wrong with this patch. > > All I'm doing (apart from the renaming of ksm_addr to addr) is moving > > the vma_pgoff_address() call from __add_to_kill() to its caller. > > Is there some reason this doesn't work? > > Sorry for not being clear.   What I meant to say is that, before the patch, > page_address_in_vma(p, vma) is the means for determining tk->addr, except > for fsdax when filesystems made a claim of wanting to participate in the UE > handling, in that case, vma_pgoff_address(fsdax_pgoff, 1, vma) is used > instead. The difference between the two means is that, although the former > eventually calls the latter _if_ vma->vm_file->f_mapping exists and is > stable, what I am unclear from Shiyang Ruan's earlier patch is that, he > seems to be concerning a case where f_mapping is not reliable, hence his > patch went straight to call vma_pgoff_address(fsdax_pgoff, 1, vma), and on > top of that, providing nr=1 to ignore the address wrap around case. > > So I don't know whether removing the fsdax special case is okay. I don't think I'm removing the fsdax special case, just moving it. If I subtract out the renaming from this patch, it looks like: tk->addr = addr ? addr : page_address_in_vma(p, vma); - if (is_zone_device_page(p)) { - if (fsdax_pgoff != FSDAX_INVALID_PGOFF) - tk->addr = vma_pgoff_address(fsdax_pgoff, 1, vma); + if (is_zone_device_page(p)) { ... { - __add_to_kill(tsk, p, vma, to_kill, 0, pgoff); + unsigned long addr = vma_pgoff_address(pgoff, 1, vma); + __add_to_kill(tsk, p, vma, to_kill, addr); } So instead of passing in '0' as the addr from add_to_kill_fsdax(), we do the address lookup in add_to_kill_fsdax() and pass it in. That means we don't call page_address_in_vma() for DAX because addr is not 0.