From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62719C54E5D for ; Fri, 15 Mar 2024 03:32:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C6FD0800F8; Thu, 14 Mar 2024 23:32:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C2020800B4; Thu, 14 Mar 2024 23:32:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0E9F800F8; Thu, 14 Mar 2024 23:32:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A2393800B4 for ; Thu, 14 Mar 2024 23:32:25 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 6D415160B3C for ; Fri, 15 Mar 2024 03:32:25 +0000 (UTC) X-FDA: 81897850650.09.D1D710C Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 58A6D180008 for ; Fri, 15 Mar 2024 03:32:22 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Dg1GUQdd; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710473544; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xad6TWdMoCDKHkALF6smFbmrqhCsydxlR9/cUgdVc/A=; b=iLdp/RAAIUW51+53wzD0V/4yeYGDGLYEtRI1XCxtb3jL7rT9/TmQZGogtwJ15IPoin57l1 kW+ciEE1CTJZZdHSTlap1xlCePLYmewr5KimCes0vjWuogn2gNRPTo59awoiSUhudfDDcT kNXNhK0/I6ClPF2HRLi5hjHFd5Gxibg= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Dg1GUQdd; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710473544; a=rsa-sha256; cv=none; b=mGkZ9tkxfSUCuXqTGe0iwUOhXMxlu6kMZs7kOUb+x8nksBLU/2Rx8AkcWx5t97vgF78B/N GNriPNDA8Ku75eGA4Tmrh9xEaHd4UniQvnyLWBFSXKESH0oRyP6tyHYoV3zkBYmOqNGcVp 61ajfGpK7mx2kWz9O3ypxJO7/OANyX0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Xad6TWdMoCDKHkALF6smFbmrqhCsydxlR9/cUgdVc/A=; b=Dg1GUQddeltBm36mqGgTIuCRNm sSXQfxqSRXod/5TL7O9KLuAPUTAAP4l/ZxtMRPtwMkv1Xz1md29Zsy4VIcfz1q4HMLOkJEjyVNXms yhHMm7bKxYbh70eg/g/kaTytL4hmggcwgf8+3si4c1qxU+joJ//Y7uokTYlkxHo+06fSAs0ptd48e UDWWzqiqWgm2qlRaG5O81hbF/VaamV/qlXlCbX2a32DJRdj1t6qRwIG3GIXywMjTxy/fc6g4WzB11 nCOUMZq4ldpo8KFOgZQk1uRQ6iJnOC4uUaNM3SL8elrqqAkDFZLk09uYUqAawtoy6aomE69VlKVea D80ilLQw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rkyIl-00000009Lp3-11Ss; Fri, 15 Mar 2024 03:32:11 +0000 Date: Fri, 15 Mar 2024 03:32:11 +0000 From: Matthew Wilcox To: kernel test robot Cc: oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , David Hildenbrand , Mel Gorman , Ryan Roberts , linux-mm@kvack.org, ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com Subject: Re: [linus:master] [mm] 99fbb6bfc1: will-it-scale.per_process_ops -4.7% regression Message-ID: References: <202403151058.7048f6a8-oliver.sang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202403151058.7048f6a8-oliver.sang@intel.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 58A6D180008 X-Stat-Signature: 4iu6gc3fi9petfi9b1yf9rjhbwk7xqsy X-Rspam-User: X-HE-Tag: 1710473542-444533 X-HE-Meta: U2FsdGVkX19hI7bhbIeo72lK7z0twsA+o2wnl5ZVaf6fyZc0RPyj2KitWkW735gSgS1HKIT7K7DTOgFhMQP2qD9qKyTqle5YEO0uZn8vn/UxPDLyWo9n9+UrYIdZey2nbLBLBEWKKXqJhbQTTx0fLKUf6lGQzs9fqGYwc6l9/x9FQA2DFRVl1eoQCxQIyLXGRDZuhaC1KQp/3snMu07DcnWXGyl7zrBajWs0syqYPJ+lAL3pSS6KA/kwds0/QYEUf6Gwt69JvkLhbY4R3zVnys2C08uceWbmmHAvNRAbBNwi52wlH7ilZGDciUmdfy1y9t2Q/gowoFHcXWYXIE5QVDT8QUl5hx+MoJ97KQzTLKs+L4NquBIodpmPaO9xUOex6jHExPUpNUvm1uccqj4k6in2fTf2brutpCtC23Z6i8JbN3trPej12+3bGVS9LwYRZK52oz5AO4aHZ2mN0hIOOHW1QIq2Od1Wb1xPuqqijLN54x2OuI563L7O8wsboEdB/x2y/lRg7kEVpUP2IJ0MTe4zJYgQgmecyTgbhKeaKmy29R3Qfwm6r3Klq3Sb/wrGNzw33oaUs8nue8V6nnEaoSgaWUuAyAazCNK93oaEQ9ybNFZZ7yt7aO5kWw7g7UP7HBY08KUUk1XmSo/VA8OJMhZlyXJjbi/XBdvpS9HCcfXnTvNpK01vBLh0meuOsreMKfe82wNkjF7gNngnCIqkHaOP1YqznKEMQhAoGQ56awvyD3ZOsuKHkqT2i4boA4SisNaBtwhbRjb1Y3pvlOuECDBV/c5RWxgMlHNV6/lXCMjzIvZUNZvDIt/fyctVF1tvRNxC9mmDEnu2jyOnUSTvM0ox4uuvRRp82R6t5hX8fy4OgMzlx0LUOTvGT/oI4QCP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Mar 15, 2024 at 11:07:58AM +0800, kernel test robot wrote: > kernel test robot noticed a -4.7% regression of will-it-scale.per_process_ops on: > > commit: 99fbb6bfc16f202adc411ad5d353db214750d121 ("mm: make folios_put() the basis of release_pages()") I was kind of hoping you'd report this before it hit Linus' tree ... I did post it last August without any response from the bot, and it's been in Andrew's tree for a couple of weeks. Is there a better way to draw the attention of the performance bots? > testcase: will-it-scale > test machine: 104 threads 2 sockets (Skylake) with 192G memory > parameters: > > nr_task: 100% > mode: process > test: page_fault2 OK, this makes sense. mmap(128MB, MAP_PRIVATE), write to all the pages, then unmap them. That's going to throw 32k pages at the page freeing path. Can you add this patch and rerun the test? diff --git a/include/linux/pagevec.h b/include/linux/pagevec.h index 87cc678adc85..67f10b8810a8 100644 --- a/include/linux/pagevec.h +++ b/include/linux/pagevec.h @@ -11,8 +11,8 @@ #include -/* 15 pointers + header align the folio_batch structure to a power of two */ -#define PAGEVEC_SIZE 15 +/* 31 pointers + header align the folio_batch structure to a power of two */ +#define PAGEVEC_SIZE 31 struct folio;