From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5206C54E58 for ; Fri, 15 Mar 2024 14:24:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DB4F8012E; Fri, 15 Mar 2024 10:24:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38B75800B4; Fri, 15 Mar 2024 10:24:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 253528012E; Fri, 15 Mar 2024 10:24:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0AA95800B4 for ; Fri, 15 Mar 2024 10:24:45 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9F4A8120404 for ; Fri, 15 Mar 2024 14:24:44 +0000 (UTC) X-FDA: 81899494488.06.DC04D3E Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf26.hostedemail.com (Postfix) with ESMTP id 1C23C140019 for ; Fri, 15 Mar 2024 14:24:41 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=g6icv7vD; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710512682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VRGW8z0NhLdznShUoOOXXxWys2yQ2J3P11bCMfJSNHA=; b=gK65oPYkwd95BESfUQZX0utkZJVAb0tGfn5lwjUlUoKKHLbNoqxp4Wx/nVmiV0hcs5ywt8 F9uoEgQ/5N6BIWbMJkWyAz00iJ72M5bY/n0+9tHzb0ce2weS8d9KQ6sVHh+UMJVzSj/31x vngYxsDIC088cQslhVbPtURvLimJ3vI= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=g6icv7vD; dmarc=none; spf=none (imf26.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710512682; a=rsa-sha256; cv=none; b=cho4664ZC2xVcI9y9eEb8Ybe/E3fmUIhZxgN4BPLbaLHQeSstZMVii+qqkJ7ef6p7KyiSW IZHneSXR1L1ulqZLL5ocDCQnJ5+ZCoVItx3Pu9SlWmPrOKnzP7y/AxErG3CvJlTjn5XHYH PY/UsyuUCu3u8lON1/IuKJoO35geSms= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=VRGW8z0NhLdznShUoOOXXxWys2yQ2J3P11bCMfJSNHA=; b=g6icv7vDDLgeuYr8NztGa/YyRL qFIBEY0IPpP1+bYI49n7SxU4bgxjkR3IrM9+Be4Fri5gtC1NtP3VH/d1pGvIeP1i2RlnVDiZtoJZn udcdVqfzdogl745CVcYKrrixMkz8s/WeJyK34trcBUP489ORyWp6kWDYJ43k+tSGlRwYJpnF9jjEa 6ROrZUs/r8mqk2pR6H8I00TlCDMwoZm7KXZSFrVn3W8HTtptAlIsHnKm46b0orWAfeK+lJbYXrim+ BdImz0lHoczac+PwFVjN8iCsjg9amJPItwdzikKwlWk9QjADmbcL4kAKoXNzxRHdIITfu2bZ5K/8d vQqsjzkA==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rl8Tc-0000000AQWv-1Isj; Fri, 15 Mar 2024 14:24:04 +0000 Date: Fri, 15 Mar 2024 14:24:04 +0000 From: Matthew Wilcox To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, kent.overstreet@linux.dev, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, jhubbard@nvidia.com, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, aliceryhl@google.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v5 14/37] lib: introduce support for page allocation tagging Message-ID: References: <20240306182440.2003814-1-surenb@google.com> <20240306182440.2003814-15-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240306182440.2003814-15-surenb@google.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1C23C140019 X-Stat-Signature: ybi7bpe3bsj4ukmwnpnzxeqpd35556ps X-Rspam-User: X-HE-Tag: 1710512681-438569 X-HE-Meta: U2FsdGVkX1/j8BT7YftL/LReRi5c8h6Y2q8f29Xv/FFDSnPpjDDm7bjPVUCPCNUSyua4zV65E4Dz4VIKmd9ybrzUHEkg9WH58po0PoDYpHl/B6uk8231IWMwVJcRNoqKSjiRQ3LEB/OMR5yj3/7NBDnZXoLhdFKinoJc6HhiQv/pBSZSODMKgIOQiydJBmoxRYVuNPeQqK4MQpkpXDDKgz9aW3fiGigMCAZzLH7oFfaguAIbqN1EuzBJvd7cF2JaQdqDqAb1+HjastIUXTH9gBpC6VlNLD3DjPGmGddShgOuXM15xoXpMEp6B4NSh+6pkoIdxmPsENncKWe/u30kaf3yRrO9VI4Mbb0YrFbg/13BNAMLD/5Sn+GoVwKuF4tGzd99M0f7AUm18TSsCFseuIBruM545v5zQMjo3FtukrSXn+8bDhE4XX6BSu+uL+TvR3oRYQaU0jx2+Wk2Ew6bvRCH2RA6/pxUsXdt91kmzonktkkahS1ZuY3epgyZbG2Y2RtUizYaMOON1T4xgR8HyyNYZY2Z/M7GaByi6U22xe7TXSUbjjserncQv0smOGHSR2Ze9RkH4VDY7H/JiXKyCrwe3s6XMqrHNOIyQta15+yGMoiqtW+k1Q6u9wOHQVCFZ3NKFIvO386xGocGcbl76CMGCecjFgdxXfSUU77yrZddz5vEidyhpo5TGe8xjcZBcaDYXMnl95v4ahHpygeOfXgGoIK3eKrVoI6VbMWWefAHyuWxoMBNuGdVT8STetHZq+f7oqgBlk+u4DEQyRROfgt7lD9P+aQs+Q8zHlFa2Ou+vOVTBhINpa2u1RKxBb5tb0FDlWhnNOYFGrLR4OMDUe1EyWIplvIhcDdhwr2yrREXfgeYnPQ+uc4EVP8SVVZmqe9/zkBZuTlWYtGrasaGrfdQYEgs/bjl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Mar 06, 2024 at 10:24:12AM -0800, Suren Baghdasaryan wrote: > +static inline void pgalloc_tag_add(struct page *page, struct task_struct *task, > + unsigned int order) If you make this "unsigned int nr" instead of order, (a) it won't look completely insane (what does adding an order even mean?) and (b) you can reuse it from the __free_pages path. > @@ -1101,6 +1102,7 @@ __always_inline bool free_pages_prepare(struct page *page, > /* Do not let hwpoison pages hit pcplists/buddy */ > reset_page_owner(page, order); > page_table_check_free(page, order); > + pgalloc_tag_sub(page, order); Obviously you'll need to make sure all the callers now pass in 1 << order instead of just order.