From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6C21C54E60 for ; Sun, 17 Mar 2024 21:14:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2FE26B0082; Sun, 17 Mar 2024 17:14:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDEA96B0083; Sun, 17 Mar 2024 17:14:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA6656B0085; Sun, 17 Mar 2024 17:14:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C7AF26B0082 for ; Sun, 17 Mar 2024 17:14:20 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 7E4B81A06B7 for ; Sun, 17 Mar 2024 21:14:20 +0000 (UTC) X-FDA: 81907784280.17.0870BCF Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP id A60F91C000D for ; Sun, 17 Mar 2024 21:14:18 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Y+s2Jfnv; dmarc=none; spf=none (imf20.hostedemail.com: domain of BATV+d5a73260bc9d3f54033b+7511+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+d5a73260bc9d3f54033b+7511+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710710058; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TCCmjmMAc3H/rSZhFRq2kqhRinVJ/Se0iD+aRpD6GuU=; b=oR9+PT+E9IOsZXIf4H2mL71j/+wuiDe6/gmGkZSUc7VEnaqlRASsjGju7skYzorbRxlIml a95C5soSZG3aDdxPMY2W4F2mBEsA4r2e8WP7jYy0iissJ33KX4WJ3dbykAOWZVEGD8UAut oBIJkin6JPdlHMu23jSjX/6GnBl5txI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Y+s2Jfnv; dmarc=none; spf=none (imf20.hostedemail.com: domain of BATV+d5a73260bc9d3f54033b+7511+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+d5a73260bc9d3f54033b+7511+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710710058; a=rsa-sha256; cv=none; b=R0D0GzRpRCBR4vt96T8La3hwm25Ry07dxDo2Ki3iX0zxY7BP0Bj4VZw6+PylCcnG47Irmj V/ld+8Hj0NGnUEAaaJKKreHQX85WjC8KOcLu4WVidggHGllckGcB7FI9xVSvRWzNwzlMPZ lQlYiXL2eW9fD6l7+AIEzMqNx0IyY3k= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=TCCmjmMAc3H/rSZhFRq2kqhRinVJ/Se0iD+aRpD6GuU=; b=Y+s2Jfnvr1GLntBNxWu27Jxf7r Wl9Ub4lVpPOUypbTjnBC+PBWROjTPqYdu9guU+7sjnvvPKPAmHlVWrGd/JvTxIsfnP5nkKc7nZk2D JvND9qqmwDaL5NFzTKsQ+uH9fPkT7X6FlhiNpDrBX7xPyv3BfYA+G7j7W5JUFihtKZdPf0ly+dhtr 3BE2QeOkdrUjKSi9FLjBDX83/mbLQuwsyvlw6kodbTOfJEncYgRdSVrq9EHtC1ny6UQx1auhY7IFU 398h8AA7lT8A6PXWAhQVo/0tDvO8WLde6MlcnelOSsTLKMxD9w6HejJOFWYHrU9Pc+FqlHiJoJOxO avXmaxgg==; Received: from hch by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rlxpg-00000006SyX-3HQ5; Sun, 17 Mar 2024 21:14:16 +0000 Date: Sun, 17 Mar 2024 14:14:16 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, fstests , xfs Subject: Re: [RFC PATCH] xfs_io: add linux madvise advice codes Message-ID: References: <20240314161300.382526-1-david@redhat.com> <20240317165157.GE1927156@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240317165157.GE1927156@frogsfrogsfrogs> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A60F91C000D X-Stat-Signature: i9uawoaz7m9pmj99jjzm81wqye4jugcn X-Rspam-User: X-HE-Tag: 1710710058-864883 X-HE-Meta: U2FsdGVkX1/rEPz2U8HJKyc/wj5d0MEVpISunHoSQCFmkbFycMooiqyDzZF/M6KnBmtDCktly+T5XtscnXeRLN0Yl38tb8otZDqJay0jveHwu9s9MNausP7hWtoCd5P9l9FTQaxM+Kag2suROWZRR6sNl1w5TDnIheWLUJKIvT4R8ePk+uSBAG4dOeARfeMUFdbeLFwOHmZbGmaOqXXFr4Dv+LjvYoLR2oe6PLAlkhQ3GxDwHzH2tLF2y8VcdWyj9syaIHmIYUJN6nDI9U3FSz4Sa3gYiqdIyFt5w67kRrm0qp4AfJqaLg/jPtDLknP4m4QnMW/DjSKJrIq8u7CNUsEUK3rkTae8//BkB/10Zli7nm+SX+HAok/KJHTb8vaZjYq2L4QtuA2mH7YZWsyMSa6S2O/qENFWyYar2Dq79abwwWXh9/qb37Y37hyf0pVaBs69L/EO15WgJ2Xb0e90FzVvparQco1cWimF+WV7mSlhojEHOS8unXD/Ify6JIVM1PevjeAeYB4KiduPDkDwtdtJKhuqIkVCVI6WfhjbPChWu8xChKE4her0gkKNiQ5h1Q2PWd1cEMaD0xI6L7IKl+kMfrynTtKFW4KxG9uYO9ws9lifHqm6ibaTZ21nqSavStJOZlzoEsMBowJUh61TnSV2LXap4OO9F5evmeJe7pZvBOknRC3eXUmypYWACZhumHaIYNFJgvowHbUN2D/+WGnyqwVXUA2mQ7u1bnjQBsSmSLTtOBCGZIVj3nCxHE114XcYV+ltvcxOID6FgUXQn20yLi9sce1wQdOHekVD3lFP1M9pJJDaU22GuSM1EpKiW8uiM/MS58BRclHkfg8gCQm9gDBGByH90eI7MzToyoWt3qWd51HnvQXPdbXspLTAOKDF+jQag7Xj1U+paAlVVGDkfqGb7wyoUEF5+1kjNYW+3XUl0mHkvL52H3GKU0/Sq1KtKzFxkrSf+p0qmAj yPQCxDDv scofSRKM8fPvjDqnQEFFM64akqx7XbJyI2JN7jlu/tb+Z8zMbJmMLpwwZvNv2401DVdUX+GzRtjW5Uuw/Gparkcmiy79wyb5Yt8m1YbG0qUG/YMSsf8bRJbnQ/KGf8mGZZEIp4VbQ9icLjDuymPgjZsifcVdO+cV3xjhRL0vBdgWBjCAuDG3Kk+C3s2yZwc7BSPOLCqIfGAZyeM0U0kd+SiqDGIwM/LAMMXkI/jDTyZXZXZHWT9Li71ly2zeDDVMa00vOuhSp9J1kP6mIlFaZpJk+dI1IIB0N/8WcwfvGTylaF3gaSx2S7jn7ux3C7uYRkgKpuoeawalSR2Wgyqto0t3BHuZBM0XmqzqT52qOOpCvXLpo4kOW5vRMbd5n08DQF7WASsMljvF3hOR5tM87PVyJ1xjd7EQPSq2asEZNhP7LUB1DGBrHxDeRvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > +# > +# Check if asm/mman.h can be included > +# > +AC_DEFUN([AC_HAVE_KERNEL_MADVISE_FLAGS], > + [ AC_MSG_CHECKING([for kernel madvise flags in asm/mman.h ]) > + AC_COMPILE_IFELSE( > + [ AC_LANG_PROGRAM([[ > +#include > + ]], [[ > +int moo = MADV_COLLAPSE; > + ]]) > + ], have_kernel_madvise=yes > + AC_MSG_RESULT(yes), > + AC_MSG_RESULT(no)) > + AC_SUBST(have_kernel_madvise) > + ]) > + I don't think we really need this check, as madvise and asm/mman.h have been around forever. We can probably also drop most of the actual flag idefs, probably for everything older than MADV_WIPEONFORK. The rest looks good to me.