From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86E20C54E5D for ; Mon, 18 Mar 2024 16:34:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB35A6B0089; Mon, 18 Mar 2024 12:34:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D627D6B008C; Mon, 18 Mar 2024 12:34:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C51DA6B0092; Mon, 18 Mar 2024 12:34:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B4E716B0089 for ; Mon, 18 Mar 2024 12:34:51 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5EB7E40738 for ; Mon, 18 Mar 2024 16:34:51 +0000 (UTC) X-FDA: 81910708782.22.55B327A Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf19.hostedemail.com (Postfix) with ESMTP id 5DD071A0009 for ; Mon, 18 Mar 2024 16:34:47 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fgL2hDA0; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710779688; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xh63bf30anS8K4DNMRz0h9Uc4GbWuHNbe+65E7aUQso=; b=P0Vh4YqMoLQLT85RZENze2md10L0Niop5qP3WxUBNF7ZSVM/foDEzWao+F8RT8P7Ham5tW o1hZWhy7H9eridq89ebtaurQl9pLqD48/xexh0aQcGJ1upjznp4xIHB0Mrs9clyjVHCYxI i9PLH3ZkuRfLov1Yuy5F0RjWnal/5OM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=fgL2hDA0; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf19.hostedemail.com: domain of rppt@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710779688; a=rsa-sha256; cv=none; b=TjnfNWSu8HPMIovENywCy95q4UW/MrieJFP43+Ibss4QP1n6Gpu5X8LWLHPFFw5IlrcmyK ZqBO/+9Vz8cp/AqJkDoVmoQKlCdz/JWDyaZLH5dea74h6tHC0Day5RG6OO3Q7OtDSTzUwn cwkmnON2XHh5EN+tpW15m+p1nomdyN8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id E0526CE0201; Mon, 18 Mar 2024 16:34:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77FD1C433F1; Mon, 18 Mar 2024 16:34:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710779684; bh=pfup/NakHv1HwT2uog2GSapR/ei7OeBW0M1tkoJiqcY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fgL2hDA0li5ZXDa1DMsldGmc5AlnJ3BWXC2dx6VCAzNwl7DLQ4pn8rf4kbS8w96p0 U+QRx/AbywGHVF6Pp+8RNEcH4esvRAKoKsy51W1vJ05fU9ESsqRMI9N0Dp/o5JQMEP ehm0G5AypWn7sEmGdy60kvLTqiFltfPrBSIjbWNL+uaMKts0rjeuJXsmOWFWoo/d4A UEEuC9A5FETOylt4Qf0zqT5cVpxXz36j1FuFbVw2T361q0aNYBlEwOoHi6aW0F2T3O WlS3+69AbhUljGv8Pfnka9xO83p2/UcWbjbjWS6g4HPubhvqgV0M7NL3j3SSboEGPJ KpOcvbBVF9HjA== Date: Mon, 18 Mar 2024 18:33:40 +0200 From: Mike Rapoport To: thunder.leizhen@huaweicloud.com Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] mm/mm_init.c: eliminate a local variable in mem_debugging_and_hardening_init() Message-ID: References: <20240318135715.312-1-thunder.leizhen@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240318135715.312-1-thunder.leizhen@huaweicloud.com> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5DD071A0009 X-Stat-Signature: uozzdp64ezhxxe9pinh3omhs77i1f8ut X-HE-Tag: 1710779687-296656 X-HE-Meta: U2FsdGVkX18yQ/vY4rqIuwkJ/z5A9OyA+cWb3OIHRh5fPHVn89qJ6y1y2/Q97uUIKijZuYezBjewHimoQULO28Tp7DKvWQ3izzxEWC6TwDPnkXkS1hJ9aC2kC+WB8r5GKf8pJz7oeX66rRjkhOXbW/+qxrZZdqNeTOlkxMoT208BcwKbcl8r4PcnjawurSPRCFliNabQNCAB71NPT44qY02y2Y2vLMXI7i9Kfsk1bfsV9fuJzGsLLLmtmfnWNowe7S5h/d6JNO6KW3tQCrTLmRTmHb+3sKKu7DEhDmzS8LWe2S6OrT4xykzE9K3Nxi2FOnc5mXQJXeLebN3FTUeMR3HDiUfLjsVDeYWTtYnezNgjthQjbsqr8TRrK7JEgDCtymGg7pSVYjH7VFFwdsvIBBMSl2aRN2d7MuQbExDb2m4ic3ozITyIOu56s0IuIaqddPgPh2+19g5OqEp5EzNmpkjgk6zuDorycAJRz2Ge86BjC6KwJC7qNlpVwt3FMKOziKZLeJo+gCXjJ+8ALd8uc5PmX8q/l7Fho3dmcAmda1W+PnzCoiej8x+O6oumSUkwd2o+XLlFsJyQhZyLxps69CZdaGi+94wwhLO9RaUVTY0vTaP1ipemX0OxRepM/voiyGHOvm8xLV++/V8KRU2GgSSLEr8yGp/u4LhMEAH5i0aroZlOLfwlQm9oPUC6jpaOlg/88u7HvjOUUDkTxzBtLT9P5Enn9ZFs2Z3wwdLlXA6FtpouELKenZFMg51FKlecHYndHlG0RFzHbicpAP0nXKqorJXPa8vOyMG4C3pYPxm+C1BIsKijTUpCrtVZVdM63E4MQjZCwQG9Ch4Habr9NvchH0M7itvhqXc0xGBI/COd2lbtKMAUW+FoTeDOJVVVFdaeeOSNcWRniQEaiRuDPXhvu0PUE31No6ibsflRuA/DgFVYSOIfIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 18, 2024 at 09:57:14PM +0800, thunder.leizhen@huaweicloud.com wrote: > From: Zhen Lei > > The local variable 'page_poisoning_requested' is assigned true at only > one point. It can be eliminated by moving the code that depends on it > to the location where it is assigned true. This also make the moved > code to be compiled only if CONFIG_PAGE_POISONING is set. I don't see it as much of an improvement and code readability becomes worse IMO. > Signed-off-by: Zhen Lei > --- > mm/mm_init.c | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/mm/mm_init.c b/mm/mm_init.c > index 549e76af8f82a8e..3eb217130bcb2b5 100644 > --- a/mm/mm_init.c > +++ b/mm/mm_init.c > @@ -2614,7 +2614,6 @@ DEFINE_STATIC_KEY_MAYBE(CONFIG_DEBUG_VM, check_pages_enabled); > */ > static void __init mem_debugging_and_hardening_init(void) > { > - bool page_poisoning_requested = false; > bool want_check_pages = false; > > #ifdef CONFIG_PAGE_POISONING > @@ -2626,18 +2625,16 @@ static void __init mem_debugging_and_hardening_init(void) > (!IS_ENABLED(CONFIG_ARCH_SUPPORTS_DEBUG_PAGEALLOC) && > debug_pagealloc_enabled())) { > static_branch_enable(&_page_poisoning_enabled); > - page_poisoning_requested = true; > want_check_pages = true; > - } > -#endif > > - if ((_init_on_alloc_enabled_early || _init_on_free_enabled_early) && > - page_poisoning_requested) { > - pr_info("mem auto-init: CONFIG_PAGE_POISONING is on, " > - "will take precedence over init_on_alloc and init_on_free\n"); > - _init_on_alloc_enabled_early = false; > - _init_on_free_enabled_early = false; > + if (_init_on_alloc_enabled_early || _init_on_free_enabled_early) { > + pr_info("mem auto-init: CONFIG_PAGE_POISONING is on, " > + "will take precedence over init_on_alloc and init_on_free\n"); > + _init_on_alloc_enabled_early = false; > + _init_on_free_enabled_early = false; > + } > } > +#endif > > if (_init_on_alloc_enabled_early) { > want_check_pages = true; > -- > 2.34.1 > -- Sincerely yours, Mike.